From 0c58cf23d59a486e7b1c7760919b7aee2d8ae008 Mon Sep 17 00:00:00 2001 From: hubwriter Date: Tue, 13 Jun 2023 11:28:20 +0100 Subject: [PATCH 1/2] Actions bug fix hour for week of May 29, 2023 (#37411) Co-authored-by: Joe Clark <31087804+jc-clark@users.noreply.github.com> --- .../security-guides/automatic-token-authentication.md | 2 ++ .../using-workflows/events-that-trigger-workflows.md | 9 +++++++++ .../actions/actions-do-not-trigger-pages-rebuilds.md | 1 + data/reusables/actions/inputs-vs-github-event-inputs.md | 6 +++++- data/reusables/pages/admin-must-push.md | 6 +++++- 5 files changed, 22 insertions(+), 2 deletions(-) create mode 100644 data/reusables/actions/actions-do-not-trigger-pages-rebuilds.md diff --git a/content/actions/security-guides/automatic-token-authentication.md b/content/actions/security-guides/automatic-token-authentication.md index e330080a4d..422d4e2208 100644 --- a/content/actions/security-guides/automatic-token-authentication.md +++ b/content/actions/security-guides/automatic-token-authentication.md @@ -38,6 +38,8 @@ You can use the `GITHUB_TOKEN` by using the standard syntax for referencing secr {% data reusables.actions.actions-do-not-trigger-workflows %} +{% data reusables.actions.actions-do-not-trigger-pages-rebuilds %} + ### Example 1: passing the `GITHUB_TOKEN` as an input {% data reusables.actions.github_token-input-example %} diff --git a/content/actions/using-workflows/events-that-trigger-workflows.md b/content/actions/using-workflows/events-that-trigger-workflows.md index 5c67242874..51df5c4fd1 100644 --- a/content/actions/using-workflows/events-that-trigger-workflows.md +++ b/content/actions/using-workflows/events-that-trigger-workflows.md @@ -1152,6 +1152,15 @@ jobs: run: echo $MESSAGE ``` +{% note %} + +**Notes**: + +- The maximum number of top-level properties in `client_payload` is 10. +- The payload can contain a maximum of 65,535 characters. + +{% endnote %} + ## `schedule` | Webhook event payload | Activity types | `GITHUB_SHA` | `GITHUB_REF` | diff --git a/data/reusables/actions/actions-do-not-trigger-pages-rebuilds.md b/data/reusables/actions/actions-do-not-trigger-pages-rebuilds.md new file mode 100644 index 0000000000..3d954369a4 --- /dev/null +++ b/data/reusables/actions/actions-do-not-trigger-pages-rebuilds.md @@ -0,0 +1 @@ +Commits pushed by a {% data variables.product.prodname_actions %} workflow that uses the `GITHUB_TOKEN` do not trigger a {% data variables.product.prodname_pages %} build. \ No newline at end of file diff --git a/data/reusables/actions/inputs-vs-github-event-inputs.md b/data/reusables/actions/inputs-vs-github-event-inputs.md index 2eb8693050..96e7c03c0e 100644 --- a/data/reusables/actions/inputs-vs-github-event-inputs.md +++ b/data/reusables/actions/inputs-vs-github-event-inputs.md @@ -2,7 +2,11 @@ {% note %} -**Note**: The workflow will also receive the inputs in the `github.event.inputs` context. The information in the `inputs` context and `github.event.inputs` context is identical except that the `inputs` context preserves Boolean values as Booleans instead of converting them to strings. The `choice` type resolves to a string and is a single selectable option. +**Notes**: + +- The workflow will also receive the inputs in the `github.event.inputs` context. The information in the `inputs` context and `github.event.inputs` context is identical except that the `inputs` context preserves Boolean values as Booleans instead of converting them to strings. The `choice` type resolves to a string and is a single selectable option. +- The maximum number of top-level properties for `inputs` is 10. +- The maximum payload for `inputs` is 65,535 characters. {% endnote %} {% endif %} diff --git a/data/reusables/pages/admin-must-push.md b/data/reusables/pages/admin-must-push.md index d86b6257d2..acdc14eab1 100644 --- a/data/reusables/pages/admin-must-push.md +++ b/data/reusables/pages/admin-must-push.md @@ -1,5 +1,9 @@ {% note %} -**Note**: {% ifversion pages-custom-workflow %}If you are publishing from a branch and{% else %}If{% endif %} your site has not published automatically, make sure someone with admin permissions and a verified email address has pushed to the publishing source. +**Notes**: + +- {% ifversion pages-custom-workflow %}If you are publishing from a branch and{% else %}If{% endif %} your site has not published automatically, make sure someone with admin permissions and a verified email address has pushed to the publishing source. + +- {% data reusables.actions.actions-do-not-trigger-pages-rebuilds %} {% endnote %} From ac7a1729cd655ca74e222bf112ddbea9ebbfec9f Mon Sep 17 00:00:00 2001 From: Diana Date: Tue, 13 Jun 2023 03:28:37 -0700 Subject: [PATCH 2/2] Adding x86-64 requirements to the CPU sections and CPU table (#37738) Co-authored-by: Matt Pollard --- .../hardware-considerations-all-platforms.md | 2 ++ data/reusables/enterprise_installation/hardware-rec-table.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/data/reusables/enterprise_installation/hardware-considerations-all-platforms.md b/data/reusables/enterprise_installation/hardware-considerations-all-platforms.md index 5005c76b4c..2af5828746 100644 --- a/data/reusables/enterprise_installation/hardware-considerations-all-platforms.md +++ b/data/reusables/enterprise_installation/hardware-considerations-all-platforms.md @@ -32,6 +32,8 @@ The available space on the root filesystem will be 50% of the total disk size. Y The CPU and memory resources that {% data variables.product.prodname_ghe_server %} requires depend on the levels of activity for users, automations, and integrations. +Any VMs you provision for {% data variables.location.product_location %} must use the x86-64 CPU architecture. Other architectures are not supported, such as Aarch64 or arm64. + {% ifversion ghes %} If you plan to enable {% data variables.product.prodname_actions %} for the users of your {% data variables.product.prodname_ghe_server %} instance, you may need to provision additional CPU and memory resources for your instance. For more information, see "[AUTOTITLE](/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server#review-hardware-considerations)." diff --git a/data/reusables/enterprise_installation/hardware-rec-table.md b/data/reusables/enterprise_installation/hardware-rec-table.md index d69f08c26d..720b3ccc83 100644 --- a/data/reusables/enterprise_installation/hardware-rec-table.md +++ b/data/reusables/enterprise_installation/hardware-rec-table.md @@ -1,4 +1,4 @@ -| User licenses | vCPUs | Memory | Root storage | Attached (data) storage | +| User licenses | x86-64 vCPUs | Memory | Root storage | Attached (data) storage | | :- | -: | -: | -: | -: | | Trial, demo, or 10 light users | 4 | 32 GB | 200 GB | 150 GB | | 10 to 3,000 | 8 | 48 GB | 200 GB | 300 GB |