From 8ee07976b69ea7811af1aad4a502fc0e7a4856e0 Mon Sep 17 00:00:00 2001 From: Isaac Brown <101839405+isaacmbrown@users.noreply.github.com> Date: Tue, 24 Jan 2023 17:07:29 +0000 Subject: [PATCH 1/3] [Improvement]: Add CLI instructions for adding a PR to a merge queue (#34116) --- ...rging-a-pull-request-with-a-merge-queue.md | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/content/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request-with-a-merge-queue.md b/content/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request-with-a-merge-queue.md index 7a9d38b849..67332c449f 100644 --- a/content/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request-with-a-merge-queue.md +++ b/content/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request-with-a-merge-queue.md @@ -10,6 +10,7 @@ shortTitle: Merge PR with merge queue redirect_from: - /pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/adding-a-pull-request-to-the-merge-queue - /github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/adding-a-pull-request-to-the-merge-queue +defaultTool: webui --- {% data reusables.pull_requests.merge-queue-beta %} @@ -21,6 +22,14 @@ redirect_from: ## Adding a pull request to a merge queue +{% webui %} + +{% tip %} + +**Tip:** You can use {% data variables.product.prodname_cli %} to add a pull request to a merge queue. For more information, click the "{% data variables.product.prodname_cli %}" tab at the top of this article. + +{% endtip %} + {% data reusables.repositories.navigate-to-repo %} {% data reusables.repositories.sidebar-pr %} @@ -38,8 +47,22 @@ redirect_from: 1. Confirm you want to add the pull request to the merge queue by clicking **Confirm merge when ready**. +{% endwebui %} + +{% cli %} + +With {% data variables.product.prodname_cli %}, you can use the `gh pr merge` command to add a pull request to a merge queue. If you are targeting a branch that requires a merge queue, this command automatically adds the pull request to the queue if required checks have passed. If required checks have not passed, this command enables auto-merge for the pull request. For more information, see [`gh pr merge`](https://cli.github.com/manual/gh_pr_merge) in the {% data variables.product.prodname_cli %} manual. + +{% endcli %} + ## Removing a pull request from a merge queue +{% cli %} + +To remove a pull request from a merge queue, you must navigate to the repository's page on {% data variables.location.product_location %}. You cannot use {% data variables.product.prodname_cli %} to remove a pull request from a merge queue. + +{% endcli %} + {% data reusables.repositories.navigate-to-repo %} {% data reusables.repositories.sidebar-pr %} @@ -52,8 +75,18 @@ Alternatively, you can navigate to the merge queue page for the base branch, cli ## Viewing merge queues +{% cli %} + +You can view the merge queue for a base branch in various places on {% data variables.product.product_name %}. You cannot use {% data variables.product.prodname_cli %} to view a merge queue. + +{% endcli %} + +{% webui %} + You can view the merge queue for a base branch in various places on {% data variables.product.product_name %}. +{% endwebui %} + - On the **Branches** page for the repository. We recommend you use this route if you don't have or don't know about a pull request already in a queue, and if you want to see what's in that queue. For more information, see "[Viewing branches in your repository](/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/viewing-branches-in-your-repository)." ![View merge queue in Branches page](/assets/images/help/pull_requests/merge-queue-branches-page.png) From 18c5a2ddf9a0a9ea75330d26f9bb4b9d8601e826 Mon Sep 17 00:00:00 2001 From: Sarah Edwards Date: Tue, 24 Jan 2023 09:12:58 -0800 Subject: [PATCH 2/3] Expand workflow to copy API schema issues to include webhook schema issues as well (#34098) --- .github/workflows/copy-api-issue-to-internal.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/copy-api-issue-to-internal.yml b/.github/workflows/copy-api-issue-to-internal.yml index d14236eea9..6d83cfe3f2 100644 --- a/.github/workflows/copy-api-issue-to-internal.yml +++ b/.github/workflows/copy-api-issue-to-internal.yml @@ -1,7 +1,7 @@ -name: Copy to REST API issue to docs-content +name: Copy to API/events issue to docs-content # **What it does**: Copies an issue in the open source repo to the docs-content repo, comments on and closes the original issue -# **Why we have it**: REST API updates cannot be made in the open source repo. Instead, we copy the issue to an internal issue (we do not transfer so that the issue does not disappear for the contributor) and close the original issue. +# **Why we have it**: OpenAPI/GraphQL schema updates cannot be made in the open source repo. Instead, we copy the issue to an internal issue (we do not transfer so that the issue does not disappear for the contributor) and close the original issue. # **Who does it impact**: Open source and docs-content maintainers on: @@ -16,7 +16,7 @@ jobs: transfer-issue: name: Transfer issue runs-on: ubuntu-latest - if: (github.event.label.name == 'rest-description' || github.event.label.name == 'graphql-description') && github.repository == 'github/docs' + if: (github.event.label.name == 'rest-description' || github.event.label.name == 'graphql-description' || github.event.label.name == 'webhook-description') && github.repository == 'github/docs' steps: - name: Check if this run was triggered by a member of the docs team uses: actions/github-script@2b34a689ec86a68d8ab9478298f91d5401337b7d @@ -53,7 +53,7 @@ jobs: ISSUE_BODY: ${{ github.event.issue.body }} - name: Comment on the old issue - run: gh issue comment $OLD_ISSUE --body "Thank you for opening this issue! Updates to the REST/GraphQL API description must be made internally. I have copied your issue to an internal issue, so I will close this issue." + run: gh issue comment $OLD_ISSUE --body "Thank you for opening this issue! Updates to the REST API, GraphQL API, and webhook reference documentation must be made internally. I have copied your issue to an internal issue, so I will close this issue." env: GITHUB_TOKEN: ${{secrets.DOCUBOT_READORG_REPO_WORKFLOW_SCOPES}} OLD_ISSUE: ${{ github.event.issue.html_url }} From c32257a10a49bb031308726bffc99e2494db6f2b Mon Sep 17 00:00:00 2001 From: mischa Date: Tue, 24 Jan 2023 09:13:34 -0800 Subject: [PATCH 3/3] Remove request access for push protection instruction (#33507) Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com> --- data/reusables/secret-scanning/push-protection-beta.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/reusables/secret-scanning/push-protection-beta.md b/data/reusables/secret-scanning/push-protection-beta.md index ff832ea8eb..2e40e4c004 100644 --- a/data/reusables/secret-scanning/push-protection-beta.md +++ b/data/reusables/secret-scanning/push-protection-beta.md @@ -1,5 +1,5 @@ {% note %} -**Note:** {% data variables.product.prodname_secret_scanning_caps %} as a protection push is currently in beta and subject to change. To request access to the beta release, [contact your account management team](https://github.com/enterprise/contact). +**Note:** {% data variables.product.prodname_secret_scanning_caps %} as a protection push is currently in beta and subject to change. {% endnote %}