jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-23 21:07:12 -05:00
Code Issues Projects Releases Wiki Activity

Do not pass null config vars to Heroku on AppSetup (#21766)

Browse Source
This commit is contained in:
James M. Greene
2021-09-27 15:47:04 -05:00
committed by GitHub
parent 7947d1795e
commit c52671408b
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
script/deployment/deploy-to-staging.js
View File

@@ -194,7 +194,8 @@ export default async function deployToStaging({
// Pass some environment variables to staging apps via Heroku // Pass some environment variables to staging apps via Heroku
// config variables. // config variables.
overrides: { overrides: {
env: appConfigVars, // AppSetup API cannot handle `null` values for config vars
env: removeEmptyProperties(appConfigVars),
}, },
}, },
}) })
@@ -650,3 +651,7 @@ function announceIfHerokuIsDown(error) {
console.error('💀 Heroku may be down! Please check its Status page: https://status.heroku.com/') console.error('💀 Heroku may be down! Please check its Status page: https://status.heroku.com/')
} }
} }
function removeEmptyProperties(obj) {
return Object.fromEntries(Object.entries(obj).filter(([key, val]) => val != null))
}