From dd26a541df5eebe90c65fd99980a004e0200b2ad Mon Sep 17 00:00:00 2001 From: Leonard Sheng Sheng Lee Date: Sat, 1 Jun 2024 02:02:28 +0200 Subject: [PATCH 1/2] docs(github-apps): explain github apps name characters limit (#33265) Co-authored-by: Alex Nguyen <150945400+nguyenalex836@users.noreply.github.com> --- .../registering-a-github-app/registering-a-github-app.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/apps/creating-github-apps/registering-a-github-app/registering-a-github-app.md b/content/apps/creating-github-apps/registering-a-github-app/registering-a-github-app.md index c3d0cc85be..858815af54 100644 --- a/content/apps/creating-github-apps/registering-a-github-app/registering-a-github-app.md +++ b/content/apps/creating-github-apps/registering-a-github-app/registering-a-github-app.md @@ -31,7 +31,7 @@ You can register a {% data variables.product.prodname_github_app %} under your p {% data reusables.user-settings.developer_settings %} {% data reusables.user-settings.github_apps %} 1. Click **New GitHub App**. -1. Under "GitHub App name", enter a name for your app. You should choose a clear and short name. Your app's name (converted to lowercase, with spaces replaced by `-`, and with special characters replaced) will be shown in the user interface when your app takes an action. For example, `My APp Näme` would display as `my-app-name`. +1. Under "GitHub App name", enter a name for your app. You should choose a clear and short name. The name cannot be longer than 34 characters. Your app's name (converted to lowercase, with spaces replaced by `-`, and with special characters replaced) will be shown in the user interface when your app takes an action. For example, `My APp Näme` would display as `my-app-name`. The name must be unique across {% data variables.product.company_short %}. You cannot use same name as an existing GitHub account, unless it is your own user or organization name. From c89eb00aefbc55cf1b12f6c4264a121a88e74b8a Mon Sep 17 00:00:00 2001 From: Amon Keishima Date: Sat, 1 Jun 2024 09:06:19 +0900 Subject: [PATCH 2/2] Update generating-a-json-web-token-jwt-for-a-github-app.md (#33231) --- .../generating-a-json-web-token-jwt-for-a-github-app.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app.md b/content/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app.md index bae0b79ead..dddef4e385 100644 --- a/content/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app.md +++ b/content/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app.md @@ -175,7 +175,7 @@ header=$( echo -n "${header_json}" | b64enc ) payload_json='{ "iat":'"${iat}"', "exp":'"${exp}"', - {% ifversion client-id-for-app %}"iss":'"${client_id}"'{% else %}"iss":'"${client_id}"'{% endif %} + {% ifversion client-id-for-app %}"iss":'"${client_id}"'{% else %}"iss":'"${app_id}"'{% endif %} }' # Payload encode payload=$( echo -n "${payload_json}" | b64enc )