diff --git a/.github/workflows/codeowners-docs-engineering.yml b/.github/workflows/codeowners-docs-engineering.yml index 85dc8e8248..dfa8ba11db 100644 --- a/.github/workflows/codeowners-docs-engineering.yml +++ b/.github/workflows/codeowners-docs-engineering.yml @@ -20,7 +20,8 @@ on: - '**.tsx' - '**.scss' - 'src/**' - - '!src/**.json' # So that Docs Engineering isn't reviewing OpenAPI PRs + - '!src/**.json' # So that Docs Engineering isn't reviewing automated pipeline data PRs + - '!src/**.yml' # So that Docs Engineering isn't reviewing automated pipeline data PRs - '.github/**' - '**Dockerfile' - 'package*.json' diff --git a/.github/workflows/sync-secret-scanning.yml b/.github/workflows/sync-secret-scanning.yml index e0148542b7..d8d65f65af 100644 --- a/.github/workflows/sync-secret-scanning.yml +++ b/.github/workflows/sync-secret-scanning.yml @@ -37,7 +37,7 @@ jobs: run: | npm run sync-secret-scanning - - name: Create and merge pull request + - name: Create a pull request env: # Needed for gh GITHUB_TOKEN: ${{ secrets.DOCS_BOT_PAT_READPUBLICKEY }} @@ -70,7 +70,9 @@ jobs: echo "Creating pull request..." gh pr create \ --title "Sync secret scanning data" \ - --body '👋 humans. This PR updates the secret scanning data with the latest changes from github/token-scanning-service.\n\n/cc @github/docs-content-security-products + --body '👋 humans. This PR updates the secret scanning data with the latest changes from github/token-scanning-service. + + /cc @github/docs-content-security-products If CI does not pass or other problems arise, contact #docs-engineering on slack.' \ --repo github/docs-internal \ diff --git a/src/secret-scanning/scripts/sync.ts b/src/secret-scanning/scripts/sync.ts index edb415fa2b..7950e6d10a 100755 --- a/src/secret-scanning/scripts/sync.ts +++ b/src/secret-scanning/scripts/sync.ts @@ -52,7 +52,7 @@ async function main() { throw new Error('The public-docs.yml file being synced does not have a valid schema') } - await writeFile(SECRET_SCANNING_FILEPATH, data) + await writeFile(SECRET_SCANNING_FILEPATH, yaml.dump(data)) // update the config file with the latest sha const configFilepath = 'src/secret-scanning/lib/config.json'