From 1b2d78874dcaf891f232917f00a0008daf0add43 Mon Sep 17 00:00:00 2001 From: Tim <103634854+sn2b@users.noreply.github.com> Date: Tue, 2 Apr 2024 11:26:10 +0200 Subject: [PATCH 1/2] Remove leftover fpt or ghec or ghes %}* from rate limit documentation (#49971) --- content/rest/rate-limit/rate-limit.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/rest/rate-limit/rate-limit.md b/content/rest/rate-limit/rate-limit.md index 312fa90f3e..13da1e5da6 100644 --- a/content/rest/rate-limit/rate-limit.md +++ b/content/rest/rate-limit/rate-limit.md @@ -30,7 +30,7 @@ The REST API for searching items has a custom rate limit that is separate from t - The `integration_manifest` object provides your rate limit status for the `POST /app-manifests/{code}/conversions` operation. For more information, see "[AUTOTITLE](/apps/creating-github-apps/setting-up-a-github-app/creating-a-github-app-from-a-manifest#3-you-exchange-the-temporary-code-to-retrieve-the-app-configuration)." -fpt or ghec or ghes %}* The `dependency_snapshots` object provides your rate limit status for submitting snapshots to the dependency graph. For more information, see "[AUTOTITLE](/rest/dependency-graph)." +- The `dependency_snapshots` object provides your rate limit status for submitting snapshots to the dependency graph. For more information, see "[AUTOTITLE](/rest/dependency-graph)." - The `code_scanning_upload` object provides your rate limit status for uploading SARIF results to code scanning. For more information, see "[AUTOTITLE](/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github)." From 0b7cd43920fc7126237b582a1dd1d6ffe513eb77 Mon Sep 17 00:00:00 2001 From: Alessandro Baccin Date: Tue, 2 Apr 2024 10:45:29 +0100 Subject: [PATCH 2/2] Specify that us-east-1 region needs to be reachable for GHES for audit log streaming to S3 (#49900) --- .../streaming-the-audit-log-for-your-enterprise.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/content/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/streaming-the-audit-log-for-your-enterprise.md b/content/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/streaming-the-audit-log-for-your-enterprise.md index 00d0f576c0..94a2527062 100644 --- a/content/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/streaming-the-audit-log-for-your-enterprise.md +++ b/content/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/streaming-the-audit-log-for-your-enterprise.md @@ -72,6 +72,14 @@ You set up the audit log stream on {% data variables.product.product_name %} by ### Setting up streaming to Amazon S3 +{% ifversion ghes %} +{% note %} + +**Note**: The Amazon region `us-east-1` must be reachable from your appliance in order for streaming to S3 to work accordingly. + +{% endnote %} +{% endif %} + {% ifversion streaming-oidc-s3 %} You can set up streaming to S3 with access keys or, to avoid storing long-lived secrets in {% data variables.product.product_name %}, with OpenID Connect (OIDC).