From c9186d07c3681362b9707d6a88f8678cee8ab3b1 Mon Sep 17 00:00:00 2001 From: Darren Reid Date: Tue, 15 Feb 2022 10:57:52 +1100 Subject: [PATCH 1/3] Use valid reusable workflow paths in example yml The docs currently state: > Reusable workflows are YAML-formatted files, very similar to any other workflow file. As with other workflow files, you locate reusable workflows in the `.github/workflows` directory of a repository. Subdirectories of the `workflows` directory are not supported. But the example yml then presents the path `uses: ./.github/actions/my-action` which doesn't follow the initial advice about location of workflow files. Change is to use `uses: ./.github/workflows/my-action` to make example valid, but this is assuming the `Creating a reusable workflow` section is also accurate. --- content/actions/using-workflows/reusing-workflows.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/actions/using-workflows/reusing-workflows.md b/content/actions/using-workflows/reusing-workflows.md index bb93f2df34..cb6cb0c668 100644 --- a/content/actions/using-workflows/reusing-workflows.md +++ b/content/actions/using-workflows/reusing-workflows.md @@ -112,7 +112,7 @@ You can define inputs and secrets, which can be passed from the caller workflow runs-on: ubuntu-latest environment: production steps: - - uses: ./.github/actions/my-action + - uses: ./.github/workflows/my-action with: username: ${{ inputs.username }} token: ${{ secrets.envPAT }} @@ -153,7 +153,7 @@ jobs: name: Pass input and secrets to my-action runs-on: ubuntu-latest steps: - - uses: ./.github/actions/my-action + - uses: ./.github/workflows/my-action with: username: ${{ inputs.username }} token: ${{ secrets.token }} From ba263ca5dc9659ddb5de4c69f8512a48d1f86b66 Mon Sep 17 00:00:00 2001 From: taleleuma Date: Thu, 24 Feb 2022 21:14:58 -0500 Subject: [PATCH 2/3] Update error-permission-denied-publickey.md sudo command is applicable to Linux only. Doesn't work on windows. --- .../troubleshooting-ssh/error-permission-denied-publickey.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/authentication/troubleshooting-ssh/error-permission-denied-publickey.md b/content/authentication/troubleshooting-ssh/error-permission-denied-publickey.md index 0386089dd3..ee2b3afa7c 100644 --- a/content/authentication/troubleshooting-ssh/error-permission-denied-publickey.md +++ b/content/authentication/troubleshooting-ssh/error-permission-denied-publickey.md @@ -14,7 +14,7 @@ topics: - SSH shortTitle: Permission denied (publickey) --- -## Should the `sudo` command be used with Git? +## (Linux) Should the `sudo` command be used with Git? You should not be using the `sudo` command with Git. If you have a *very good reason* you must use `sudo`, then ensure you are using it with every command (it's probably just better to use `su` to get a shell as root at that point). If you [generate SSH keys](/articles/generating-an-ssh-key) without `sudo` and then try to use a command like `sudo git push`, you won't be using the same keys that you generated. From 4cdd1f6f7676443ff598e076d7adb3569a12702f Mon Sep 17 00:00:00 2001 From: Vanessa Date: Wed, 2 Mar 2022 12:00:10 +1000 Subject: [PATCH 3/3] Update error-permission-denied-publickey.md --- .../troubleshooting-ssh/error-permission-denied-publickey.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/authentication/troubleshooting-ssh/error-permission-denied-publickey.md b/content/authentication/troubleshooting-ssh/error-permission-denied-publickey.md index ee2b3afa7c..7c01367bc9 100644 --- a/content/authentication/troubleshooting-ssh/error-permission-denied-publickey.md +++ b/content/authentication/troubleshooting-ssh/error-permission-denied-publickey.md @@ -14,9 +14,9 @@ topics: - SSH shortTitle: Permission denied (publickey) --- -## (Linux) Should the `sudo` command be used with Git? +## Should the `sudo` command or elevated privileges be used with Git? -You should not be using the `sudo` command with Git. If you have a *very good reason* you must use `sudo`, then ensure you are using it with every command (it's probably just better to use `su` to get a shell as root at that point). If you [generate SSH keys](/articles/generating-an-ssh-key) without `sudo` and then try to use a command like `sudo git push`, you won't be using the same keys that you generated. +You should not be using the `sudo` command or elevated privileges, such as administrator permissions, with Git. If you have a *very good reason* you must use `sudo`, then ensure you are using it with every command (it's probably just better to use `su` to get a shell as root at that point). If you [generate SSH keys](/articles/generating-an-ssh-key) without `sudo` and then try to use a command like `sudo git push`, you won't be using the same keys that you generated. ## Check that you are connecting to the correct server