jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-23 21:07:12 -05:00
Code Issues Projects Releases Wiki Activity

Mention reviewing the source diff (#17141)

Browse Source
This commit is contained in:
hubwriter
2021-01-07 14:20:27 +00:00
committed by GitHub
parent 2e1d48d585
commit d81f607947
3 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
content/github/collaborating-with-issues-and-pull-requests/reviewing-dependency-changes-in-a-pull-request.md
View File

@@ -36,7 +36,7 @@ Dependency review supports the same languages and package management ecosystems
![The file filter menu](/assets/images/help/pull_requests/file-filter-menu-json.png) ![The file filter menu](/assets/images/help/pull_requests/file-filter-menu-json.png)
1. On the right of the header for a manifest or lock file, display the dependency review by clicking the rich diff button. 1. On the right of the header for a manifest or lock file, display the dependency review by clicking the **{% octicon "file" aria-label="The rich diff icon" %}** rich diff button.
![The rich diff button](/assets/images/help/pull_requests/dependency-review-rich-diff.png) ![The rich diff button](/assets/images/help/pull_requests/dependency-review-rich-diff.png)
@@ -69,6 +69,4 @@ Dependency review supports the same languages and package management ecosystems
* The severity of the vulnerability. * The severity of the vulnerability.
* The version of the dependency in which the vulnerability was fixed. If you are reviewing a pull request for someone, you might ask the contributor to update the dependency to the patched version, or a later release. * The version of the dependency in which the vulnerability was fixed. If you are reviewing a pull request for someone, you might ask the contributor to update the dependency to the patched version, or a later release.
1. You can return to the original view of the file by clicking the source diff button. {% data reusables.repositories.return-to-source-diff %}
![The source diff button](/assets/images/help/pull_requests/dependency-review-source-diff.png)

4
content/github/collaborating-with-issues-and-pull-requests/reviewing-proposed-changes-in-a-pull-request.md
View File

@@ -37,9 +37,11 @@ If the pull request contains changes to dependencies you can use the dependency
{% data reusables.repositories.changed-files %} {% data reusables.repositories.changed-files %}
1. On the right of the header for a manifest or lock file, display the dependency review by clicking the rich diff button. 1. On the right of the header for a manifest or lock file, display the dependency review by clicking the **{% octicon "file" aria-label="The rich diff icon" %}** rich diff button.
![The rich diff button](/assets/images/help/pull_requests/dependency-review-rich-diff.png) ![The rich diff button](/assets/images/help/pull_requests/dependency-review-rich-diff.png)
{% data reusables.repositories.return-to-source-diff %}
{% endif %} {% endif %}
### Marking a file as viewed ### Marking a file as viewed

5
data/reusables/repositories/return-to-source-diff.md Normal file
View File

@@ -0,0 +1,5 @@
1. You may also want to review the source diff, because there could be changes to the manifest or lock file that don't change dependencies, or there could be dependencies that {% data variables.product.prodname_dotcom %} can't parse and which, as a result, don't appear in the dependency review.
To return to the source diff view, click the **{% octicon "code" aria-label="The source diff icon" %}** button.
![The source diff button](/assets/images/help/pull_requests/dependency-review-source-diff.png)