diff --git a/tests/content/graphql.js b/tests/content/graphql.js index 8133ebc194..b6d2be45e8 100644 --- a/tests/content/graphql.js +++ b/tests/content/graphql.js @@ -22,100 +22,82 @@ describe('graphql json files', () => { test('static files have versions as top-level keys', () => { graphqlVersions.forEach((version) => { - // todo: remove if check once we have API/webhook versions for ghec - if (version !== 'ghec') { - expect(version in previewsJson).toBe(true) - expect(version in upcomingChangesJson).toBe(true) - expect(version in prerenderedObjectsJson).toBe(true) - } + expect(version in previewsJson).toBe(true) + expect(version in upcomingChangesJson).toBe(true) + expect(version in prerenderedObjectsJson).toBe(true) }) }) test('schemas object validation', () => { graphqlVersions.forEach((version) => { - // todo: remove if check once we have API/webhook versions for ghec - if (version !== 'ghec') { - const schemaJsonPerVersion = JSON.parse( - fs.readFileSync(path.join(process.cwd(), `lib/graphql/static/schema-${version}.json`)) - ) - // all graphql types are arrays except for queries - graphqlTypes - .filter((type) => type !== 'queries') - .forEach((type) => { - schemaJsonPerVersion[type].forEach((typeObj) => { - const { valid, errors } = revalidator.validate(typeObj, schemaValidator[type]) - const errorMessage = JSON.stringify(errors, null, 2) - expect(valid, errorMessage).toBe(true) - }) + const schemaJsonPerVersion = JSON.parse( + fs.readFileSync(path.join(process.cwd(), `lib/graphql/static/schema-${version}.json`)) + ) + // all graphql types are arrays except for queries + graphqlTypes + .filter((type) => type !== 'queries') + .forEach((type) => { + schemaJsonPerVersion[type].forEach((typeObj) => { + const { valid, errors } = revalidator.validate(typeObj, schemaValidator[type]) + const errorMessage = JSON.stringify(errors, null, 2) + expect(valid, errorMessage).toBe(true) }) - - // check query connections separately - schemaJsonPerVersion.queries.connections.forEach((connection) => { - const { valid, errors } = revalidator.validate( - connection, - schemaValidator.queryConnections - ) - const errorMessage = JSON.stringify(errors, null, 2) - expect(valid, errorMessage).toBe(true) }) - // check query fields separately - schemaJsonPerVersion.queries.fields.forEach((field) => { - const { valid, errors } = revalidator.validate(field, schemaValidator.queryFields) - const errorMessage = JSON.stringify(errors, null, 2) - expect(valid, errorMessage).toBe(true) - }) - } + // check query connections separately + schemaJsonPerVersion.queries.connections.forEach((connection) => { + const { valid, errors } = revalidator.validate(connection, schemaValidator.queryConnections) + const errorMessage = JSON.stringify(errors, null, 2) + expect(valid, errorMessage).toBe(true) + }) + + // check query fields separately + schemaJsonPerVersion.queries.fields.forEach((field) => { + const { valid, errors } = revalidator.validate(field, schemaValidator.queryFields) + const errorMessage = JSON.stringify(errors, null, 2) + expect(valid, errorMessage).toBe(true) + }) }) }) test('previews object validation', () => { graphqlVersions.forEach((version) => { - // todo: remove if check once we have API/webhook versions for ghec - if (version !== 'ghec') { - previewsJson[version].forEach((previewObj) => { - const { valid, errors } = revalidator.validate(previewObj, previewsValidator) - const errorMessage = JSON.stringify(errors, null, 2) - expect(valid, errorMessage).toBe(true) - }) - } + previewsJson[version].forEach((previewObj) => { + const { valid, errors } = revalidator.validate(previewObj, previewsValidator) + const errorMessage = JSON.stringify(errors, null, 2) + expect(valid, errorMessage).toBe(true) + }) }) }) test('upcoming changes object validation', () => { graphqlVersions.forEach((version) => { - // todo: remove if check once we have API/webhook versions for ghec - if (version !== 'ghec') { - Object.values(upcomingChangesJson[version]).forEach((changes) => { - // each object value is an array of changes - changes.forEach((changeObj) => { - const { valid, errors } = revalidator.validate(changeObj, upcomingChangesValidator) - const errorMessage = JSON.stringify(errors, null, 2) - expect(valid, errorMessage).toBe(true) - }) + Object.values(upcomingChangesJson[version]).forEach((changes) => { + // each object value is an array of changes + changes.forEach((changeObj) => { + const { valid, errors } = revalidator.validate(changeObj, upcomingChangesValidator) + const errorMessage = JSON.stringify(errors, null, 2) + expect(valid, errorMessage).toBe(true) }) - } + }) }) }) test('prerendered objects validation', () => { graphqlVersions.forEach((version) => { - // todo: remove if check once we have API/webhook versions for ghec - if (version !== 'ghec') { - // shape of prerenderedObject: { - // html: