From b37646b9e13272f423e19ef71a0a7460f9114ba1 Mon Sep 17 00:00:00 2001 From: Peter Bengtsson Date: Tue, 28 Feb 2023 15:52:01 -0500 Subject: [PATCH 1/2] Use composite action for getting docs-early-access in link checker (#35148) --- .../check-broken-links-github-github.yml | 15 ++++----------- .github/workflows/link-check-on-pr.yml | 18 +----------------- 2 files changed, 5 insertions(+), 28 deletions(-) diff --git a/.github/workflows/check-broken-links-github-github.yml b/.github/workflows/check-broken-links-github-github.yml index ecb9b7a439..0e839543d4 100644 --- a/.github/workflows/check-broken-links-github-github.yml +++ b/.github/workflows/check-broken-links-github-github.yml @@ -44,19 +44,12 @@ jobs: # To prevent issues with cloning early access content later persist-credentials: 'false' - - name: Clone docs-early-access - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 - with: - repository: github/docs-early-access - token: ${{ secrets.DOCUBOT_REPO_PAT }} - path: docs-early-access - ref: main - - - name: Merge docs-early-access repo's folders - run: .github/actions-scripts/merge-early-access.sh - - uses: ./.github/actions/node-npm-setup + - uses: ./.github/actions/get-docs-early-access + with: + token: ${{ secrets.DOCUBOT_REPO_PAT }} + - name: Build server run: npm run build diff --git a/.github/workflows/link-check-on-pr.yml b/.github/workflows/link-check-on-pr.yml index 8efb2ca526..16ea0a4f9d 100644 --- a/.github/workflows/link-check-on-pr.yml +++ b/.github/workflows/link-check-on-pr.yml @@ -30,26 +30,10 @@ jobs: - uses: ./.github/actions/node-npm-setup - - name: Figure out which docs-early-access branch to checkout, if internal repo + - uses: ./.github/actions/get-docs-early-access if: ${{ github.repository == 'github/docs-internal' }} - id: check-early-access - env: - BRANCH_NAME: ${{ github.head_ref || github.ref_name }} - GITHUB_TOKEN: ${{ secrets.DOCUBOT_REPO_PAT }} - run: node .github/actions-scripts/what-docs-early-access-branch.js - - - name: Check out docs-early-access too, if internal repo - if: ${{ github.repository == 'github/docs-internal' }} - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 with: - repository: github/docs-early-access token: ${{ secrets.DOCUBOT_REPO_PAT }} - path: docs-early-access - ref: ${{ steps.check-early-access.outputs.branch }} - - - name: Merge docs-early-access repo's folders - if: ${{ github.repository == 'github/docs-internal' }} - run: .github/actions-scripts/merge-early-access.sh # TODO: When we want to fix redirects on changed files we can uncomment everything below # Creates file "${{ env.HOME }}/files.json", among others From b25f57ed67517fcd3a21de1e68135cf26a62b14e Mon Sep 17 00:00:00 2001 From: Robert Sese <734194+rsese@users.noreply.github.com> Date: Tue, 28 Feb 2023 15:14:46 -0600 Subject: [PATCH 2/2] enum type could be an array that contains a null value (#35186) --- components/parameter-table/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/parameter-table/types.ts b/components/parameter-table/types.ts index 104049af3c..de551facb1 100644 --- a/components/parameter-table/types.ts +++ b/components/parameter-table/types.ts @@ -26,7 +26,7 @@ export interface ChildParameter { description: string type: string isRequired?: boolean - enum?: null | string[] + enum?: Array default?: string | boolean | number | undefined | string[] childParamsGroups?: ChildParameter[] }