From 3b6745d85f36576e19f09cda6f0a1c882d1715e4 Mon Sep 17 00:00:00 2001 From: Rachael Sewell Date: Wed, 19 Jun 2024 13:11:27 -0700 Subject: [PATCH 1/2] Fix typo in what data is written - secret scanning automation (#51292) --- src/secret-scanning/scripts/sync.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/secret-scanning/scripts/sync.ts b/src/secret-scanning/scripts/sync.ts index 7950e6d10a..8bd70c0a4b 100755 --- a/src/secret-scanning/scripts/sync.ts +++ b/src/secret-scanning/scripts/sync.ts @@ -52,7 +52,7 @@ async function main() { throw new Error('The public-docs.yml file being synced does not have a valid schema') } - await writeFile(SECRET_SCANNING_FILEPATH, yaml.dump(data)) + await writeFile(SECRET_SCANNING_FILEPATH, yaml.dump(yamlData)) // update the config file with the latest sha const configFilepath = 'src/secret-scanning/lib/config.json' From 30593a3a763d2700b65fec04a25387b008be6aab Mon Sep 17 00:00:00 2001 From: Rachael Sewell Date: Wed, 19 Jun 2024 13:16:19 -0700 Subject: [PATCH 2/2] Revert survey visit duration (#51293) Co-authored-by: docs-bot <77750099+docs-bot@users.noreply.github.com> --- src/events/components/Survey.tsx | 3 +-- src/events/components/events.ts | 3 +-- src/events/lib/schema.js | 6 ------ 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/events/components/Survey.tsx b/src/events/components/Survey.tsx index 86f7a56d24..3f99cbc1ce 100644 --- a/src/events/components/Survey.tsx +++ b/src/events/components/Survey.tsx @@ -7,7 +7,7 @@ import useSWR from 'swr' import { useTranslation } from 'src/languages/components/useTranslation' import { Link } from 'src/frame/components/Link' -import { sendEvent, EventType, startVisitTime } from 'src/events/components/events' +import { sendEvent, EventType } from 'src/events/components/events' import styles from './Survey.module.scss' @@ -324,7 +324,6 @@ function trackEvent(eventData: EventData) { survey_vote: eventData.vote, survey_comment: eventData.comment || undefined, survey_email: eventData.email || undefined, - survey_visit_duration: (Date.now() - startVisitTime) / 1000, survey_rating: eventData.rating, }) } diff --git a/src/events/components/events.ts b/src/events/components/events.ts index 1d9d9b4153..3c32d290f1 100644 --- a/src/events/components/events.ts +++ b/src/events/components/events.ts @@ -6,7 +6,7 @@ import { isLoggedIn } from 'src/frame/components/hooks/useHasAccount' const COOKIE_NAME = '_docs-events' -export const startVisitTime = Date.now() +const startVisitTime = Date.now() let initialized = false let cookieValue: string | undefined @@ -119,7 +119,6 @@ type SendEventProps = { survey_vote: boolean survey_comment?: string survey_email?: string - survey_visit_duration?: number survey_rating?: number } } diff --git a/src/events/lib/schema.js b/src/events/lib/schema.js index e33bdeb836..41fa78a085 100644 --- a/src/events/lib/schema.js +++ b/src/events/lib/schema.js @@ -389,12 +389,6 @@ const survey = { format: 'email', description: "The user's email address, if the user provided and consented.", }, - survey_visit_duration: { - type: 'number', - minimum: 0.001, - description: - 'The duration of survey submission - page.timestamp, in seconds. Used to filter out bot-generated survey resopnses.', - }, survey_rating: { type: 'number', description: