jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-22 11:26:57 -05:00
Code Issues Projects Releases Wiki Activity

Small accessibility changes - adding ul to li (#24449)

Browse Source 
* adding ul to li

* move ul for just the mobile picker
This commit is contained in:
Grace Park
2022-01-20 09:54:49 -08:00
committed by GitHub
parent 92fa1c4994
commit eb776f64e4
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
components/landing/GuideCards.tsx
View File

@@ -20,10 +20,12 @@ export const GuideCards = () => {
return ( return (
<div> <div>
<div className="d-lg-flex gutter-lg flex-items-stretch"> <div className="d-lg-flex flex-items-stretch">
{(featuredLinks.guideCards || []).map((guide) => { <ul className="d-flex flex-wrap gutter">
return <GuideCard key={guide.href} guide={guide} /> {(featuredLinks.guideCards || []).map((guide) => {
})} return <GuideCard key={guide.href} guide={guide} />
})}
</ul>
</div> </div>
{!currentCategory && hasGuidesPage && ( {!currentCategory && hasGuidesPage && (

6
components/ui/Picker/Picker.tsx
View File

@@ -40,7 +40,11 @@ function PickerSummaryWrapper({ variant, children }: PickerWrapperPropsT) {
function PickerOptionsWrapper({ variant, children }: PickerWrapperPropsT) { function PickerOptionsWrapper({ variant, children }: PickerWrapperPropsT) {
if (variant === 'inline') { if (variant === 'inline') {
return <Box py="2">{children}</Box> return (
<Box py="2">
<ul>{children}</ul>
</Box>
)
} }
return ( return (
<Dropdown.Menu direction="sw" style={{ width: 'unset' }}> <Dropdown.Menu direction="sw" style={{ width: 'unset' }}>