From 26b4dc46ddba90a2f16b1cdc942c64dc1eb14759 Mon Sep 17 00:00:00 2001
From: Kevin Heis <heiskr@users.noreply.github.com>
Date: Fri, 14 Apr 2023 12:52:46 -0700
Subject: [PATCH 1/2] Lower footer heading levels (#36396)

---
 components/page-footer/Contribution.tsx   | 2 +-
 components/page-footer/LegalFooter.tsx    | 2 +-
 components/page-footer/Support.tsx        | 2 +-
 components/page-footer/SupportSection.tsx | 2 +-
 components/page-footer/Survey.tsx         | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/components/page-footer/Contribution.tsx b/components/page-footer/Contribution.tsx
index 77e5292a15..9b515c3df4 100644
--- a/components/page-footer/Contribution.tsx
+++ b/components/page-footer/Contribution.tsx
@@ -13,7 +13,7 @@ export const Contribution = () => {
 
   return (
     <div className="f5 contribution">
-      <h2 className="f4 mb-3">{t`title`}</h2>
+      <h3 className="f4 mb-3">{t`title`}</h3>
       <p className="max-w-xs color-fg-muted mb-3">{t`body`}</p>
       <a className="btn color-border-accent-emphasis" href={contributionHref}>
         <GitPullRequestIcon size="small" className="octicon mr-1" />
diff --git a/components/page-footer/LegalFooter.tsx b/components/page-footer/LegalFooter.tsx
index a40176b1fd..af682a32e0 100644
--- a/components/page-footer/LegalFooter.tsx
+++ b/components/page-footer/LegalFooter.tsx
@@ -9,7 +9,7 @@ export const LegalFooter = () => {
   const { t } = useTranslation('footer')
   return (
     <section className="container-xl px-3 mt-6 pb-8 px-md-6 color-fg-muted">
-      <h1 className="f4 mb-2 col-12">{t('legal_heading')}</h1>
+      <h2 className="f4 mb-2 col-12">{t('legal_heading')}</h2>
       <ul className="d-flex flex-wrap list-style-none">
         <li className="mr-3">&copy; {new Date().getFullYear()} GitHub, Inc.</li>
         {/* In Germany, Austria, and Switzerland, the Impressum link is legally required. */}
diff --git a/components/page-footer/Support.tsx b/components/page-footer/Support.tsx
index f46a2bfefb..8e27dff062 100644
--- a/components/page-footer/Support.tsx
+++ b/components/page-footer/Support.tsx
@@ -9,7 +9,7 @@ export const Support = () => {
 
   return (
     <div>
-      <h2 className="mb-3 f4">{t`still_need_help`}</h2>
+      <h3 className="mb-3 f4">{t`still_need_help`}</h3>
       <div className="mb-2">
         <a
           id="ask-community"
diff --git a/components/page-footer/SupportSection.tsx b/components/page-footer/SupportSection.tsx
index b8d3ee7c92..39e83b02c1 100644
--- a/components/page-footer/SupportSection.tsx
+++ b/components/page-footer/SupportSection.tsx
@@ -28,7 +28,7 @@ export const SupportSection = () => {
 
   return (
     <section className="container-xl mt-lg-8 mt-6 px-3 px-md-6 no-print mx-auto">
-      <h1 className="f3">{t('support_heading')}</h1>
+      <h2 className="f3">{t('support_heading')}</h2>
       <div className="container-xl mx-auto py-6 py-lg-6 clearfix border-top border-color-secondary">
         {showSurvey && (
           <div
diff --git a/components/page-footer/Survey.tsx b/components/page-footer/Survey.tsx
index 2dec484764..11421cf6a0 100644
--- a/components/page-footer/Survey.tsx
+++ b/components/page-footer/Survey.tsx
@@ -80,7 +80,7 @@ export const Survey = () => {
 
   return (
     <form className="f5" onSubmit={submit} ref={formRef} data-testid="survey-form">
-      <h2 className="f4 mb-3">{t`able_to_find`}</h2>
+      <h3 className="f4 mb-3">{t`able_to_find`}</h3>
 
       {/* Honeypot: token isn't a real field */}
       <input type="text" className="d-none" name="survey-token" aria-hidden="true" />

From adea632fe2c44dab1aedc2e86f934090c7cadf91 Mon Sep 17 00:00:00 2001
From: Robert Sese <734194+rsese@users.noreply.github.com>
Date: Fri, 14 Apr 2023 15:09:49 -0500
Subject: [PATCH 2/2] add no breadcrumb at xl playwright test (#36397)

---
 tests/browser/browser.js                         | 16 ----------------
 .../playwright-rendering.spec.ts                 | 14 ++++++++++++++
 2 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/tests/browser/browser.js b/tests/browser/browser.js
index 0f5320435d..58693ced91 100644
--- a/tests/browser/browser.js
+++ b/tests/browser/browser.js
@@ -145,22 +145,6 @@ describe('browser search', () => {
   })
 })
 
-describe('x-large viewports - 1280+', () => {
-  jest.setTimeout(60 * 1000)
-  it('in article breadcrumbs at xl viewport should remove last breadcrumb', async () => {
-    await page.setViewport({ width: 1300, height: 700 })
-    await page.goto(
-      'http://localhost:4000/en/enterprise-cloud@latest/admin/identity-and-access-management/managing-iam-for-your-enterprise/about-authentication-for-your-enterprise'
-    )
-    const breadcrumbsElement = await page.$$('[data-testid=breadcrumbs-in-article] ul li')
-    const breadcrumbsMissingElement = await page.$$(
-      '[data-testid=breadcrumbs-in-article] ul li .d-none'
-    )
-    expect(breadcrumbsMissingElement.length).toBe(1)
-    expect(breadcrumbsElement.length).toBe(4)
-  })
-})
-
 describe('large -> x-large viewports - 1012+', () => {
   jest.setTimeout(60 * 1000)
   it('version picker is visible in header', async () => {
diff --git a/tests/rendering-fixtures/playwright-rendering.spec.ts b/tests/rendering-fixtures/playwright-rendering.spec.ts
index b07db8a78c..7f6f27dc9c 100644
--- a/tests/rendering-fixtures/playwright-rendering.spec.ts
+++ b/tests/rendering-fixtures/playwright-rendering.spec.ts
@@ -228,3 +228,17 @@ test('hovercards', async ({ page }) => {
   await page.locator('#article-contents').getByRole('link', { name: 'introduction' }).hover()
   await expect(page.getByText('You can use GitHub Pages to showcase')).toBeVisible()
 })
+
+test('x-large viewports - 1280+', async ({ page }) => {
+  page.setViewportSize({
+    width: 1300,
+    height: 700,
+  })
+  await page.goto('/get-started/foo/bar')
+
+  // in article breadcrumbs at xl viewport should remove last breadcrumb so
+  // for this page we should only have 'Get Started / Foo'
+  expect(await page.getByTestId('breadcrumbs-in-article').getByRole('link').all()).toHaveLength(2)
+  await expect(page.getByTestId('breadcrumbs-in-article').getByText('Foo')).toBeVisible()
+  await expect(page.getByTestId('breadcrumbs-in-article').getByText('Bar')).not.toBeVisible()
+})