From ea5f2988594b39e4ae0e030bbbadc07d93e6cc85 Mon Sep 17 00:00:00 2001 From: Matt Hall Date: Tue, 9 Mar 2021 13:00:58 -0400 Subject: [PATCH 1/8] Clearer instructions I was unclear on how to upload a file and found the instructions oddly worded. Also fixed a missing word in 3rd 'About gists' bullet point. --- content/github/writing-on-github/creating-gists.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/github/writing-on-github/creating-gists.md b/content/github/writing-on-github/creating-gists.md index f6ca69abb9..c91549cd13 100644 --- a/content/github/writing-on-github/creating-gists.md +++ b/content/github/writing-on-github/creating-gists.md @@ -33,7 +33,7 @@ If your site administrator has disabled private mode, you can also use anonymous You'll receive a notification when: - You are the author of a gist. - Someone mentions you in a gist. -- You subscribe to a gist, by clicking **Subscribe** at the top any gist. +- You subscribe to a gist, by clicking **Subscribe** at the top of any gist. {% if currentVersion == "free-pro-team@latest" or enterpriseServerVersions contains currentVersion %} @@ -55,7 +55,7 @@ Gist supports mapping GeoJSON files. These maps are displayed in embedded gists, ### Creating a gist -You can also drag and drop a text file from your desktop directly into the gist editor. +Follow the steps below to create a gist. {% if currentVersion == "free-pro-team@latest" or currentVersion ver_gt "enterprise-server@2.19" or currentVersion == "github-ae@latest" %} {% note %} @@ -70,7 +70,7 @@ You can also create a gist using the {% data variables.product.prodname_cli %}. 3. Type an optional description and name for your gist. ![Gist name description](/assets/images/help/gist/gist_name_description.png) -4. Type the text of your gist into the gist text box. +4. Type the text of your gist into the gist text box. Alternatively, you can drag and drop a text file from your desktop directly into the editor. ![Gist text box](/assets/images/help/gist/gist_text_box.png) 5. Optionally, to create {% if currentVersion == "github-ae@latest" %}an internal{% else %}a public{% endif %} gist, click {% octicon "triangle-down" aria-label="The downwards triangle icon" %}, then click **Create {% if currentVersion == "github-ae@latest" %}internal{% else %}public{% endif %} gist**. From 483dd1702ef8d7035a32232320cfc18edaf1b243 Mon Sep 17 00:00:00 2001 From: Florian Imdahl Date: Thu, 1 Apr 2021 07:44:10 +0200 Subject: [PATCH 2/8] Update enabling-and-disabling-version-updates.md --- .../enabling-and-disabling-version-updates.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/code-security/supply-chain-security/enabling-and-disabling-version-updates.md b/content/code-security/supply-chain-security/enabling-and-disabling-version-updates.md index ed1b037ce0..a61ecb8370 100644 --- a/content/code-security/supply-chain-security/enabling-and-disabling-version-updates.md +++ b/content/code-security/supply-chain-security/enabling-and-disabling-version-updates.md @@ -114,7 +114,7 @@ updates: interval: "daily" # Overwrite any ignores created using `@dependabot ignore` commands ignore: - # Ignore updates to packages that start 'aws' + # Ignore updates to packages that start with 'aws' # Wildcards match zero or more arbitrary characters - dependency-name: "aws*" # Ignore some updates to the 'express' package From f098026b4da52a94d17a00a9ee14d19c3e09f618 Mon Sep 17 00:00:00 2001 From: Sarita Iyer Date: Thu, 1 Apr 2021 10:59:22 -0400 Subject: [PATCH 3/8] moved sentence to earlier note --- content/github/writing-on-github/creating-gists.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/content/github/writing-on-github/creating-gists.md b/content/github/writing-on-github/creating-gists.md index c91549cd13..355b3203e9 100644 --- a/content/github/writing-on-github/creating-gists.md +++ b/content/github/writing-on-github/creating-gists.md @@ -62,6 +62,8 @@ Follow the steps below to create a gist. You can also create a gist using the {% data variables.product.prodname_cli %}. For more information, see "[`gh gist create`](https://cli.github.com/manual/gh_gist_create)" in the {% data variables.product.prodname_cli %} documentation. +Alternatively, you can drag and drop a text file from your desktop directly into the editor. + {% endnote %} {% endif %} @@ -70,7 +72,7 @@ You can also create a gist using the {% data variables.product.prodname_cli %}. 3. Type an optional description and name for your gist. ![Gist name description](/assets/images/help/gist/gist_name_description.png) -4. Type the text of your gist into the gist text box. Alternatively, you can drag and drop a text file from your desktop directly into the editor. +4. Type the text of your gist into the gist text box. ![Gist text box](/assets/images/help/gist/gist_text_box.png) 5. Optionally, to create {% if currentVersion == "github-ae@latest" %}an internal{% else %}a public{% endif %} gist, click {% octicon "triangle-down" aria-label="The downwards triangle icon" %}, then click **Create {% if currentVersion == "github-ae@latest" %}internal{% else %}public{% endif %} gist**. From 2277052509b92e1d16cb22737751da01fd39d25e Mon Sep 17 00:00:00 2001 From: Logan Rosen Date: Thu, 1 Apr 2021 13:58:25 -0400 Subject: [PATCH 4/8] Update link to Linguist troubleshooting documentation --- .../about-repository-languages.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/github/creating-cloning-and-archiving-repositories/about-repository-languages.md b/content/github/creating-cloning-and-archiving-repositories/about-repository-languages.md index 2fde93a169..3e93dd6e4f 100644 --- a/content/github/creating-cloning-and-archiving-repositories/about-repository-languages.md +++ b/content/github/creating-cloning-and-archiving-repositories/about-repository-languages.md @@ -18,7 +18,7 @@ topics: {% data variables.product.product_name %} uses the open source [Linguist library](https://github.com/github/linguist) to determine file languages for syntax highlighting and repository statistics. Language statistics will update after you push changes to your default branch. -Some files are hard to identify, and sometimes projects contain more library and vendor files than their primary code. If you're receiving incorrect results, please consult the Linguist [troubleshooting guide](https://github.com/github/linguist#troubleshooting) for help. +Some files are hard to identify, and sometimes projects contain more library and vendor files than their primary code. If you're receiving incorrect results, please consult the Linguist [troubleshooting guide](https://github.com/github/linguist/blob/master/docs/troubleshooting.md) for help. ### Markup languages From c958ff071c3777559dc95bddfd41c1e8520472d1 Mon Sep 17 00:00:00 2001 From: Aaron Harpole Date: Fri, 2 Apr 2021 02:02:18 -0700 Subject: [PATCH 5/8] Adding some extra detail around renaming (#4830) Co-authored-by: Lucas Costi --- .../github/administering-a-repository/renaming-a-branch.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/content/github/administering-a-repository/renaming-a-branch.md b/content/github/administering-a-repository/renaming-a-branch.md index 2386a11954..4bf0adb79c 100644 --- a/content/github/administering-a-repository/renaming-a-branch.md +++ b/content/github/administering-a-repository/renaming-a-branch.md @@ -4,7 +4,7 @@ intro: You can change the name of a branch in a repository. permissions: People with write permissions to a repository can rename a branch in the repository. People with admin permissions can rename the default branch. versions: free-pro-team: '*' - enterprise-server: '>=3.1' + enterprise-server: '>=3.2' topics: - repositories --- @@ -13,7 +13,9 @@ topics: You can rename a branch in a repository on {% data variables.product.product_location %}. For more information about branches, see "[About branches](/github/collaborating-with-issues-and-pull-requests/about-branches)." -If you rename a branch, {% data variables.product.prodname_dotcom %} will automatically redirect links on {% if currentVersion == "free-pro-team@latest" %}{% data variables.product.prodname_dotcom_the_website %}{% else %}{% data variables.product.product_location_enterprise %}{% endif %} that contain the old branch name to the equivalent link on the renamed branch. {% data variables.product.prodname_dotcom %} will also update branch protection policies, as well as the base branch for open pull requests and draft releases. +When you rename a branch on {% data variables.product.product_location %}, any URLs that contain the old branch name are automatically redirected to the equivalent URL for the renamed branch. Branch protection policies are also updated, as well as the base branch for open pull requests (including those for forks) and draft releases. After the rename is complete, {% data variables.product.prodname_dotcom %} provides instructions on the repository's home page directing contributors to update their local Git environments. + +Although file URLs are automatically redirected, raw file URLs are not redirected. Also, {% data variables.product.prodname_dotcom %} does not perform any redirects if users perform a `git pull` for the previous branch name. ### Renaming a branch From 154884cd79bdd5e2f0873022015ec8f0e38102fb Mon Sep 17 00:00:00 2001 From: lowlighter <22963968+lowlighter@users.noreply.github.com> Date: Fri, 2 Apr 2021 13:07:42 +0200 Subject: [PATCH 6/8] Add PullRequestReviewEvent documentation --- .../webhooks-and-events/github-event-types.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/content/developers/webhooks-and-events/github-event-types.md b/content/developers/webhooks-and-events/github-event-types.md index 72098b42fa..3abcd29f20 100644 --- a/content/developers/webhooks-and-events/github-event-types.md +++ b/content/developers/webhooks-and-events/github-event-types.md @@ -181,6 +181,19 @@ This event returns an empty `payload` object. {% data reusables.webhooks.pull_request_event_api_properties %} {% data reusables.webhooks.pull_request_properties %} +### PullRequestReviewEvent + +{% data reusables.webhooks.pull_request_review_short_desc %} +{% data reusables.webhooks.events_api_payload %} + +#### Event `payload` object + +Key | Type | Description +----|------|------------- +`action` | `string` | The action that was performed. Can be `created`. +`pull_request` | `object` | The pull request the review pertains to. +`review` | `object` | The review that was affected. + ### PullRequestReviewCommentEvent {% data reusables.webhooks.pull_request_review_comment_short_desc %} @@ -198,6 +211,8 @@ This event returns an empty `payload` object. {% data reusables.webhooks.events_api_payload %} +#### Event `payload` object + Key | Type | Description ----|------|------------- `push_id` | `integer` | Unique identifier for the push. From 92a55f75dc3a7aec5e11e09a13c797c69ed7a1ea Mon Sep 17 00:00:00 2001 From: lowlighter <22963968+lowlighter@users.noreply.github.com> Date: Fri, 2 Apr 2021 13:17:51 +0200 Subject: [PATCH 7/8] Add missing line-break in PullRequestReviewEvent --- content/developers/webhooks-and-events/github-event-types.md | 1 + 1 file changed, 1 insertion(+) diff --git a/content/developers/webhooks-and-events/github-event-types.md b/content/developers/webhooks-and-events/github-event-types.md index 3abcd29f20..18c5d27720 100644 --- a/content/developers/webhooks-and-events/github-event-types.md +++ b/content/developers/webhooks-and-events/github-event-types.md @@ -184,6 +184,7 @@ This event returns an empty `payload` object. ### PullRequestReviewEvent {% data reusables.webhooks.pull_request_review_short_desc %} + {% data reusables.webhooks.events_api_payload %} #### Event `payload` object From efc9d4c15091e810f1c8dcf1ad3d82be46262496 Mon Sep 17 00:00:00 2001 From: Abdul Aziz Al Basyir Date: Sat, 3 Apr 2021 01:14:42 +0700 Subject: [PATCH 8/8] remove `.git` for example folder (#5016) --- .../duplicating-a-repository.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/content/github/creating-cloning-and-archiving-repositories/duplicating-a-repository.md b/content/github/creating-cloning-and-archiving-repositories/duplicating-a-repository.md index 69243b563c..d0990e60e8 100644 --- a/content/github/creating-cloning-and-archiving-repositories/duplicating-a-repository.md +++ b/content/github/creating-cloning-and-archiving-repositories/duplicating-a-repository.md @@ -23,13 +23,13 @@ Before you can duplicate a repository and push to your new copy, or _mirror_, of ``` 3. Mirror-push to the new repository. ```shell - $ cd old-repository.git + $ cd old-repository $ git push --mirror https://{% data variables.command_line.codeblock %}/exampleuser/new-repository.git ``` 4. Remove the temporary local repository you created earlier. ```shell $ cd .. - $ rm -rf old-repository.git + $ rm -rf old-repository ``` ### Mirroring a repository that contains {% data variables.large_files.product_name_long %} objects @@ -41,7 +41,7 @@ Before you can duplicate a repository and push to your new copy, or _mirror_, of ``` 3. Navigate to the repository you just cloned. ```shell - $ cd old-repository.git + $ cd old-repository ``` 4. Pull in the repository's {% data variables.large_files.product_name_long %} objects. ```shell @@ -58,7 +58,7 @@ Before you can duplicate a repository and push to your new copy, or _mirror_, of 7. Remove the temporary local repository you created earlier. ```shell $ cd .. - $ rm -rf old-repository.git + $ rm -rf old-repository ``` ### Mirroring a repository in another location @@ -72,7 +72,7 @@ If you want to mirror a repository in another location, including getting update ``` 3. Set the push location to your mirror. ```shell - $ cd repository-to-mirror.git + $ cd repository-to-mirror $ git remote set-url --push origin https://{% data variables.command_line.codeblock %}/exampleuser/mirrored ```