Kevin Heis
a99924640a
Add link_container property to link events ( #40413 )
2023-08-09 15:17:54 +00:00
Hector Alfaro
82e81b5cd4
Wrap sidebar in a nav element ( #40171 )
2023-08-02 17:31:40 +00:00
Hector Alfaro
9b4997196c
Remove banner landmark for side nav, mark up multiple nav elements ( #40045 )
2023-07-31 18:58:46 +00:00
Robert Sese
913703d877
a11y: increase breakpoint width where we hide/show sidebar ( #39465 )
...
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
2023-07-26 20:01:03 +00:00
Grace Park
5b2c714950
Remove sidebarhomepage and add external links to More docs ( #39738 )
2023-07-26 19:27:36 +00:00
Grace Park
bcf79e2a92
Update link to outside li for TreeView ( #39627 )
2023-07-25 17:02:39 +00:00
Grace Park
f3f45a9f06
Add aria-labelledby and aria-label to sidebar ( #39605 )
2023-07-24 18:36:20 +00:00
Grace Park
0ad14484a6
Update nav for accessibility ( #39376 )
2023-07-20 17:16:05 +00:00
Grace Park
36d942900f
Keep active element in visible view on keyboard navigation in sidebar ( #39272 )
2023-07-19 17:58:19 +00:00
Grace Park
f910e1d143
Accessibility updates for homepage sidebar ( #37414 )
...
Co-authored-by: Hector Alfaro <hectorsector@github.com >
2023-07-13 15:53:49 +00:00
Peter Bengtsson
2ec905fc77
trailingCommas:all on prettier ( #38888 )
2023-07-11 11:44:52 +00:00
Peter Bengtsson
9041a57ae5
Refactor how currentProductTree works ( #37808 )
...
Co-authored-by: Grace Park <gracepark@github.com >
2023-07-10 19:26:10 +00:00
Kevin Heis
ac38ab609e
Import from the src directory in Node using #src ( #37578 )
2023-06-05 21:44:20 +00:00
Kevin Heis
cad57eeca3
Create landings subject folder ( #37416 )
2023-06-02 17:50:08 +00:00
Kevin Heis
ab91bc6b43
Move more REST files into src ( #37026 )
...
Co-authored-by: Rachael Sewell <rachmari@github.com >
2023-05-11 17:17:57 +00:00
Kevin Heis
2d15c92e84
Move a few more files into events src ( #36574 )
2023-05-08 15:33:13 +00:00
Grace Park
8356ab490b
Keyboard navigation treeview ( #36557 )
2023-04-26 16:58:45 +00:00
Kevin Heis
cc5a0e9613
Aria labelledby ( #36370 )
2023-04-13 16:35:30 +00:00
Kevin Heis
87db182e58
Add aria-labelledby to sidebar nav ( #36317 )
2023-04-11 21:09:14 +00:00
Kevin Heis
022c8b03e6
Add aria-label to external site icons ( #36269 )
2023-04-07 17:12:11 +00:00
Grace Park
a428d85b26
Add aria-label to nav for sidebar ( #36205 )
2023-04-05 18:03:45 +00:00
Grace Park
7ecafa279d
Updating sidebar to TreeView ( #35455 )
2023-03-28 16:58:13 +00:00
Peter Bengtsson
07a3e2a48c
Preview hover cards ( #34702 )
...
Co-authored-by: Grace Park <gracepark@github.com >
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com >
2023-03-21 19:59:49 +00:00
Kevin Heis
0c67aadebc
Move events into subject folder ( #35262 )
2023-03-14 15:53:42 +00:00
Robert Sese
e5370a5990
Feature Branch: Global Nav Phase 2 ( #34359 )
...
Co-authored-by: Grace Park <gracepark@github.com >
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com >
2023-02-13 17:37:47 +00:00
Grace Park
ef2efb0636
Feature Branch: Global Nav Phase 1 ( #33465 )
...
Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com >
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com >
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2023-01-31 17:49:50 +00:00
Grace Park
baa53b778f
Picker refactor ( #33113 )
...
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2022-12-07 23:17:06 +00:00
Grace Park
53f54707c5
Updating to check apiVersion is a real apiVersion ( #33058 )
...
Co-authored-by: Rachael Sewell <rachmari@github.com >
2022-11-29 19:23:54 +00:00
Grace Park
e3f8f71c42
Rest api versioning redo ( #33011 )
...
Co-authored-by: Rachael Sewell <rachmari@github.com >
Co-authored-by: Sarah Edwards <skedwards88@github.com >
Co-authored-by: Grace Park <gracepark@Graces-MacBook-Pro-2.local >
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com >
Co-authored-by: Sarah Schneider <sarahs@github.com >
2022-11-28 11:55:02 -08:00
Peter Bengtsson
64ee6b2f09
optimize the getCurrentProductTree function ( #31620 )
2022-10-27 20:13:00 +00:00
Peter Bengtsson
b1dc21ccbd
make 'All products' link a Router link ( #31642 )
2022-10-12 17:04:23 +00:00
Sarah Edwards
d2a2113c11
REST new user guidance ( #29642 )
2022-08-23 19:31:01 +00:00
Peter Bengtsson
8765c628ff
dedicated search results page (redux) ( #29902 )
...
* dedicated search results page (redux)
* Update SearchResults.tsx
* adding pagination
* fix pagination
* say something on NoQuery
* better Flash
* tidying link
* small fixes for results
* debug info
* l18n the meta info
* inDebugMode
* basic jest rendering of the skeleton page
* basic jest rendering test
* fix content tests
* better document title
* fix tests
* quote query in page title
* use home page sidebar
* something when nothing is found
* parseInt no longer needs the 10
* fix linting tests
* fix test
* prettier
* Update pages/search.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
2022-08-19 13:36:55 +00:00
Rachael Sewell
26e4dbc4bf
refactor rest context provider to be generic ( #29021 )
2022-07-14 14:09:38 +00:00
Grace Park
822fe2926b
Megabranch: Upgrade primer/react ( #28458 )
...
* upgrade primer/react
* upgrade
* using deprecated
* remove lib"
* Upgrade primer/react: Upgrade Label (#28502 )
update Label to primer/react 35.2.2
* fix merge conflicts
* primer/react v35: update ActionList (#28467 )
* Update to v35 ActionList for LearningTrack
* Update to v35 ActionList for ArticleList
* Update to v35 ActionList for ProductArticleList
* Update to v35 ActionList for TableOfContents
* Update to v35 ActionList for ProductCollapsibleSection
* Update to v35 ActionList for RestCollapsibleSection
* Update to v35 ActionList for SidebarHomepage
* Update to v35 ActionList for MiniTocs
* Update to v35 ActionList for Search
* Extra div for rendering test
* One less div for rendering test
* All the style updates for v35 ActionList
* Works without setting as an li which is already the default (didn't before for some reason)
* Use deprecated ItemInput for now
* Picker update for primer/react (#28485 )
* update picker
* inline picker for mobile
* set width to auto
* Update components/ui/Picker/Picker.tsx
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
* update
* Update Picker.tsx
* update onselect
* checking language code
* move language cookie setting to language picker
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
* Resolve package merge conflicts
* fresh npm install
* Primer update UnderlineNav (#28582 )
* update underlinenav for primer/react update
* update tests
* update switches test
* update one last label
* update header test"
* remove href in underlinenav
* update rendering tests
* update cursor
* primer/react v35: update DropDownMenu to ActionMenu (#28576 )
* Update to v35 ActionMenu for ArticleCards
* Update to v35 ActionMenu for Search
* Set button to inline-block
* Put the props on the overlay
* Update test for ActionMenu markup
* update package
* update package lock
* primer/react v35: CodeLanguagePicker update from SelectMenu to ActionMenu (#28625 )
* Use octicon for menu down arrow
* Update to v35 ActionMenu for CodeLanguagePicker
* update to SubNav
Co-authored-by: Grace Park <gracepark@github.com >
* update package-lock
Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com >
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
2022-07-11 11:51:18 -07:00
Peter Bengtsson
071c95a91c
make miniToc pure data and no html strings ( #28517 )
...
* make miniToc pure data and no html strings
* fixups
* some types refactoring
2022-06-15 18:31:36 +00:00
Grace Park
2e821f52ff
REST subcategory/category rendering test and refactor test-open-api-schema ( #27138 )
...
* first stage of test
* update test
* add rest test for categories and subcategories rendering
* update timeout back to original
* remove export
* remove testing
* refactor test-open-api-schema
* remove function
* remove check
* remove slash
* remove comment
* rearrange
* update getting the categories and maptopic levels
* update tests
* update copy
* add error message task
2022-05-10 17:09:47 +00:00
Grace Park
982d596d28
REST Bug fixes: Guides/Overview useEffect, duplicate key ( #27414 )
...
* add conditional in useeffect
* fix duplicate key error
* consolidate conceptual article check
* remove unnecessary currentanchor
* revert consolidating variable
Co-authored-by: Rachael Sewell <rachmari@github.com >
2022-05-02 13:39:53 -07:00
Grace Park
f5bffa3817
REST API Pages: active anchor highlighting on scroll sidebar ( #27310 )
...
* add anchor highlighting
* update to show active when going to direct anchor link
* update rootMargin
2022-04-28 12:26:28 -07:00
Grace Park
b98c83e924
REST operations sidebar ( #26225 )
...
* testing out a rest operations sidebar
* cleanup
* renamed 5 files
* renamed 5 files
* set redirect_from on 5 files
* renamed 1 files
* renamed 1 files
* renamed 3 files
* renamed 1 files
* renamed 1 files
* renamed 3 files
* renamed 1 files
* renamed 2 files
* renamed 1 files
* renamed 4 files
* renamed 15 files
* renamed 2 files
* renamed 6 files
* renamed 1 files
* renamed 4 files
* renamed 7 files
* renamed 1 files
* renamed 3 files
* renamed 3 files
* renamed 1 files
* renamed 5 files
* renamed 1 files
* renamed 1 files
* renamed 3 files
* renamed 4 files
* renamed 1 files
* renamed 1 files
* renamed 2 files
* renamed 4 files
* renamed 1 files
* renamed 1 files
* renamed 1 files
* renamed 6 files
* renamed 6 files
* renamed 4 files
* move files
* adding more
* updating to add restcontext and start of removing data/reusables/rest-reference
* removed data/reusables
* add a RestMiniTocItem and updating the filtering to add a subcategory so all manually added H3s are in mini tocs in addition to operations
* remove console log
* [WIP]: REST New Proposal Sidebar (#26471 )
* saving
* update sidebar
* remove console log
* update guides and overview
* import Category for category level rest pages
* update undefined restOperations
* update restOperationData category and subcategory levels"
* minor updates
* update get mini toc items function
* updating REST context for sidebar
* updating rest data
* remove console logs
* WIP: mini-toc-ing the sidebar
Co-authored-by: Robert Sese <rsese@github.com >
* A little cleanup
* Fix first subcategory link and add some comments
* updating anchor links in sidebar
* adding updates
* remove standalone
* update product and maptopic pages using article context
* add conditional link wrapper
* fix sidebar toggle and versions for enterprise admin
* update versions per subcategory
* Highlight sidebar link for current page
* Update miniToc hash links and hash change tracking
* fix unique key in CollapsibleSection
* Fix list markup
* remove title
* update permissions
* Hide minitocs on landing (#26594 )
* hide minitocs on landing page
* simplify page components and remove minitoc from sidebar for guides/overview
* fix carats and category fix
* remove id
Co-authored-by: Grace Park <gracepark@github.com >
* updating content based on versions script check with the OpenAPI
* update script and content files
* update script and content/rest files
* update to add TocLanding
* update script
* update index files
* add codespaces repository-secrets
* remove openapi schema check script
* remove minitocs at the top
* add h2 about the {title} api
* fix tests/unit/openapi-schema.js
* Fix linting tests
* fix search/topics test
* fix tests/unit/pages test
* update rest/reference links in components
* run prettier
* Update components/rest/RestReferencePage.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update components/rest/RestReferencePage.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update tests/unit/openapi-schema.js
Co-authored-by: Rachael Sewell <rachmari@github.com >
* updating comment location
* remove dependabot override
* remove path-utils current product update for rest
* run linter
* remove dependabot.md and remove h2 heading on restreference
* update the correct product to rest for rest pages
* adding comments for updates to path-utils
* remove console log
* REST sidebar: handle legacy v3 redirects (#26686 )
* Add script to handle legacy v3 REST redirects
* Run the script
* Handle a redirect to a redirect
* Update REST test URLs
* 'await' and test runs subcategory of checks
* Update REST URLs for routing/developer-site-redirects tests
* Update developer-redirects fixture with new REST URLs
* Resolve merge conflicts
* Update rest-redirects fixture with new REST URLs
* Fix broken links with REST pages re-org
* redirectTo could be undefined
* Fix script for posterity, can't redirect paths with hashes
* Remove invalid hash redirects
* Typically don't need to save one-off scripts
* Undo redirect changes (not necessary for handling v3 redirects)
* Remove script-added redirects
* Update old v3 redirects with new REST URLs
* No more GHES search indexing page
* 'org' not 'organization'
* Update fixture data for new REST URLs
* revert any content directory changes
Co-authored-by: Grace Park <gracepark@github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Adding test rest (#26750 )
* add test to check openapi schema versions and content rest frontmatter versions
* update lib/redirects
* fix test and add error messages
* adding repository secrets
* adding repository-secrets.md
* Revert "update lib/redirects"
This reverts commit 3aafe28265764d5bc09c0c478c8e0ca099c8fbcf.
* remove lib/redirects changes and console logs
* Update lib/rest/index.js
Co-authored-by: Rachael Sewell <rachmari@github.com >
* update unique key
* Rest client side redirects (#26754 )
* adding tags subcategory for the rest content repos category
* run prettier
* bug fix for anchor scrolls" (#26892 )
* updating width size for rest reference page
* Rest sidebar consolidation (#26862 )
* refactor sidebar
* fix articlecontext provider issue on rest product landing page for all versions
* fix a bug, create new component
* revert change to create new component and fix bug
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Set currentAnchor with a hashchange handler (#26923 )
* Rest sidebar design tweaks (#26807 )
* Rest sidebar design tweaks
* tweak color to subtle
* use muted color and margin for line
* update to design feedback
Co-authored-by: Grace Park <gracepark@github.com >
* Remove cheerio from rest-collapsible (#26948 )
* remove cheerio from rest-collapsible
* update type
* adding endswith instead
* use productId instead
* one off edge case for secret-scanning
* Reorganize subcategory and category, Update pre -> div, Add RestContext (#26950 )
* reorganize subcategory and category
* add RestContext
* update comment
* update for endpoints page
* add comment
* move object to restcontext
* remove effectiveDate in restcontext
* remove width calculation for rest reference page
* fix adding manual writer's minitocs to sidebar
* update with feedback
* update comment
* update isRestReferencePage
* remove page component and fix bug
* adding back rest/index.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* update content/rest"
* add back design tweak
* update to div
* update margins on rest api reference
* remove page component
* adding tests
* separate product from rest sidebar (#27065 )
* separate product from rest sidebar
* Use ProductCollapsibleSections for product pages
* fix tests
Co-authored-by: Robert Sese <rsese@github.com >
Co-authored-by: Grace Park <gracepark@github.com >
* Rest sidebar translations (#27052 )
* update translations
* remove general test
Co-authored-by: Robert Sese <rsese@github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
2022-04-20 10:19:48 -07:00
Ramya Parimi
ae8beecb78
Sidebar Nav improvements ( #21500 )
...
* 300px sidebar
* Show nested child page count
* labels to left and ellipses
* section header lowercase
* prettier removed ,
* show more button
* Update components/sidebar/SidebarProduct.tsx
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
* Update components/sidebar/SidebarProduct.tsx
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
* show more for child pages instead of products.
Font size of product title increased.
* remove truncate
* show more
* state-ify terminalpagelink component
* product name lowercase
* added counter label
* merge conflicts, remove counter label
* Update components/sidebar/SidebarProduct.tsx
Co-authored-by: Robert Sese <rsese@github.com >
Co-authored-by: Robert Sese <sese@github.com >
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
Co-authored-by: Robert Sese <rsese@github.com >
2022-03-10 09:42:20 -08:00
Mike Surowiec
f3fc80cf05
Upgrade primer/components -> primer/react ( #25591 )
...
* upgrade primer/components -> primer/react
* fix jest failure
2022-02-24 00:30:14 +00:00
Robert Sese
c5f9788223
Version the 'All products' link ( #24972 )
...
* Don't show link no matter what version you're on
* Maintain current version in link
* No 'All products' link on homepage for all versions
2022-02-03 16:31:05 +00:00
Grace Park
934b255119
add keyboard focus to scroll top and remove wording to keep one button ( #24817 )
2022-01-31 17:45:44 +00:00
Grace Park
a3b81bb93c
restructure footer and header ( #24601 )
2022-01-24 15:19:45 -08:00
Peter Bengtsson
7d75265b01
hydration fails on CollapsibleSection with hash in URL ( #24105 )
2022-01-07 02:25:16 +00:00
Robert Sese
9dbc44100c
Misc accessibility bits ( #23495 )
...
* Fix and make article date format consistent
* Add aria-label to repo icon
* Remove unnecessary title attribute
2021-12-08 19:01:40 +00:00
Robert Sese
74c94121be
Use Primer ActionList for sidebar ( #22885 )
...
* Initial move to ActionLists nav, handle terminal links
* ActionList-ify map topic items
* Some 🎨
* ActionList-ify homepage sidebar
* More 🎨
* Resolve test failures (and 'better' markup?)
* Properties don't exist on ActionList
* Use ul + li elements for ActionLists
* Workaround for TS error with 'as='
Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com >
2021-11-23 18:33:54 +00:00
Kevin Heis
58fbe1edf5
Move px to rem in scss files ( #23009 )
...
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com >
2021-11-19 21:06:45 +00:00
Grace Park
596207f743
update to color-bg-default ( #22482 )
...
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
2021-10-29 15:05:48 +00:00