- pull_request is more dynamic in its life-cycle than check_suite as
subsequent git pushes are made
- ∴ the PR's latest head_sha may not match the check_suite's head_sha
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Grace Park <gracepark@github.com>
* Deprecate 3.0
* 3.0 deprecation: remove 3.0 markup (#25647)
* Remove liquid conditionals and content for 3.0 deprecation
* Remove manually, no longer versioned in a supported version
* Remove translations manually, no longer versioned in a supported version
* Remove 'if', now in all supported versions
* Remove dangling 'elseif', now in all supported versions
* Remove dangling 'elseif' and 3.0 screenshot reference, now in all supported versions
* Nudge to latest supported GHES version
* Nudge to latest supported release GHES version
* Bump all the version for the liquid tests
* Bump first deprecated version for linting tests
* Prefer double quotes
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Prefer double quotes
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Prefer double quotes
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Prefer double quotes
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Prefer double quotes
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Prefer double quotes
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Prefer double quotes
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Prefer double quotes
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Prefer double quotes
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Remove extra newline
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Remove extra newline
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Remove extra newline
Co-authored-by: Laura Coursen <lecoursen@github.com>
* One reusable per line
Co-authored-by: Laura Coursen <lecoursen@github.com>
* One reusable per line
Co-authored-by: Laura Coursen <lecoursen@github.com>
* One reusable per line
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Version check not needed anymore
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Version check not needed anymore
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Version check not needed anymore
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Version check not needed anymore
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Version check not needed anymore
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Version check not needed anymore
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Version check not needed anymore
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Stray whitespace ✂️
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Stray whitespace ✂️
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Stray whitespace ✂️
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Stray whitespace ✂️
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Stray whitespace ✂️
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Stray whitespace ✂️
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Stray whitespace ✂️
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Stray whitespace ✂️
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Version check not needed anymore
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Version check not needed anymore
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Just 'ghes' since we're deprecating 3.0
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Just 'ghes' since we're deprecating 3.0
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Just 'ghes' since we're deprecating 3.0
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Just 'ghes' since we're deprecating 3.0
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Just 'ghes' since we're deprecating 3.0
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Just 'ghes' since we're deprecating 3.0
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Just 'ghes' since we're deprecating 3.0
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Just 'ghes' since we're deprecating 3.0
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Don't depend on hardcoded versions
Co-authored-by: Laura Coursen <lecoursen@github.com>
* Remove static files for 3.0 deprecation (#25649)
Co-authored-by: Laura Coursen <lecoursen@github.com>
My tests lead me to the assumption, that the `released`-action is only triggered when a release is done (either directly or by finishing a draft).
The docs say, `release` is also triggered when a release-draft is published. But IMO this isn't the case. And it wouldn't make sense with an action called `release`, as a draft is NOT a release.
* Use in_progress workflow_job example, not queued
### tl;dr
This changes the example `workflow_job` payload to be an `in_progress` event instead of `queued` event.
### why
In #22174, I added some keys to the example workflow_job json. This was correct, but by adding non-null _values_, **I introduced a subtle bug**.
It's a bug because a `queued` workflow is—by definition—_not_ yet assigned to a runner. So all the `runner_*` attributes will be `null` in the real world.
After the workflow becomes `in_progress`, all the values are guaranteed to exist. So let's change the example to be an `in_progress` event, since it's a better example for documentation.
* Explain more about the runner_* attributes in "workflow_job_properties.md"
* Consistentize naming
Co-authored-by: Martin Lopes <martin389@github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
