1
0
mirror of synced 2025-12-21 10:57:10 -05:00
Commit Graph

20 Commits

Author SHA1 Message Date
Kevin Heis
8a56437c93 Pretty format (#20352)
* Update prettier flow to include JS

* Run prettier

* ...run prettier
2021-07-14 14:35:01 -07:00
Kevin Heis
42e785b0a8 Migrate CommonJS to ESM (#20301)
* First run of script

* Get the app running --- ish

* Get NextJS working

* Remove `node:`

* Get more tests passing in unit directory

* Update FailBot test to use nock

* Update test.yml

* Update Dockerfile

* tests/content fixes

* Update page.js

* Update build-changelog.js

* updating tests/routing

* Update orphan-tests.js

* updating tests/rendering

* Update .eslintrc.js

* Update .eslintrc.js

* Install jest/globals

* "linting" tests

* staging update to server.mjs

* Change '.github/allowed-actions.js' to a ESM export

* Lint

* Fixes for the main package.json

* Move Jest to be last in the npm test command so we can pass args

* Just use 'npm run lint' in the npm test command

* update algolia label script

* update openapi script

* update require on openapi

* Update enterprise-algolia-label.js

* forgot JSON.parse

* Update lunr-search-index.js

* Always explicitly include process.cwd() for JSON file reads pathed from project root

* update graphql/update-files.js script

* Update other npm scripts using jest to pass ESM NODE_OPTIONS

* Update check-for-enterprise-issues-by-label.js for ESM

* Update create-enterprise-issue.js for ESM

* Import jest global for browser tests

* Convert 'script/deploy' to ESM

Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: James M. Greene <jamesmgreene@github.com>
2021-07-14 13:49:18 -07:00
James M. Greene
2dbae93c53 Try to prevent late/duplicate response errors (#20077)
* Ensure all Express 'next' calls include 'return's

* Add headersSent checks during archived versions flow

* Return a 404 earlier if archived resource fetch fails

* Short-circuit responses for archived stuff

* Be more careful about responding to and short-circuiting after search requests

* Fix tests
2021-06-28 19:31:54 +00:00
Kevin Heis
a92d820888 Remove remaining JSON requires (#20110)
* Remove remaining JSON requires

* Lint

* Update feature-flags.js
2021-06-23 14:57:50 -07:00
James M. Greene
c940dcd98b Middleware overhaul! (#18218)
* Middleware overhaul!

- Remove unnecessary 'async' keywords from middleware functions
- Ensure all middleware functions we create have names
- Wrap the method contents of all async middleware functions in a try-catch+next(error) pattern

* Use asyncMiddleware wrapper instead of try-catch+next(error) pattern

* Remove unnecessary try-catch+next(error) pattern from context middleware
2021-03-11 01:12:41 +00:00
Sarah Schneider
f1336fd26c need to parse the JSON first 2021-02-24 16:33:14 -05:00
Sarah Schneider
08bbe0396f put the got request in a try to prevent timeouts 2021-02-24 10:58:02 -05:00
Sarah Schneider
dce6e7d5bd udpate middleware to read redirects from top-level redirects.json in archival repo 2021-02-22 11:13:52 -05:00
James M. Greene
4dea2779f3 More explicit terminations of middleware (#17666)
* Be more explicit about next/res.send ending middleware functions

* Add note explaining the one exception
2021-02-03 16:38:41 -06:00
Sarah Schneider
a54c3ffd5a use new static file instead of searching live set of pages 2021-01-19 17:43:55 -05:00
Sarah Schneider
752edcfc53 use new static redirects file instead of precompiling on every server restart 2021-01-19 10:46:32 -05:00
Sarah Schneider
d752732b16 update refs to reinstated findPage() 2021-01-13 16:49:35 -05:00
Sarah Schneider
33f93e39c7 remove overloaded helper functions and move code directly where it is used 2021-01-07 13:14:44 -05:00
Kevin Heis
c62f49aa0e Block indexing not crawling (#17044)
* Block indexing instead of crawling

* Lint

* Update deprecated-enterprise-versions.js

* Combine loops
2020-12-17 11:57:18 -08:00
Kevin Heis
11d8e415da Check repository references (#16680)
* Check repository references

* Remove "foundRepoNames" that I used to find all the unique names

* A little speed up with Set

* Ignore a few files

* Remove remaining references

* Update README.md
2020-12-03 16:41:03 +00:00
Sarah Schneider
67f490752a move is-archived-version into a function instead of middleware 2020-11-18 15:18:50 -05:00
Sarah Schneider
9942fd3950 dry up archived versions middleware checks 2020-11-17 18:46:30 -05:00
Jeff McAffer
a9112d885d fix up redirect paths for Windows 2020-10-09 08:24:01 -07:00
Sarah Schneider
5caa6f282c satisifies -> satisfies (#15814) 2020-09-30 10:28:47 -04:00
Vanessa Yuen
3df90fc9b8 Hello git history spelunker!
Are you looking for something? Here is all of the GitHub Docs history in one single commit. Enjoy! 🎉
2020-09-27 14:10:11 +02:00