1
0
mirror of synced 2025-12-21 02:46:50 -05:00
Commit Graph

16 Commits

Author SHA1 Message Date
Grace Park
2dbea3737a Removing algolia (#20633) 2021-08-05 13:10:51 -04:00
Kevin Heis
8a56437c93 Pretty format (#20352)
* Update prettier flow to include JS

* Run prettier

* ...run prettier
2021-07-14 14:35:01 -07:00
Kevin Heis
42e785b0a8 Migrate CommonJS to ESM (#20301)
* First run of script

* Get the app running --- ish

* Get NextJS working

* Remove `node:`

* Get more tests passing in unit directory

* Update FailBot test to use nock

* Update test.yml

* Update Dockerfile

* tests/content fixes

* Update page.js

* Update build-changelog.js

* updating tests/routing

* Update orphan-tests.js

* updating tests/rendering

* Update .eslintrc.js

* Update .eslintrc.js

* Install jest/globals

* "linting" tests

* staging update to server.mjs

* Change '.github/allowed-actions.js' to a ESM export

* Lint

* Fixes for the main package.json

* Move Jest to be last in the npm test command so we can pass args

* Just use 'npm run lint' in the npm test command

* update algolia label script

* update openapi script

* update require on openapi

* Update enterprise-algolia-label.js

* forgot JSON.parse

* Update lunr-search-index.js

* Always explicitly include process.cwd() for JSON file reads pathed from project root

* update graphql/update-files.js script

* Update other npm scripts using jest to pass ESM NODE_OPTIONS

* Update check-for-enterprise-issues-by-label.js for ESM

* Update create-enterprise-issue.js for ESM

* Import jest global for browser tests

* Convert 'script/deploy' to ESM

Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: James M. Greene <jamesmgreene@github.com>
2021-07-14 13:49:18 -07:00
James M. Greene
2dbae93c53 Try to prevent late/duplicate response errors (#20077)
* Ensure all Express 'next' calls include 'return's

* Add headersSent checks during archived versions flow

* Return a 404 earlier if archived resource fetch fails

* Short-circuit responses for archived stuff

* Be more careful about responding to and short-circuiting after search requests

* Fix tests
2021-06-28 19:31:54 +00:00
Grace Park
d3d1902414 Merge pull request #20017 from github/upgrade-esm
Enforce and Move to Top Level require
2021-06-22 11:27:48 -07:00
Kevin Heis
57e1a1b9c1 End Lunr AB test (#19155)
* Revert "Start an AB test with Lunr search results as treatment (#18993)"

This reverts commit 3d621ba715.

* Update lunr-search.js
2021-05-06 18:04:28 +00:00
Kevin Heis
3d621ba715 Start an AB test with Lunr search results as treatment (#18993)
* Start search_lunr AB test

* Towards prewarming

* Towards prewarming

* Warm only english/dotcom index

* Update warm-server.js
2021-05-04 16:24:19 +00:00
Kevin Heis
f160594a09 Enable set AIRGAP cookie to view Lunr search results (#18648)
* Enable set `lunr` cookie to view Lunr search results

* Use AIRGAP instead of lunr for cookie name
2021-04-09 17:38:32 +00:00
Kevin Heis
2e07070fb9 Add filters params to search endpoint (#18289)
* Add filters params to search endpoint

* Update search.md

* Update middleware/search.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-03-17 21:02:47 +00:00
James M. Greene
c940dcd98b Middleware overhaul! (#18218)
* Middleware overhaul!

- Remove unnecessary 'async' keywords from middleware functions
- Ensure all middleware functions we create have names
- Wrap the method contents of all async middleware functions in a try-catch+next(error) pattern

* Use asyncMiddleware wrapper instead of try-catch+next(error) pattern

* Remove unnecessary try-catch+next(error) pattern from context middleware
2021-03-11 01:12:41 +00:00
Kevin Heis
a3ad549e39 Block a few more things in AIRGAP (#17657)
* Block a few more things in AIRGAP

* Update middleware/context.js

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>

* Update product-landing.html

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
2021-02-09 23:07:23 +00:00
Kevin Heis
8b86fd8fef Reduce minified JS bundle size from 189kb to 73kb (#17552) 2021-01-28 22:12:04 +00:00
Kevin Heis
d9d61f42ef Add Lunr as a site search option (#17388)
* Add Lunr as a site search option

* Use a class like the Algolia option does

* Lint

* Working on showing real content, prep for highlighting

* Move searching to their own files

* Split out ridiculous fn

* Add highlighting

* Less lunr search code

* A little more tidy

* Then chain on write too

* Mark from server too

* Write a batch of indices

* Update compress.js

* Highlighting with fewer calls

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js
2021-01-28 19:38:22 +00:00
Kevin Heis
c51f5390d4 Move search results to use relative urls (#17411)
* Move search results to use relative urls

* ..and now we have real mark tags instead of em tags

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-21 17:23:16 +00:00
Kevin Heis
c21a738e95 Make browser search tests green (#17385)
* Make browser search tests green

* Okay... lodash get then _Linter_ ugh
2021-01-20 16:20:32 +00:00
Kevin Heis
2fb2e962bc Move site search to use an endpoint (#17359)
* Move site search to use an endpoint

* Update browser.js

* Update search.js

* Update lib/search/versions.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Fix URLs

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-01-20 15:37:42 +00:00