1
0
mirror of synced 2025-12-21 10:57:10 -05:00
Commit Graph

48 Commits

Author SHA1 Message Date
Mike Surowiec
06d8f81401 Two-pane Experiment (#21092)
* pull changes from docs-playground

* cleanup, add callout banner

* cleanup linting and test fixes

* add discussion link

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-08-26 14:19:40 -04:00
Mike Surowiec
6bc50f7e30 fix: filter hidden pages from the currentProductTree (SidebarProduct) (#20404)
* fix some async test things

* allow eslint to parse top-level awaits

* fix: filter out hidden pages closer to SidebarProduct usage
2021-07-20 12:32:35 -04:00
Kevin Heis
8a56437c93 Pretty format (#20352)
* Update prettier flow to include JS

* Run prettier

* ...run prettier
2021-07-14 14:35:01 -07:00
Kevin Heis
42e785b0a8 Migrate CommonJS to ESM (#20301)
* First run of script

* Get the app running --- ish

* Get NextJS working

* Remove `node:`

* Get more tests passing in unit directory

* Update FailBot test to use nock

* Update test.yml

* Update Dockerfile

* tests/content fixes

* Update page.js

* Update build-changelog.js

* updating tests/routing

* Update orphan-tests.js

* updating tests/rendering

* Update .eslintrc.js

* Update .eslintrc.js

* Install jest/globals

* "linting" tests

* staging update to server.mjs

* Change '.github/allowed-actions.js' to a ESM export

* Lint

* Fixes for the main package.json

* Move Jest to be last in the npm test command so we can pass args

* Just use 'npm run lint' in the npm test command

* update algolia label script

* update openapi script

* update require on openapi

* Update enterprise-algolia-label.js

* forgot JSON.parse

* Update lunr-search-index.js

* Always explicitly include process.cwd() for JSON file reads pathed from project root

* update graphql/update-files.js script

* Update other npm scripts using jest to pass ESM NODE_OPTIONS

* Update check-for-enterprise-issues-by-label.js for ESM

* Update create-enterprise-issue.js for ESM

* Import jest global for browser tests

* Convert 'script/deploy' to ESM

Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: James M. Greene <jamesmgreene@github.com>
2021-07-14 13:49:18 -07:00
Kevin Heis
d3403e8653 Address goofy exports (#20113)
* Address a goofy export

* Fix more exports

* Change two exports
2021-06-24 14:59:06 +00:00
Sarah Schneider
7de66fe4ef Merge branch 'main' of github.com:github/docs-internal into script-to-use-short-versions 2021-06-24 10:14:50 -04:00
Sarah Schneider
7e3e75616c Merge branch 'main' of github.com:github/docs-internal into feature-versioning 2021-06-23 15:59:37 -04:00
Grace Park
fcf1fdd682 adding james feedback to add single app instance 2021-06-23 11:21:20 -07:00
Grace Park
6c0b43a4bb updating libapp in one script and tests 2021-06-23 10:46:10 -07:00
Sarah Schneider
c4d6ae71a0 fix versions schema 2021-06-22 10:40:02 -04:00
Sarah Schneider
7f0737b162 add feature versions schema and tests 2021-06-17 14:41:31 -04:00
Sarah Schneider
f4b455b0c3 move from test helpers to script helpers 2021-06-16 13:14:55 -04:00
Sarah Schneider
bf23c05cb5 rename helper module 2021-06-15 15:03:17 -04:00
Sarah Schneider
b4b4804a07 add ifversion tag linter 2021-06-11 15:23:09 -04:00
Sarah Schneider
5d6d2d2cb7 Merge branch 'main' of github.com:github/docs-internal into support-short-versions 2021-06-09 17:00:37 -04:00
Sarah Schneider
ca30a48ba6 add shortName as a required prop in the versions schema 2021-06-09 16:59:09 -04:00
Grace Park
e7f04c0386 Update tests/helpers/supertest.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-06-07 12:52:50 -07:00
Grace Park
a3e36c0d6a Merge branch 'main' into localization-grace 2021-06-01 15:45:42 -07:00
Sarah Schneider
d9e5b026bd add schema specific to GHAE release notes 2021-05-28 11:31:24 -04:00
Grace Park
6a321c29e3 updating with headers within the opts and adding 3 tests to cover en and chinese 2021-05-25 21:12:33 -07:00
Grace Park
82e9247d95 remove trailing space 2021-05-25 15:01:48 -07:00
Grace Park
9c50a1200e adding test case 2021-05-25 14:56:32 -07:00
Sarah Schneider
5978edb47b remove feature flagged code 2021-05-20 10:01:33 -04:00
Sarah Schneider
e30292c0fd add feature flagged conditionals to tests 2021-05-18 20:44:46 -04:00
Sarah Schneider
6cb0ebe228 add learning tracks schema 2021-04-27 17:13:23 -04:00
Sarah Schneider
3cdc9af2c9 update refs again 2021-04-27 14:20:28 -04:00
Sarah Schneider
30c09ca2f1 move to tests/helpers instead! 2021-04-27 14:13:25 -04:00
Vanessa Yuen
a8d54c9af7 Improvements in tools to help merge crowdin PRs (#18409)
- add `script/test-render-translation.js` to render all translated content to catch malformed liquid that would cause render errors
- improve test output for `script/fix-translation-errors.js` and `tests/content/lint-files.js`
- make it so `script/reset-translated-file.js` can handle files that have been renamed
2021-03-26 19:21:45 +00:00
James M. Greene
6e20ed7927 Implement app clustering (#17752)
* Install throng for easy cluster management
* Extract the Express app construction into its own file
* Switch server.js to use app clustering for deployed environments
* Worker count is based on the lesser of process.env.WEB_CONCURRENCY and the count of CPUs
* Reading clustered output is difficult, let's prefix the std{out,err} streams

Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2021-03-19 20:07:46 +00:00
Vanessa Yuen
a1d93a7619 Lint translation files (#17561)
### Why:

A lot of content gets mistranslated, some common patterns are: frontmatter date and enums getting translated, liquid tags get translated or go missing during the translation process. These translation errors are tough to catch, especially when they often come in huge PRs. 

### What's being changed:

- Frontmatter is also getting linted against schema as part of `lint-files`
- When an environment variable `TEST_TRANSLATION` is passed,
   - `lint-files` will run its tests against all files that have been newly translated (by git-diffing between `translations` branch and `main` branch), and
   - results are outputted using a custom jest reporter. The output is formatted in a way that makes it easy to exclude the problematic translated files from being merged, and to share the errors with [localization support](https://github.com/github/localization-support/issues/489). 
- Run the implemented translation test as part of the existing `Node.js Tests - Translations` workflow
2021-02-01 17:59:33 +01:00
Jason Etcovitch
8d4f3e65fe Move test & script utils out of /lib (#17517)
* Remove an unused file

* Move authenticate-to-aws to scripts/utils

* Move crowdin-config to tests/utils

* Remove add-frontmatter-to-file

* Move find-unused-assets

* Move git-utils to script/utils

* Move lib/github to script/utils

* Revert "Remove an unused file"

This reverts commit cd93ad846a0354e957359f23124eb0724c9147cf.

* Move find-extraneous-translation-files to script/utils

* We already have tests/helpers

* Rename script/utils => helpers for consistency

* Forgot a path

* Fix path to crowdin-config

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-29 10:30:51 -05:00
Sarah Schneider
b0677b2442 use script instead of jest, much faster 2021-01-22 09:28:06 -05:00
Sarah Schneider
79a7a7972f Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-13 16:58:05 -05:00
Vanessa Yuen
641ed02e81 Actions Guides sublanding page (#16740)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
2021-01-11 18:30:57 +01:00
Sarah Schneider
ead1dc202c Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-07 14:43:50 -05:00
Sarah Schneider
33f93e39c7 remove overloaded helper functions and move code directly where it is used 2021-01-07 13:14:44 -05:00
Kevin Heis
4ffc2a5e2b Fix a bunch of typos in tests dir (#17132)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-05 11:25:14 -05:00
Sarah Schneider
185737342e the new map topic handling now needs context.currentPath 2020-12-17 12:02:28 -05:00
Sarah Schneider
78895184a7 updates for clarity 2020-12-17 10:19:44 -05:00
Sarah Schneider
624245dabe Merge branch 'main' of github.com:github/docs-internal into check-links-improvement-redux 2020-12-14 15:52:46 -05:00
Sarah Schneider
a161a5923b lint 2020-12-08 11:40:52 -05:00
Sarah Schneider
117bd5fcb8 add new conditional test runs helper 2020-12-08 11:36:53 -05:00
Sarah Schneider
432d13fd32 Add more detail in comment 2020-12-01 10:25:23 -05:00
Sarah Schneider
74fe86d91e clarify what is happening with the context objects 2020-12-01 10:16:05 -05:00
Sarah Schneider
a8e12608fa Update tests/helpers/links-checker.js
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2020-11-30 13:26:41 -05:00
Sarah Schneider
f483874687 lint 2020-11-25 20:12:45 -05:00
Sarah Schneider
08d548a978 add new link checking code 2020-11-25 20:04:04 -05:00
Sarah Schneider
3121eae634 move tests/helpers.js into subdir and rename 2020-11-24 15:41:38 -05:00