1
0
mirror of synced 2025-12-21 10:57:10 -05:00
Commit Graph

519 Commits

Author SHA1 Message Date
Sarah Schneider
7a93a3a639 add tests for the ifver tag 2021-06-09 16:58:39 -04:00
Kate Higa
d578acf8f6 add necessary eslint/prettier/typescript plugins 2021-06-09 09:37:15 -07:00
Sarah Schneider
f41ff942cf add tests 2021-06-08 10:03:56 -04:00
Grace Park
e8c6d272d0 Merge branch 'main' into localization-grace 2021-06-07 13:19:03 -07:00
Grace Park
e7f04c0386 Update tests/helpers/supertest.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-06-07 12:52:50 -07:00
Kevin Heis
516106b7c5 Rename "helpfulness" to survey (#19727) 2021-06-04 12:22:31 -07:00
Sarah Schneider
52daa592d3 Merge branch 'main' of github.com:github/docs-internal into middleware-perf-part2 2021-06-04 13:58:30 -04:00
Mike Surowiec
6bdbe209c9 Default sponsors+discussions pages to nextjs rendering (#19667)
* default to nextjs rendering on sponsors and discussions pages
2021-06-03 11:17:15 -07:00
Grace Park
a3e36c0d6a Merge branch 'main' into localization-grace 2021-06-01 15:45:42 -07:00
Grace Park
8b52946af0 updating to add 2nd preference and accept-language-parser module 2021-06-01 15:45:02 -07:00
Sarah Schneider
49166811f5 exercise the GHAE schema in lint-files 2021-05-28 11:32:41 -04:00
Sarah Schneider
d9e5b026bd add schema specific to GHAE release notes 2021-05-28 11:31:24 -04:00
Sarah Schneider
4b35b4987b Merge branch 'main' of github.com:github/docs-internal into github-ae-release-notes 2021-05-28 09:23:56 -04:00
Mike Surowiec
2de358187c Performance testing NextJS / React (#19540)
* Remove json.parse(json.stringify( usage to improve performance
* Fix missing / duplicate keys in some renders
* Fix missing react-is dependency (only seemed to cause problems from pruning on the heroku deploy)
* Add nextjs tag to datadog-connect config when nextjs is a query param
* Fix router.asPath usage to exclude query param
* Fix styling inconsistencies noticed when testing
* Add a few tests
2021-05-27 15:17:27 -07:00
Grace Park
d6b3d0764d Updating try/catch and adding tests 2021-05-27 15:02:33 -07:00
Grace Park
df318951ea Merge branch 'main' of https://github.com/github/docs-internal into localization-grace 2021-05-27 09:46:48 -07:00
Sarah Edwards
7e4db83ead Add event tracking for application selector (#19533)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-05-26 14:11:55 -07:00
Sarah Schneider
313cbc8785 lint 2021-05-26 15:18:26 -04:00
Sarah Schneider
6eca699e04 Merge branch 'main' of github.com:github/docs-internal into middleware-perf-part2 2021-05-26 13:54:45 -04:00
Sarah Schneider
77e778f359 Merge branch 'main' of github.com:github/docs-internal into github-ae-release-notes 2021-05-26 09:45:44 -04:00
Grace Park
b18484c35b fixing escape character 2021-05-25 21:18:44 -07:00
Grace Park
6a321c29e3 updating with headers within the opts and adding 3 tests to cover en and chinese 2021-05-25 21:12:33 -07:00
Grace Park
82e9247d95 remove trailing space 2021-05-25 15:01:48 -07:00
Grace Park
3d03eb0002 Merge branch 'main' of https://github.com/github/docs-internal into localization-grace 2021-05-25 14:57:04 -07:00
Grace Park
9c50a1200e adding test case 2021-05-25 14:56:32 -07:00
James M. Greene
542a459c06 Move script-only dependencies to devDependencies (#19542)
* Move lib/search/sync.js to script/search/sync.js

* Move mdast-util-from-markdown to devDeps

* Move lib/redirects/add-redirect-to-frontmatter.js to script/helpers/

* Move mkdirp to devDeps

* Move linkinator to devDeps

* Move rimraf to devDeps

* Fix script/search/sync.js require paths

* Move lib/search/build-records.js to script/search/

* Move lib/search/find-indexable-pages to script/search/

* Fix require paths for build-records

* Fix require paths for find-indexable-pages

* Move lib/search/algolia-get-remote-index-names.js to script/search/

* Movbe lib/search/algolia-search-index.js to script/search/

* Move lib/search/lunr-search-index.js to script/search/

* Move lib/search/lunr-get-index-names.js to script/search/

* Fix Lunr search index paths

* Move lib/search/validate-records.js to script/search/

* Move is-url to devDeps

* Move lib/search/algolia-client.js to script/search/

* Move lib/search/parse-page-sections-into-records.js to script/search/

* Move lib/search/rank.js to script/search/

* Fix path to cached-index-names.json file

* Normalize require for fs.promises
2021-05-25 20:44:19 +00:00
Sarah Edwards
7bb65a6388 Issues etc restructuring (#19506) 2021-05-25 19:00:59 +00:00
Martin Lopes
c34031a583 Keep Actions docs up to date with security practices (#19076)
* Update security-hardening-for-github-actions.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Jaroslav Lobačevski <jarlob@github.com>
2021-05-25 22:26:51 +10:00
Mike Surowiec
37f73f0bb3 Heroku dev deps (#19431)
* fix: req.csrfToken doesn't always exist (e.g. 500 page)

* feat: update dockerfile and add nextjs to build

* fix: run linter

* move @babel deps -> dev deps

* move webpack looking things from deps -> dev deps

* move pa11y-ci to optional dep

* explicitly include optional deps for pa11y

* allow heroku dev deps to be installed

* fix: update postcss module

* fix: update dockerfile build

* tmp: disable renderReact

* see if another deploy is slower/faster

* move a few more packages to devDeps

* upgrade to package-lock v2

* use dayjs instead of date-fns

* move cross-env to devDeps

* remove unused 'del' package

* commit husky precommit hooks

* add hrtime to clone-for-build.js

* Revert "add hrtime to clone-for-build.js"

This reverts commit 70ee647bacce833f4ed2f621f62c63c1d85e5413.

* update babel/eslint

* fix: remove unused plugin

* try a .slugignore

* fix: heroku-postbuild to use npm run build

* fix: i cannot spell dereferenced

* add .next/cache to heroku cacheDirectories

* test cached build

* remove aws-sdk, see what breaks

* move jest-puppeteer to optional deps

* fix: update browser-test.yml to use newer node version

* move jimp to optional dependencies

* move puppeteer to optional dependencies

* fix: ci optional include

* fix: bad copy pasta

* remove previous react experiment

* update tests/README.md with note about optional deps

* bump node test version back to 14

* convert package-lock back to v1

* fix: use node 15.x to leverage npm optional deps

* fix: optional dep install

* test: see what happens with heroku/nodejs-typescript buildpack

* back to heroku/nodejs buildpack

* move jest to optional

* revert jest move

* remove .slugignore

* cleanup dockerfile, move xlsx-population to optional, add comment about optional deps

* Update Dockerfile

Co-authored-by: James M. Greene <JamesMGreene@github.com>

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-05-24 15:40:50 -07:00
Sarah Schneider
ff718d7fc1 Merge branch 'main' of github.com:github/docs-internal into github-ae-release-notes 2021-05-24 10:00:07 -04:00
Sarah Schneider
566e32c177 Merge branch 'main' of github.com:github/docs-internal into middleware-perf-part2 2021-05-21 16:22:43 -04:00
Kevin Heis
3b6bba8d04 Increase developer redirect test time (#19499) 2021-05-21 20:13:32 +00:00
Sarah Schneider
255864e210 remove a couple no longer relevant tests; these parts of the site tree do not need to be sorted 2021-05-21 12:47:48 -04:00
Sarah Schneider
8b6e5f30f7 no longer need the middleware in tests 2021-05-21 12:32:05 -04:00
Sarah Schneider
5978edb47b remove feature flagged code 2021-05-20 10:01:33 -04:00
Kevin Heis
e983736990 tests/routing/developer-site-redirects.js needs more time (#19438) 2021-05-19 20:08:56 +00:00
Kevin Heis
f6acb1f08a Update dependencies (#19408)
* Update dependencies 2

* Lint fixes

* Update graphql packages

* Update changelog-entry.json

* Update @octokit/rest

* Update commander with help from @rachmari

@rachmari

* Upgrade helmet

* Upgrade js-yaml

* Update server.js

* Update cheerio

* Revert "Update cheerio"

This reverts commit 8aa17c39fbf564ee554037d89e7a473027d16984.
2021-05-19 17:32:47 +00:00
Sarah Schneider
e6986fec32 update early access breadcrumb tests for new site tree (take 2) 2021-05-19 10:35:40 -04:00
Sarah Schneider
ca1c68fdcb update early access breadcrumb tests for new site tree 2021-05-19 10:23:15 -04:00
Sarah Schneider
e30292c0fd add feature flagged conditionals to tests 2021-05-18 20:44:46 -04:00
James M. Greene
885da5b3d3 Local run of Translations patching process over batch (#19360)
* New Crowdin translations by Github Action

* Reset broken translated files to English

* Ran script/i18n/homogenize-frontmatter.js

* Ran script/fix-translation-errors.js

* Reverted translated files with parsing and rendering errors

* fix malformed liquid

* add next directory to exclude list

* currentversion -> currentVersion

* fix liquid errors

* fix liquid errors

* Reset broken translated files to English

* Ran script/i18n/homogenize-frontmatter.js

* Revert /ja/github/authenticating-to-github/about-authentication-with-saml-single-sign-on

* Reset known broken translation files LAST

* Run script/i18n/homogenize-frontmatter.js

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-05-18 15:07:05 +00:00
James M. Greene
a68d285228 Crowdin remediation process tweaks (#19252) 2021-05-13 20:38:43 +00:00
Sarah Schneider
a5d52dcef0 Add landing page for GitHub Enterprise (#19041) 2021-05-12 11:55:32 +00:00
Sarah Edwards
e6ef3b57fe [May 14] Add guide for GitHub flow (#19188)
Co-authored-by: mchammer01 <mchammer01@github.com>
2021-05-11 15:25:58 +00:00
Sarah Edwards
91d4f62135 Add template and workflow to add review template to PRs (#19185)
* add review template and workflow

* use sha instead of version for action

* exclude template from check for private repo links

* Apply suggestions from code review

Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>

Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-05-10 18:41:09 +00:00
mc
8a9683d345 Quickstart guide about issues, pull requests, GitHub Discussions and team discussions (the return) (#18980)
* made a start

* start addressing comments

* simplify, simplify, simplify

* more changes

* rework completely

* tidy up, fix typos

* Update content/github/getting-started-with-github/be-social.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update content/github/collaborating-with-issues-and-pull-requests/quickstart-for-communicating-on-github.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update content/github/collaborating-with-issues-and-pull-requests/quickstart-for-communicating-on-github.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update content/github/collaborating-with-issues-and-pull-requests/quickstart-for-communicating-on-github.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update content/github/collaborating-with-issues-and-pull-requests/quickstart-for-communicating-on-github.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Apply suggestions from code review

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* address comments

* tidy up

* upcase topic

* add more topics

* use test fixture instead of live content

* Apply suggestions from code review

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* address latest comments

Co-authored-by: Sarah Edwards <skedwards88@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
2021-05-07 08:25:11 +01:00
Sarah Edwards
be8aa2bccb Add tabs for cli/desktop/ui (#19071) 2021-05-04 16:53:52 +00:00
Amy Burns
c863678e73 New organization for codespaces docs (#18910)
* adding new tables and linking to info on audit logs

* editing some text:

* adding new info on how to add image registry login

* adding link and fixing table

* formatting

* formatting

* Apply suggestions from code review

Co-authored-by: Laura Coursen <lecoursen@github.com>

* updaing private image registry secret info and other improvements

* some minor fixes

* fixing test errors

* rewriting registry secret section

* rewriting registry secret section

* updating link to reflect title

* Update content/github/developing-online-with-codespaces/managing-encrypted-secrets-for-codespaces.md

Co-authored-by: Laura Coursen <lecoursen@github.com>

* updating bullet point

* moving codespaces to top-level item

* fixing duplicated redirect

* Adding some organization for contributors

* adding learning codespaces to index file

* do not error out if category array is empty

* Apply suggestions from code review

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* fixing broken link

* Document choosing machine type for a codespace in the GitHub UI (#19055)

* Document choosing machine type in the GitHub UI

* Replace link placeholder with actual path

* Update content/codespaces/changing-the-machine-type-for-your-codespace.md

Co-authored-by: Amy Burns <timeyoutakeit@github.com>

Co-authored-by: Amy Burns <timeyoutakeit@github.com>

* reoganizing based on CD

* putting machine type doc in correct location

* fixing broken redirects

* removing quickstart example from index page

* updating main index file

* Fixing broken links

* adding intros

* adding js quickstart (#18960)

* adding js quickstart

* clarify walkthrough

* adding more images and last few sections

* fixing broken links

* fixing broken links and formatting

* formatting fixes

* Apply suggestions from code review

Co-authored-by: hubwriter <hubwriter@github.com>

* adding index file for learn folder

* adding some feedback changes

* adding some review comments

* fixing broken links

Co-authored-by: hubwriter <hubwriter@github.com>

* doing some additional re-org

* fixing topics

* adding Codespaces as a topic

* fixing so title matches slug

* Update data/reusables/codespaces/codespaces-machine-types.md

Co-authored-by: Meg Bird <megbird@github.com>

* expanding intro

Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: Meg Bird <megbird@github.com>
2021-05-03 17:06:49 +00:00
jmarlena
e71021ae66 Packages content redesign (#18847)
* Add actions category name as first commit

* Package reorganization: rename articles for "Learning..." and "Managing..." categories (#18880)

* Initial prep work for Packages reorg

* Make changes for Learning and Managing categories

* Match file name to revised article title

* Rework packages guides (#18902)

* Create new directory

* Delete guides directory and index.md link

* Remove duplicated redirects to fix test

* fix folder name

* delete temporary directory of old content

* Add Gradle article

* Update landing page with new links

* Update test to fix CI failure for deleted articles

* Update links and titles for reorg-ed articles

* Fix broken links

Co-authored-by: hubwriter <hubwriter@github.com>

* Update more changed article titles in links (#18911)

* remove test line to test PR build failure

* Add sections to permissions article

* Add draft reusable

* restore versioning tests

* Remove accidental inclusion of new reusable from a different branch

* Package registry content redesign updates (#18930)

* Update container registry product variable

* First round of edits

* Update tidbit

* Apply suggestions from code review

Co-authored-by: hubwriter <hubwriter@github.com>

* Update docker-vs-container-registry.md

* Update authentication section to resolve bug/confusion

* Revisions

* Last touchups

* Migration from intro article

Co-authored-by: hubwriter <hubwriter@github.com>

* Add versioned diagrams

* Add packages actions revisions (#18956)

* Add refreshed content

* Update content/packages/managing-github-packages-using-github-actions-workflows/example-workflows-for-publishing-a-package.md

Due to tightness of time on this I'm going to commit this suggestion so that I can merge this PR into the Packages megabranch.

Co-authored-by: hubwriter <hubwriter@github.com>

* Packages reorg: "Introduction to GitHub Packages" article (#18906)

* Initial commit. Remove stray comma

* Initial CC work - WiP

* More changes for the Introduction article

* Make changes as per Jessica's review

* Fix broken reusable ref

* improve test failure message and add clarifying comments

* Packages reorganization: More updates to the 'Learn GitHub Packages' articles" (#18961)

* Viewing - WiP

* More updates to the 'Learn...' category

* revisions to intro article

* Add permissions article and make a few other streamlined updates

* Fix links 🌿

Co-authored-by: jmarlena <>

* Apply suggestions from code review

* Apply product input

* Fix versioning

* Apply some straight-forward suggested changes 

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Apply suggestions from code review

* Add "GitHub Packages" before container registry mention

* Standardize visibility & permsisions section into a reusable

* Add link

* Replace outdated link

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* ✂️ cut note

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Superseded rewrite?

* bye single-use reusable

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Condense packages & actions conceptual content

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* remove "package registries"

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Add reusable

* Add these redirects from the deleted containers conceptual article

* Incorporate changes from main into retitled articles 💫

* Missing endif

* Fix unexpected redirect behavior

* Revamp and consolidate actions access settings

* Further reading section

* Last fix for now

* standardize steps

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: jmarlena <>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
2021-04-30 16:28:27 -07:00
Sarah Schneider
3293ed0939 Merge branch 'main' of github.com:github/docs-internal into sublanding-fixes 2021-04-30 11:58:09 -04:00