jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-21 19:06:49 -05:00
Code Issues Projects Releases Wiki Activity
25,979 Commits 28 Branches 1 Tag
0c77f19f6b51c0e1b83b4838389912c9af0aa3dc
Commit Graph

64 Commits

Author SHA1 Message Date
Matt Pollard
ab1f8b0ee2 First responder bug fixes for 2022-05-20 (#27875) 2022-05-23 15:41:33 +00:00
Peter Bengtsson
18504871b9 cache full rendering (#25424) 
* cache full rendering

* still not working with gzip

* progress progress progress

* smaller

* hacky progress

* small fixes

* wip

* lock file

* wip

* wip

* package-lock updates

* wip

* search DOM in lowercase

* simplify

* with instrument

* improve test coverage

* mutateCheeriobodyByRequest

* fix

* remove renderContentCacheByContex

* disable render caching in sync-search

* diables things in github/github link checker

* gzip lru

* tidying up

* updated

* correct tests

* fix: move userLanguage to LanguagesContext

* Revert "fix: move userLanguage to LanguagesContext"

This reverts commit d7c05d958c71eaad496eb46764eb845d80b866ca.

* contexts ftw

* fixed rendering tests

* oops for got new file

* nits addressed

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
 2022-05-23 12:12:09 +00:00
Grace Park
10fea98af5 Search updates larger font (#27838) 
* removing search from home page and adding to header

* remove homepage search

* adding description

* update to f5

* remove homepage search test

* removing homepage search rendering test

* showing preview of larger font

* update wording at breakpoint

* update to short description everywhere

* Update components/homepage/HomePageHero.tsx

Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>

* remove unnecessary stylesheet

* Update data/ui.yml

Co-authored-by: Janice <janiceilene@github.com>

Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>
Co-authored-by: Janice <janiceilene@github.com>
 2022-05-20 12:12:36 -07:00
Sarah Schneider
a9d3390c2f change hiddenNoBanner to noEarlyAccessBanner 2022-05-13 16:35:33 -04:00
Sarah Schneider
2962666b55 update banner component 2022-05-13 12:47:11 -04:00
Robert Sese
3404349081 Fix sticky header issue in Firefox (#27159) 
* Redundant sticky?

* update zindex to bring scroll button up

Co-authored-by: Grace Park <gracepark@github.com>
 2022-04-22 21:31:12 +00:00
Grace Park
b98c83e924 REST operations sidebar (#26225) 
* testing out a rest operations sidebar

* cleanup

* renamed 5 files

* renamed 5 files

* set redirect_from on 5 files

* renamed 1 files

* renamed 1 files

* renamed 3 files

* renamed 1 files

* renamed 1 files

* renamed 3 files

* renamed 1 files

* renamed 2 files

* renamed 1 files

* renamed 4 files

* renamed 15 files

* renamed 2 files

* renamed 6 files

* renamed 1 files

* renamed 4 files

* renamed 7 files

* renamed 1 files

* renamed 3 files

* renamed 3 files

* renamed 1 files

* renamed 5 files

* renamed 1 files

* renamed 1 files

* renamed 3 files

* renamed 4 files

* renamed 1 files

* renamed 1 files

* renamed 2 files

* renamed 4 files

* renamed 1 files

* renamed 1 files

* renamed 1 files

* renamed 6 files

* renamed 6 files

* renamed 4 files

* move files

* adding more

* updating to add restcontext and start of removing data/reusables/rest-reference

* removed data/reusables

* add a RestMiniTocItem and updating the filtering to add a subcategory so all manually added H3s are in mini tocs in addition to operations

* remove console log

* [WIP]: REST New Proposal Sidebar (#26471)

* saving

* update sidebar

* remove console log

* update guides and overview

* import Category for category level rest pages

* update undefined restOperations

* update restOperationData category and subcategory levels"

* minor updates

* update get mini toc items function

* updating REST context for sidebar

* updating rest data

* remove console logs

* WIP: mini-toc-ing the sidebar

Co-authored-by: Robert Sese <rsese@github.com>

* A little cleanup

* Fix first subcategory link and add some comments

* updating anchor links in sidebar

* adding updates

* remove standalone

* update product and maptopic pages using article context

* add conditional link wrapper

* fix sidebar toggle and versions for enterprise admin

* update versions per subcategory

* Highlight sidebar link for current page

* Update miniToc hash links and hash change tracking

* fix unique key in CollapsibleSection

* Fix list markup

* remove title

* update permissions

* Hide minitocs on landing (#26594)

* hide minitocs on landing page

* simplify page components and remove minitoc from sidebar for guides/overview

* fix carats and category fix

* remove id

Co-authored-by: Grace Park <gracepark@github.com>

* updating content based on versions script check with the OpenAPI

* update script and content files

* update script and content/rest files

* update to add TocLanding

* update script

* update index files

* add codespaces repository-secrets

* remove openapi schema check script

* remove minitocs at the top

* add h2 about the {title} api

* fix tests/unit/openapi-schema.js

* Fix linting tests

* fix search/topics test

* fix tests/unit/pages test

* update rest/reference links in components

* run prettier

* Update components/rest/RestReferencePage.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update components/rest/RestReferencePage.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update tests/unit/openapi-schema.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

* updating comment location

* remove dependabot override

* remove path-utils current product update for rest

* run linter

* remove dependabot.md and remove h2 heading on restreference

* update the correct product to rest for rest pages

* adding comments for updates to path-utils

* remove console log

* REST sidebar: handle legacy v3 redirects (#26686)

* Add script to handle legacy v3 REST redirects

* Run the script

* Handle a redirect to a redirect

* Update REST test URLs

* 'await' and test runs subcategory of checks

* Update REST URLs for routing/developer-site-redirects tests

* Update developer-redirects fixture with new REST URLs

* Resolve merge conflicts

* Update rest-redirects fixture with new REST URLs

* Fix broken links with REST pages re-org

* redirectTo could be undefined

* Fix script for posterity, can't redirect paths with hashes

* Remove invalid hash redirects

* Typically don't need to save one-off scripts

* Undo redirect changes (not necessary for handling v3 redirects)

* Remove script-added redirects

* Update old v3 redirects with new REST URLs

* No more GHES search indexing page

* 'org' not 'organization'

* Update fixture data for new REST URLs

* revert any content directory changes

Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>

* Adding test rest (#26750)

* add test to check openapi schema versions and content rest frontmatter versions

* update lib/redirects

* fix test and add error messages

* adding repository secrets

* adding repository-secrets.md

* Revert "update lib/redirects"

This reverts commit 3aafe28265764d5bc09c0c478c8e0ca099c8fbcf.

* remove lib/redirects changes and console logs

* Update lib/rest/index.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

* update unique key

* Rest client side redirects (#26754)

* adding tags subcategory for the rest content repos category

* run prettier

* bug fix for anchor scrolls" (#26892)

* updating width size for rest reference page

* Rest sidebar consolidation (#26862)

* refactor sidebar

* fix articlecontext provider issue on rest product landing page for all versions

* fix a bug, create new component

* revert change to create new component and fix bug

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Set currentAnchor with a hashchange handler (#26923)

* Rest sidebar design tweaks (#26807)

* Rest sidebar design tweaks

* tweak color to subtle

* use muted color and margin for line

* update to design feedback

Co-authored-by: Grace Park <gracepark@github.com>

* Remove cheerio from rest-collapsible (#26948)

* remove cheerio from rest-collapsible

* update type

* adding endswith instead

* use productId instead

* one off edge case for secret-scanning

* Reorganize subcategory and category, Update pre -> div, Add RestContext (#26950)

* reorganize subcategory and category

* add RestContext

* update comment

* update for endpoints page

* add comment

* move object to restcontext

* remove effectiveDate in restcontext

* remove width calculation for rest reference page

* fix adding manual writer's minitocs to sidebar

* update with feedback

* update comment

* update isRestReferencePage

* remove page component and fix bug

* adding back rest/index.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* update content/rest"

* add back design tweak

* update to div

* update margins on rest api reference

* remove page component

* adding tests

* separate product from rest sidebar (#27065)

* separate product from rest sidebar

* Use ProductCollapsibleSections for product pages

* fix tests

Co-authored-by: Robert Sese <rsese@github.com>
Co-authored-by: Grace Park <gracepark@github.com>

* Rest sidebar translations (#27052)

* update translations

* remove general test

Co-authored-by: Robert Sese <rsese@github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
 2022-04-20 10:19:48 -07:00
Peter Bengtsson
43f0e5270c remove GHEC signup button for dotcom_user cookied users (#26521) 2022-03-29 20:21:38 +00:00
Grace Park
2c8713037d Move deploy keys from deployments to keys in rest pages (#26166) 
* move deploy keys from deployments to keys in rest pages

* move minitocs above intro

* Update content/rest/reference/keys.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* add to banner, add redirects from deployments

* remove deploy keys from deployments intro

* update data/reusables name

* update - to _

* update script and add redirects for subcategories turned categories

Co-authored-by: Sarah Edwards <skedwards88@github.com>
 2022-03-17 17:25:12 +00:00
Peter Bengtsson
95297c3c9d Simplify getBreadcrumbs (#26015) 
* fix getBreadcrumbs

* don't go too deep

* remove commented out code
 2022-03-09 01:14:49 +00:00
Peter Bengtsson
9d4b913bdc language redirects without cache (#25872) 
* redirect to your preferred language (#25664)

* redirect to your preferred language

* refactorings

* use js-cookies

* make sure no cache when language is involved in the redirect

* fix tests
 2022-03-07 16:25:22 +00:00
Peter Bengtsson
881a6d2212 Revert "redirect to your preferred language (#25664)" (#25869) 
This reverts commit a9947c086c.
 2022-03-04 21:56:57 +00:00
Peter Bengtsson
a9947c086c redirect to your preferred language (#25664) 
* redirect to your preferred language

* refactorings

* use js-cookies
 2022-03-04 16:29:11 +00:00
Rachael Sewell
2ade7d8489 reactify rest pages (#25005) 2022-02-28 18:30:54 +00:00
Mike Surowiec
f3fc80cf05 Upgrade primer/components -> primer/react (#25591) 
* upgrade primer/components -> primer/react

* fix jest failure
 2022-02-24 00:30:14 +00:00
Robert Sese
55a0cbf674 Fix string key (#25576) 2022-02-23 11:48:55 -06:00
Robert Sese
2e4187733f Add link to versions doc in version picker (#25012) 
* Add link to 'about versions' in version picker

* Add translation string

* Match article short title

* Better text contrast

* Key names is 'docs_versions'

* 'About versions'

* Show version picker when only 1 version

Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
 2022-02-22 17:53:32 +00:00
Lucas Costi
e6af9ae1e6 Remove Actions REST enterprise subcategory (moved to Actions page) (#25065) 
Co-authored-by: Rachael Sewell <rachmari@github.com>
 2022-02-17 15:18:07 +10:00
Robert Sese
62ce173b76 Fix when we show the 'All Enterprise Releases' link (#25002) 
* Enterprise versions start with 'enterprise-server'

* Show only if all versions are ghes versions

* Show link if there's any ghes versioning
 2022-02-04 21:59:02 +00:00
Peter Bengtsson
a34f2c3787 reduce flash of sign-up CTA button (#24933) 2022-02-02 22:36:56 +00:00
Anosike Osifo
ec73762b3e Add GHEC Trial CTA to header of docs.github (#23324) 
* Add GHEC Trial CTA to header of docs.github

* use i18n logic

* add signup cta

* add signup cta

* Update the Trial CTA href to allow users choose trial plan

* Update logic to conditionally display signup CTA. Also remove GH EC Trial CTA

* update logic to use && operator

* fix wrapping search bar bug
 2022-01-28 20:15:54 +00:00
Grace Park
a3b81bb93c restructure footer and header (#24601) 2022-01-24 15:19:45 -08:00
Robert Sese
d0db00cd98 a11y: match picker label with current selection (#24321) 
* Match label with selection

* defaultText is a better default

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* No longer used

* Also no longer used

* No longer used in the dropdown pickers

* Add translation strings for pickers

* Use translated strings in picker components

Co-authored-by: Peter Bengtsson <peterbe@github.com>
 2022-01-19 18:43:31 +00:00
Peter Bengtsson
4947218cba fix React key uniqueness in Breadcrumbs (#24182) 2022-01-11 01:56:30 +00:00
Rachael Sewell
a340162d84 reorganize repository apis (#23728) 
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
 2022-01-11 11:53:12 +10:00
Grace Park
a4c5d58507 Accessibility: Breadcrumbs (#24151) 
* programmatically group breadcrumbs

* forgot to commit li
'
'

* adding inline-block
 2022-01-07 12:01:52 -08:00
Peter Bengtsson
7d75265b01 hydration fails on CollapsibleSection with hash in URL (#24105) 2022-01-07 02:25:16 +00:00
Peter Bengtsson
5893ae32b3 don't let the href depend on the router hash in client-side rendering (#24106) 2022-01-06 20:59:47 +00:00
Grace Park
124f54eb0c Accessibility changes for Nav Menu (#24099) 
* updating to nav landmark

* support keyboard esc to close mobile menu

* update to ChevronDown to remove nested div
 2022-01-06 17:34:19 +00:00
Robert Sese
bcb1b3c8bc Use lang attribute and translate picker aria-label (#24096) 
* Translate picker aria-label

* Use lang attribute
 2022-01-05 23:28:05 +00:00
Peter Bengtsson
3f9d798037 render same DOM in SSR as client (#24078) 2022-01-05 14:53:43 +00:00
Peter Bengtsson
53b0484a66 unique keys for RestRepoBanner links (#23764) 2021-12-15 16:08:43 -08:00
Robert Sese
5ff7bf2c65 Capitalize and comma outside link (#23723) 2021-12-14 16:57:24 -06:00
Rachael Sewell
bf7b2085bd fix broken links in banner component (#23719) 2021-12-14 14:00:47 -08:00
Rachael Sewell
daafb8cb9d break up large rest pages (#23652) 2021-12-14 20:39:25 +00:00
Peter Bengtsson
815f9d40c3 only link all enterprise versions if any is enterprise version (#23640) 2021-12-13 17:19:15 +00:00
Robert Sese
4ce6dd2840 More misc a11y bits (#23542) 
* List-ify guide labels

* Use aria-expanded with 🍔 menu
 2021-12-09 19:20:04 +00:00
Grace Park
f19223503a Update Search Version Button to Dropdown (#23465) 
* adding to view

* updating the portal location

* add new line

* updating font styling to class

* Update components/Search.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* Update components/Search.module.scss

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* update ItemInput

* using router.replace and import updates

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* run prettier

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
 2021-12-09 17:56:24 +00:00
Kevin Heis
58fbe1edf5 Move px to rem in scss files (#23009) 
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
 2021-11-19 21:06:45 +00:00
Kevin Heis
329a8c664e Create a shared picker component (#22836) 
* Unified picker component

* Add picker to storybook

* TS fixes

* Simplify "mobile" header spacing

* Fix a few testid

* Update Picker.tsx

* Update Picker.tsx

* Update Picker.tsx

* Fix unit test

* Fix rendering tests
 2021-11-16 19:10:28 +00:00
Peter Bengtsson
07a5edd2ab rewrite search state from useRouter (take 2) (#22833) 
* rewrite search state from useRouter (take 2)

* fix the problem with isHeaderSearch

* cleaning ups

* updating mobile search results ui (#22841)

* remove useCallback

Co-authored-by: Grace Park <gracepark@github.com>
 2021-11-16 18:55:48 +00:00
Grace Park
5bf39459ca Updating Search using Primer Components (#22677) 
* updating search icon

* remove no fill

* update fill color

* using ActionList and Overlay

* update to ActionList, Overlay, add Label to Breadcrumbs, and change Mark

* add search-results test data and move header search results to right

* make search results scrollable and fix max-width in header search

* update header search and styling updates

* add highlight

* update styling

* styling and lint errors

* fix lint error and fetch

* Update components/Search.tsx

* update label color

* remove bottom margin

Co-authored-by: Rachael Sewell <rachmari@github.com>
 2021-11-12 12:25:47 -08:00
Rachael Sewell
0244fda807 search improvements (#22443) 2021-11-10 11:11:28 -08:00
Peter Bengtsson
0d13379462 fix TS usage around VersionPicker (#22739) 2021-11-10 11:00:34 -08:00
Kevin Heis
6ec20638b5 Version picker combo (#22694) 
* Move version picker next to product picker

* Always render in header

* Inline variant

* Remove topper-sidebar

* Handle breadcrumb length

* Have breadcrumbs use Primer breakpoint

* Make a breadcrumbs scss module

* Update Breadcrumbs.tsx

* Update Breadcrumbs.module.scss

* Update Breadcrumbs.module.scss

* Update server.js

* Use responsive classes for hide/show breadcrumb
 2021-11-10 16:20:34 +00:00
Grace Park
d75bd265eb Flash updates for deprecation and header notifications (#22632) 
* flash updates for deprecation and header notifications

* adding import and updating position
 2021-11-09 19:52:20 +00:00
Grace Park
240f5fbafe Updating breadcrumbs (#22626) 
* updating breadcrumbs

* fix tests

* one more
 2021-11-08 17:53:19 +00:00
Grace Park
2969394991 have header span the entire page (#22543) 2021-11-02 13:08:27 -07:00
Grace Park
b211776b85 Updating to scroll past header notifications and keep header sticky (#22539) 
* updating to scroll past notification and keep header sticky

* Update components/page-header/Header.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
 2021-11-02 18:50:31 +00:00
Grace Park
f684e7fe82 adding margin top to anchor links (#22515) 2021-11-01 13:57:00 -07:00