1
0
mirror of synced 2026-01-06 15:01:04 -05:00
Commit Graph

3 Commits

Author SHA1 Message Date
Patrick Ellis
4b5e01365c Use in_progress workflow_job example, not queued (#22880)
* Use in_progress workflow_job example, not queued

### tl;dr

This changes the example `workflow_job` payload to be an `in_progress` event instead of `queued` event.

### why

In #22174, I added some keys to the example workflow_job json. This was correct, but by adding non-null _values_, **I introduced a subtle bug**.

It's a bug because a `queued` workflow is—by definition—_not_ yet assigned to a runner. So all the `runner_*` attributes will be `null` in the real world. 

After the workflow becomes `in_progress`, all the values are guaranteed to exist. So let's change the example to be an `in_progress` event, since it's a better example for documentation.

* Explain more about the runner_* attributes in "workflow_job_properties.md"

* Consistentize naming

Co-authored-by: Martin Lopes <martin389@github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
2021-11-17 15:48:31 +00:00
Kevin Heis
3b092b4cb8 Deprecate 2.22 b (#22366)
* Update enterprise-server-releases.js

* Run deprecation script

* Remove finding / managing security vulnerabilities

* remove vuln from translations

* remove more dead pages

* Restore heavily used files

* Remove 2.22 refs in tests

* Update working-with-the-npm-registry.md
2021-10-22 13:23:16 -07:00
Martin Lopes
bfc959c4f2 [September 20, 2021] Autoscaling for ephemeral self-hosted runners (#20119)
Co-authored-by: Ross Brodbeck <hross@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Patrick Ellis <patrick.j.ellis@gmail.com>
2021-09-20 13:29:16 -04:00