1
0
mirror of synced 2026-01-17 21:01:42 -05:00
Commit Graph

55 Commits

Author SHA1 Message Date
James M. Greene
2dbae93c53 Try to prevent late/duplicate response errors (#20077)
* Ensure all Express 'next' calls include 'return's

* Add headersSent checks during archived versions flow

* Return a 404 earlier if archived resource fetch fails

* Short-circuit responses for archived stuff

* Be more careful about responding to and short-circuiting after search requests

* Fix tests
2021-06-28 19:31:54 +00:00
Kevin Heis
a92d820888 Remove remaining JSON requires (#20110)
* Remove remaining JSON requires

* Lint

* Update feature-flags.js
2021-06-23 14:57:50 -07:00
Grace Park
06ebe03c9b one more update on createApp change 2021-06-23 11:25:29 -07:00
Grace Park
fcf1fdd682 adding james feedback to add single app instance 2021-06-23 11:21:20 -07:00
Grace Park
6c0b43a4bb updating libapp in one script and tests 2021-06-23 10:46:10 -07:00
Grace Park
26f70c5563 updating tests for usefaketimers 2021-06-22 11:53:47 -07:00
Grace Park
d3d1902414 Merge pull request #20017 from github/upgrade-esm
Enforce and Move to Top Level require
2021-06-22 11:27:48 -07:00
Emily Gould
1e5372ac79 Move Getting started category to top-level doc set (#20008)
* Move category to top-level doc set

* Move doc set to the top and update short title

* Undo package-lock changes

* updated hardcoded refs in tests

* Update test

* Fix hardcoded link in test

Co-authored-by: Sarah Schneider <sarahs@github.com>
2021-06-18 17:13:04 +00:00
Sarah Schneider
255bb9e0f3 check status code too 2021-06-17 16:06:43 -04:00
Sarah Schneider
c4076da967 test for release notes content, not just response 2021-06-17 09:33:45 -04:00
Kevin Heis
516106b7c5 Rename "helpfulness" to survey (#19727) 2021-06-04 12:22:31 -07:00
Sarah Schneider
77e778f359 Merge branch 'main' of github.com:github/docs-internal into github-ae-release-notes 2021-05-26 09:45:44 -04:00
Sarah Edwards
7bb65a6388 Issues etc restructuring (#19506) 2021-05-25 19:00:59 +00:00
Sarah Schneider
ff718d7fc1 Merge branch 'main' of github.com:github/docs-internal into github-ae-release-notes 2021-05-24 10:00:07 -04:00
Kevin Heis
3b6bba8d04 Increase developer redirect test time (#19499) 2021-05-21 20:13:32 +00:00
Sarah Schneider
5978edb47b remove feature flagged code 2021-05-20 10:01:33 -04:00
Kevin Heis
e983736990 tests/routing/developer-site-redirects.js needs more time (#19438) 2021-05-19 20:08:56 +00:00
Sarah Schneider
e30292c0fd add feature flagged conditionals to tests 2021-05-18 20:44:46 -04:00
Sarah Schneider
a5d52dcef0 Add landing page for GitHub Enterprise (#19041) 2021-05-12 11:55:32 +00:00
mc
8a9683d345 Quickstart guide about issues, pull requests, GitHub Discussions and team discussions (the return) (#18980)
* made a start

* start addressing comments

* simplify, simplify, simplify

* more changes

* rework completely

* tidy up, fix typos

* Update content/github/getting-started-with-github/be-social.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update content/github/collaborating-with-issues-and-pull-requests/quickstart-for-communicating-on-github.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update content/github/collaborating-with-issues-and-pull-requests/quickstart-for-communicating-on-github.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update content/github/collaborating-with-issues-and-pull-requests/quickstart-for-communicating-on-github.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update content/github/collaborating-with-issues-and-pull-requests/quickstart-for-communicating-on-github.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Apply suggestions from code review

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* address comments

* tidy up

* upcase topic

* add more topics

* use test fixture instead of live content

* Apply suggestions from code review

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* address latest comments

Co-authored-by: Sarah Edwards <skedwards88@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
2021-05-07 08:25:11 +01:00
Sarah Schneider
4d7674e324 reduce number of developer site paths we check now that the migration is well behind us 2021-04-28 14:41:12 -04:00
James M. Greene
6e20ed7927 Implement app clustering (#17752)
* Install throng for easy cluster management
* Extract the Express app construction into its own file
* Switch server.js to use app clustering for deployed environments
* Worker count is based on the lesser of process.env.WEB_CONCURRENCY and the count of CPUs
* Reading clustered output is difficult, let's prefix the std{out,err} streams

Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2021-03-19 20:07:46 +00:00
Sarah Schneider
bc5e576e38 Merge branch 'main' of github.com:github/docs-internal into github-ae-release-notes 2021-03-04 13:45:48 -05:00
Sarah Schneider
d9d9834194 add basic test 2021-03-01 19:18:39 -05:00
Sarah Schneider
284cfeda4b rename test file 2021-03-01 17:04:27 -05:00
Sarah Schneider
d3617af76a add test 2021-02-26 13:23:55 -05:00
Sarah Schneider
a28c7ac2a2 add test 2021-02-22 11:14:01 -05:00
Sarah Schneider
0dbfa96b65 add message to test output 2021-01-25 13:10:08 -05:00
Sarah Schneider
5445a98116 revert to main 2021-01-19 21:02:14 -05:00
Sarah Schneider
5e1f14ab39 remove no longer needed tests 2021-01-19 17:44:53 -05:00
Sarah Schneider
9809627129 lint 2021-01-14 17:10:12 -05:00
Sarah Schneider
affbc80a3c update tests to remove free-pro-team from expected results 2021-01-14 17:08:30 -05:00
Sarah Schneider
a8afad4eb9 add test 2021-01-13 14:05:36 -05:00
Kevin Heis
c62f49aa0e Block indexing not crawling (#17044)
* Block indexing instead of crawling

* Lint

* Update deprecated-enterprise-versions.js

* Combine loops
2020-12-17 11:57:18 -08:00
Kevin Heis
122da9610c Move redirect calculation from loadPages to loadRedirects (#16918)
* Move redirect calculation from loadPages to loadRedirects

* Make buildredirects a method for tests

* Update redirects.js

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-15 18:40:50 +00:00
Jason Etcovitch
d891618fcc Import Enterprise release notes for 2.20, 2.21 and 2.22.5 (#16909)
* Add 2.20

* Add 2.21

* Add 2.22.5

* Lint

* Properly format dates

* Update the tests
2020-12-14 15:16:29 +00:00
Sarah Schneider
bc6c0cc6be Merge branch 'main' of github.com:github/docs-internal into yank-outdated-redirect-code 2020-12-09 20:47:40 -05:00
Rachael Sewell
6a3d326fcf add one-off cases for hooks and pre-receive-hooks (#16784)
* add one-off cases for hooks and pre-receive-hooks

* add forum redirect

* update redirect test

* update 2.19-2.22 fixutres

* revert 2.18/2.19 changes

* remove dotcom test

* update dotcom test
2020-12-09 19:50:46 +00:00
Kevin Heis
62889986b6 Revert "Revert "Speed up warmServer by loading pages (and files) asyn… (#16837)
* Revert "Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)"

This reverts commit a14517115f.

* Move async to regular dependencies

* Update package-lock.json
2020-12-09 17:40:58 +00:00
Jason Etcovitch
a14517115f Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)
This reverts commit 1d5e216404.
2020-12-09 17:12:07 +00:00
Kevin Heis
1d5e216404 Speed up warmServer by loading pages (and files) asynchronously (#16752)
* Async `new Page`

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Using mapLimit

* Update pages.js

* Test updates

* Update pages.js

* Move exists to page class

* Test fixes

* Slightly faster localized paths process
2020-12-09 16:57:18 +00:00
Sarah Schneider
373a1ddd44 lint 2020-12-08 11:30:21 -05:00
Sarah Schneider
b75f18f2d2 yank outdated tests 2020-12-08 09:30:32 -05:00
Sarah Schneider
18d25f6129 update references to old helpers.js 2020-11-24 15:42:11 -05:00
Jason Etcovitch
cc719ffb6f Render Enterprise release notes on docs.github.com (#16367)
* Create basic layout

* Create stubbed out release note YAML

* Get a real implementation going

* Simplify using site-data

* Add a real page to send from render-page.js

* Use array of patches

* Render patches

* Add sidebar and breadcrumbs

* Reverse order

* Add date

* Tweak labels

* Redirect to entweb for missing versions

* Render patch.intro

* Move to separate files for patches

* Show support for RC versions

* Improve some comments

* Sticky headers!

* Remove a console log

* Improve example formatting

* Add a link on /admin

* Add a schema and test

* Move to /index.md, add version_num filter

* Improve layout

* Use <details>

* Placeholder more realistic notes

* Don't require links in index pages

* Remove admin/index link for now

* Remove unused frontmatter field

* Add a test for middleware

* Fix remaining YAML file to test CI

* Update 2-rc.yml

* Don't call it RC

* Just push

* Make a main a div

* Fix a borked class

* Lint YAML files

* Improve Download link

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Improve check order

* Move to contextualizers

* Use alternative version thing

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Move back to `release-notes.md`

* Use version for anchor IDs

* Undo category-pages test change

* Fix borked details layout in Chrome

* Improve mobile setup

* Render markdown in note tags

* Use allVersions[currentVersion] again

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Undo change to extended-markdown

* Add whitespace so it renders markdown bits

* Remove 2-22 files

* Add check for any release notes

* Fix the failing tests

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-11-20 13:33:11 -05:00
Sarah Schneider
0c3a46f205 update asset path for <2.13 CSS files 2020-11-18 12:53:39 -05:00
Sarah Schneider
a3559e12bd remove test that should have been removed in #16490 2020-11-17 16:34:20 -05:00
Sarah Schneider
8bb7120185 lint 2020-11-17 11:45:18 -05:00
Sarah Schneider
bed7ecc890 Update tests/routing/deprecated-enterprise-versions.js
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2020-11-17 11:37:54 -05:00
Sarah Schneider
a895ef68ba update tests 2020-11-16 20:07:04 -05:00