1
0
mirror of synced 2026-01-02 03:04:13 -05:00
Commit Graph

607 Commits

Author SHA1 Message Date
Peter Bengtsson
7c66d4456f static assets should not use csrf (Set-Cookie) (#23357)
* static assets should not use csrf (Set-Cookie)

Part of #1316

* move setFastlySurrogateKey up too
2021-12-06 13:00:34 +00:00
Peter Bengtsson
ddd14479c5 24h cache all internal redirects without language prefix (#23354)
Part of #1271
2021-12-03 21:51:04 +00:00
Kevin Heis
fae539f9c9 Update release-notes.js 2021-12-03 12:48:39 -08:00
Kevin Heis
d79f78c87e Refactor developer site redirects test (#23342) 2021-12-02 23:42:53 +00:00
Peter Bengtsson
26014646dd Massive DIFF_FILES crashes bash in repo-sync (#23326)
* Massive DIFF_FILES crashes bash in repo-sync

Part of #1304

* gst

* make exception
2021-12-02 18:57:38 +00:00
Grace Park
4ff5167e51 Updating name: sublanding to guides and using DropdownMenu for type/topics filter (#23290)
* updating sublanding to guides page and using DropdownMenu primer component

* fix linting error

* remove unnecessary import

* updating translation files

* move data-testid

* trying to fix test

* fix browser tests

* Update content/README.md

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
2021-12-02 18:43:33 +00:00
Peter Bengtsson
1ab125dd08 draw title from first H1 only (#23266)
Part of #1218
2021-12-01 23:26:08 +00:00
Peter Bengtsson
8e1508d5fd remove crowdin-support hack (#23231) 2021-12-01 22:56:03 +00:00
Peter Bengtsson
5f2d621408 make release-notes tests not depend on real network (#23196)
Part of #1246
2021-11-30 21:47:32 +00:00
Peter Bengtsson
2f6f076cc0 LinkChecker and better linksToSkip function (#23001)
* LinkChecker and better linksToSkip function

Part of #1253

* try now

* escaped

* make sure it skips all non-english links

* feedbacked
2021-11-30 21:39:39 +00:00
Peter Bengtsson
e59c79acd0 speed up repository reference checks (#23178)
* speed up repository reference checks

Part of #1246

* feedbacked

* microoptimization
2021-11-30 21:32:33 +00:00
Rachael Sewell
63ab5664ca remove test for previews in openapi schema (#23181) 2021-11-30 01:59:36 +00:00
Kevin Heis
e3b2e820fd React tool picker (#23004)
* Working on tool picker

* Start on react version of tool picker

* Update ToolPicker.tsx

* Update tool-switcher.html

* Get it working

* Update browser.js

* Update browser.js

* Update ToolPicker.tsx
2021-11-29 23:04:06 +00:00
Grace Park
ed2495ed97 using legacy fake timers (#23110) 2021-11-29 18:40:31 +00:00
Robert Sese
a0042e40a3 Add more syntax highlighting tests (#23085)
* Add more syntax highlighting tests

* Add erb highlighting test

* Test JS keyword highlighted
2021-11-24 17:30:29 +00:00
Marcelo Jacobus
2de66f3c81 Fix script/i18n/lint-translation-files.js (#23016)
* Fix error

* Attempt to fix that error

* Remove debugging code

* fix: Update path of lint-translation script

* fix: Update conditional guard clause

The conditional compared an array to a string using strict equality, so
it was never going to be true. This change makes sure we return early
when there are no changes.

* fix: Exit early when there are no files to lint

* refactor: Filter files to reset in plain javascript

As opposed to doing it in bash.

* Update tests/linting/lint-files.js

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>

* Update tests/linting/lint-files.js

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>

* Update script/i18n/lint-translation-files.js

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
2021-11-23 16:11:34 -08:00
Francis
9c4ef4dcc0 Add a new test that checks every YAML document can be parsed (#23053)
* fix: update lint-translation script to point to the correct test

This change reflects its new home in `test/linting/lint-files.js` as committed in f0d17c300d on April 28, 2021.

* test: check release notes can be parsed a single YAML document

* test: check yaml content parsability

* test: check parsability for all YAML content

* refactor: move annotations to lint yaml content suite

* fix: revert file contents

* fix: remove local test script

* refactor: lowercase yaml file type

* fix: remove null assignment to stay consistent with other variables

* refactor: update reference name to caught error

* fix: remove the royal we from annotation

* refactor: update annotation for improved readability

* fix: add missing preposition
2021-11-23 18:46:04 +00:00
Grace Park
33c5ce2d36 Updating images styling and accessibility for minitocitems (#22976)
* updating images styling on design systems feedback

* maintaining ul li structure for accessiblity

Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
2021-11-19 00:56:51 +00:00
Grace Park
5a809be3dc MiniTocItems: rerender tocs and fix bugs (#22948)
* add key to force rerender tocs

* move up platform specific to properly display none and go back to using contents

* remove i
2021-11-17 22:29:07 -08:00
Peter Bengtsson
480159e778 only lint the files that changed (#22924)
* only lint the files that changed

* allowed action

* do nothing

* debug more

* less debugging

* debug

* debug

* debug

* using patterns

* testing something

* testing something (2)

* lemme try something

* lemme try something

* one more attempt

* testing

* tidying up

* sample changes

* add debugging

* some code comments

* fine but sample changes

* update allowed actions

* final cleaning before opening PR for review

* tiny update

* remove commented out code

* feedbacked
2021-11-18 03:03:47 +00:00
Grace Park
0afdf66a08 Primer Update: Table of Contents (#22933)
* update to ActionList

* fix nested mini tocs

* adding key

* remove li and fix tests

* update font size to 14px

* remove border radius
2021-11-18 00:27:12 +00:00
Francis
f66b87c934 enhancement: offer advice when unmatched English pages are detected (#22893) 2021-11-16 18:52:02 -08:00
Peter Bengtsson
5760b8512d make FailBot unit tests independent of env (#22871)
Part of #1229
2021-11-16 20:40:08 +00:00
Kevin Heis
329a8c664e Create a shared picker component (#22836)
* Unified picker component

* Add picker to storybook

* TS fixes

* Simplify "mobile" header spacing

* Fix a few testid

* Update Picker.tsx

* Update Picker.tsx

* Update Picker.tsx

* Fix unit test

* Fix rendering tests
2021-11-16 19:10:28 +00:00
Rachael Sewell
4cab1e7bc9 stop gap for open redirect (#22839) 2021-11-16 17:48:12 +00:00
Peter Bengtsson
ed53e2dd77 use @github/failbot with got (#22842)
* use @github/failbot

Part of #1222

* tests are not working yet

* fix unit tests

* cleanup
2021-11-16 16:48:40 +00:00
Marcelo Jacobus
0bb92d7b7e Assert translated pages match an English one (#22180) 2021-11-12 18:36:26 +00:00
Mike Surowiec
7310fc998a Refactor display-platform-specific-content (#22665)
* refactor display-platform-specific-content

* update PlatformPicker tests and cleanup
2021-11-12 14:40:35 +00:00
Rachael Sewell
0244fda807 search improvements (#22443) 2021-11-10 11:11:28 -08:00
Kevin Heis
6ec20638b5 Version picker combo (#22694)
* Move version picker next to product picker

* Always render in header

* Inline variant

* Remove topper-sidebar

* Handle breadcrumb length

* Have breadcrumbs use Primer breakpoint

* Make a breadcrumbs scss module

* Update Breadcrumbs.tsx

* Update Breadcrumbs.module.scss

* Update Breadcrumbs.module.scss

* Update server.js

* Use responsive classes for hide/show breadcrumb
2021-11-10 16:20:34 +00:00
Grace Park
240f5fbafe Updating breadcrumbs (#22626)
* updating breadcrumbs

* fix tests

* one more
2021-11-08 17:53:19 +00:00
Marcelo Jacobus
ed9e3d79cb Add test and script to ensure 1:1 parity of liquid tags between source and translation (#22472)
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-11-04 10:59:17 -03:00
Kevin Heis
9d53e40612 Make individual learning paths linkable (#22545)
* Make individual learning paths linkable

* Update learning-tracks.js

* Update LearningTrack.module.scss
2021-11-02 21:32:04 +00:00
Kevin Heis
dca7e56c3d More hydro error info (#22533)
* Add more info to hydro failures

* Clean up

* Update hydro.js

* Move hydro names to event schema file

* Update hydro.js
2021-11-02 16:13:48 +00:00
Jules Parker
2a08f64ad2 out of date branch Merge branch 'main' into jules-4795 2021-11-01 10:25:05 +01:00
Grace Park
75d41076a7 Article Layout Improvements (#22424)
* moving breadcrumbs to sticky header

* update scroll

* update color-bg-primary to color-bg-default

* change back to primary since were on primer 17

* add effect dependency

* not changing

* clip left box shadow of header and unmount

* update to default

* update breadcrumbs tests

* sticky editor
2021-10-29 19:57:07 +00:00
Rachael Sewell
684b8d79a1 Update test message with troubleshooting tips (#22143) 2021-10-28 23:01:45 +00:00
Kevin Heis
567652b0e3 Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Robert Sese
df2e3be178 Small bits of test cleanup 🧹 (#22442)
* Unskip test, ghec graphql version added

* Link to test skip issue

* Stray console.log ✂️
2021-10-27 22:31:41 +00:00
Robert Sese
693e36bfdd Fix breadcrumbs when paths have partial match 🍞 (#22414)
* Add failing breadcrumb test for paths with partial match

* Handle overlapping paths when creating breadcrumbs
2021-10-26 21:24:54 +00:00
Mike Surowiec
e3074d998f fix: detect language error on /_next/data/ input (#22419) 2021-10-26 21:03:47 +00:00
Jules Parker
3e72ad4dce Merge branch 'main' into jules-4795 2021-10-26 12:01:50 +02:00
Mike Surowiec
bede852dc4 fix: detect-language correctly handles root path, add unit tests (#22404) 2021-10-26 03:22:25 +00:00
Kevin Heis
3b092b4cb8 Deprecate 2.22 b (#22366)
* Update enterprise-server-releases.js

* Run deprecation script

* Remove finding / managing security vulnerabilities

* remove vuln from translations

* remove more dead pages

* Restore heavily used files

* Remove 2.22 refs in tests

* Update working-with-the-npm-registry.md
2021-10-22 13:23:16 -07:00
Edward Thomson
0fee9aedcd Landing page: groups of features (#22313)
* homepage: reduce padding below search area

Bring as much useful content up "above the fold".

* homepage: add groups for the front page sections

Group the homepage links into sections that map to the GitHub features
page (`/features`) plus two groups that are bespoke to the docs ("Get
started" and "Developers").

* homepage: update group design

Group the feature list area using the design exploration work by
@arisacoba.  Remove the description.

* homepage: remove ungrouped items from main area

Remove ungrouped items (like the external links) from the main feature
area.  Users can still navigate to ungrouped items in the sidebar.

* fix tsc error, use Link component

* homepage: support empty icon in group

Don't assume that we have icons everywhere on the landing page groups.

* homepage: drop octocat/invertocat

Looks weird with the modern icons, looks bad in dark mode.  Drop them
for now.

* homepage: document the childGroups frontmatter property

* homepage: don't test that sidebar == main content

We're reducing the links on the homepage in the main content area, but
the sidebar should be the complete list of products.  Remove the tests
that ensure that the main content area has all the sidebar content.  But
keep the tests that ensure that the sidebar content has all the links in
the main content area.

* homepage: remove "GitHub" doc set

The "GitHub" doc set "will be removed soon as we keep moving more content
out of it, so let's not include it here to keep the page more
evergreen."

* homepage: don't test that `/github` is linked on the main page

We're removing the `/github` doc set, and it's now not in the main page
grouped links.  Remove the test that `/github` exists, now look for
`/get-started`.

* homepage: use octicons instead of images

The images from https://github.com/features will be updated 🔜 - in
the meantime, let's use octicons which are consistent and give visual
interest.

* homepage: use octicons from @primer/octicons-react

Using the react components adds `<svg>` elements instead of `<img>`
elements, which lets the element use the current fill color, supporting
both light and dark themes.

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-10-22 17:58:16 +00:00
Matt Pollard
5016286f81 Merge branch 'main' into jules-4795 2021-10-22 09:24:18 +02:00
Sarah Edwards
ce5ab14f67 Not as big as it looks! Migrate guide.github.com content (#21942) 2021-10-20 14:53:24 +00:00
Matt Pollard
4657a4d3f3 Merge branch 'main' into jules-4795 2021-10-20 15:49:31 +02:00
Peter Bengtsson
4e4ca1d12d gg commit (#22323)
Part of #1061
2021-10-20 09:45:18 -04:00
Matt Pollard
ab397d54d8 Adjust expected number of featured links again 2021-10-20 12:35:25 +02:00