1
0
mirror of synced 2025-12-30 12:02:01 -05:00
Commit Graph

935 Commits

Author SHA1 Message Date
Marcelo Jacobus
cf2603ac01 fix: retry translation batch PR creation if we hit a 502 (#23633)
* Fix error on Pull Request creation

Fix https://github.com/github/docs-engineering/issues/1293. This
solution does not really handle the error, it just prevents the script
from stopping, since sometimes we get a timeout error from the load
balancer even though the request was successfully handled by rails.

* Add a nudge to the localization folks when a batch is created

Ever since the translation batches are created and merged automatically
it is difficult to see when they started or finished correctly. Also,
sometimes, docubot automatically closes some pull requests, and at the
time of this writing I don't know the reason.

This change intends to make batches not go unnoticed. We can revert it
later if this becomes too noisy and the process is stable.

* fix: remove ping to docs-localization team from batch PR body

Discussion: https://github.com/github/docs-internal/pull/23633/files#r771896816

* refactor: move report-reset-files into its own step

* refactor: move git push into its own step

* spike: move PR creation into its own script

* feat: annotate createTranslationBatchPullRequest fn

* enhancement: embed nwo#pr format in logger

* fix: import fs directly

* fix: import @actions/github directly

* docs: update annotations in fn block

* build: update step name to be self-documenting

* Retry on 502

* Rename method to reflect its behaviour

* Update codeowners

* Fix comment

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Appease linter and fix script

* Move options to main

* Rename var

* Refactor options

* Check for response

* First try to find and then to create the PR

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>

* Remove unreachable conditional

* Lint

* fix: remove duplicate annotation

Co-authored-by: docubot <67483024+docubot@users.noreply.github.com>
Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-11 23:06:18 +00:00
James M. Greene
fc25c1a7be Simplify and correct 'npm test' usage in Workflows (#24219) 2022-01-11 21:05:39 +00:00
Mike McDonald
04da545821 Adding Codespace prebuilds to docs-internal (#23952)
* Adding Codespaces prebuilds
* Adding permissions
* Use pinned SHA for github/codespaces-precache action
* Add comments
* Add codespaces-precache repo to reference allow list

Co-authored-by: James M. Greene <jamesmgreene@github.com>
2022-01-11 00:23:08 -06:00
Peter Bengtsson
4406fd9834 treat list of files as space separated (#24176)
* treat list of files as space separated

* debuggnig

* debuggnig

* better

* test now

* cleanup

* all cleanups

* mention feature request on the action
2022-01-11 02:58:45 +00:00
dependabot[bot]
893f50cd7a Bump actions/setup-node from 2.5.0 to 2.5.1 (#24009)
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.5.0 to 2.5.1.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](04c56d2f95...1f8c6b94b2)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-10 09:07:53 -05:00
dependabot[bot]
1d20c5d10f Bump actions/cache from 2.1.6 to 2.1.7 (#24013)
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](c64c572235...937d244753)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-01-07 23:42:39 +00:00
dependabot[bot]
9028fadad1 Bump peter-evans/create-pull-request from 3.10.1 to 3.12.0 (#24012)
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 3.10.1 to 3.12.0.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](7380612b49...dcd5fd746d)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-01-07 23:38:43 +00:00
dependabot[bot]
35366aefc6 Bump actions/upload-artifact from 2.2.4 to 2.3.1 (#24011)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2.2.4 to 2.3.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](27121b0bdf...82c141cc51)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-01-07 23:34:37 +00:00
dependabot[bot]
366af672fc Bump EndBug/add-and-commit from 7.2.1 to 7.5.0 (#24010)
Bumps [EndBug/add-and-commit](https://github.com/EndBug/add-and-commit) from 7.2.1 to 7.5.0.
- [Release notes](https://github.com/EndBug/add-and-commit/releases)
- [Changelog](https://github.com/EndBug/add-and-commit/blob/main/CHANGELOG.md)
- [Commits](2bdc0a61a0...8c12ff729a)

---
updated-dependencies:
- dependency-name: EndBug/add-and-commit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-01-07 23:30:39 +00:00
Ramya Parimi
03c9f5ea57 Merged notification workflow are failing (#24081)
* Update triage-issue-comments.yml

* Update merged-notification.yml

* Update triage-issue-comments.yml
2022-01-07 02:30:47 +00:00
James M. Greene
2d8a3cc7d0 Add actions:read permissions to GITHUB_TOKEN (#24113) 2022-01-06 17:16:19 +00:00
James M. Greene
be4249b57c Remove the concept of "undeployment" as a part of the PR deployment lifecycle (#23731)
* Update remove-stale-staging-resources workflow to completely replace undeploy workflow
* Delete the staging-undeploy-pr workflow file
* Delete all undeployment scripts and logic
* Remove all references to the automated-block-deploy label used for undeployment
* Simplify staging cross-workflow concurrency needs
2022-01-06 16:27:48 +00:00
Peter Bengtsson
26d2c5438a Check for orphaned assets in CI (#24074) 2022-01-05 16:26:45 +00:00
Mike Surowiec
a840d2bb13 Add production Azure workflow (#24038)
* add prod-build-deploy-azure workflow
2022-01-04 22:40:08 -06:00
Peter Bengtsson
9bdbec73d4 escape echo of changed files in Action (#24058)
* escape echo of changed files in Action

* escaped

* escaped (2)

* temporary

* reset temporary tests
2022-01-04 22:50:43 +00:00
Robert Sese
a9da0c8681 Singular script directory (#24052) 2022-01-04 21:00:47 +00:00
Sarah Edwards
7cff1636cd use pull_request_target trigger (#23946)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-01-04 19:56:16 +00:00
James M. Greene
6f2170e825 Remove duplicate CI env vars from Actions workflows (#23921) 2022-01-04 18:29:04 +00:00
Peter Bengtsson
1a8d06089e use pull_request for the private staging-build-and-deploy (#23783) 2022-01-04 18:01:27 +00:00
Kevin Heis
55ee70e06b Check that actions specify hashes instead of allowlist (#24042)
* Check that actions specify hashes instead of allowlist

* Fixes for unhashed version

* Update actions-workflows.js
2022-01-04 17:43:40 +00:00
Sarah Edwards
d5c3731634 handle case where requestedReviewer is null (#24043) 2022-01-04 09:39:11 -08:00
Sarah Edwards
ed92a75e10 Classify hubber PRs as hubber contributions even in the OS repo (#23987)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-01-04 17:10:01 +00:00
Sarah Edwards
767d7d8f51 Get all open PRs instead of last 100 (#23985) 2022-01-04 16:16:58 +00:00
Marcelo Jacobus
3b0594e3ce Automate closing of stale translation batches (#23581)
* Automatically close stale translation batches

* fix: adjust spacing for the query key

Resolves CI failure: https://github.com/github/docs-internal/runs/4486848450?check_suite_focus=true#step:3:4

* Fix query

* enhancement: add type filter to query

`type` filter restricts results to either issues or pull requests. In this case, we want to close existing stale batches that are _only_ pull requests.

Docs: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-only-issues-or-pull-requests

* feat: use lee-dohm/close-matching-issues v2.1.0

https://github.com/lee-dohm/close-matching-issues/pull/357 is merged into this release, which gives the action the ability to close matching issues _and_ pull requests.

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
2021-12-20 17:50:37 +00:00
James M. Greene
94659705b1 Alternative repo-sync fixes (#23892)
* Info is in the data prop

* Don't bother to comment when closing our own automated repo-sync PRs

Co-authored-by: Robert Sese <sese@github.com>
2021-12-18 14:31:40 -06:00
James M. Greene
b486966547 Add a few checks to close the repo-sync PR if no changes remain (#23839) 2021-12-17 20:37:56 +00:00
James M. Greene
d6405ecb45 Optimize workflow runs with concurrency settings (#23811)
* Add concurrency settings for a bunch of workflows
* Restrict prod deployments to one at a time but disallow interrupting
* Remove redundant pull_request.types specification
2021-12-17 16:00:52 +00:00
Robert Sese
3f2283fcb3 Add popular-pages.json to CODEOWNERS (#23796)
* Add popular-pages.json to CODEOWNERS

* Actually add to CODEOWNERS correctly for docs-eng
2021-12-16 18:36:09 +00:00
Peter Bengtsson
a44fe743f7 don't run old link checkers on pushes (#23785) 2021-12-16 18:10:20 +00:00
Rachael Sewell
02c5e44c4d Run translation workflow once a day (#23765)
Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
2021-12-16 16:56:35 +00:00
Peter Bengtsson
84f323fdc1 Ability to soft-purge Fastly with a click of a button (#23508)
* Ability to soft-purge Fastly with a click of a button

* permissions

* install dependencies would help
2021-12-16 13:30:22 +00:00
Peter Bengtsson
17e33bbb61 don't run unit tests on pushes to main (#23755) 2021-12-16 12:51:30 +00:00
Peter Bengtsson
1c2219c057 remove old debugging in staging-deploy-pr (#23701) 2021-12-15 20:16:04 +00:00
Peter Bengtsson
bf5c7353d2 eslint check the .github/actions-scripts/* files too (#23698)
* eslint check the .github/actions-scripts/* files too

* but ignore node_modules/.bin/*

* fix errors

* last one

* feedbacked
2021-12-15 17:35:34 +00:00
Peter Bengtsson
a736b53cec Only run browser tests on pull request (#23704)
* only run browser tests on pull_request

* package.json also

* helps if I edit the right file
2021-12-15 17:21:51 +00:00
Robert Sese
0e9c08f040 Unlock before approving in repo sync (#23730)
* Unlock before approving

* Revert "Unlock before approving"

This reverts commit 2b9bc2de94b412a49d3b81f4e48d798c48abfca0.

* Set content:write so we can approve locked PRs
2021-12-15 17:01:33 +00:00
James M. Greene
dc756b9dd3 Adjust internal staging build/deploy job name (#23725)
A unique name is critical so we can make it a required check
2021-12-14 18:21:47 -06:00
Peter Bengtsson
2e9128b148 shared .next/cache in staging-build workflow (#23700)
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-12-15 00:01:12 +00:00
James M. Greene
526b5bd651 Add nextjs caching into all workflows with builds (#23654)
* Add nextjs caching into all workflows with builds

* Reposition the nextjs cache step for test-windows.yml

* Fix cache and run build for browser-test.yml

* Update .github/workflows/browser-test.yml
2021-12-14 23:21:06 +00:00
Peter Bengtsson
d3396ff4c0 ReferenceError in .github/actions-scripts/staging-commit-status-success.js (#23697) 2021-12-14 10:56:16 -05:00
Peter Bengtsson
f68eb74d90 Make a dedicated, fast, workflow just for docs-internal only (#23289)
* Make a dedicated, fast, workflow just for docs-internal only

Part of #1297

* make staging-build-pr only for github/docs

* prune later

* make it louder and clearer about disabling workflows

* does it merge?

* typo

* rename ref

* rename

* early access should be good to go

* far from perfect

* start with that

* gzip

* rearrange

* html_url

* correction of actions/checkout sha

* correction of actions/setup-node sha

* quote

* ooops

* actually deploy

* move @octokit/rest to dependencies

* await-sleep hack

* reinstall npm

* typo

* CONTEXT_NAME

* deployments:write permission

* pull-requests:read permission

* actions:read and statuses:write permissions

* private repo mention exception

* it's called github.run_id

* Apply suggestions from code review

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* make CONTEXT_NAME optional (if it works)

* comment out CONTEXT_NAME

* simplifying

* going to run on on.pull_request instead

* remove comment

* only the 2-phase staging deploy on github/docs

* better if statement on label check

* refactor of staging-deploy script

* switch to npm install to get the deDependencies back

* using --only=dev

* updating comments

* event_name

* not on pushes to main

* add staging-commit-status-success

* testing testing

* fix linting error

* Remove other docs-internal references from staging-deploy-pr.yml

* Cleaning up new staging-commit-status-success script and usage

* Remove unnecessary environment refs

* Remove unnecessary fallback

Since the only event trigger is pull_request now instead of also push

* Remove unnecessary env vars from workflow

* docs-internal or docs but not both

* Don't provide unnecessary environment refs

* remove now moot exception

* setting it to pull_request_target

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-12-14 08:57:54 -05:00
James M. Greene
6b01293461 Add missing security-events:write permissions for CodeQL (#23676) 2021-12-13 23:35:03 -06:00
James M. Greene
3d88cae50b Add permission matrices to all Actions workflows (#23563)
* Add permission matrices to all Actions workflows

Also cleanup a few token references

* Add actions:read permissions for CodeQL

* Add prs:read permissions for unit test workflow
2021-12-14 04:37:36 +00:00
Marcelo Jacobus
dc0d22fa84 Run workflow every six hours (#23585)
* Run cronjob every six hours

* fix: run translation batch PRs on the 25th minute

Resolves CI failure in https://github.com/github/docs-internal/runs/4490412418?check_suite_focus=true#step:10:97

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
2021-12-13 17:48:23 +00:00
Marcelo Jacobus
26d7681b95 Remove crowdin.yml workflow (#23490)
* Remove crowdin.yml workflow

Closes https://github.com/github/docs-engineering/issues/1341

* Fix test

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
2021-12-13 17:30:07 +00:00
Francis
04c8ed5726 fix: verify Crowdin CLI download before installing (#23515)
This change uses the suggested steps in https://support.crowdin.com/cli-tool/#debian,
with a slight modification in creating the `crowdin.list` file in the `/etc/apt/sources.list.d` directory.

This approach creates a new file for `crowdin.list`, then pipes the content to `tee -a`. Credits go to [this Ask Ubuntu thread reply](https://askubuntu.com/questions/185268/permission-denied-etc-apt-sources-list/185270#185270).
2021-12-11 02:08:00 +00:00
Marcelo Jacobus
daa16775d8 Fix label for translation batches (#23577) 2021-12-11 01:48:22 +00:00
Marcelo Jacobus
953e87e7a0 Use @octomerger for approving and merging translation batches (#23546)
* Use @octomerger for approving and merging translation batches

Here is a [list of bots](https://github.com/github/docs-engineering#bot-accounts)

* Set @octomerger as a code owner of /translations
2021-12-09 20:13:43 +00:00
Marcelo Jacobus
a7175314ec Remove ownership from @github-actions (#23543)
A bot cannot currently own a file, according to this
https://github.community/t/is-it-possible-to-add-github-apps-bot-to-codeowners/3146
2021-12-09 20:04:52 +00:00
Marcelo Jacobus
1f4b19ae9c Revert "Attempt to fix ownership (#23538)" (#23540)
This reverts commit e126be0147.
2021-12-09 18:52:27 +00:00