1
0
mirror of synced 2026-01-06 06:02:35 -05:00
Commit Graph

229 Commits

Author SHA1 Message Date
Sarah Schneider
520ff1bc5f Merge branch 'main' of github.com:github/docs-internal into move-product-list-to-frontmatter 2021-04-07 14:33:56 -04:00
James M. Greene
22e8d75c91 RedisAccessor tolerance for GET failures (#18586)
* Update RedisAccessor to allow for graceful GET failures, too
* Add unit tests for allowGetFailures behavior
2021-04-05 16:26:46 +00:00
Sarah Schneider
bc15682ecc Merge branch 'main' into scheduled-workflow-tests 2021-04-01 16:23:40 -04:00
Sarah Schneider
c7f647f68a update references 2021-04-01 15:29:59 -04:00
Sarah Schneider
4c7af55699 add a parallel toHaveLength test 2021-04-01 14:10:41 -04:00
Sarah Schneider
0c91835cee add tests 2021-04-01 11:12:31 -04:00
Sarah Schneider
10b13a8ebd Merge branch 'main' of github.com:github/docs-internal into scheduled-workflow-tests 2021-03-31 09:14:31 -04:00
James M. Greene
84547e54c7 Use node-redis for page cache (#18421)
* Use [node-]redis as a direct dependency

* Extract Redis client creation to its own module

* Attach extensive logging in the Redis client creation module

* Allow the rate limiter to pass requests when Redis is disconnected

* Update rate-limit-redis

* Default error input to empty object for formatRedisError method

* Provide a name for the rate limiter's Redis client

* Include redis-mock, exclude ioredis/ioredis-mock

* Remove unused RedisAccessor#exists method

* Switch RedisAccessor to use redis/redis-mock

* Provide a name for logging on the Redis page cache

* Remove extraneous trailing space from Redis logging prefix

Our updated use of console.* will already be adding a space after the prefix

* Replace ioredis-mock with redis-mock in tests

* Revert removal of ioredis dependency

* Bind Redis client to async promisified methods

* Extract former RedisAccessor constructor tests to new create-client tests

* Update RedisAccessor tests to work with the callback-based redis client

* Handle formatting Redis errors (or not) with more resiliency
2021-03-29 17:34:22 +00:00
Sarah Schneider
df6be79b0f Merge branch 'main' of github.com:github/docs-internal into scheduled-workflow-tests 2021-03-24 13:27:00 -04:00
Matt Pollard
4ce3cb1fb1 Document enterprise policies for GitHub Advanced Security (#18263) 2021-03-22 16:20:27 +00:00
Sarah Schneider
d7f78d8238 use regex as a less brittle check for any number of zeros 2021-03-18 13:55:17 -04:00
Sarah Schneider
d0a136caee add tests to ensure workflow crons are unique and do not run at top of the hour 2021-03-18 13:39:59 -04:00
Rachael Sewell
02ee72fa25 add topics attribute to search (#18212) 2021-03-17 13:11:29 -07:00
Sarah Schneider
5006cdaff2 add tests 2021-03-17 10:30:16 -04:00
Rachael Sewell
01e52046f0 migrate away from AWS S3 (#17669) 2021-02-12 10:25:45 -08:00
Jason Etcovitch
e68e6a5185 Revert "Revert "Absorb @github-docs/frontmatter (#17783)" (#17793)" (#17799)
* Revert "Revert "Absorb @github-docs/frontmatter (#17783)" (#17793)"

This reverts commit 11baf43eee.

* Move revalidator to depedencies
2021-02-11 11:15:59 -05:00
Jason Etcovitch
11baf43eee Revert "Absorb @github-docs/frontmatter (#17783)" (#17793)
This reverts commit 1e96c03489.
2021-02-10 20:28:41 +00:00
Jason Etcovitch
1e96c03489 Absorb @github-docs/frontmatter (#17783) 2021-02-10 15:10:46 -05:00
Vanessa Yuen
4038e9ca85 Add topic property and filter to guides page (#17328)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-29 12:32:31 +00:00
Kevin Heis
2fb2e962bc Move site search to use an endpoint (#17359)
* Move site search to use an endpoint

* Update browser.js

* Update search.js

* Update lib/search/versions.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Fix URLs

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-01-20 15:37:42 +00:00
Vanessa Yuen
b46da8dfc7 Sublanding page all guides section (#16869)
* get link liquid tag to accept variables as param

* new liquid tag `link_as_article_card`

* refactor link liquid tag slightly so we can control what props get rendered

* generalize filterCodeExample to use in all guides section

* pass in `js-filter-card-max` instead of hardcode max

* tweaks and add `data` to CSP for images

* add liquid tag tests

* add some browser tests for card filters

* we still need to rely on `getPathWithLanguage` for hrefs that already have the language code embedded


Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-18 12:23:23 +00:00
Sarah Schneider
564628799c Merge branch 'remove-fpt' of github.com:github/docs-internal into remove-fpt-helper 2021-01-15 09:39:12 -05:00
Sarah Schneider
ffb4e548a0 Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-15 09:38:15 -05:00
Vanessa Yuen
eaacb54422 small liquid link tag cleanup (#17280)
* remove unnecessary `render` methods
* we don't use `link_with_short_title` anymore
* remove `shortTitle` option
* remove ink_with_short_title tag test
2021-01-15 13:24:39 +00:00
Sarah Schneider
9809627129 lint 2021-01-14 17:10:12 -05:00
Sarah Schneider
affbc80a3c update tests to remove free-pro-team from expected results 2021-01-14 17:08:30 -05:00
Sarah Schneider
ed8b46267c Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-14 12:08:27 -05:00
Sarah Schneider
39fe8cb96c add currentVersion to test context 2021-01-14 12:08:01 -05:00
Jason Etcovitch
0ec47e0246 Only read the frontmatter from files in warm-server (#17222)
* Add read-frontmatter.js

* Use it

* Page static read/init are async now

* Fix some blockers

* I'm confused

* Fix some more bugs

* Use frontmatter schema, ensure end fence exists

* Fix a bug

* Still read full contents for index.md files

* Remove comment

* Only get ToC items for index pages

* Readd frontmatter error and verdadero handling

* Fix some borked tests

* Simplify the code

* Add a comment

* Remove redundant variable

* Re-simplify the Page construction

* End chunk _after_ endline

* Just use Page.init
2021-01-14 10:46:59 -05:00
Sarah Schneider
79a7a7972f Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-13 16:58:05 -05:00
Sarah Schneider
e1cb587339 update refs to reinstated findPage() 2021-01-13 16:50:20 -05:00
Sarah Schneider
23170a50e6 lint 2021-01-13 16:50:05 -05:00
Vanessa Yuen
641ed02e81 Actions Guides sublanding page (#16740)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
2021-01-11 18:30:57 +01:00
Sarah Schneider
9d318e0380 Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-08 11:06:27 -05:00
Sarah Schneider
5f42c407f3 add a few redirects to fake context object 2021-01-08 11:05:55 -05:00
Barry McGee
ffdd3b3d97 Update tests with new expected semantic headings 2021-01-08 00:08:47 +00:00
James M. Greene
068c472084 Cache rendered pages in Redis (#17106)
* Explicitly set the Redis database number used for rate limiting

* Switch to using ioredis as the Redis client for rate limiting

* Install ioredis-mock as a primary dependency

* Create a Redis BasicAccessor class and tests

* Switch rendered page caching to use Redis for storage

* Add support for additional Redis SET options like TTLs

* Remove currently unused methods

* Rename redis-accessors/basic to redis-accessor and remove extra fluff

* Change default behavior for cache setting to throw if an error occurs

Add option allowSetFailures to facilitate graceful failures

* Allow SET failures to fail gracefully for the rendered page cache

* Remove as-yet unneeded serialization options from RedisAccessor

* Move Redis client construction into RedisAccessor constructor, just pass in databaseNumber as option

* Remove rendered-page-cache in favor of direct RedisAccessor use

* Add tests for RedisAccessor constructor param validations

* Eliminate one roundtrip to Redis for the cached HTML existence check

Are we fast yet?

* Set a rendered page cache TTL of 24 hours
2021-01-06 15:30:51 -06:00
Kevin Heis
4ffc2a5e2b Fix a bunch of typos in tests dir (#17132)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-05 11:25:14 -05:00
Kevin Heis
59f375ab1d Merge branch 'main' into default-platform 2020-12-16 14:36:46 -08:00
James M. Greene
9d73f5adef Remove accidentally committed console logging from test (#16813)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-15 17:40:01 -05:00
Simran Spiller
d565a13d8d Fix unit test error 2020-12-11 02:01:14 +01:00
Simran Spiller
4afc7d4035 Merge remote-tracking branch 'upstream/main' into default-platform 2020-12-11 01:13:32 +01:00
Sarah Schneider
5b82f5e03e Merge branch 'main' into skip-early-access-tests 2020-12-09 21:32:50 -05:00
James M. Greene
e6518ff9c3 Fix unresolved data lookups on GitHub Glossary page (#16815)
* Support [...] in data tag path

* Use forloop.index0 to get data tag path

* Commit whitespace change to not keep getting it

* Recursively render glossary terms as well

* Add tests to verify Liquid data tag can handle bracketed access

* Remove superfluous 'set' for context in tests

* Avoid the mystery guest anti-pattern... move the test data closer to the test

* Escape the `-` character in the data regex

Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-09 18:58:00 -06:00
Kevin Heis
e7406b7336 Merge branch 'main' into default-platform 2020-12-09 15:06:30 -08:00
Kevin Heis
1b424dfdc4 Bring in data-directory, let's go async file reads (#16782)
* Bring in data-directory, let's go async file reads

* Lint fixes

* Update glossary.js
2020-12-09 11:20:24 -08:00
Kevin Heis
62889986b6 Revert "Revert "Speed up warmServer by loading pages (and files) asyn… (#16837)
* Revert "Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)"

This reverts commit a14517115f.

* Move async to regular dependencies

* Update package-lock.json
2020-12-09 17:40:58 +00:00
Jason Etcovitch
a14517115f Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)
This reverts commit 1d5e216404.
2020-12-09 17:12:07 +00:00
Kevin Heis
1d5e216404 Speed up warmServer by loading pages (and files) asynchronously (#16752)
* Async `new Page`

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Using mapLimit

* Update pages.js

* Test updates

* Update pages.js

* Move exists to page class

* Test fixes

* Slightly faster localized paths process
2020-12-09 16:57:18 +00:00
Kevin Heis
98e4b78112 Update tests to use fs.promises when not top-level (#16803)
* Update tests to use fs.promises when not top-level

* Move two to asyncFilter

* Update site-data-references.js

* Update site-data-references.js

* Clear out await fs.exists

* Lint

* A few more fixes

* Can't use async when defining tests
2020-12-09 15:42:02 +00:00