1
0
mirror of synced 2025-12-23 11:54:18 -05:00
Commit Graph

57 Commits

Author SHA1 Message Date
Peter Bengtsson
43f0e5270c remove GHEC signup button for dotcom_user cookied users (#26521) 2022-03-29 20:21:38 +00:00
Grace Park
2c8713037d Move deploy keys from deployments to keys in rest pages (#26166)
* move deploy keys from deployments to keys in rest pages

* move minitocs above intro

* Update content/rest/reference/keys.md

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* add to banner, add redirects from deployments

* remove deploy keys from deployments intro

* update data/reusables name

* update - to _

* update script and add redirects for subcategories turned categories

Co-authored-by: Sarah Edwards <skedwards88@github.com>
2022-03-17 17:25:12 +00:00
Peter Bengtsson
95297c3c9d Simplify getBreadcrumbs (#26015)
* fix getBreadcrumbs

* don't go too deep

* remove commented out code
2022-03-09 01:14:49 +00:00
Peter Bengtsson
9d4b913bdc language redirects without cache (#25872)
* redirect to your preferred language (#25664)

* redirect to your preferred language

* refactorings

* use js-cookies

* make sure no cache when language is involved in the redirect

* fix tests
2022-03-07 16:25:22 +00:00
Peter Bengtsson
881a6d2212 Revert "redirect to your preferred language (#25664)" (#25869)
This reverts commit a9947c086c.
2022-03-04 21:56:57 +00:00
Peter Bengtsson
a9947c086c redirect to your preferred language (#25664)
* redirect to your preferred language

* refactorings

* use js-cookies
2022-03-04 16:29:11 +00:00
Rachael Sewell
2ade7d8489 reactify rest pages (#25005) 2022-02-28 18:30:54 +00:00
Mike Surowiec
f3fc80cf05 Upgrade primer/components -> primer/react (#25591)
* upgrade primer/components -> primer/react

* fix jest failure
2022-02-24 00:30:14 +00:00
Robert Sese
55a0cbf674 Fix string key (#25576) 2022-02-23 11:48:55 -06:00
Robert Sese
2e4187733f Add link to versions doc in version picker (#25012)
* Add link to 'about versions' in version picker

* Add translation string

* Match article short title

* Better text contrast

* Key names is 'docs_versions'

* 'About versions'

* Show version picker when only 1 version

Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
2022-02-22 17:53:32 +00:00
Lucas Costi
e6af9ae1e6 Remove Actions REST enterprise subcategory (moved to Actions page) (#25065)
Co-authored-by: Rachael Sewell <rachmari@github.com>
2022-02-17 15:18:07 +10:00
Robert Sese
62ce173b76 Fix when we show the 'All Enterprise Releases' link (#25002)
* Enterprise versions start with 'enterprise-server'

* Show only if all versions are ghes versions

* Show link if there's any ghes versioning
2022-02-04 21:59:02 +00:00
Peter Bengtsson
a34f2c3787 reduce flash of sign-up CTA button (#24933) 2022-02-02 22:36:56 +00:00
Anosike Osifo
ec73762b3e Add GHEC Trial CTA to header of docs.github (#23324)
* Add GHEC Trial CTA to header of docs.github

* use i18n logic

* add signup cta

* add signup cta

* Update the Trial CTA href to allow users choose trial plan

* Update logic to conditionally display signup CTA. Also remove GH EC Trial CTA

* update logic to use && operator

* fix wrapping search bar bug
2022-01-28 20:15:54 +00:00
Grace Park
a3b81bb93c restructure footer and header (#24601) 2022-01-24 15:19:45 -08:00
Robert Sese
d0db00cd98 a11y: match picker label with current selection (#24321)
* Match label with selection

* defaultText is a better default

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* No longer used

* Also no longer used

* No longer used in the dropdown pickers

* Add translation strings for pickers

* Use translated strings in picker components

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-19 18:43:31 +00:00
Peter Bengtsson
4947218cba fix React key uniqueness in Breadcrumbs (#24182) 2022-01-11 01:56:30 +00:00
Rachael Sewell
a340162d84 reorganize repository apis (#23728)
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-11 11:53:12 +10:00
Grace Park
a4c5d58507 Accessibility: Breadcrumbs (#24151)
* programmatically group breadcrumbs

* forgot to commit li
'
'

* adding inline-block
2022-01-07 12:01:52 -08:00
Peter Bengtsson
7d75265b01 hydration fails on CollapsibleSection with hash in URL (#24105) 2022-01-07 02:25:16 +00:00
Peter Bengtsson
5893ae32b3 don't let the href depend on the router hash in client-side rendering (#24106) 2022-01-06 20:59:47 +00:00
Grace Park
124f54eb0c Accessibility changes for Nav Menu (#24099)
* updating to nav landmark

* support keyboard esc to close mobile menu

* update to ChevronDown to remove nested div
2022-01-06 17:34:19 +00:00
Robert Sese
bcb1b3c8bc Use lang attribute and translate picker aria-label (#24096)
* Translate picker aria-label

* Use lang attribute
2022-01-05 23:28:05 +00:00
Peter Bengtsson
3f9d798037 render same DOM in SSR as client (#24078) 2022-01-05 14:53:43 +00:00
Peter Bengtsson
53b0484a66 unique keys for RestRepoBanner links (#23764) 2021-12-15 16:08:43 -08:00
Robert Sese
5ff7bf2c65 Capitalize and comma outside link (#23723) 2021-12-14 16:57:24 -06:00
Rachael Sewell
bf7b2085bd fix broken links in banner component (#23719) 2021-12-14 14:00:47 -08:00
Rachael Sewell
daafb8cb9d break up large rest pages (#23652) 2021-12-14 20:39:25 +00:00
Peter Bengtsson
815f9d40c3 only link all enterprise versions if any is enterprise version (#23640) 2021-12-13 17:19:15 +00:00
Robert Sese
4ce6dd2840 More misc a11y bits (#23542)
* List-ify guide labels

* Use aria-expanded with 🍔 menu
2021-12-09 19:20:04 +00:00
Grace Park
f19223503a Update Search Version Button to Dropdown (#23465)
* adding to view

* updating the portal location

* add new line

* updating font styling to class

* Update components/Search.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* Update components/Search.module.scss

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* update ItemInput

* using router.replace and import updates

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* run prettier

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-12-09 17:56:24 +00:00
Kevin Heis
58fbe1edf5 Move px to rem in scss files (#23009)
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-11-19 21:06:45 +00:00
Kevin Heis
329a8c664e Create a shared picker component (#22836)
* Unified picker component

* Add picker to storybook

* TS fixes

* Simplify "mobile" header spacing

* Fix a few testid

* Update Picker.tsx

* Update Picker.tsx

* Update Picker.tsx

* Fix unit test

* Fix rendering tests
2021-11-16 19:10:28 +00:00
Peter Bengtsson
07a5edd2ab rewrite search state from useRouter (take 2) (#22833)
* rewrite search state from useRouter (take 2)

* fix the problem with isHeaderSearch

* cleaning ups

* updating mobile search results ui (#22841)

* remove useCallback

Co-authored-by: Grace Park <gracepark@github.com>
2021-11-16 18:55:48 +00:00
Grace Park
5bf39459ca Updating Search using Primer Components (#22677)
* updating search icon

* remove no fill

* update fill color

* using ActionList and Overlay

* update to ActionList, Overlay, add Label to Breadcrumbs, and change Mark

* add search-results test data and move header search results to right

* make search results scrollable and fix max-width in header search

* update header search and styling updates

* add highlight

* update styling

* styling and lint errors

* fix lint error and fetch

* Update components/Search.tsx

* update label color

* remove bottom margin

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-11-12 12:25:47 -08:00
Rachael Sewell
0244fda807 search improvements (#22443) 2021-11-10 11:11:28 -08:00
Peter Bengtsson
0d13379462 fix TS usage around VersionPicker (#22739) 2021-11-10 11:00:34 -08:00
Kevin Heis
6ec20638b5 Version picker combo (#22694)
* Move version picker next to product picker

* Always render in header

* Inline variant

* Remove topper-sidebar

* Handle breadcrumb length

* Have breadcrumbs use Primer breakpoint

* Make a breadcrumbs scss module

* Update Breadcrumbs.tsx

* Update Breadcrumbs.module.scss

* Update Breadcrumbs.module.scss

* Update server.js

* Use responsive classes for hide/show breadcrumb
2021-11-10 16:20:34 +00:00
Grace Park
d75bd265eb Flash updates for deprecation and header notifications (#22632)
* flash updates for deprecation and header notifications

* adding import and updating position
2021-11-09 19:52:20 +00:00
Grace Park
240f5fbafe Updating breadcrumbs (#22626)
* updating breadcrumbs

* fix tests

* one more
2021-11-08 17:53:19 +00:00
Grace Park
2969394991 have header span the entire page (#22543) 2021-11-02 13:08:27 -07:00
Grace Park
b211776b85 Updating to scroll past header notifications and keep header sticky (#22539)
* updating to scroll past notification and keep header sticky

* Update components/page-header/Header.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-11-02 18:50:31 +00:00
Grace Park
f684e7fe82 adding margin top to anchor links (#22515) 2021-11-01 13:57:00 -07:00
Grace Park
3957ffeb1c fix so mobile menu is sticky when open (#22498) 2021-10-30 09:34:27 -07:00
Grace Park
75d41076a7 Article Layout Improvements (#22424)
* moving breadcrumbs to sticky header

* update scroll

* update color-bg-primary to color-bg-default

* change back to primary since were on primer 17

* add effect dependency

* not changing

* clip left box shadow of header and unmount

* update to default

* update breadcrumbs tests

* sticky editor
2021-10-29 19:57:07 +00:00
Kevin Heis
567652b0e3 Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Mike Surowiec
d81f51ebf7 Picker improvements (#21765)
* close Language and ArticleVersion pickers after click

* cleanup ArticleGridLayout due to VersionPicker changes

* fix tsc errors resulting from primer upgrade

* fix / update tests

* cleanup mobile pickers visual consistency

* use btn-sm on VersionPicker

* update translation and close on click for enterprise releases

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 20:22:13 +00:00
Mike Surowiec
3125579983 remove currentLanguage from mainContext, use router.locale instead (#21716) 2021-09-27 14:40:43 +00:00
Kevin Heis
29ebc555cb Add btn-primary-matte, ScrollButton, TruncateLines to storybook (#21611)
* Update create-processor.js

* Use built in semibold

* Preparing articlelist

* Add blue button to storybook

* Scope fade styles

* Add truncate component

* Add scroll button to storybook

* Update storybook.tsx

* Update DefaultLayout.tsx
2021-09-20 23:21:29 +00:00
Kevin Heis
9f7c20dae8 Upgrade Primer CSS to version 17, removing marketing styles (#20965)
* Package updates

* Fix up things that look broken

* Add to utils

* Lead now just sets font size, just use f3 where needed

* Update package-lock.json

* Update index.tsx

* Delete bump-link.scss

* Update trigger-error.js

* Update components/GenericError.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update ArticlePage.tsx

* Update ActionBar.tsx

* Changes from meeting

* Found a few more monos

* Fix from a merge conflict

* Missed a few f3s

* Update SubLandingHero.tsx

* Bye gradients

* Match up breadcrumbs

* Update SubLandingHero.tsx

* Update lists.scss

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-08-31 14:49:39 -07:00