1
0
mirror of synced 2026-01-02 03:04:13 -05:00
Commit Graph

239 Commits

Author SHA1 Message Date
Mike Surowiec
0c3fa5f80b fix: use components/Link in Search.tsx (#23019) 2021-11-22 15:08:02 +00:00
Kevin Heis
58fbe1edf5 Move px to rem in scss files (#23009)
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-11-19 21:06:45 +00:00
Grace Park
33c5ce2d36 Updating images styling and accessibility for minitocitems (#22976)
* updating images styling on design systems feedback

* maintaining ul li structure for accessiblity

Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
2021-11-19 00:56:51 +00:00
Kevin Heis
f17c7a2598 Update search to use rem units where possible (#22970)
* Update search to use rem units where possible

* Use more primer classes

* Move more search to primer classes
2021-11-18 20:43:31 +00:00
Kevin Heis
308aa9cb0c Fix heading sizes (#22968)
* Align heading sizes with Primer

* Make the headings on other pages match normal pages
2021-11-18 19:45:13 +00:00
Grace Park
f5008425ba Updating ordered lists numbering border (#22972)
* updating ordered lists numbering border

* moving 8px away
2021-11-18 11:12:55 -08:00
Grace Park
75577663e9 bringing back i - thanks rsese (#22969) 2021-11-18 17:41:20 +00:00
Grace Park
5a809be3dc MiniTocItems: rerender tocs and fix bugs (#22948)
* add key to force rerender tocs

* move up platform specific to properly display none and go back to using contents

* remove i
2021-11-17 22:29:07 -08:00
Robert Sese
98d87bb4f2 Make list key unique (#22946) 2021-11-17 23:30:21 -06:00
Grace Park
130016bd0a Fix html in tocs (#22936)
* fix html in tocs

* render html
2021-11-17 17:17:10 -08:00
Grace Park
0afdf66a08 Primer Update: Table of Contents (#22933)
* update to ActionList

* fix nested mini tocs

* adding key

* remove li and fix tests

* update font size to 14px

* remove border radius
2021-11-18 00:27:12 +00:00
Peter Bengtsson
d605556a80 encode 'query' in 'redirectQuery' (#22913) 2021-11-17 23:08:46 +00:00
Peter Bengtsson
eb4a4741ad refactory getting 'query' with a hook (#22879) 2021-11-17 15:02:50 +00:00
Grace Park
56521881a2 Adding scroll to header search results (#22874)
* adding scroll to header search results

* move search-result

* search-result data test id addition

* forgot s
2021-11-16 21:32:45 +00:00
Kevin Heis
329a8c664e Create a shared picker component (#22836)
* Unified picker component

* Add picker to storybook

* TS fixes

* Simplify "mobile" header spacing

* Fix a few testid

* Update Picker.tsx

* Update Picker.tsx

* Update Picker.tsx

* Fix unit test

* Fix rendering tests
2021-11-16 19:10:28 +00:00
Peter Bengtsson
07a5edd2ab rewrite search state from useRouter (take 2) (#22833)
* rewrite search state from useRouter (take 2)

* fix the problem with isHeaderSearch

* cleaning ups

* updating mobile search results ui (#22841)

* remove useCallback

Co-authored-by: Grace Park <gracepark@github.com>
2021-11-16 18:55:48 +00:00
Rachael Sewell
e919d5085d change version within search result window (#22702) 2021-11-12 22:01:08 +00:00
Grace Park
5ac9d72005 styling updates and get all results (#22809) 2021-11-12 21:47:40 +00:00
Grace Park
5bf39459ca Updating Search using Primer Components (#22677)
* updating search icon

* remove no fill

* update fill color

* using ActionList and Overlay

* update to ActionList, Overlay, add Label to Breadcrumbs, and change Mark

* add search-results test data and move header search results to right

* make search results scrollable and fix max-width in header search

* update header search and styling updates

* add highlight

* update styling

* styling and lint errors

* fix lint error and fetch

* Update components/Search.tsx

* update label color

* remove bottom margin

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-11-12 12:25:47 -08:00
Mike Surowiec
d6e0485602 fix: platform content initial render (#22802) 2021-11-12 11:15:08 -06:00
Mike Surowiec
7310fc998a Refactor display-platform-specific-content (#22665)
* refactor display-platform-specific-content

* update PlatformPicker tests and cleanup
2021-11-12 14:40:35 +00:00
Ramya Parimi
9dff265cfd Merge branch 'main' into i11236-fix-workflow-path 2021-11-11 07:05:52 -06:00
Rachael Sewell
0244fda807 search improvements (#22443) 2021-11-10 11:11:28 -08:00
Peter Bengtsson
0d13379462 fix TS usage around VersionPicker (#22739) 2021-11-10 11:00:34 -08:00
Kevin Heis
6ec20638b5 Version picker combo (#22694)
* Move version picker next to product picker

* Always render in header

* Inline variant

* Remove topper-sidebar

* Handle breadcrumb length

* Have breadcrumbs use Primer breakpoint

* Make a breadcrumbs scss module

* Update Breadcrumbs.tsx

* Update Breadcrumbs.module.scss

* Update Breadcrumbs.module.scss

* Update server.js

* Use responsive classes for hide/show breadcrumb
2021-11-10 16:20:34 +00:00
ftnext
b987ffd10a fix typo in workflow paths 2021-11-10 22:53:34 +09:00
Grace Park
d75bd265eb Flash updates for deprecation and header notifications (#22632)
* flash updates for deprecation and header notifications

* adding import and updating position
2021-11-09 19:52:20 +00:00
Grace Park
240f5fbafe Updating breadcrumbs (#22626)
* updating breadcrumbs

* fix tests

* one more
2021-11-08 17:53:19 +00:00
Robert Sese
ad40e86796 Add release notes label and heading colors (#22585) 2021-11-03 22:47:55 +00:00
Ramya Parimi
7db55a6a7e Merge branch 'main' into main 2021-11-03 06:04:00 -05:00
Kevin Heis
9d53e40612 Make individual learning paths linkable (#22545)
* Make individual learning paths linkable

* Update learning-tracks.js

* Update LearningTrack.module.scss
2021-11-02 21:32:04 +00:00
Grace Park
2969394991 have header span the entire page (#22543) 2021-11-02 13:08:27 -07:00
Grace Park
b211776b85 Updating to scroll past header notifications and keep header sticky (#22539)
* updating to scroll past notification and keep header sticky

* Update components/page-header/Header.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-11-02 18:50:31 +00:00
Grace Park
f684e7fe82 adding margin top to anchor links (#22515) 2021-11-01 13:57:00 -07:00
Grace Park
3957ffeb1c fix so mobile menu is sticky when open (#22498) 2021-10-30 09:34:27 -07:00
Grace Park
75d41076a7 Article Layout Improvements (#22424)
* moving breadcrumbs to sticky header

* update scroll

* update color-bg-primary to color-bg-default

* change back to primary since were on primer 17

* add effect dependency

* not changing

* clip left box shadow of header and unmount

* update to default

* update breadcrumbs tests

* sticky editor
2021-10-29 19:57:07 +00:00
Peter Bengtsson
453e6340a7 reset survey after route navigation (#22488)
Part of #1115
2021-10-29 15:19:54 +00:00
Grace Park
596207f743 update to color-bg-default (#22482)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-10-29 15:05:48 +00:00
Kevin Heis
567652b0e3 Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Grace Park
d2b50026b4 Minor sidebar updates (#22403)
* minor sidebar updates batch

* Update components/sidebar/SidebarNav.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update components/sidebar/SidebarProduct.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* changing back to bg-primary since we are on primer 17

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-10-28 17:07:10 +00:00
Mike Surowiec
b223df9a8d fix: includeGuides should always include topics array (#22455) 2021-10-28 16:14:30 +00:00
Mike Surowiec
3fbda10305 fix html encoded entity in code example and article cards (#22328) 2021-10-25 20:40:02 +00:00
Edward Thomson
0fee9aedcd Landing page: groups of features (#22313)
* homepage: reduce padding below search area

Bring as much useful content up "above the fold".

* homepage: add groups for the front page sections

Group the homepage links into sections that map to the GitHub features
page (`/features`) plus two groups that are bespoke to the docs ("Get
started" and "Developers").

* homepage: update group design

Group the feature list area using the design exploration work by
@arisacoba.  Remove the description.

* homepage: remove ungrouped items from main area

Remove ungrouped items (like the external links) from the main feature
area.  Users can still navigate to ungrouped items in the sidebar.

* fix tsc error, use Link component

* homepage: support empty icon in group

Don't assume that we have icons everywhere on the landing page groups.

* homepage: drop octocat/invertocat

Looks weird with the modern icons, looks bad in dark mode.  Drop them
for now.

* homepage: document the childGroups frontmatter property

* homepage: don't test that sidebar == main content

We're reducing the links on the homepage in the main content area, but
the sidebar should be the complete list of products.  Remove the tests
that ensure that the main content area has all the sidebar content.  But
keep the tests that ensure that the sidebar content has all the links in
the main content area.

* homepage: remove "GitHub" doc set

The "GitHub" doc set "will be removed soon as we keep moving more content
out of it, so let's not include it here to keep the page more
evergreen."

* homepage: don't test that `/github` is linked on the main page

We're removing the `/github` doc set, and it's now not in the main page
grouped links.  Remove the test that `/github` exists, now look for
`/get-started`.

* homepage: use octicons instead of images

The images from https://github.com/features will be updated 🔜 - in
the meantime, let's use octicons which are consistent and give visual
interest.

* homepage: use octicons from @primer/octicons-react

Using the react components adds `<svg>` elements instead of `<img>`
elements, which lets the element use the current fill color, supporting
both light and dark themes.

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-10-22 17:58:16 +00:00
Mike Surowiec
567879365f fix: grid blowout due to missing min width (#22352) 2021-10-21 20:25:23 +00:00
Kevin Heis
83804c7114 Create search result event (#22307)
* Create search result event

* Update Search.tsx

* actually send it

* remove comment

* Apply suggestions from code review

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* add 'required' to schema

Co-authored-by: Peter Bengtsson <mail@peterbe.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-10-21 00:37:39 +00:00
Grace Park
884556eb02 Adding effectiveDate frontmatter property (#22317)
* adding effectiveDate frontmatter property

* Update components/article/ArticlePage.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* adding validation for correct date

* update to dateTime

* update to year month day

* update error date validation

* moving validation to getArticleContextFromRequest and moving id to div

* remove enteredDate

* Update content/README.md

Co-authored-by: Laura Coursen <lecoursen@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
2021-10-20 19:40:13 +00:00
Peter Bengtsson
3994797e81 indicate 0 search results as a result (#22262)
* indicate 0 search results as a result

fixes https://github.com/github/docs-engineering/issues/955

* correct logic

* refactored into own component
2021-10-19 22:23:36 +00:00
Anil Seervi
c183d07491 Update footer help link 2021-10-19 03:07:24 +00:00
Anil Seervi
4fcd2b4d1c use Link tag and relative url 2021-10-19 02:13:46 +00:00
Anil Seervi
8189f38035 Make internal footer links dynamic to language picker : Fixes #11274 2021-10-18 15:13:47 +00:00