1
0
mirror of synced 2026-01-06 15:01:04 -05:00
Commit Graph

44 Commits

Author SHA1 Message Date
Jason Etcovitch
1750f3d48a Fix missing webhook payloads on marketplace API page (#16641)
* Also check for github-marketplace path

* Check for webhook, no s
2020-11-26 20:42:31 -05:00
Sarah Schneider
26b9459048 Merge branch 'main' of github.com:github/docs-internal into find-page-in-version-redux 2020-11-23 12:14:45 -05:00
Jason Etcovitch
cc719ffb6f Render Enterprise release notes on docs.github.com (#16367)
* Create basic layout

* Create stubbed out release note YAML

* Get a real implementation going

* Simplify using site-data

* Add a real page to send from render-page.js

* Use array of patches

* Render patches

* Add sidebar and breadcrumbs

* Reverse order

* Add date

* Tweak labels

* Redirect to entweb for missing versions

* Render patch.intro

* Move to separate files for patches

* Show support for RC versions

* Improve some comments

* Sticky headers!

* Remove a console log

* Improve example formatting

* Add a link on /admin

* Add a schema and test

* Move to /index.md, add version_num filter

* Improve layout

* Use <details>

* Placeholder more realistic notes

* Don't require links in index pages

* Remove admin/index link for now

* Remove unused frontmatter field

* Add a test for middleware

* Fix remaining YAML file to test CI

* Update 2-rc.yml

* Don't call it RC

* Just push

* Make a main a div

* Fix a borked class

* Lint YAML files

* Improve Download link

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Improve check order

* Move to contextualizers

* Use alternative version thing

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Move back to `release-notes.md`

* Use version for anchor IDs

* Undo category-pages test change

* Fix borked details layout in Chrome

* Improve mobile setup

* Render markdown in note tags

* Use allVersions[currentVersion] again

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Undo change to extended-markdown

* Add whitespace so it renders markdown bits

* Remove 2-22 files

* Add check for any release notes

* Fix the failing tests

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-11-20 13:33:11 -05:00
Jason Etcovitch
9332c62195 Sm0ller webpack output (#16543)
* Install friendly-errors-webpack-plugin

* Use it
2020-11-19 13:06:20 -05:00
Sarah Schneider
d208a8951e Merge branch 'main' into find-page-in-version-redux 2020-11-18 16:49:46 -05:00
Sarah Schneider
67f490752a move is-archived-version into a function instead of middleware 2020-11-18 15:18:50 -05:00
Sarah Schneider
dbcb3a5cee use the referrer exclusively for asset paths 2020-11-18 14:50:58 -05:00
Sarah Schneider
60b834012b tweak comment 2020-11-18 12:57:24 -05:00
Sarah Schneider
6edd292fc7 proxy path is actually the same regardless of version 2020-11-18 12:53:17 -05:00
Sarah Schneider
18241fe808 use referrer path if it exists, otherwise use req.path 2020-11-18 12:52:53 -05:00
Sarah Schneider
9942fd3950 dry up archived versions middleware checks 2020-11-17 18:46:30 -05:00
Kevin Heis
08880d9ecb Sort middleware by categories (#16494) 2020-11-17 09:49:10 -08:00
Sarah Schneider
4533dee334 Merge branch 'main' into add-dev-toc-redux 2020-11-16 20:47:48 -05:00
Kevin Heis
4d2e25b429 Use Redis Store for rate limiting when available (#16484) 2020-11-16 15:55:07 -08:00
Matt Pollard
5553e1cfec Merge branch 'main' into add-dev-toc-redux 2020-11-16 09:12:50 +01:00
Jason Etcovitch
0730158918 Datadoge (#16464)
* Install hot-shots

* Add statsd client

* Add some metrics

* Add a comment

* Comment typo fix

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2020-11-13 15:49:50 -05:00
Sarah Schneider
0df213dea6 add the barest minimal dev-toc 2020-11-13 14:31:59 -05:00
Sarah Schneider
5705d334ca Header notification updates (#16425)
* remove middleware that sets notification flags

* move all notification handling into includes/header-notification.html

* update tests
2020-11-12 16:27:29 -05:00
Sarah Schneider
d9b1fa9d40 use new module 2020-11-12 13:31:57 -05:00
Jason Etcovitch
dd91c5a707 "Guides" section of the Actions landing page (#16216)
* Add custom hover shadows

* Support avatars

* Add guide-card include

* Use it in product-landing

* Add gradient styles

* Add guides frontmatter

* Use guideArticles instead of full objects

* Add support for authors

* Add support for category header

* Just pass the whole page

* Use it

* guide.url => guide.href

* Use `*.githubusercontent.com`

* Fix mobile card width

* Remove showDescription check

* Use featureLinks.guideCards

* Forgot an if

* Remove support banner

* Just use login instead of name/avatarUrl

* Change card spacing

* Use circular avatars

* Add margin beneath "Guides"

* Use smaller font

* Even moar spacing

* Remove category

* Remove lead text, move button to bottom right

* update guide cards

* Change author of setting up ci to GitHub

* Attribute node js guide to GitHub

* Add author tag to powershell guide

* update top guides section with correct actions links

* Enforce size for single avatars

* Adjust spacing

Co-authored-by: Cynthia Rich <crichID@users.noreply.github.com>
2020-11-11 12:53:46 -05:00
Sarah Schneider
dfb29cfb59 Remove no longer needed middleware (#16384)
* remove no longer needed middleware

* remove accompanying test
2020-11-06 14:14:28 -05:00
Jason Etcovitch
ac2bc682d1 Don't bork locally without Hydro (#16361)
* Add hydro.maySend() check

* Return a 200 to differentiate

* Add NODE_ENV check, move below validation
2020-11-05 19:06:46 +00:00
Kevin Heis
85c52d47e5 Don't record 304 redirects (#16245) 2020-11-03 22:21:12 +00:00
Chiedo John
7924aea2f8 Instruct search engines to not crawl archived versions (#16292)
* Instruct search engines to not crawl archived versions

* Update middleware/robots.js

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Add test

* Fix spooky bug

Co-authored-by: Chiedo <chiedo@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-11-03 08:23:22 -05:00
Laura Coursen
a3e1733aa1 GitHub AE (GHAE) (#16090) 2020-11-02 15:12:44 -06:00
Jason Etcovitch
174d8539c6 Support arbitrary keys in new featuredLinks frontmatter (#16239)
* Add featuredLinks to frontmatter

* Parse them in featured-links.js

* Remove old raw setup

* Use them

* Missed a couple

* Update translation files

* Fix frontmatter schema

* Loop over the right object

* Also update translations' usage

* Update docs and tests

* Better README comment

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Return next()

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-10-27 13:53:10 -04:00
Rachael Sewell
f22a82fcfb translate openapi versioning (#16202) 2020-10-26 14:38:30 -07:00
Kevin Heis
d743ff9512 Remove more Google Analytics references (#16194) 2020-10-26 14:17:49 -07:00
Kevin Heis
93849795e0 Record redirect events (#16181)
* Record redirect events

* Update index.js

* Update record-redirect.js

* Only run when it can send to Hydro

* Update record-redirect.js
2020-10-26 10:18:42 -07:00
Chiedo John
3600e4d9ee Don't enable cache on CI (#16180)
Co-authored-by: Chiedo <chiedo@users.noreply.github.com>
2020-10-22 15:10:19 -04:00
Chiedo John
73559d914e Add a in-memory page cache for renderings (#16173)
* Add a in-memory page cache for renderings

* Update render-page.js

* Update render-page.js

* Update render-page.js

* Make the render page cache more intelligent

Co-authored-by: Chiedo <chiedo@users.noreply.github.com>
2020-10-22 14:35:19 -04:00
Kevin Heis
380c4dcc82 Hydro exit event (#16067)
* Start a basic exit event

* Combine to one performance function

* Lint

* Fancy operators

* Update events.js

* Update events.js

* Update cookie-settings.js

* Add scroll tracking

* Tell "standard" to use babel-eslint

* Throttle scroll tracking

* Lint

* Use sendBeacon

* Update index.js
2020-10-21 09:42:02 -07:00
Chiedo John
9f10fdd033 Improve performance of csrf errors (#16136)
* Improve performance of csrf errors

* Fix handle csrf error middleware

Co-authored-by: Chiedo <chiedo@users.noreply.github.com>
2020-10-20 11:42:05 -04:00
Kevin Heis
8982d200cc Migrate experiments and helpfulness to Hydro (#16059)
* Migrate experiments and helpfulness to Hydro

* Clean out old tests

* ...and more old tests to delete
2020-10-19 14:31:54 -07:00
Sarah Schneider
da60aa51e1 Support enterpriseServerVersions in Liquid statements (#16058)
* remove outdated and redundant context.enterpriseVersions and add new context.enterpriseServerVersions

* update references from context.enterpriseVersions -> context.enterpriseServerReleases

* add test

* also test oldest supported enterprise version in addition to the latest

* Script to update not-free-pro-team conditionals (#16060)

* script to update not-free-pro-team conditionals

* change string to regex so we can do replace all

* remove stray test.only

* Update middleware/context.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update tests/unit/page.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update tests/unit/page.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update tests/fixtures/page-versioned-for-all-enterprise-releases.md

Co-authored-by: James M. Greene <JamesMGreene@github.com>

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2020-10-15 16:20:41 -04:00
Chiedo
6e2fa20dd8 Merge remote-tracking branch 'origin/jeffmcaffer-patch-4' into bulk-windows-fixes-1602277955 2020-10-09 17:17:31 -04:00
Kevin Heis
10371a375b Send a 502 when write to airtable or hydro fails (#15976) 2020-10-09 10:26:54 -07:00
Jeff McAffer
a9112d885d fix up redirect paths for Windows 2020-10-09 08:24:01 -07:00
Kevin Heis
7c0c493c35 Sending events to POST /events endpoint (#15796) 2020-10-08 09:24:41 -07:00
Chiedo John
89e546ffd1 Make Rate Limiter Aggressive on statuses > 400 (#15888)
Make Rate Limiter Aggressive on statuses > 400

This is based on the hypothesis that the Node
application shouldn't be getting hit with a large number of requests in
general thanks to Fastly and certainly shouldn't be getting hit with a
large number of requests that have status codes greater than 400 unless
a user or bot is trying to guess random URLs and as a result. For
example, see this IP address that caused some site issues on October 3

Co-authored-by: Chiedo <chiedo@users.noreply.github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2020-10-05 10:36:13 -04:00
Sarah Schneider
5caa6f282c satisifies -> satisfies (#15814) 2020-09-30 10:28:47 -04:00
Sarah Schneider
aa5a62d49d Remove versions feature flag code (#15793)
* remove FEATURE_NEW_VERSIONS from feature-flags.json

* remove process.env.FEATURE_NEW_VERSIONS from include files

* remove process.env.FEATURE_NEW_VERSIONS from lib files

* remove process.env.FEATURE_NEW_VERSIONS from middleware files

* remove process.env.FEATURE_NEW_VERSIONS from script files

* remove process.env.FEATURE_NEW_VERSIONS from test files

* update test fixtures to use new versions as canonical fixtures
2020-09-29 13:36:07 -04:00
Kevin Heis
c450d8d555 Send CSRF tokens over XHR (#15778)
* Send CSRF tokens over XHR

* Update events.js

* Update browser.js
2020-09-28 09:44:14 -07:00
Vanessa Yuen
3df90fc9b8 Hello git history spelunker!
Are you looking for something? Here is all of the GitHub Docs history in one single commit. Enjoy! 🎉
2020-09-27 14:10:11 +02:00