1
0
mirror of synced 2025-12-30 12:02:01 -05:00
Commit Graph

581 Commits

Author SHA1 Message Date
Marcelo Jacobus
0bb92d7b7e Assert translated pages match an English one (#22180) 2021-11-12 18:36:26 +00:00
Mike Surowiec
7310fc998a Refactor display-platform-specific-content (#22665)
* refactor display-platform-specific-content

* update PlatformPicker tests and cleanup
2021-11-12 14:40:35 +00:00
Rachael Sewell
0244fda807 search improvements (#22443) 2021-11-10 11:11:28 -08:00
Kevin Heis
6ec20638b5 Version picker combo (#22694)
* Move version picker next to product picker

* Always render in header

* Inline variant

* Remove topper-sidebar

* Handle breadcrumb length

* Have breadcrumbs use Primer breakpoint

* Make a breadcrumbs scss module

* Update Breadcrumbs.tsx

* Update Breadcrumbs.module.scss

* Update Breadcrumbs.module.scss

* Update server.js

* Use responsive classes for hide/show breadcrumb
2021-11-10 16:20:34 +00:00
Grace Park
240f5fbafe Updating breadcrumbs (#22626)
* updating breadcrumbs

* fix tests

* one more
2021-11-08 17:53:19 +00:00
Marcelo Jacobus
ed9e3d79cb Add test and script to ensure 1:1 parity of liquid tags between source and translation (#22472)
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-11-04 10:59:17 -03:00
Kevin Heis
9d53e40612 Make individual learning paths linkable (#22545)
* Make individual learning paths linkable

* Update learning-tracks.js

* Update LearningTrack.module.scss
2021-11-02 21:32:04 +00:00
Kevin Heis
dca7e56c3d More hydro error info (#22533)
* Add more info to hydro failures

* Clean up

* Update hydro.js

* Move hydro names to event schema file

* Update hydro.js
2021-11-02 16:13:48 +00:00
Jules Parker
2a08f64ad2 out of date branch Merge branch 'main' into jules-4795 2021-11-01 10:25:05 +01:00
Grace Park
75d41076a7 Article Layout Improvements (#22424)
* moving breadcrumbs to sticky header

* update scroll

* update color-bg-primary to color-bg-default

* change back to primary since were on primer 17

* add effect dependency

* not changing

* clip left box shadow of header and unmount

* update to default

* update breadcrumbs tests

* sticky editor
2021-10-29 19:57:07 +00:00
Rachael Sewell
684b8d79a1 Update test message with troubleshooting tips (#22143) 2021-10-28 23:01:45 +00:00
Kevin Heis
567652b0e3 Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Robert Sese
df2e3be178 Small bits of test cleanup 🧹 (#22442)
* Unskip test, ghec graphql version added

* Link to test skip issue

* Stray console.log ✂️
2021-10-27 22:31:41 +00:00
Robert Sese
693e36bfdd Fix breadcrumbs when paths have partial match 🍞 (#22414)
* Add failing breadcrumb test for paths with partial match

* Handle overlapping paths when creating breadcrumbs
2021-10-26 21:24:54 +00:00
Mike Surowiec
e3074d998f fix: detect language error on /_next/data/ input (#22419) 2021-10-26 21:03:47 +00:00
Jules Parker
3e72ad4dce Merge branch 'main' into jules-4795 2021-10-26 12:01:50 +02:00
Mike Surowiec
bede852dc4 fix: detect-language correctly handles root path, add unit tests (#22404) 2021-10-26 03:22:25 +00:00
Kevin Heis
3b092b4cb8 Deprecate 2.22 b (#22366)
* Update enterprise-server-releases.js

* Run deprecation script

* Remove finding / managing security vulnerabilities

* remove vuln from translations

* remove more dead pages

* Restore heavily used files

* Remove 2.22 refs in tests

* Update working-with-the-npm-registry.md
2021-10-22 13:23:16 -07:00
Edward Thomson
0fee9aedcd Landing page: groups of features (#22313)
* homepage: reduce padding below search area

Bring as much useful content up "above the fold".

* homepage: add groups for the front page sections

Group the homepage links into sections that map to the GitHub features
page (`/features`) plus two groups that are bespoke to the docs ("Get
started" and "Developers").

* homepage: update group design

Group the feature list area using the design exploration work by
@arisacoba.  Remove the description.

* homepage: remove ungrouped items from main area

Remove ungrouped items (like the external links) from the main feature
area.  Users can still navigate to ungrouped items in the sidebar.

* fix tsc error, use Link component

* homepage: support empty icon in group

Don't assume that we have icons everywhere on the landing page groups.

* homepage: drop octocat/invertocat

Looks weird with the modern icons, looks bad in dark mode.  Drop them
for now.

* homepage: document the childGroups frontmatter property

* homepage: don't test that sidebar == main content

We're reducing the links on the homepage in the main content area, but
the sidebar should be the complete list of products.  Remove the tests
that ensure that the main content area has all the sidebar content.  But
keep the tests that ensure that the sidebar content has all the links in
the main content area.

* homepage: remove "GitHub" doc set

The "GitHub" doc set "will be removed soon as we keep moving more content
out of it, so let's not include it here to keep the page more
evergreen."

* homepage: don't test that `/github` is linked on the main page

We're removing the `/github` doc set, and it's now not in the main page
grouped links.  Remove the test that `/github` exists, now look for
`/get-started`.

* homepage: use octicons instead of images

The images from https://github.com/features will be updated 🔜 - in
the meantime, let's use octicons which are consistent and give visual
interest.

* homepage: use octicons from @primer/octicons-react

Using the react components adds `<svg>` elements instead of `<img>`
elements, which lets the element use the current fill color, supporting
both light and dark themes.

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-10-22 17:58:16 +00:00
Matt Pollard
5016286f81 Merge branch 'main' into jules-4795 2021-10-22 09:24:18 +02:00
Sarah Edwards
ce5ab14f67 Not as big as it looks! Migrate guide.github.com content (#21942) 2021-10-20 14:53:24 +00:00
Matt Pollard
4657a4d3f3 Merge branch 'main' into jules-4795 2021-10-20 15:49:31 +02:00
Peter Bengtsson
4e4ca1d12d gg commit (#22323)
Part of #1061
2021-10-20 09:45:18 -04:00
Matt Pollard
ab397d54d8 Adjust expected number of featured links again 2021-10-20 12:35:25 +02:00
Matt Pollard
5361d22323 Merge branch 'main' into jules-4795 2021-10-20 10:52:47 +02:00
Rachael Sewell
8ad7c37cee Remove German as supported language (#22311) 2021-10-19 21:36:46 +00:00
Matt Pollard
9a0b2eb7b7 Remove route with language code from test 2021-10-19 13:50:07 +02:00
Matt Pollard
86a2290aaf Update URL for test 2021-10-19 13:41:47 +02:00
Matt Pollard
16c8801dbc Merge branch 'main' into jules-4795 2021-10-19 12:26:41 +02:00
Peter Bengtsson
1d72d4c87e use temporary redirect to inject locale prefix (#22239)
* use temporary redirect to inject locale prefix

Fixes #996

* fix routing tests
2021-10-18 20:09:20 +00:00
Jules Parker
65a50a9b5b Update featured-links.js 2021-10-18 15:28:34 +02:00
Jules Parker
13edfd8788 Merge branch 'main' into jules-4795 2021-10-18 15:11:48 +02:00
Peter Bengtsson
c712da8f5d be more conservative with spotting q= in URL (#21945)
* be more conservative with spotting q= in URL

Fixes https://github.com/github/docs-engineering/issues/951

* refactor check

* Update tests/routing/redirects.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-10-18 12:04:45 +00:00
Edward Thomson
dba3b44ea9 frontpage: add npm documentation links (#22173)
Co-authored-by: Laura Coursen <lecoursen@github.com>
2021-10-15 22:16:03 +00:00
Laura Coursen
8f964ea2cb GHEC version (#20947)
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: Steve Guntrip <12534592+stevecat@users.noreply.github.com>
Co-authored-by: Robert Sese <sese@github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-10-15 15:41:33 -05:00
Jules Parker
0e8ab632ec Update featured-links.js
Update hardcoded links
2021-10-11 14:50:08 +02:00
Matt Pollard
51ad46b7ae Update hardcoded link 2021-10-11 13:36:26 +02:00
Matt Pollard
8739d0670f Update hardcoded link 2021-10-11 12:58:33 +02:00
Matt Pollard
dfb4d8265e Update hardcoded link 2021-10-11 12:53:18 +02:00
Grace Park
fd3d223bce Adding links to all skipped tests (#22037)
* adding links to all skipped tests

* updating links
2021-10-08 21:53:44 +00:00
Mike Surowiec
b279482cf9 Footer styling (#21877) 2021-10-06 18:09:11 +00:00
Matt Pollard
307e8094ec Backport updated content from GitHub AE M2 megabranch and version for ghae-next (#21525) 2021-10-04 16:11:57 +00:00
Mike Surowiec
85f6a43502 Mini TOC semantic rendering (#21836)
* semantic rendering of miniTocItems

* feat: create nested mini toc structure to simplify semantic rendering

* remove className usage of indentationLevel in miniToc rendering

* manually run script/graphql/update-files.js to update pre-rendered files

* use less brittle regex method to extract number
2021-10-04 10:48:42 -04:00
Kevin Heis
1e2fedd16a Update developer-site-redirects.js (#21848) 2021-10-01 17:11:32 +00:00
Robert Sese
000799df17 Handle learning track paths from a different product (#21776)
* Add trackProduct property

* Fall back to learning track product URL param

* Add product URL param to learning track banner

* Add product URL param to featured track links

* Fix typo :(

* Add product URL param to learning track

* Add multi-product learning track tests

* Re-enable tests with a Code Security learning track

* Re-enable more tests with Code Security learning tracks

* Add more multi-product testing

* Update components/sublanding/LearningTrack.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 21:17:02 +00:00
Mike Surowiec
d81f51ebf7 Picker improvements (#21765)
* close Language and ArticleVersion pickers after click

* cleanup ArticleGridLayout due to VersionPicker changes

* fix tsc errors resulting from primer upgrade

* fix / update tests

* cleanup mobile pickers visual consistency

* use btn-sm on VersionPicker

* update translation and close on click for enterprise releases

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 20:22:13 +00:00
Marcelo Jacobus
aed6c1654f translation batch 1632491035 (#21717) 2021-09-30 11:53:04 +00:00
Melanie Yarbrough
2a10e30adc New workflow to aid internal contributions in PRs (#21612)
Co-authored-by: Sarah Edwards <skedwards88@github.com>
2021-09-29 13:09:26 -04:00
Rachael Sewell
c0a667a8d1 fix a few hardcoded tests temporarily (#21740) 2021-09-27 20:56:42 +00:00
Robert Sese
27eaff7caa Handle learning track URL redirects (#21613)
* Handle redirects for learning tracks

* Test for learning track URL redirects

* Test latest Enterprise version

Co-authored-by: Rachael Sewell <rachmari@github.com>

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-09-22 20:33:56 +00:00