1
0
mirror of synced 2025-12-22 03:16:52 -05:00
Commit Graph

29 Commits

Author SHA1 Message Date
Kevin Heis
8a56437c93 Pretty format (#20352)
* Update prettier flow to include JS

* Run prettier

* ...run prettier
2021-07-14 14:35:01 -07:00
Kevin Heis
42e785b0a8 Migrate CommonJS to ESM (#20301)
* First run of script

* Get the app running --- ish

* Get NextJS working

* Remove `node:`

* Get more tests passing in unit directory

* Update FailBot test to use nock

* Update test.yml

* Update Dockerfile

* tests/content fixes

* Update page.js

* Update build-changelog.js

* updating tests/routing

* Update orphan-tests.js

* updating tests/rendering

* Update .eslintrc.js

* Update .eslintrc.js

* Install jest/globals

* "linting" tests

* staging update to server.mjs

* Change '.github/allowed-actions.js' to a ESM export

* Lint

* Fixes for the main package.json

* Move Jest to be last in the npm test command so we can pass args

* Just use 'npm run lint' in the npm test command

* update algolia label script

* update openapi script

* update require on openapi

* Update enterprise-algolia-label.js

* forgot JSON.parse

* Update lunr-search-index.js

* Always explicitly include process.cwd() for JSON file reads pathed from project root

* update graphql/update-files.js script

* Update other npm scripts using jest to pass ESM NODE_OPTIONS

* Update check-for-enterprise-issues-by-label.js for ESM

* Update create-enterprise-issue.js for ESM

* Import jest global for browser tests

* Convert 'script/deploy' to ESM

Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: James M. Greene <jamesmgreene@github.com>
2021-07-14 13:49:18 -07:00
Grace Park
d3d1902414 Merge pull request #20017 from github/upgrade-esm
Enforce and Move to Top Level require
2021-06-22 11:27:48 -07:00
Grace Park
1823cff641 updating pages to page-data 2021-06-15 11:02:05 -07:00
Sarah Schneider
5978edb47b remove feature flagged code 2021-05-20 10:01:33 -04:00
Sarah Schneider
e30292c0fd add feature flagged conditionals to tests 2021-05-18 20:44:46 -04:00
Sarah Schneider
cd8d908691 no longer need the site.data part of these tags 2021-04-21 13:10:30 -04:00
Kevin Heis
46c16001c3 Upgrade Primer with translation shim for trashcan icon (#18735)
* Revert "Revert "Upgrade Primer CSS to 16 (#18713)""

This reverts commit c01d3e302e.

* Add a hack to handle trashcan icon in translated content
2021-04-13 18:38:04 +00:00
Mike Surowiec
c01d3e302e Revert "Upgrade Primer CSS to 16 (#18713)"
This reverts commit 49377f9096.
2021-04-13 09:19:28 -07:00
Kevin Heis
49377f9096 Upgrade Primer CSS to 16 (#18713)
* Upgrade primer to 16

* Upgrade colors in scss

* Get SCSS to build

* Initial dark mode support

* trashcan -> trash

* More specific search browser test

* Fix link color on homepage

* Update overrides.scss

* Upgrade some colors to primer variables

* Hide dark mode support for now

* Apply suggestions from code review

* Update overrides.scss
2021-04-13 16:00:46 +00:00
Vanessa Yuen
4038e9ca85 Add topic property and filter to guides page (#17328)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-29 12:32:31 +00:00
Vanessa Yuen
b46da8dfc7 Sublanding page all guides section (#16869)
* get link liquid tag to accept variables as param

* new liquid tag `link_as_article_card`

* refactor link liquid tag slightly so we can control what props get rendered

* generalize filterCodeExample to use in all guides section

* pass in `js-filter-card-max` instead of hardcode max

* tweaks and add `data` to CSP for images

* add liquid tag tests

* add some browser tests for card filters

* we still need to rely on `getPathWithLanguage` for hrefs that already have the language code embedded


Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-18 12:23:23 +00:00
Sarah Schneider
564628799c Merge branch 'remove-fpt' of github.com:github/docs-internal into remove-fpt-helper 2021-01-15 09:39:12 -05:00
Sarah Schneider
ffb4e548a0 Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-15 09:38:15 -05:00
Vanessa Yuen
eaacb54422 small liquid link tag cleanup (#17280)
* remove unnecessary `render` methods
* we don't use `link_with_short_title` anymore
* remove `shortTitle` option
* remove ink_with_short_title tag test
2021-01-15 13:24:39 +00:00
Sarah Schneider
9809627129 lint 2021-01-14 17:10:12 -05:00
Sarah Schneider
affbc80a3c update tests to remove free-pro-team from expected results 2021-01-14 17:08:30 -05:00
Sarah Schneider
23170a50e6 lint 2021-01-13 16:50:05 -05:00
Sarah Schneider
9d318e0380 Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-08 11:06:27 -05:00
Sarah Schneider
5f42c407f3 add a few redirects to fake context object 2021-01-08 11:05:55 -05:00
Barry McGee
ffdd3b3d97 Update tests with new expected semantic headings 2021-01-08 00:08:47 +00:00
James M. Greene
e6518ff9c3 Fix unresolved data lookups on GitHub Glossary page (#16815)
* Support [...] in data tag path

* Use forloop.index0 to get data tag path

* Commit whitespace change to not keep getting it

* Recursively render glossary terms as well

* Add tests to verify Liquid data tag can handle bracketed access

* Remove superfluous 'set' for context in tests

* Avoid the mystery guest anti-pattern... move the test data closer to the test

* Escape the `-` character in the data regex

Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-09 18:58:00 -06:00
Kevin Heis
62889986b6 Revert "Revert "Speed up warmServer by loading pages (and files) asyn… (#16837)
* Revert "Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)"

This reverts commit a14517115f.

* Move async to regular dependencies

* Update package-lock.json
2020-12-09 17:40:58 +00:00
Jason Etcovitch
a14517115f Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)
This reverts commit 1d5e216404.
2020-12-09 17:12:07 +00:00
Kevin Heis
1d5e216404 Speed up warmServer by loading pages (and files) asynchronously (#16752)
* Async `new Page`

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Using mapLimit

* Update pages.js

* Test updates

* Update pages.js

* Move exists to page class

* Test fixes

* Slightly faster localized paths process
2020-12-09 16:57:18 +00:00
James M. Greene
fb30a0766f Unravel pages (the array + map object) (#16708)
* Revise the 'pages' module to export two methods: 'loadPages' and 'loadPageMap'

Update all existing references to use 'loadPages' for now

* Remove explicit Promise resolutions on loadPage* methods

* Condense reduction method into its now-singular usage spot

* Opt for for-of instead of forEach

* Make require of pages in warm-server more explicit

* Be more explicit about find-page using a pageMap

* Be more explicit about find-page-in-version using a pageMap

* Be more explicit about site-tree using a pageMap

* Extract the map creation from loadPageMap

* Be more explicit about using a pageMap

* Update redirects precompile to take two arguments: pageList, pageMap

* Rename internal loadPages method to loadPageList

* Clarify pageMap is what is stored in context.pages

* Use loadPageMap in tests and stuff
2020-12-03 22:31:10 +00:00
Jason Etcovitch
1ec8c35e34 Refactor indented_data_reference to use Liquid internals (#16623)
* Refactor indented-data-reference

* Add spacing around referenced reusables

* Update expected test output

* Fail silently with empty valuer
2020-11-24 16:50:20 -05:00
Sarah Schneider
aa5a62d49d Remove versions feature flag code (#15793)
* remove FEATURE_NEW_VERSIONS from feature-flags.json

* remove process.env.FEATURE_NEW_VERSIONS from include files

* remove process.env.FEATURE_NEW_VERSIONS from lib files

* remove process.env.FEATURE_NEW_VERSIONS from middleware files

* remove process.env.FEATURE_NEW_VERSIONS from script files

* remove process.env.FEATURE_NEW_VERSIONS from test files

* update test fixtures to use new versions as canonical fixtures
2020-09-29 13:36:07 -04:00
Vanessa Yuen
3df90fc9b8 Hello git history spelunker!
Are you looking for something? Here is all of the GitHub Docs history in one single commit. Enjoy! 🎉
2020-09-27 14:10:11 +02:00