1
0
mirror of synced 2026-01-06 15:01:04 -05:00
Commit Graph

123 Commits

Author SHA1 Message Date
Kevin Heis
46ccfc5d93 Run AB test on survey stars (#17861)
* Run AB test on survey stars

* Update browser.js

* Use text stars instead of primer ones

* Update experiment.js
2021-02-18 16:29:17 +00:00
Kevin Heis
eedcd1d861 Combine three super footer elements into one section (#16724)
* Combine three super footer elements into one section

* Update support-section.html

* Update heading font sizes
2021-02-11 14:10:33 -08:00
Kevin Heis
a3ad549e39 Block a few more things in AIRGAP (#17657)
* Block a few more things in AIRGAP

* Update middleware/context.js

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>

* Update product-landing.html

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
2021-02-09 23:07:23 +00:00
Kevin Heis
1918d2ea14 Inline CSRF token in HTML (#17748)
* Inline CSRF token

* Fix tests
2021-02-09 22:08:24 +00:00
Jason Etcovitch
7aed83d5f8 Remove currentLanguage from translation_notification (#17733) 2021-02-08 20:05:29 +00:00
Jason Etcovitch
fcade11d77 FIx version switcher size (#17732) 2021-02-08 19:45:04 +00:00
Jason Etcovitch
28efe65bf5 Fix some invalid Liquid (#17705)
* Remove quotes from render paths

* Do the same for includes

* Fix {{{ in breadcrumbs

* Remove some old octicon syntax

* Fix some wonks

* Borked one

* Unchange `render` calls

* Smaller diff

* Even smaller
2021-02-05 13:17:15 -05:00
Vanessa Yuen
4038e9ca85 Add topic property and filter to guides page (#17328)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-29 12:32:31 +00:00
Kevin Heis
8b86fd8fef Reduce minified JS bundle size from 189kb to 73kb (#17552) 2021-01-28 22:12:04 +00:00
Vanessa Yuen
9bc90cd932 Learning Track navigation banner (#17440)
* add middleware to handle `learn` query param

* add exception to query-less cache key

* add querystring to learning track guides
2021-01-25 16:57:32 +00:00
Kevin Heis
2fb2e962bc Move site search to use an endpoint (#17359)
* Move site search to use an endpoint

* Update browser.js

* Update search.js

* Update lib/search/versions.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Fix URLs

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-01-20 15:37:42 +00:00
James M. Greene
9724f763f5 Implement discount fingerprinting without webpack (#17337) 2021-01-19 23:00:54 -06:00
Vanessa Yuen
b46da8dfc7 Sublanding page all guides section (#16869)
* get link liquid tag to accept variables as param

* new liquid tag `link_as_article_card`

* refactor link liquid tag slightly so we can control what props get rendered

* generalize filterCodeExample to use in all guides section

* pass in `js-filter-card-max` instead of hardcode max

* tweaks and add `data` to CSP for images

* add liquid tag tests

* add some browser tests for card filters

* we still need to rely on `getPathWithLanguage` for hrefs that already have the language code embedded


Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-18 12:23:23 +00:00
Octomerger Bot
c301ac4b30 Branch was updated using the 'autoupdate branch' Actions workflow. 2021-01-16 01:28:17 +10:00
Vanessa Yuen
eaacb54422 small liquid link tag cleanup (#17280)
* remove unnecessary `render` methods
* we don't use `link_with_short_title` anymore
* remove `shortTitle` option
* remove ink_with_short_title tag test
2021-01-15 13:24:39 +00:00
skullface
c61e5ce42a use www 2021-01-14 15:08:00 -05:00
skullface
a4fc70d6d4 use www 2021-01-14 15:04:52 -05:00
skullface
0a73f8ef86 update electron link 2021-01-14 15:01:09 -05:00
skullface
bf9982026e use https over http 2021-01-14 14:02:35 -05:00
Melanie Yarbrough
c2336bb11e [DO NOT MERGE] GitHub Enterprise Server 3.0 release candidate megabranch (#16479) 2021-01-13 19:16:05 -08:00
Barry McGee
eaa4a0be3a Move aria-hidden onto agolia form element
This hides the whole form element as it's third party and not accessible.
2021-01-08 00:08:26 +00:00
Barry McGee
85d20a30a7 Removed nested main elements on specific products
Main landmark must not be contained in another landmark

https://dequeuniversity.com/rules/axe/4.1/landmark-main-is-top-level
2021-01-08 00:08:26 +00:00
Barry McGee
3b4232ff8d Move nested <ul> inside <li> in specific product sidebar
<ul> and <ol> must only directly contain <li>, <script> or <template> elements

https://dequeuniversity.com/rules/axe/4.1/list
2021-01-08 00:08:26 +00:00
Barry McGee
08ac2a2bd2 Wrap sidebar navigation in <nav> sectioning element
This will provide semantic context to the unordered navigation list.

Ref: All page content must be contained by landmarks: https://dequeuniversity.com/rules/axe/4.1/region
2021-01-08 00:08:26 +00:00
Barry McGee
b46f447f0f Add banner role to logo container in sidebar header
All page content must be contained by landmarks: https://dequeuniversity.com/rules/axe/4.1/region
2021-01-08 00:08:26 +00:00
Barry McGee
d4d701782f Make heading are semantic while maintaining font-size
Headings should only ever increment by one

https://dequeuniversity.com/rules/axe/4.1/heading-order
2021-01-08 00:08:25 +00:00
Barry McGee
8a7bfac10e Remove aria-hidden link from tab index
More info: https://dequeuniversity.com/rules/axe/4.1/aria-hidden-focus
2021-01-08 00:08:25 +00:00
Abby Vollmer
f5a2c56de6 Project Visby site-policy updates (change date + hide from GitHub Docs) (#17139)
and support site policy hidden articles
2021-01-07 22:44:34 +00:00
Kevin Heis
bb46eb5231 Merge branch 'main' into fix-bread 2021-01-05 08:21:55 -08:00
Kevin Heis
d7eb248a10 Fix a bunch of random typos (#17129)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-05 16:07:27 +00:00
Arhell
ec8f03c3af fix breadcrumbs block 2020-12-22 01:09:59 +02:00
Sarah Schneider
a252390408 remove extra lang codes 2020-12-18 15:08:07 -05:00
Chiedo John
4654635962 Merge branch 'main' into default-platform 2020-12-18 10:45:26 -05:00
Kevin Heis
59f375ab1d Merge branch 'main' into default-platform 2020-12-16 14:36:46 -08:00
Sarah Schneider
dca55a0257 Revert "Revert "sitetree optimizations"" 2020-12-14 20:25:01 -05:00
Sarah Schneider
b38eec9964 Revert "sitetree optimizations" 2020-12-14 16:53:04 -05:00
Sarah Schneider
f5b050dc5e updates now that siteTree paths include language codes 2020-12-14 14:39:45 -05:00
Jason Etcovitch
ca127e987e Change release notes colors (#16923)
* Use pastel colors

* Whit text

* Slugify/anchor section headings

* Use classes instead of style attributes

* Use fancy-pants SCSS

* Simplify a tad

* TIL text-inherit helper

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>

* Remove redundant `style` attr

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
2020-12-14 15:06:03 +00:00
Jason Etcovitch
92d5722103 Add 2.22 release notes (#16586)
* Add 2.22.0

* Add 2.22.1

* Add 2.22.2

* Add 2.22.3

* Add 2.22.4

* Lint YAML files

* intro shouldn't be required

* Align all notes

* Full height sidebar

* Make the sidebar full height properly

* Get the real layout going

* Include full name

* Move details > summary around

* Fix sticky sidebar

* Tweak bottom of page

* Add more label colors

* Change heading title

* Don't be <details>, change sticky header

* Include other releases' info

* Show prev/next links

* Change sidenav to show all releases

* Fix ordering of chevron

* Fix link underlines

* Collapsing minor versions

* Moar padding

* Setup schema for sub-sections

* Update a YAML file to match schema

* Redo rendering/sorting logic

* Update layout

* Convert remaining notes

* Improve schema

* Use proper min properties

* Custom bullet points

* Show details control for version picker

* Improve layout on small screens

* One more tiny fix

* Order by semver

* Use proper version in details

* Fix extra arrows showing up

* Change label colors

* Pass the reference check

* Add gradients

* Gradient all the things
2020-12-11 13:43:11 -05:00
Simran Spiller
4afc7d4035 Merge remote-tracking branch 'upstream/main' into default-platform 2020-12-11 01:13:32 +01:00
Simran Spiller
3f8f75e116 YAGNI: Remove support for {% all %} 2020-12-11 01:05:23 +01:00
Sarah Schneider
cada14981b Merge branch 'main' of github.com:github/docs-internal into list-of-deprecated-versions 2020-12-09 22:05:26 -05:00
Sarah Schneider
cfc4f6754d Merge branch 'main' into early-access-tweaks 2020-12-09 21:13:50 -05:00
Simran
2a3fdd43ac Merge branch 'main' into default-platform 2020-12-09 02:06:46 +01:00
Simran Spiller
64f2d638d5 Add support for defaultPlatform frontmatter
TODO: add 'all' to frontmatter schema enum?
2020-12-09 01:28:09 +01:00
Melanie Yarbrough
91d3857341 [DO NOT MERGE] Universe 2020 Day 1: December 8, 2020 (#16480)
* Update README

* [Universe] Dark mode (#16545)

* Dark mode updates (#16696)

* [Universe] Corporate sponsors (#16457)

* Dependency review beta (#16563)

* Add placeholder topic file

* Revert change I didn't make

I'm not sure where this change came from or why it's showing up in my PR here but I didn't make this change and it's not part of Dependency Review so I'm reverting it.

* Un-revert previous change

OK I see what happened there. I was comparing the PR to main rather than the Universe megabranch, hence it showed a change I didn't make.
This commit undoes the change I do not want to revert on the megabranch.

* Update image to add the Checks tab

* Finish updating topic to mention DR

* Fix check errors

* Fix another versioning error

* Add a sentence about supported ecosystems

* Add review changes

* Remove Further reading topics in same category

As suggested by James, I've removed the links to topics that are in the same `/collaborating-with-issues-and-pull-requests/` category as this topic.

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

* Updates in the light of Maya's review

* Remove use of "exploit" in description

* Change 'dependency review summary' to 'dependency review'

See PR review comment from Maya.

* Mention that the age of the dependency is given

* Update screenshots to latest GUI

* Add details of dependency ordering within a DR

* Update content/github/collaborating-with-issues-and-pull-requests/reviewing-dependency-changes-in-a-pull-request.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/visualizing-repository-data-with-graphs/about-the-dependency-graph.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* [Universe 2020] New audit log REST API endpoint (#16699)

* Minimal updates for preview

*  API previews 

* Update beta note

*  Update API previews 

*  Update previews 

* Add draft section for git events

* Clean API previews

* More fixes + API previews

* Address review comments + update API previews

* Mention cursor-based pagination

* Update content/rest/overview/resources-in-the-rest-api.md

Co-authored-by: Jeff Saracco <jeffsaracco@github.com>

* Temporarily revert API previews

* Small tweaks from review comments + API previews

* revert json schemas

* Updating OpenAPI descriptions (#16776)

* Updating OpenAPI descriptions

* Add decorated OpenAPI schema files

Co-authored-by: Jeff Saracco <jeffsaracco@github.com>
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com>

* [Universe 2020] GitHub Actions: Workflow visualization (#16629)

* initial empty commit

* replace image used only for dotcom

* add new image and version usage

* add new image and version usage

* add new image and version usage

* add new image and version usage, delete unneeded image

* add new image and version usage, fix incorrect image

* add new image and version usage

* add new image and version usage

* add new image and version usage

* add new image and version usage

* update screenshot update

* add new image and version usage

* add new image and version usage

* update text

* update images and fix list numbering

* add step with graph

* Add missing versioning

* add overview of visualization

* fix title to match filename

* add beta note

* update wording

* Restructuring packages (#16731)

* restructuring packages

* moving more content

* moving more content

* fixing the toc for guides

* removing CR from the landing page

* adjusting qs

* updating npm

* enhancing guides

* Update updating-github-insights.md

* fixing link problems

* fixing link problems

* redirecting the redirects

* another change

* fixing the guides landing page

* add packages quickstart

* moving CR content

* adding some descriptive text

* add packages landing page

* adding guide content back

* update popular articles based on data

* fix caps on product name

* try removing product from front matter

* Update content/packages/quickstart.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/quickstart.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* add node package instructions to quickstart

* fixing links and adding redirect

* fixing redirects

* renaming to container guides

* renaming to container guides and fixing reusables

* adding context and about section to CR

* removign landign page extra titles and descriptions

* reverting the packages

* updating link

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* updating

* update test to reflect redesigned product landing page

* Add private vs public clarification

* Fix borked test

* filter out standalone category files from test

Co-authored-by: Cynthia Rich <crichID@github.com>
Co-authored-by: Cynthia Rich <crichID@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>

* Add discussions video
See https://github.com/github/docs-internal/pull/16759

* Remove typos

* update article name in test

Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Jeff Saracco <jeffsaracco@github.com>
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com>
Co-authored-by: Meg Bird <megbird@github.com>
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
Co-authored-by: Cynthia Rich <crichID@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2020-12-08 12:20:02 -05:00
Sarah Schneider
e51842b586 Merge branch 'main' into early-access-tweaks 2020-12-08 11:10:42 -05:00
Sarah Schneider
afb30d2d98 add a final else for displaying a title if no page.fullTitle 2020-12-08 10:45:28 -05:00
Sarah Schneider
c52a9ba1ef rename page to enterprise-server-releases 2020-12-08 10:15:23 -05:00
Sarah Schneider
da51ae2a05 remove border 2020-12-08 10:00:14 -05:00