1
0
mirror of synced 2026-01-06 15:01:04 -05:00
Commit Graph

73 Commits

Author SHA1 Message Date
Steve Ward
0e5268eeaa Provide some additional clarity to various GitHub Desktop articles (#36047)
Co-authored-by: Peter Bengtsson <peterbe@github.com>
Co-authored-by: Isaac Brown <101839405+isaacmbrown@users.noreply.github.com>
2023-05-05 20:14:57 +00:00
Peter Bengtsson
f16c5d60af Don't redirect q= to query= if query= already present (#36892) 2023-05-05 14:39:04 +00:00
Peter Bengtsson
a91ad4f7da Remove legacy keys from wrapped got in end-to-end tests (#36265) 2023-04-07 14:45:25 +00:00
Peter Bengtsson
fc63361276 Be gone old api/search/legacy (#34839) 2023-02-16 16:26:13 +00:00
Grace Park
ef2efb0636 Feature Branch: Global Nav Phase 1 (#33465)
Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com>
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2023-01-31 17:49:50 +00:00
Kevin Heis
b7d6ee0853 Cache language redirects (#33028) 2022-12-01 20:01:52 +00:00
Evan Bonsignori
b1a36fb7ff Revert "set max-age=0 when you want no cache (#31657)"
This reverts commit 5dfca10bba.
2022-10-12 13:10:34 -07:00
Peter Bengtsson
5dfca10bba set max-age=0 when you want no cache (#31657) 2022-10-12 19:54:28 +00:00
Peter Bengtsson
74103cd650 redirect /search to /api/search/legacy (#31566) 2022-10-10 19:23:54 +00:00
github-openapi-bot
757066487d Update OpenAPI Descriptions (#30924)
Co-authored-by: github-openapi-bot <github-openapi-bot@users.noreply.github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: Grace Park <gracepark@Graces-MacBook-Pro-2.local>
Co-authored-by: Hector Alfaro <hectorsector@github.com>
Co-authored-by: Ashwin Jeyaseelan <8gitbrix@github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: Sarita Iyer <66540150+saritai@users.noreply.github.com>
2022-09-19 10:28:23 -07:00
Kevin Heis
7523a7c460 Prep for ts-node (#30587) 2022-09-08 15:45:13 +00:00
Peter Bengtsson
90b754fe3c Test JSON API without enabling dedicated search results page (#30542) 2022-09-06 17:05:22 +00:00
Kevin Heis
303d5190db Create a translations test suite (#30000)
* Scaffold files for migration

* Move user-agent into unit suite

* Nothing to move from browser suite

* Migrate tests to translations/content

* Migrate existing translation test to meta

* No graphql tests to migrate

* Migrate lint-translation-reporter

* Migrate lint-translation-reporter

* Remove languages-schema, unused

* Restore languages-schema

* Restore languages-schema

* Migrate rendering

* Migrate routing

* Migrate most of unit

* Remove dead files, comment out tests that aren't expected to work yet

* Migrate from get-redirect

* Migrate page and pages

* Migrate linting code

* Fix lint issues

* Found a few more

* Run prettier

* Move crowdin-config test and helper

* Update crowdin-config.js

* Remove translation linting, crowdin config lint, reduce file count

* Remove test that's been skipped for a year

* Restore linting with note to remove later

* Update lint-translation-reporter.js

* Clean up rendering suite

* Update rendering.js

* Remove excessive describe blocks

* Redirect tests

* Clean up unit

* Remove test that's never called

* Don't compare early access

* Rename test suites

* Update "content" tests

* Update files.js

* Update search.js

* Update files.js

* Update files.js
2022-08-25 12:38:03 -07:00
Peter Bengtsson
c260d9f04d only redirect to /$locale/search if ES is set (#30104)
* only redirect to /$locale/search if ES is set

* only redirect to /$locale/search if ES is set
2022-08-19 18:57:07 +00:00
Peter Bengtsson
8765c628ff dedicated search results page (redux) (#29902)
* dedicated search results page (redux)

* Update SearchResults.tsx

* adding pagination

* fix pagination

* say something on NoQuery

* better Flash

* tidying link

* small fixes for results

* debug info

* l18n the meta info

* inDebugMode

* basic jest rendering of the skeleton page

* basic jest rendering test

* fix content tests

* better document title

* fix tests

* quote query in page title

* use home page sidebar

* something when nothing is found

* parseInt no longer needs the 10

* fix linting tests

* fix test

* prettier

* Update pages/search.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
2022-08-19 13:36:55 +00:00
Kevin Heis
101e7155c8 userLanguage in browser instead of XHR (#29782)
* userLanguage in browser instead of XHR

* refactors on pr 29782 (#29798)

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-08-10 15:28:21 +00:00
Sarah Schneider
4cbbf22fbd Merge branch 'main' of github.com:github/docs-internal into versioned-redirects 2022-07-21 09:04:04 -04:00
Peter Bengtsson
9dce4cd96d redirect to language url for ghes 3.0 and 3.1 (#29136)
Co-authored-by: Hector Alfaro <hectorsector@github.com>
2022-07-19 15:22:48 +00:00
Peter Bengtsson
4bff926c7e inject language for legact admin/release-notes URLs (#29082) 2022-07-15 20:28:31 +00:00
Peter Bengtsson
e0a20add31 //en/some/path should redirect to /en/some/path (#29077)
* //en/some/path should redirect to /en/some/path

* remove debugging
2022-07-15 19:16:42 +00:00
Peter Bengtsson
ef5406ae9a rest reference redirects with free-pro-team@latest (#28838) 2022-06-29 20:42:58 +00:00
Sarah Schneider
aed1f595c6 remove no longer needed test 2022-06-24 13:05:00 -04:00
Kevin Heis
f948c81038 Upgrade got (#28617)
* Upgrade got

* Update e2etest.js

* Skip following redirects on redirect tests

* Update deprecated-enterprise-versions.js
2022-06-21 16:23:51 +00:00
Robert Sese
beefde480e Use issues product for homepage redirect tests 2022-06-08 11:37:44 -05:00
Matt Pollard
0984f7dae6 Fix tests 2022-06-08 14:47:15 +02:00
Matt Pollard
e4877b8517 Fix two tests for deleted product 2022-06-08 14:44:13 +02:00
Peter Bengtsson
d014f36222 fix external redirects (#28063)
* fix external redirects

* oops

* feedbacked
2022-06-02 02:06:29 +00:00
Peter Bengtsson
75c0ec5cab /en/ permanent redirects to /en should be CDN cacheable (#27976) 2022-05-25 13:51:16 +00:00
Peter Bengtsson
8362602503 do rendering end-to-end tests with a real server (#26169)
* reinstate

* start server manually

* routing tests too

* skip more

* sleep more and fail if not 200

* use e2etest for content/ too

* feedbacked
2022-03-18 17:06:12 -04:00
Peter Bengtsson
9d4b913bdc language redirects without cache (#25872)
* redirect to your preferred language (#25664)

* redirect to your preferred language

* refactorings

* use js-cookies

* make sure no cache when language is involved in the redirect

* fix tests
2022-03-07 16:25:22 +00:00
Peter Bengtsson
881a6d2212 Revert "redirect to your preferred language (#25664)" (#25869)
This reverts commit a9947c086c.
2022-03-04 21:56:57 +00:00
Peter Bengtsson
a9947c086c redirect to your preferred language (#25664)
* redirect to your preferred language

* refactorings

* use js-cookies
2022-03-04 16:29:11 +00:00
Peter Bengtsson
07c8fc3c2a Decouple redirects from language (#24597)
* experimenting with redirects

* cleanup developer.json

* wip

* clean console.log

* progress

* some progress

* progress

* much progress

* debugging tests

* hacky progress

* ditch latest -> number redirects

* minor

* hacky progress

* lots of progress

* some small fixes

* fix rendering tests

* small fixes

* progress

* undo debugging

* better

* routing tests OK

* more cleaning

* unit tests

* undoing lineending edit

* undoing temporary debugging

* don't ever set this.redirects on Page

* cope with archived version redirects

* adding code comments on the major if statements

* address all feedback

* update README about redirects

* delete invalid test

* fix feedback
2022-02-14 20:19:10 +00:00
Jules Parker
e20f8548cf fixes conflict 2022-01-25 12:43:09 +01:00
Peter Bengtsson
c42823af9d use 302 when redirecting from enterprise-server@latest to enterprise-server@<version> (#24494)
* use 302 when redirecting from enterprise-server@latest to enterprise-server@<version>

* correct tests
2022-01-21 17:10:09 +00:00
Laura Coursen
baec362248 Reframe the GitHub Connect docs (#24146) 2022-01-20 15:39:16 -06:00
Jules Parker
70342a38bd fixes tests 2022-01-13 15:26:00 +01:00
Jules Parker
d1ace77811 fixes tests 2022-01-13 15:08:29 +01:00
Jules Parker
39e8de7076 fixes tests 2022-01-13 14:27:26 +01:00
Jules Parker
74774e1674 fixes tests 2022-01-13 13:20:10 +01:00
Peter Bengtsson
9782b804a0 refactor redirecting specifically for the old query string key (#23749)
* refactor redirecting specifically for the old query string key

* fix tests
2021-12-16 13:09:37 +00:00
Peter Bengtsson
53e3077973 use 302 when redirecting from without language prefix (#23409)
Part of #1312
2021-12-07 14:07:11 +00:00
Matt Pollard
4657a4d3f3 Merge branch 'main' into jules-4795 2021-10-20 15:49:31 +02:00
Peter Bengtsson
4e4ca1d12d gg commit (#22323)
Part of #1061
2021-10-20 09:45:18 -04:00
Matt Pollard
16c8801dbc Merge branch 'main' into jules-4795 2021-10-19 12:26:41 +02:00
Peter Bengtsson
1d72d4c87e use temporary redirect to inject locale prefix (#22239)
* use temporary redirect to inject locale prefix

Fixes #996

* fix routing tests
2021-10-18 20:09:20 +00:00
Peter Bengtsson
c712da8f5d be more conservative with spotting q= in URL (#21945)
* be more conservative with spotting q= in URL

Fixes https://github.com/github/docs-engineering/issues/951

* refactor check

* Update tests/routing/redirects.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-10-18 12:04:45 +00:00
Matt Pollard
dfb4d8265e Update hardcoded link 2021-10-11 12:53:18 +02:00
Matt Pollard
307e8094ec Backport updated content from GitHub AE M2 megabranch and version for ghae-next (#21525) 2021-10-04 16:11:57 +00:00
Laura Coursen
b8429d8248 "Authentication" top-level doc set (#21531) 2021-09-21 19:27:08 +00:00