1
0
mirror of synced 2026-01-05 21:04:17 -05:00
Commit Graph

139 Commits

Author SHA1 Message Date
Sarah Schneider
a5d52dcef0 Add landing page for GitHub Enterprise (#19041) 2021-05-12 11:55:32 +00:00
Mike Surowiec
e716172ba6 Merge branch 'main' into sponsors-react-3 2021-05-11 13:41:15 -07:00
Mike Surowiec
744051006f Merge branch 'main' into sponsors-react-2 2021-05-11 13:34:38 -07:00
Mike Surowiec
f0fe065cef feat: implement changelog feed, guide section 2021-05-10 15:17:52 -07:00
dependabot[bot]
f4ba932e78 Bump hosted-git-info from 2.7.1 to 2.8.9 (#19216) 2021-05-10 12:00:24 -07:00
James M. Greene
ed0f942cf2 Merge branch 'main' into dependabot/npm_and_yarn/lodash-4.17.21 2021-05-07 17:16:11 -05:00
Mike Surowiec
e3ff452f47 feat: add primer/components, wire up SSR for styled-components 2021-05-06 15:07:15 -07:00
Mike Surowiec
8930036e67 Merge branch 'main' into sponsors-react-1 2021-05-06 13:58:54 -07:00
dependabot[bot]
de7cc2db05 Bump lodash from 4.17.20 to 4.17.21
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-06 18:46:59 +00:00
Mike Surowiec
e10c29b1fb feat: use eslint for dependency checks 2021-05-06 08:31:04 -07:00
Mike Surowiec
f3a029b6dd feat: add SupportSection 2021-05-05 15:58:21 -07:00
Mike Surowiec
34dcba51f1 feat: add DefaultLayout, add to sponsors landing page 2021-05-05 14:54:49 -07:00
Mike Surowiec
eaddbc5db7 feat: add nextjs middleware handling (#19139)
* feat: add nextjs middleware handling split

* fix: eslint errors

* fix: filter boolean from csp list

* fix: feature flag nextjs server start

* feat: add prettier rules for ts,tsx files

* fix: remove unnecessary async from next middleware

* fix: next middleware name

* Update tsconfig.json

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update next-env.d.ts

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* fix: add typescript linting to lint command

* add comment for unsafe-eval, update webpack to use eval in development

* fix: feature flag typo

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-05-05 15:23:46 +00:00
James M. Greene
816a7bbc4e Follow-up for removing stale apps (#19056)
* Use existing 'github' script helper to get Octokit instance

* Move @octokit/rest to devDeps

We only use it in scripts, currently

* Removed outdated delete-unused-staging-apps script
2021-04-29 11:09:34 -04:00
dependabot[bot]
7e7f17c3f8 Bump redis from 3.0.2 to 3.1.1 (#5775) 2021-04-28 16:38:05 -07:00
Marc-Andre Giroux
2deb8275da Accept glob patterns for source files in openapi-check script (#18965)
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-04-26 21:56:12 +00:00
James M. Greene
919054f91c Update npm dependencies to address Dependabot security alerts (#18992)
* npm audit fix

Addresses 1 Dependabot security alert for marked@<2.0.0, which is a dependency of linkinator

https://github.com/advisories/GHSA-4r62-v4vq-hr96

* Update jest to latest, which updates node-notifier@<8.0.1, to address 1 Dependabot security alert

https://github.com/advisories/GHSA-5fw9-fq32-wv5p

* Update rehype-highlight to latest, which updates highlight.js@<10.4.1, to address 1 Dependabot security alert

https://github.com/advisories/GHSA-7wwv-vh3v-89cq
2021-04-26 21:21:09 +00:00
dependabot[bot]
74ba87a972 Bump y18n from 4.0.0 to 4.0.3 (#18800) 2021-04-15 17:06:14 +00:00
Mike Surowiec
4a931237ea Merge branch 'main' into update-webpack-dep 2021-04-13 16:55:31 -07:00
Mike Surowiec
1c5cd44a83 fix: move ajv from devDeps to deps 2021-04-13 16:49:31 -07:00
Kevin Heis
46c16001c3 Upgrade Primer with translation shim for trashcan icon (#18735)
* Revert "Revert "Upgrade Primer CSS to 16 (#18713)""

This reverts commit c01d3e302e.

* Add a hack to handle trashcan icon in translated content
2021-04-13 18:38:04 +00:00
Mike Surowiec
c01d3e302e Revert "Upgrade Primer CSS to 16 (#18713)"
This reverts commit 49377f9096.
2021-04-13 09:19:28 -07:00
Kevin Heis
49377f9096 Upgrade Primer CSS to 16 (#18713)
* Upgrade primer to 16

* Upgrade colors in scss

* Get SCSS to build

* Initial dark mode support

* trashcan -> trash

* More specific search browser test

* Fix link color on homepage

* Update overrides.scss

* Upgrade some colors to primer variables

* Hide dark mode support for now

* Apply suggestions from code review

* Update overrides.scss
2021-04-13 16:00:46 +00:00
Sarah Schneider
53b7208fe9 Merge branch 'main' into update-webpack-dep 2021-04-09 12:22:18 -04:00
Vanessa Yuen
bbd9f03f6e Populate product-landing "What's new" section using GitHub Changelog (#18328)
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2021-04-08 20:51:37 +00:00
Sarah Schneider
d75621aa0e update webpack plugins and remove friendly-errors-webpack-plugin abandonware 2021-04-07 11:26:39 -04:00
Sarah Schneider
583914fc8c sigh retry assert in dependencies 2021-04-07 08:27:44 -04:00
Sarah Schneider
640b9866db move assert to devdeps 2021-04-06 19:19:41 -04:00
Sarah Schneider
274ef8287a update webpack to resolve dependabot alert 2021-04-06 16:33:03 -04:00
Sarah Schneider
107b8e5bc0 Move scheduled tasks code into docs repo (#17926)
Co-authored-by: Rachael Sewell <rachmari@github.com> - https://github.com/github/docs-internal/pull/18453
2021-04-02 12:42:41 -07:00
James M. Greene
d8e0b29fcd Use node-redis for soft-purging cache on deploy (#18474)
* Use [node-]redis as a direct dependency

* Extract Redis client creation to its own module

* Attach extensive logging in the Redis client creation module

* Allow the rate limiter to pass requests when Redis is disconnected

* Update rate-limit-redis

* Default error input to empty object for formatRedisError method

* Provide a name for the rate limiter's Redis client

* Include redis-mock, exclude ioredis/ioredis-mock

* Remove unused RedisAccessor#exists method

* Switch RedisAccessor to use redis/redis-mock

* Provide a name for logging on the Redis page cache

* Remove extraneous trailing space from Redis logging prefix

Our updated use of console.* will already be adding a space after the prefix

* Replace ioredis-mock with redis-mock in tests

* Revert removal of ioredis dependency

* Bind Redis client to async promisified methods

* Extract former RedisAccessor constructor tests to new create-client tests

* Update RedisAccessor tests to work with the callback-based redis client

* Handle formatting Redis errors (or not) with more resiliency

* Remove ioredis as a dependency

* Update Redis soft-purging script to use node-redis

* Do more promisifying for less ugly code

* Add comment explaining TTL of -1

* Make the script executable
2021-03-30 20:40:28 +00:00
dependabot[bot]
33ff95185f Bump y18n from 4.0.0 to 4.0.1 (#4909) 2021-03-29 15:12:12 -07:00
James M. Greene
84547e54c7 Use node-redis for page cache (#18421)
* Use [node-]redis as a direct dependency

* Extract Redis client creation to its own module

* Attach extensive logging in the Redis client creation module

* Allow the rate limiter to pass requests when Redis is disconnected

* Update rate-limit-redis

* Default error input to empty object for formatRedisError method

* Provide a name for the rate limiter's Redis client

* Include redis-mock, exclude ioredis/ioredis-mock

* Remove unused RedisAccessor#exists method

* Switch RedisAccessor to use redis/redis-mock

* Provide a name for logging on the Redis page cache

* Remove extraneous trailing space from Redis logging prefix

Our updated use of console.* will already be adding a space after the prefix

* Replace ioredis-mock with redis-mock in tests

* Revert removal of ioredis dependency

* Bind Redis client to async promisified methods

* Extract former RedisAccessor constructor tests to new create-client tests

* Update RedisAccessor tests to work with the callback-based redis client

* Handle formatting Redis errors (or not) with more resiliency
2021-03-29 17:34:22 +00:00
Vanessa Yuen
1be2866297 Translation batch (#18439) 2021-03-26 21:27:27 +01:00
Vanessa Yuen
a8d54c9af7 Improvements in tools to help merge crowdin PRs (#18409)
- add `script/test-render-translation.js` to render all translated content to catch malformed liquid that would cause render errors
- improve test output for `script/fix-translation-errors.js` and `tests/content/lint-files.js`
- make it so `script/reset-translated-file.js` can handle files that have been renamed
2021-03-26 19:21:45 +00:00
James M. Greene
23bcc0bb06 Use node-redis for rate limiter (#18416)
* Use [node-]redis as a direct dependency
* Extract Redis client creation to its own module
* Attach extensive logging in the Redis client creation module
* Allow the rate limiter to pass requests when Redis is disconnected
* Update rate-limit-redis
* Default error input to empty object for formatRedisError method
* Provide a name for the rate limiter's Redis client

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-03-25 23:54:25 +00:00
James M. Greene
6e20ed7927 Implement app clustering (#17752)
* Install throng for easy cluster management
* Extract the Express app construction into its own file
* Switch server.js to use app clustering for deployed environments
* Worker count is based on the lesser of process.env.WEB_CONCURRENCY and the count of CPUs
* Reading clustered output is difficult, let's prefix the std{out,err} streams

Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2021-03-19 20:07:46 +00:00
Rachael Sewell
e067616355 add script to read topics spreadsheet (#18175) 2021-03-11 17:20:27 -08:00
James M. Greene
fd7d0eeb1a Add timeout and abort middleware and processing halts (#18177)
* Add middleware to timeout requests after a period

* Add halt-on-dropped-connection middleware to stop the middleware processing stack if the connection was already dropped

* Add a few strategic bail-out spots for dropped connections during the render-page middleware

* Handle 404s and HEAD requests earlier in the page rendering flow

* Add a few more strategic bail-out spots for dropped connections during the render-page middleware

* Add middleware to notice aborted requests

* Add a check for aborted requests into the isConnectionDropped logic

* Reformat comment for consistency

* Handle aborted requests correctly in the error handler

* Explicit returns for consistency
2021-03-09 19:14:02 +00:00
Rachael Sewell
01e52046f0 migrate away from AWS S3 (#17669) 2021-02-12 10:25:45 -08:00
Jason Etcovitch
e68e6a5185 Revert "Revert "Absorb @github-docs/frontmatter (#17783)" (#17793)" (#17799)
* Revert "Revert "Absorb @github-docs/frontmatter (#17783)" (#17793)"

This reverts commit 11baf43eee.

* Move revalidator to depedencies
2021-02-11 11:15:59 -05:00
Jason Etcovitch
11baf43eee Revert "Absorb @github-docs/frontmatter (#17783)" (#17793)
This reverts commit 1e96c03489.
2021-02-10 20:28:41 +00:00
Jason Etcovitch
1e96c03489 Absorb @github-docs/frontmatter (#17783) 2021-02-10 15:10:46 -05:00
dependabot[bot]
02c4df5ab6 Bump ini from 1.3.5 to 1.3.8 (#17742)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-08 18:29:32 +00:00
Jason Etcovitch
39e0e0dda1 Use Liquidjs instead of Liquid (#16743)
* Install liquidjs, uninstall liquid

* Comment a bunch of stuff out to get going

* Fix invalid includes

* Fix all includes (path => 'path')

* Get the homepage to render

* Do link-in-list kinda

* Revert "Fix all includes (path => 'path')"

This reverts commit d6fead646353aa5041d9229470a62a1d487456b9.

* Support non-dynamic partials

* Extract getTemplate helper

* Do remaining custom Liquid tags

* Fix some custom tag bugs

* Moar bugs

* Re-add link tag

* Cleaner diff

* Actually fix extended markdown tags

* Fully comment out version matchers

* Smaller diff

* Rely only on Liquid internals for conditionals

* Use new operators option in Liquid engine

* Fix link.js

* Don't need options

* Updoot to the right doot

* Fix some bugs

* Fix another bug

* Pass a test

* Fix the translate bits

* Adjust a test

* Fix another invalid Liquid bug

* Two more borked translations

* Found some more

* Don't need this change

* Revert "Don't need this change"

This reverts commit a916d619747f0492865a69c3e237c97c4d4e7fad.

* This should fix the broken links

* Missed one

* Revert "This should fix the broken links"

This reverts commit e6c2cc0d9055d958706260d57edbe293281c150e.

* Revert "Missed one"

This reverts commit bbe1f23baf16e020f6f7931589decb1afc75dfbd.

* Updoot liquidjs
2021-02-08 12:58:51 -05:00
James M. Greene
f7ec320b64 npm audit fix (#17675) 2021-02-06 23:57:14 +00:00
Kevin Heis
e07c603b7d Remove html-truncate, truncate with CSS instead (#17630)
* Remove html-truncate, truncate with CSS instead

* Update search.js
2021-02-02 17:55:05 +00:00
Jason Etcovitch
bd63f47636 Remove cheerio from Page#render (#17566)
* Write our plugin

* Include it

* Move the RegEx

* Don't rewriteLocalLinks with cheerio anymore

* Process after HTML ast is generated

* Use the same logic as before, just to see if it'll pass

* Don't require languageCode/version

* Only work on local links

* Needs an href

* Only update href if there's a new one to use

* Check for node.properties

* Some links are just mean

* Move use-english-headings to be a plugin

* Bail if no englishHeadings were passed

* Install rehype-wrap

* Wrap ol > li img in div.procedural-image-wrapper

* Test for platform without cheerio

* Use a plugin for rewriteAssetPathsToS3

* Remove cheerio from page.render

* Fix require paths

* SImplify

* Fix some 🐛s

* Use our own rehype-wrap

* Move rewriteAssetPathsToS3 after HTML AST

* Remove some console logs

* Fix check for includesPlatformSpecificContent

* Rename ast => tree
2021-01-29 15:44:50 -05:00
Kevin Heis
8b86fd8fef Reduce minified JS bundle size from 189kb to 73kb (#17552) 2021-01-28 22:12:04 +00:00
Jason Etcovitch
2572d7bb85 Remove hubdown and use our own markdown pipeline (#17551)
* Uninstall hubdown, install unified deps

* Create create-processor

* Use it

* Update a doc

* Tweak the language

* Use the same versions that hubdown used
2021-01-28 17:06:19 -05:00