1
0
mirror of synced 2025-12-23 03:44:00 -05:00
Commit Graph

58 Commits

Author SHA1 Message Date
Grace Park
ff23e33c3e Remove maximum-scale accessibility issue (#34757) 2023-02-14 21:47:32 +00:00
Grace Park
302b3a0663 Fixing mobile search header (#34326) 2023-02-01 18:21:18 +00:00
Grace Park
ef2efb0636 Feature Branch: Global Nav Phase 1 (#33465)
Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com>
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2023-01-31 17:49:50 +00:00
Peter Bengtsson
8ec4ddf836 use keepPreviousData for uswSWR in Search component (#33592) 2022-12-16 17:29:40 +00:00
Peter Bengtsson
401d9696a6 use /api/search/v1 in Search.tsx (#31952) 2022-11-14 12:34:21 +00:00
Rachael Sewell
5f40f9341d Switch search backend from Lunr to Elasticsearch (#31257)
Co-authored-by: Peter Bengtsson <mail@peterbe.com>
2022-10-04 19:04:47 +00:00
Kevin Heis
c4a1027d97 Reinstate search result event (#31146) 2022-09-27 09:08:10 -04:00
Peter Bengtsson
a1e3866fa5 don't get available languages from session (#29715)
* don't get available languages from session

* update useSession

* one more fix
2022-08-08 11:13:27 -04:00
Peter Bengtsson
f8f20605f4 search api with elasticsearch (#29053)
* indexing records into Elasticsearch

* @elastic/elasticsearch@8.2.0

* mv

* fix the code

* pipe

* lfs

* use sha

* change how index names work

* search api with Elasticsearch

* works

* refactor client

* better snowballing

* remove dbg

* wip

* highlights and fuzzy search

* improvements and upgrade

* also upgrade

* wip

* index more explicitly

* better validation

* change max size

* popularity by ordinal ranking instead

* playing

* fix package-lock

* rearranging

* catchMiddlewareError

* fix indexing

* match_phrase_prefix on wrapped search

* refactorings

* escape html in content

* wip

* search by URL

* update lock file

* v1 api

* inroads on jest testing the search

* valid yaml hopefully

* index fixtures into local elasticsearch

* specific versions to index only

* small fixes

* feedbacked

* fix tests

* use the npm script
2022-08-05 19:40:38 +00:00
Kevin Heis
56aa9ea094 Move use session to its own hook file (#29641)
* Move use session to its own hook file

* Trying useSWR

* Try one hour html cache

* blah blah lint

* Update to include loading state

* Update components/hooks/useSession.ts

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-08-05 14:47:10 +00:00
Kevin Heis
0886faddac Move language context to browser/session (#29433) 2022-07-28 18:50:46 +00:00
Peter Bengtsson
8d1f41633a prevent whitespace-only searches (#29075) 2022-07-15 19:10:10 +00:00
Peter Bengtsson
08ffe45da7 add debounced search query string without anchor (#29073)
add debounched search query string without anchor
2022-07-15 18:41:14 +00:00
Robert Sese
c9870c5418 Add 'About versions' link to search version dropdown (#29005)
* Add 'About versions' to search versions dropdown

* Fix search result list markup
2022-07-13 17:58:10 +00:00
Grace Park
822fe2926b Megabranch: Upgrade primer/react (#28458)
* upgrade primer/react

* upgrade

* using deprecated

* remove lib"

* Upgrade primer/react: Upgrade Label (#28502)

update Label to primer/react 35.2.2

* fix merge conflicts

* primer/react v35: update ActionList (#28467)

* Update to v35 ActionList for LearningTrack

* Update to v35 ActionList for ArticleList

* Update to v35 ActionList for ProductArticleList

* Update to v35 ActionList for TableOfContents

* Update to v35 ActionList for ProductCollapsibleSection

* Update to v35 ActionList for RestCollapsibleSection

* Update to v35 ActionList for SidebarHomepage

* Update to v35 ActionList for MiniTocs

* Update to v35 ActionList for Search

* Extra div for rendering test

* One less div for rendering test

* All the style updates for v35 ActionList

* Works without setting as an li which is already the default (didn't before for some reason)

* Use deprecated ItemInput for now

* Picker update for primer/react (#28485)

* update picker

* inline picker for mobile

* set width to auto

* Update components/ui/Picker/Picker.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* update

* Update Picker.tsx

* update onselect

* checking language code

* move language cookie setting to language picker

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* Resolve package merge conflicts

* fresh npm install

* Primer update UnderlineNav (#28582)

* update underlinenav for primer/react update

* update tests

* update switches test

* update one last label

* update header test"

* remove href in underlinenav

* update rendering tests

* update cursor

* primer/react v35: update DropDownMenu to ActionMenu (#28576)

* Update to v35 ActionMenu for ArticleCards

* Update to v35 ActionMenu for Search

* Set button to inline-block

* Put the props on the overlay

* Update test for ActionMenu markup

* update package

* update package lock

* primer/react v35: CodeLanguagePicker update from SelectMenu to ActionMenu (#28625)

* Use octicon for menu down arrow

* Update to v35 ActionMenu for CodeLanguagePicker

* update to SubNav

Co-authored-by: Grace Park <gracepark@github.com>

* update package-lock

Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-07-11 11:51:18 -07:00
Peter Bengtsson
070ac1b823 fix more shorthand eslint warnings (#27952) 2022-05-24 13:23:11 -04:00
Grace Park
10fea98af5 Search updates larger font (#27838)
* removing search from home page and adding to header

* remove homepage search

* adding description

* update to f5

* remove homepage search test

* removing homepage search rendering test

* showing preview of larger font

* update wording at breakpoint

* update to short description everywhere

* Update components/homepage/HomePageHero.tsx

Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>

* remove unnecessary stylesheet

* Update data/ui.yml

Co-authored-by: Janice <janiceilene@github.com>

Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>
Co-authored-by: Janice <janiceilene@github.com>
2022-05-20 12:12:36 -07:00
Ritesh Patil
1a7f1a813e fix: add relationship between Select version and Youre searching the Free, Pro, & Team version text 2022-04-12 12:19:58 +00:00
Ritesh Patil
ce5f599a4e fix: Rephrase search label; add an aria description label to the search input 2022-04-07 08:26:28 +00:00
Mike Surowiec
f3fc80cf05 Upgrade primer/components -> primer/react (#25591)
* upgrade primer/components -> primer/react

* fix jest failure
2022-02-24 00:30:14 +00:00
Peter Bengtsson
53796d44ac make octicon search svgs cached longer (#25421)
* make octicon search svgs cached longer

* not an orphan exception
2022-02-16 17:11:43 +00:00
Mike Surowiec
e1a2860adb add shallow true to search to avoid triggering page data requests (#25184) 2022-02-09 16:23:10 +00:00
Peter Bengtsson
f2f679550d display possible search error (#24429)
* display possible search error

* feedbacked
2022-01-19 21:41:17 +00:00
Grace Park
47de433865 Accessibility Search updates and additional minor changes (#24136)
* update to use heading markup

* updating to h3 for accessibility

* increase opactiy to meet 5.5:1 color contrast ratio

* update opacity to meet color contrast ratio

* update styling to match original but use heading markup

* remove aria-hidden for accessibility

* add h1 title search results and update scroll tip colors

* add number of matches

* remove no results since we are showing 0 results

* add overflow to fix border bottom on version search

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* incorporating feedback and update padding

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-07 21:29:49 +00:00
Robert Sese
d2b9b236c4 Add label for search input (#24130) 2022-01-06 22:35:56 +00:00
Grace Park
e0c31e09e7 update padding bottom (#23580)
Co-authored-by: docubot <67483024+docubot@users.noreply.github.com>
2021-12-13 09:58:53 -08:00
Grace Park
f19223503a Update Search Version Button to Dropdown (#23465)
* adding to view

* updating the portal location

* add new line

* updating font styling to class

* Update components/Search.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* Update components/Search.module.scss

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* update ItemInput

* using router.replace and import updates

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* run prettier

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-12-09 17:56:24 +00:00
Peter Bengtsson
046de169fd fix TypeScript violation with Overlay in @primer/components@32.1.0 (#23358)
Part of #1311
2021-12-03 19:43:12 +00:00
Mike Surowiec
0c3fa5f80b fix: use components/Link in Search.tsx (#23019) 2021-11-22 15:08:02 +00:00
Kevin Heis
f17c7a2598 Update search to use rem units where possible (#22970)
* Update search to use rem units where possible

* Use more primer classes

* Move more search to primer classes
2021-11-18 20:43:31 +00:00
Peter Bengtsson
d605556a80 encode 'query' in 'redirectQuery' (#22913) 2021-11-17 23:08:46 +00:00
Peter Bengtsson
eb4a4741ad refactory getting 'query' with a hook (#22879) 2021-11-17 15:02:50 +00:00
Grace Park
56521881a2 Adding scroll to header search results (#22874)
* adding scroll to header search results

* move search-result

* search-result data test id addition

* forgot s
2021-11-16 21:32:45 +00:00
Peter Bengtsson
07a5edd2ab rewrite search state from useRouter (take 2) (#22833)
* rewrite search state from useRouter (take 2)

* fix the problem with isHeaderSearch

* cleaning ups

* updating mobile search results ui (#22841)

* remove useCallback

Co-authored-by: Grace Park <gracepark@github.com>
2021-11-16 18:55:48 +00:00
Rachael Sewell
e919d5085d change version within search result window (#22702) 2021-11-12 22:01:08 +00:00
Grace Park
5ac9d72005 styling updates and get all results (#22809) 2021-11-12 21:47:40 +00:00
Grace Park
5bf39459ca Updating Search using Primer Components (#22677)
* updating search icon

* remove no fill

* update fill color

* using ActionList and Overlay

* update to ActionList, Overlay, add Label to Breadcrumbs, and change Mark

* add search-results test data and move header search results to right

* make search results scrollable and fix max-width in header search

* update header search and styling updates

* add highlight

* update styling

* styling and lint errors

* fix lint error and fetch

* Update components/Search.tsx

* update label color

* remove bottom margin

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-11-12 12:25:47 -08:00
Rachael Sewell
0244fda807 search improvements (#22443) 2021-11-10 11:11:28 -08:00
Kevin Heis
567652b0e3 Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Kevin Heis
83804c7114 Create search result event (#22307)
* Create search result event

* Update Search.tsx

* actually send it

* remove comment

* Apply suggestions from code review

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* add 'required' to schema

Co-authored-by: Peter Bengtsson <mail@peterbe.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-10-21 00:37:39 +00:00
Peter Bengtsson
3994797e81 indicate 0 search results as a result (#22262)
* indicate 0 search results as a result

fixes https://github.com/github/docs-engineering/issues/955

* correct logic

* refactored into own component
2021-10-19 22:23:36 +00:00
Mike Surowiec
d81f51ebf7 Picker improvements (#21765)
* close Language and ArticleVersion pickers after click

* cleanup ArticleGridLayout due to VersionPicker changes

* fix tsc errors resulting from primer upgrade

* fix / update tests

* cleanup mobile pickers visual consistency

* use btn-sm on VersionPicker

* update translation and close on click for enterprise releases

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 20:22:13 +00:00
Kevin Heis
29ebc555cb Add btn-primary-matte, ScrollButton, TruncateLines to storybook (#21611)
* Update create-processor.js

* Use built in semibold

* Preparing articlelist

* Add blue button to storybook

* Scope fade styles

* Add truncate component

* Add scroll button to storybook

* Update storybook.tsx

* Update DefaultLayout.tsx
2021-09-20 23:21:29 +00:00
Mike Surowiec
d8b4383dc6 Improve Search styling (#21295)
* fix: improve search highlight contrast
2021-09-03 16:20:23 +00:00
Kevin Heis
9f7c20dae8 Upgrade Primer CSS to version 17, removing marketing styles (#20965)
* Package updates

* Fix up things that look broken

* Add to utils

* Lead now just sets font size, just use f3 where needed

* Update package-lock.json

* Update index.tsx

* Delete bump-link.scss

* Update trigger-error.js

* Update components/GenericError.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update ArticlePage.tsx

* Update ActionBar.tsx

* Changes from meeting

* Found a few more monos

* Fix from a merge conflict

* Missed a few f3s

* Update SubLandingHero.tsx

* Bye gradients

* Match up breadcrumbs

* Update SubLandingHero.tsx

* Update lists.scss

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-08-31 14:49:39 -07:00
Mike Surowiec
2a25efcd8e Scope Search scss (#20964)
* scope Search scss, reduce custom styling

* use translation for loading and no results found

* remove unnescessary test
2021-08-23 09:15:39 -04:00
Grace Park
2dbea3737a Removing algolia (#20633) 2021-08-05 13:10:51 -04:00
Mike Surowiec
a9a19ef6da Move languages out of MainContext (#20503)
* move languages off of MainContext

* load languages from request to workaround sharing the languages file
2021-07-29 13:36:11 +00:00
Grace Park
8ba413cabc React Cleanup: Documentation (#20517)
* initial documentation changes

* editing layouts terminology

* update to match other files

* move javascripts to components/lib

* fix: dockerfile

* update based on Mikes updates to the javascripts directory

* update components/README.md

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-07-27 09:07:18 -07:00
Mike Surowiec
b084dbc23d React: Enable all remaining pages (#20012)
* enable all remaining pages

* update tests for survey, filter card dropdowns

* fix search test

* fix: mobile search layout

* update sidebar test

* fix: learning track page is optional

* fix broken links
2021-06-21 19:52:58 +00:00