1
0
mirror of synced 2026-01-03 15:05:54 -05:00
Commit Graph

725 Commits

Author SHA1 Message Date
Rachael Sewell
67360f5ad5 refactor rest code (#25879) 2022-03-11 20:23:38 +00:00
Peter Bengtsson
01baeda3c0 sync serialize sitedata to disk (#25749)
* sync serialize sitedata to disk

* use os.tmpdir

* refactor tests

* debugging

* use log

* debugging

* louder about syntax errors

* warn-before-tests

* louder about disk-caching redirects

* less loud

* only in development again
2022-03-09 20:57:40 -05:00
Peter Bengtsson
5d5c3e971b add context to liquid rendering in linting tests (#26055)
* HACK

* back

* remove consolelog

* remove debugging

* remove more debugging
2022-03-09 16:45:18 +00:00
Peter Bengtsson
fcda086e13 make enterprise 3.0 redirects work (#26041)
* make enterprise 3.0 redirects work

* improve tests and better variable name
2022-03-09 16:32:05 +00:00
Peter Bengtsson
95297c3c9d Simplify getBreadcrumbs (#26015)
* fix getBreadcrumbs

* don't go too deep

* remove commented out code
2022-03-09 01:14:49 +00:00
Peter Bengtsson
e18396c7fd avoid mocking in robots.txt testing (#26018)
* avoid mocking in robots.txt testing

* remove package
2022-03-09 01:08:49 +00:00
Peter Bengtsson
9d4b913bdc language redirects without cache (#25872)
* redirect to your preferred language (#25664)

* redirect to your preferred language

* refactorings

* use js-cookies

* make sure no cache when language is involved in the redirect

* fix tests
2022-03-07 16:25:22 +00:00
Peter Bengtsson
881a6d2212 Revert "redirect to your preferred language (#25664)" (#25869)
This reverts commit a9947c086c.
2022-03-04 21:56:57 +00:00
Rachael Sewell
9fd4fe0a6c remove prerendered response rest docs (#25652) 2022-03-04 21:24:46 +00:00
Peter Bengtsson
a9947c086c redirect to your preferred language (#25664)
* redirect to your preferred language

* refactorings

* use js-cookies
2022-03-04 16:29:11 +00:00
Peter Bengtsson
d75c49b1c6 loadPages by 'en' only (#25846) 2022-03-04 16:24:24 +00:00
Peter Bengtsson
c4489e6fa4 Throw an error if a 'data' Liquid tag fails (#25730) 2022-03-04 12:16:32 +00:00
Peter Bengtsson
22cd55f3e3 cache changelog feed in CI (#25759)
* cache changelog feed in CI

* unbreak unit tests

* feedbacked

Co-authored-by: Robert Sese <rsese@github.com>
2022-03-03 20:32:34 +00:00
Robert Sese
876b3d4d67 Don't hardcode version (#25808) 2022-03-03 14:26:59 -06:00
Robert Sese
79c48070c4 Deprecate 3.0 (#25646)
* Deprecate 3.0

* 3.0 deprecation: remove 3.0 markup (#25647)

* Remove liquid conditionals and content for 3.0 deprecation

* Remove manually, no longer versioned in a supported version

* Remove translations manually, no longer versioned in a supported version

* Remove 'if', now in all supported versions

* Remove dangling 'elseif', now in all supported versions

* Remove dangling 'elseif' and 3.0 screenshot reference, now in all supported versions

* Nudge to latest supported GHES version

* Nudge to latest supported release GHES version

* Bump all the version for the liquid tests

* Bump first deprecated version for linting tests

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove extra newline

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove extra newline

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove extra newline

Co-authored-by: Laura Coursen <lecoursen@github.com>

* One reusable per line

Co-authored-by: Laura Coursen <lecoursen@github.com>

* One reusable per line

Co-authored-by: Laura Coursen <lecoursen@github.com>

* One reusable per line

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Don't depend on hardcoded versions

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove static files for 3.0 deprecation (#25649)

Co-authored-by: Laura Coursen <lecoursen@github.com>
2022-03-03 13:08:24 -06:00
Peter Bengtsson
693fb35bc6 links on /rest/overview/endpoints (#25771)
* links on /rest/overview/endpoints-available-for-github-apps

* tests

* remove unused code
2022-03-03 17:45:37 +00:00
Peter Bengtsson
e69144b51f temporarily re-introduct includes/rest_operations_at_current_path.html (#25719) 2022-03-01 08:32:30 -05:00
Peter Bengtsson
eef77058ab throw if no value not found in indented_data_reference (#25711)
* throw if no value not found in indented_data_reference

* better comment

* deliberate writer-error saple

* all strings are truthy'ish

* undo

* fix tests
2022-02-28 20:40:06 +00:00
Rachael Sewell
2ade7d8489 reactify rest pages (#25005) 2022-02-28 18:30:54 +00:00
Peter Bengtsson
d0524e5124 make sure req.ip becomes correct (#25628)
* make sure req.ip becomes correct

* feedbacked
2022-02-24 17:54:09 +00:00
Peter Bengtsson
6bc2600b3b renable backfills missing translation site data test (#25303)
* renable backfills missing translation site data test

* adding a code comment to explain how finally relates to jest
2022-02-24 13:42:49 +00:00
Peter Bengtsson
16113fd23a don't check the productMap for translations (#25589)
* don't check the productMap for translations

* fix breaking test
2022-02-24 13:05:35 +00:00
Peter Bengtsson
c976b9da6a formate /_ip with JSON instead (#25574) 2022-02-23 17:58:39 +00:00
Peter Bengtsson
177e197d8d soft rate limit all requests (#25556)
* rate limit all requests

* set IP in tags to statsd

* expose _ip route for assuring we get the right IP

* remove old unit test

* nit
2022-02-23 16:46:29 +00:00
Peter Bengtsson
96701946ae delete .frontmatterErrors after it has been used (#25389) 2022-02-22 21:03:14 +00:00
Sarita Iyer
9913717066 Update repository-references.js 2022-02-22 12:38:57 -05:00
Robert Sese
ef9b6ebd0e Test that categories all have the same child type (#25392)
* Track category child types

* Test that category children are all of the same type

* Add custom error message

Co-authored-by: Grace Park <gracepark@github.com>

Co-authored-by: Grace Park <gracepark@github.com>
2022-02-16 19:02:31 +00:00
Peter Bengtsson
19b246022a handle search with colon (#25128)
* handle search with colon

* nicer 400 errors

* split up by words first to avoid dangerous regex

* code comment
2022-02-15 21:56:50 +00:00
Peter Bengtsson
95a3e82ac5 remove 'redirects versioned category page' test (#25304) 2022-02-15 21:44:34 +00:00
Peter Bengtsson
a867973876 serve /apple-touch-icon.png (#25371)
* serve apple-touch-icon.png

* rename

* 'directives'

* use a lazy but caching pattern

* update code comment
2022-02-15 21:35:08 +00:00
Peter Bengtsson
0d01c5b7b6 refactor developer-site-redirects test code (#25376) 2022-02-15 21:22:50 +00:00
Grace Park
d3cb224cc9 Testing moving the setTimeout outside describe block (#25362)
* testing moving the setTimeout outside describe block

* Revert "testing moving the setTimeout outside describe block"

This reverts commit 60ddb42ce6f27b729f4db70d2dece39b1d71d59a.

* update setTimeout

* increase timeout

* move settimeout
2022-02-15 20:38:46 +00:00
Peter Bengtsson
2f4af03975 be loud about failed learning track processing (#25370)
* be loud about failed learning track processing

* rendering test

* undo whitespace cleanup
2022-02-15 20:14:13 +00:00
Peter Bengtsson
c9aa9edeeb make supertest wrappers less weird (#25347) 2022-02-14 21:58:25 +00:00
Peter Bengtsson
07c8fc3c2a Decouple redirects from language (#24597)
* experimenting with redirects

* cleanup developer.json

* wip

* clean console.log

* progress

* some progress

* progress

* much progress

* debugging tests

* hacky progress

* ditch latest -> number redirects

* minor

* hacky progress

* lots of progress

* some small fixes

* fix rendering tests

* small fixes

* progress

* undo debugging

* better

* routing tests OK

* more cleaning

* unit tests

* undoing lineending edit

* undoing temporary debugging

* don't ever set this.redirects on Page

* cope with archived version redirects

* adding code comments on the major if statements

* address all feedback

* update README about redirects

* delete invalid test

* fix feedback
2022-02-14 20:19:10 +00:00
Peter Bengtsson
b381520839 don't overload the eventloop (#25344)
* don't overload the eventloop

* adding comment
2022-02-14 20:04:37 +00:00
Peter Bengtsson
caf0791694 support archived enterprise assets (#25224)
* support archived enterprise assets

* better tests
2022-02-11 15:58:05 -05:00
Mike Surowiec
624581e527 Remove most of Heroku references (#25208)
* remove most of heroku references

* remove more stuff

* update codeowners
2022-02-10 17:36:07 -06:00
Peter Bengtsson
24d3ea6814 remove catch-bad-accept-language middleware (#25231) 2022-02-10 18:51:30 +00:00
Peter Bengtsson
5c9a83be7c Stop doing Gzip in the middleware (#25227) 2022-02-10 11:01:56 -05:00
Peter Bengtsson
e535e52280 minimize caching on static asset 404s (#25192) 2022-02-09 20:03:15 +00:00
Peter Bengtsson
a1c78717d5 cache the search API (#25068)
* cache the search API

* extend tests
2022-02-09 17:21:49 +00:00
Peter Bengtsson
987fef9315 correct how legacy enterprise links are rewritten (#25183)
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2022-02-09 16:09:42 +00:00
Peter Bengtsson
94d976c1fa faster 404 for missing static assets (#25124) 2022-02-08 18:30:07 +00:00
Peter Bengtsson
2599d72116 conditionally clone docs-early-access by branchname (#24674)
* conditionally clone docs-early-access by branchname

* fix path

* right api

* the correct use of Octokit

* try that

* destructuring total_count

* test early access with fs.existsSync

* debugging

* bad lookup

* better lookup technique

* trying something

* always check it out

* with debugging

* with token

* with path

* better

* go for it

* only on docs-internal

* better name

* formatting

* tidying up

* correct octokit

* feedbacked

* correct hopefully

* final version

* disable test that checks for perfect translation-to-English file parity

* Accidentally committed in the wrong branch.

This reverts commit adee780718ea7414934e2257d17b0c004bd804af.

* match the azure-preview-env-deploy.yml
2022-02-08 17:20:51 +00:00
Peter Bengtsson
a0af48149e delete old deploy.js script (#24862) 2022-02-08 16:11:11 +00:00
Peter Bengtsson
ac30f9297c basic tests of the search API (#25069)
* basic tests of the search API

* lfs
2022-02-07 17:11:08 +00:00
Peter Bengtsson
cc44b2725e an empty 'product', 'permissions', or 'learningTracks' gets stuck (#25070)
* and empty 'this.product' gets stuck

* add test to prove change
2022-02-07 16:08:51 +00:00
Peter Bengtsson
f33ab1cf89 set 'manul-purge' surrogate key on assets/cb- URLs (#25028) 2022-02-04 11:55:40 -05:00
Peter Bengtsson
14ca55f670 cope with possible translation drift (#24842)
* cope with possible translation drift

* fix test

* don't shallow clone

* fix unit tests

* update code comments

* more code comment corrections

* more code comment

* feedbacked
2022-02-04 14:31:56 +00:00