1
0
mirror of synced 2025-12-26 14:02:45 -05:00
Commit Graph

407 Commits

Author SHA1 Message Date
Kevin Heis
5b1ac53379 A few things that Prettier seemed to miss (#23005) 2021-11-19 18:32:20 +00:00
Francis
8f4140fa9f fix: update permissions and command execution for linting translation files (#22922)
* fix: make script for linting translations executable

* fix: execute the command directly

* feat: surface any errors if lint check fails

* fix: do not return early if lint check errors

Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
2021-11-18 21:36:33 +00:00
Peter Bengtsson
a5dc892147 retry on 403 secondary rate limit errors (#22828)
* retry on 403 secondary rate limit errors

Part of #1215

* longer sleep time
2021-11-18 14:32:45 +00:00
Francis
5bb2c7acb2 [Localization] Refactor script for linting translation files to require check type (#22653)
* feat: stub two reset scripts

* refactor: split lint script into two separate files

* fix: revert back to original lint script

* refactor: use commander interface for linting translation files

* Skip reset attempt when violation list is empty

So that "execSync(`cat ${log}...`)" in line 64 is never executed. When
there are no errors, the log file is not created, and unless it had been
previously created by another process, the script will error out.

Co-authored-by: Marcelo Jacobus <marcelo.jacobus@gmail.com>
2021-11-17 03:09:07 +00:00
Francis
2422a22293 Reset known and unique broken translation files sequentially (#22709)
* fix: de-duplicate and filter non-existent broken files

* fix: sequentially reset known broken translation files

When a known broken translation is reset, a Git operation performs the
underlying reset. If more than one Git operation is running at a time,
Git will throw an error:

> Another git process seems to be running in this repository [...]

This change ensures that we reset each broken translation file
sequentially to not run into this error.

* Skip reset of a file that does not exist

Co-authored-by: Marcelo Jacobus <marcelo.jacobus@gmail.com>
2021-11-15 16:24:23 +00:00
Grace Park
5bf39459ca Updating Search using Primer Components (#22677)
* updating search icon

* remove no fill

* update fill color

* using ActionList and Overlay

* update to ActionList, Overlay, add Label to Breadcrumbs, and change Mark

* add search-results test data and move header search results to right

* make search results scrollable and fix max-width in header search

* update header search and styling updates

* add highlight

* update styling

* styling and lint errors

* fix lint error and fetch

* Update components/Search.tsx

* update label color

* remove bottom margin

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-11-12 12:25:47 -08:00
dependabot[bot]
15cbf8e063 Bump @babel/eslint-parser from 7.16.0 to 7.16.3 (#22751)
Bumps [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) from 7.16.0 to 7.16.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.16.3/eslint/babel-eslint-parser)

---
updated-dependencies:
- dependency-name: "@babel/eslint-parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-11-12 16:35:11 +00:00
Rachael Sewell
0244fda807 search improvements (#22443) 2021-11-10 11:11:28 -08:00
Rachael Sewell
a83c0cfd50 remove old unused scripts (#22650) 2021-11-08 17:43:59 +00:00
Rachael Sewell
1c196cdd42 test frontmatter properties too (#22642) 2021-11-05 20:05:55 +00:00
Rachael Sewell
8c7deebadc add script to remove stale translation files (#22555) 2021-11-05 01:00:54 +00:00
Rachael Sewell
c5df94c88b Crowdin broken liquid test (#22559) 2021-11-04 14:27:22 -07:00
Rachael Sewell
cbcd383323 add search QA tests (#22593) 2021-11-04 14:05:11 -07:00
Marcelo Jacobus
ed9e3d79cb Add test and script to ensure 1:1 parity of liquid tags between source and translation (#22472)
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-11-04 10:59:17 -03:00
Chris
bb20db6ed9 Update reset-known-broken-translation-files to ignore checked files sources from GitHub issue (#22576) 2021-11-03 19:32:07 +00:00
Rachael Sewell
95d02d7eef group translations scripts together (#22232) 2021-11-03 10:28:32 -07:00
Rachael Sewell
2f8283a79f remove german search indexes (#22554) 2021-11-02 17:55:58 -07:00
Robert Sese
06f9fa101c Add GHEC link check workflow (#22478)
* Add GHEC link checker workflow

* Update link check script for GHEC

* Remove stale comments
2021-10-29 20:50:22 +00:00
Mike Surowiec
eba366be21 update check-github-github-links.js to ignore specific link path (#22479) 2021-10-29 04:44:10 +00:00
Kevin Heis
567652b0e3 Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Peter Bengtsson
d4c4c46f95 search sync with popular-pages.json (#22353) 2021-10-26 10:08:14 -07:00
Rachael Sewell
1570dc66e6 add ghec version to graphql guides (#22314) 2021-10-22 10:05:17 -07:00
Kevin Heis
0fa35fe0f2 Deprecate allow issue (#22355)
* Update remove-liquid-statements.js

* Update remove-liquid-statements.js

* Update remove-liquid-statements.js
2021-10-21 21:56:02 +00:00
Peter Bengtsson
26e5ee8425 refactor unnecessary use of process.exit(1) (#21974) 2021-10-18 14:43:32 +00:00
Robert Sese
f7799cd3dd Allow 421 on warmup requests (#21973) 2021-10-07 21:44:03 +00:00
James M. Greene
bb0455962e Do not use build.status as a looping condition for Heroku deployment (#21909)
* Do not use `build.status` of 'pending' as a looping condition for Heroku deployment
* Don't wait for `appSetup.status` either
* Fix incorrect Octokit method usage in local deploy script
* Bump the number of allowable errors from 5 to 10
* More logging!
* Add an environment variable for easily increasing the number of allowed Heroku failures per phase of polling
2021-10-06 12:57:30 -05:00
James M. Greene
8771695531 Make the HEROKU_PRODUCTION_APP_NAME env var required for prod deployment (#21910) 2021-10-06 11:53:28 -05:00
James M. Greene
b4473a9dc6 Delete the 'create-app' module previously used for Docker deployment (#21906) 2021-10-05 18:12:48 -04:00
James M. Greene
9314c0ff94 Remove gha- staging app prefix for Actions-based deployments (#21799)
* Make the default app name prefix include the dash

* Remove the default app name prefix
2021-10-05 15:19:47 -05:00
Matt Pollard
307e8094ec Backport updated content from GitHub AE M2 megabranch and version for ghae-next (#21525) 2021-10-04 16:11:57 +00:00
James M. Greene
8d2e1ad577 Enable prod deployment via Actions (Take 2!) (#21852)
* Move concurrency control to top-level in prod deploy workflow

* Add 503 to the list of temporarily acceptable Heroku failure codes

* Add HEROKU_PRODUCTION_APP_NAME back into the prod deploy workflow
2021-10-01 13:37:46 -05:00
Grace Park
96ff67d756 Workflow to test docs.github.com links on github/github (#21601)
* run prettier

* removing files from test/integration

* update cron job to not start on the hour

* add github/github comment

* update comment

* updating to search by indices in the content rather than by line

* small updates and updating character max

* update name of script run

* updating to use api search code and get contents

* using api search code and get contents

* adding token check and .js

* remove blank line for title

* update issue body content

* update comment

* add support for GitHub.developer_help_url links
2021-10-01 17:23:58 +00:00
Marcelo Jacobus
aed6c1654f translation batch 1632491035 (#21717) 2021-09-30 11:53:04 +00:00
James M. Greene
7e954927e2 [DO NOT MERGE] Revert to no longer deploy to production via Actions (#21808)
* Update the production deployment workflow to target the main Heroku app

Without exposing our internal Heroku app name!

* Refactor the staging deployment script a bit to match more closely

* Use the HEROKU_PRODUCTION_APP_NAME Secret in the workflow

* Add a note about the newly required environment variable for production deployment into the local deploy script

* Add critical errors if the HEROKU_PRODUCTION_APP_NAME is missing

* Extract HEROKU_PRODUCTION_APP_NAME from process.env

* Revert the critical parts of PR #21807 to no longer deploy to prod via Actions

* Don't require HEROKU_PRODUCITON_APP_NAME
2021-09-29 15:29:53 -05:00
James M. Greene
90d030a41e Deploy to the primary production Heroku App via Actions (#21807)
* Update the production deployment workflow to target the main Heroku app

Without exposing our internal Heroku app name!

* Refactor the staging deployment script a bit to match more closely

* Use the HEROKU_PRODUCTION_APP_NAME Secret in the workflow

* Add a note about the newly required environment variable for production deployment into the local deploy script

* Add critical errors if the HEROKU_PRODUCTION_APP_NAME is missing

* Extract HEROKU_PRODUCTION_APP_NAME from process.env
2021-09-29 14:43:29 -05:00
James M. Greene
12134aa84b Use staging app name module for content changes table generation (#21805)
* Use the 'script/deployment/create-staging-app-name' module when creating the content changes table comments

* Remove the shebang from the non-runnable script helper module
2021-09-29 09:00:19 -07:00
James M. Greene
469e33cbb6 Allow Heroku 500 error codes while polling (#21795)
* Extract allowable Heroku error checks into a reusable function

* Add 500 to the list of allowable Heroku errors while polling
2021-09-28 21:00:03 +00:00
James M. Greene
1d0d782342 Production deploy script (#21768)
* Create a logic branch to deploy to production via a local script

* Ignore forceRebuild default value for production

* Add soft warnings for missing-but-not-critical env vars

* Only include the Preboot delay if the Fastly env vars are present

* Add some warning emojis ⚠️

* More emojis!

* Make FASTLY_* checks all independent

* Add more comments about additional env vars recommended for a local prod deployment
2021-09-27 22:17:21 +00:00
James M. Greene
c52671408b Do not pass null config vars to Heroku on AppSetup (#21766) 2021-09-27 15:47:04 -05:00
James M. Greene
deab27360c Announce if Heroku appears to be down (#21762) 2021-09-27 20:17:05 +00:00
James M. Greene
1024ede61d Explicitly unset the DOCUBOT_REPO_PAT Heroku config var when possible (#21751) 2021-09-27 18:22:02 +00:00
James M. Greene
a76f30e5f2 Move delay for Heroku Preboot to before marking deployment successful (#21736)
* Move delay for Heroku Preboot from post-deploy to pre-success

* Shorten arbitrary delay before first Fastly purge
2021-09-24 19:35:13 -05:00
Grace Park
9c9d47f508 Prod deployment workflow (#21223)
* add production deployment

* updating existing build

* remove state

* remove PR_URL and switch to main branch

* break out into build, prepare, and deploy

* update to download-artifact

* update staging to prod

* Actions production deployment redux (#21238)

* Simplify production deployment into a single Actions job

* Force esm to install

* Switch flag ordering to match staging deploy

* Use 'npm install' for the second installation to avoid deleting the prodDeps

* Apply Heroku upload fixes

* Include `.npmrc` file in builds to omit `optionalDeps`

* Remove download-artifact action

Co-authored-by: Grace Park <gracepark@github.com>

* Script updates to prod deployment (#21247)

* updating script to use latest sha

* changing back workflowRunLog

* remove line

* update error wording

* remove comment - using commit sha

* need release.id

* Update script/deployment/deploy-to-production.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* remove hydro

* Update script/deployment/deploy-to-production.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update .github/workflows/prod-build-deploy-pr.yml

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update script/deployment/deploy-to-production.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update script/deployment/deploy-to-production.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update script/deployment/deploy-to-production.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* updating spacing

* add 404/429 responses while polling Heroku API for prod

* removing nested ifs

* adding SOURCE_BLOB_URL

* update for early access

* add install dotenv

* need to add persist-credentials

* Testing GET request

* update request

* Rename workflow file to remove '-pr'

We are now triggering on pushes to 'main' rather than PR merges

* Remove the unnecessary workflow step to create a failure Status

Because the production deploy is done via a single workflow rather than a 2-part workflow chain, this is thankfully unnecessary

* Install all of the npm dependencies

We'll need them!

* Add the '-z' flag to 'tar' to gzip the tarball

* Pass the Heroku upload URL via env vars for security

Prevents potential injection attacks

* Log the deployment ID and log URL as deploy step outputs

* Take notice of Heroku polling resulting in failure statuses

* Add a note to consider waiting for Heroku Preboot

* Add a script and workflow step to purge Fastly

* update response to get sha

* Switch to Octokit functions instead of 'request' method

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-09-24 16:09:08 +00:00
Francis
53ec53d5ac fix: update ghesReleaseNotesSchema's module name
Closes https://github.com/github/docs-engineering/issues/920
2021-09-23 14:33:36 -07:00
Rachael Sewell
bbc5778e4a add new options to rest schema script (#21571) 2021-09-23 19:34:56 +00:00
James M. Greene
e29a965405 Display the reason for Heroku AppSetup failure (#21683) 2021-09-23 10:51:50 -05:00
James M. Greene
0c97550a77 Take notice of Heroku polling resulting in failure statuses (#21680) 2021-09-23 09:55:58 -05:00
Robert Sese
f6d85c6d64 Security: remove Docker PR build/deploy workflows (#21599)
* Remove Docker PR build/deploy workflows

* Remove supporting Docker deploy script
2021-09-17 23:17:17 +00:00
James M. Greene
b2c8af9d31 Secure early access staging deployment (#21450)
* Explicitly ensure the early access parent directories are created when cloning

* Use explicit --file flag with tar

* Remove security hole for Staging deployment by concatenating archives

* Fail the staging builds if *.js, .npmrc, or Procfile is changed in the open source repo

* docker build: extract user-code in separate directory

* Checkout PR base branch and install dependencies

* Remove one-off package installs

* Remove selective file checkout

* Don't persist git cloning credentials

It usually makes the clone of early access content fail in the later steps

* Update .github/workflows/staging-deploy-pr-docker.yml

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update .github/workflows/staging-deploy-pr-docker.yml

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Remove debugging step

* Best practice: Use environment variables to avoid potential injection attacks if the data was user-controlled

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
Co-authored-by: Robert Sese <sese@github.com>
Co-authored-by: Robert Sese <robert.sese@gmail.com>
2021-09-17 22:41:13 +00:00
James M. Greene
7ae1eea3b5 Undeploy without Environment cleanup (#21530)
* Ensure we handle multiple pages of Deployments
* Do NOT delete the Environment during undeploy
* Do NOT deploy/undeploy PRs on lock/unlock events
2021-09-15 15:11:48 +00:00