1
0
mirror of synced 2026-01-01 09:04:46 -05:00
Commit Graph

338 Commits

Author SHA1 Message Date
Robert Sese
918a0956e0 Update icon colors (#25189) 2022-02-09 18:25:23 +00:00
Mike Surowiec
e1a2860adb add shallow true to search to avoid triggering page data requests (#25184) 2022-02-09 16:23:10 +00:00
Robert Sese
a8565f507a Depend on the path for the tool switcher (#25018) 2022-02-04 22:12:38 +00:00
Robert Sese
62ce173b76 Fix when we show the 'All Enterprise Releases' link (#25002)
* Enterprise versions start with 'enterprise-server'

* Show only if all versions are ghes versions

* Show link if there's any ghes versioning
2022-02-04 21:59:02 +00:00
Robert Sese
c5f9788223 Version the 'All products' link (#24972)
* Don't show link no matter what version you're on

* Maintain current version in link

* No 'All products' link on homepage for all versions
2022-02-03 16:31:05 +00:00
Mike Surowiec
1d42bbebb3 catch sendBeacon failures and console.warn (#24990) 2022-02-03 16:26:52 +00:00
Lucas Costi
a7860a720f Change code-example test to not use Actions (#24979)
* Change code-example test to not use Actions

* Use discussions instead

* Use code-security, but make the 'more' test not an exact number

* Removed references to actions/code-examples.yml

* Update tests/browser/browser.js

Co-authored-by: Robert Sese <robert.sese@gmail.com>

Co-authored-by: Martin Lopes <martin389@github.com>
Co-authored-by: Robert Sese <robert.sese@gmail.com>
2022-02-02 22:32:39 -06:00
Peter Bengtsson
a34f2c3787 reduce flash of sign-up CTA button (#24933) 2022-02-02 22:36:56 +00:00
Grace Park
d78f1dfa5a Fix screen width - release notes (#24881)
* fix screen width

* center items

* set maxwidth

* set back to justify between

* adding overflow auto to default layout

* remove center alignment for release note content

* fix vertically align release candidate button

Co-authored-by: Rachael Sewell <rachmari@github.com>
2022-02-02 21:28:47 +00:00
Laura Coursen
4ede312204 Add early access docs for GEI-CLI (#24592) 2022-02-02 14:25:05 -06:00
Rachael Sewell
0d20dc0972 remove unused variables (#24847)
* remove unused variables

* moving label to center

* update span to h3

Co-authored-by: Grace Park <gracepark@github.com>
2022-01-31 23:50:11 +00:00
Grace Park
c7ff324110 Release Notes Primer Update: Remove top navigation buttons convert download link to button (#24844)
* remove navigation buttons at top and convert download link to button

* remove background color
2022-01-31 22:17:23 +00:00
Rachael Sewell
bd0cc83d73 use accessible text for view all links (#24747) 2022-01-31 22:02:29 +00:00
Rachael Sewell
845de4f29d add underline to categories in all docs section (#24818) 2022-01-31 18:22:49 +00:00
Grace Park
934b255119 add keyboard focus to scroll top and remove wording to keep one button (#24817) 2022-01-31 17:45:44 +00:00
Anosike Osifo
ec73762b3e Add GHEC Trial CTA to header of docs.github (#23324)
* Add GHEC Trial CTA to header of docs.github

* use i18n logic

* add signup cta

* add signup cta

* Update the Trial CTA href to allow users choose trial plan

* Update logic to conditionally display signup CTA. Also remove GH EC Trial CTA

* update logic to use && operator

* fix wrapping search bar bug
2022-01-28 20:15:54 +00:00
Peter Bengtsson
9a3adcff9c lazy highlight json examples on Webhooks page (#24785)
* lazy-highlight JSON examples on Webhooks page

* it works

* using intersectionobserver

* explain in  formatAsJsonCodeBlock

* fix tests
2022-01-28 12:20:56 -05:00
Robert Sese
abe3881aa3 a11y: link style updates (#24680)
* Remove opacity classes on REST pages

* Underline links in article page content

* Typo 🔨

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-01-28 11:11:23 -06:00
Rachael Sewell
ef4dee2e7d Revert "Revert "rest/reference/repos#statuses redirect"" (#24559) 2022-01-27 22:09:20 +00:00
Rachael Sewell
f9095482cf accessible description for learning paths (#24742) 2022-01-27 22:01:49 +00:00
Robert Sese
60aa8347f5 Bold-ify supported release card links (#24736) 2022-01-27 15:46:32 -06:00
Robert Sese
850aa34e05 a11y: set focus after submitting survey (#24666)
* Set focus after submitting survey

* Add role=status to success message
2022-01-26 18:14:39 +00:00
Peter Bengtsson
b32df3dfb9 display title if no shortTitle on product landing pages (#24657)
* display 'title' if no 'shortTitle' on product landing pages

* remove pointless shortTitles

* Revert "Fix search sync (#24620)"

This reverts commit 16c9fc3ec5.

* undo

* undo sample changes
2022-01-26 16:30:45 +00:00
Grace Park
8374263842 a11y: Remove redundant banner (#24605)
* remove redundant banner

* adding flex-1
2022-01-25 17:32:34 +00:00
Robert Sese
96118839a9 Make scrollable code blocks focusable (#24607) 2022-01-25 17:26:34 +00:00
Grace Park
a3b81bb93c restructure footer and header (#24601) 2022-01-24 15:19:45 -08:00
Grace Park
66d8e2b15c skip link for screen readers to main content (#24599) 2022-01-24 14:19:15 -08:00
Grace Park
2ae7d02f1a adding keyboard focus to survey buttons (#24595) 2022-01-24 14:11:53 -08:00
Grace Park
a0a24b605c Keyboard Focus for Guides Page: Learning Paths (#24483)
* remove useEffect on ref

* updating keyboard focus for guides page
2022-01-21 16:33:03 +00:00
Grace Park
ddc5e19570 remove useEffect on ref (#24470) 2022-01-20 21:06:24 +00:00
Grace Park
eb776f64e4 Small accessibility changes - adding ul to li (#24449)
* adding ul to li

* move ul for just the mobile picker
2022-01-20 17:54:49 +00:00
Peter Bengtsson
f2f679550d display possible search error (#24429)
* display possible search error

* feedbacked
2022-01-19 21:41:17 +00:00
Robert Sese
d0db00cd98 a11y: match picker label with current selection (#24321)
* Match label with selection

* defaultText is a better default

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* No longer used

* Also no longer used

* No longer used in the dropdown pickers

* Add translation strings for pickers

* Use translated strings in picker components

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-19 18:43:31 +00:00
Robert Sese
54af81acd5 a11y: update code example search (#24226)
* Search on submit

* Should be a ul

* Fix broken link

* No search on change event

* Add translation strings

* Add role for the 0 results message

* Update test with new search behavior

* Make search input a controlled component

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Trim whitespace in search text

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Better variable names

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update visible results count in useEffect

* Control the input's value with the typed state

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Inline the submit handler

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-19 12:53:50 +00:00
Robert Sese
1c768fe9a0 a11y: even more headings adjustments (#24315)
* Adjust Enterprise supported release card heading

* Adjust learning track headings

* Adjust guide list card headings
2022-01-14 20:08:55 +00:00
Robert Sese
cc69799558 a11y: landing page headings adjustments (#24295)
* Adjust heading level and only heading with intro text

* Adjust heading level

* Adjust code example and guide card heading levels

* Adjust tests for new heading levels

* Adjust rendering test for new heading levels
2022-01-14 17:23:05 +00:00
Grace Park
d5097397c8 underline links on toc pages (#24217) 2022-01-11 20:48:35 +00:00
Grace Park
f5c615cbd0 Guides List markup and Link Icon in Permalink Headings (#24211)
* list markup for article cards and learning paths

* adding link icon to section permalinks
2022-01-11 11:38:57 -08:00
Grace Park
d2494c3e2d Keyboard focus on Guides Pages (#24209)
* accessibility: make label autofocus on dropdown when clicked

* update to div element

* fix keyboard focus on X more guides and load more guides

* tabIndex is optional
2022-01-11 19:26:12 +00:00
Grace Park
69543377cb Accessibility: Guides Pages, types/topics dropdown (#24185)
* accessibility: make label autofocus on dropdown when clicked

* update to div element
2022-01-11 17:53:55 +00:00
Peter Bengtsson
4947218cba fix React key uniqueness in Breadcrumbs (#24182) 2022-01-11 01:56:30 +00:00
Rachael Sewell
a340162d84 reorganize repository apis (#23728)
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-11 11:53:12 +10:00
Robert Sese
d31d6a5b4e a11y: add title text for view all links (#24193)
* Add optional 'view all' title text in the context

* Use viewAllTitleText in ArticleList

* Set viewAllTitleText for sections with 'view all' links
2022-01-11 01:30:10 +00:00
Robert Sese
fcc9b904dd Comment on why we do manual email validation (#24192)
* Comment on why we do manual email validation

* One 'do'
2022-01-10 22:47:46 +00:00
Grace Park
0b33fbb167 Fix max height for minitocs (#24163)
* update max-height

* set fixed max height for mini tocs to make scrollable from top
2022-01-08 01:48:02 +00:00
dependabot[bot]
ce8f21487b Bump @primer/components from 32.1.0 to 33.1.0 (#24023) 2022-01-08 00:25:04 +00:00
Grace Park
e37fc2edd9 Accessibility footer color color contrast ratio (#24158)
* programmatically group breadcrumbs

* forgot to commit li
'
'

* adding inline-block

* add emphasis color on border to meet accessibility color contrast ratio

* update border for footer buttons to meet accessibility color contrast ratio

* run prettier
2022-01-07 16:20:54 -08:00
Robert Sese
76b0b5ade1 a11y: survey email validation (#24159)
* Add email error state checking

* Clear email error on cancel

* Disable submit if email is invalid

* Add Primer-ized error message

* Add aria attributes

* Better function name
2022-01-08 00:01:42 +00:00
Grace Park
47de433865 Accessibility Search updates and additional minor changes (#24136)
* update to use heading markup

* updating to h3 for accessibility

* increase opactiy to meet 5.5:1 color contrast ratio

* update opacity to meet color contrast ratio

* update styling to match original but use heading markup

* remove aria-hidden for accessibility

* add h1 title search results and update scroll tip colors

* add number of matches

* remove no results since we are showing 0 results

* add overflow to fix border bottom on version search

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* incorporating feedback and update padding

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-07 21:29:49 +00:00
Grace Park
a4c5d58507 Accessibility: Breadcrumbs (#24151)
* programmatically group breadcrumbs

* forgot to commit li
'
'

* adding inline-block
2022-01-07 12:01:52 -08:00