1
0
mirror of synced 2025-12-21 19:06:49 -05:00
Commit Graph

17 Commits

Author SHA1 Message Date
Sarah Schneider
7bd169f35c be more flexible so we do not rewrite hardcoded deprecated versions OR supported 2021-04-26 16:01:44 -04:00
Sarah Schneider
7343b88e63 divs mess up the DOM and create empty <p> tags; use spans instead so they stay nested in <p>s 2021-04-22 11:15:01 -04:00
Sarah Schneider
6c51a6b970 also pass the processed selector, not the original selector 2021-04-21 15:00:51 -04:00
Sarah Schneider
5ddaafb6ba use wrapper from options instead of hardcoded div 2021-04-21 14:43:24 -04:00
Sarah Schneider
2aa1347bc6 add option to return cheerio object from renderContent instead of html 2021-02-23 20:30:09 -05:00
Rachael Sewell
01e52046f0 migrate away from AWS S3 (#17669) 2021-02-12 10:25:45 -08:00
Jason Etcovitch
39e0e0dda1 Use Liquidjs instead of Liquid (#16743)
* Install liquidjs, uninstall liquid

* Comment a bunch of stuff out to get going

* Fix invalid includes

* Fix all includes (path => 'path')

* Get the homepage to render

* Do link-in-list kinda

* Revert "Fix all includes (path => 'path')"

This reverts commit d6fead646353aa5041d9229470a62a1d487456b9.

* Support non-dynamic partials

* Extract getTemplate helper

* Do remaining custom Liquid tags

* Fix some custom tag bugs

* Moar bugs

* Re-add link tag

* Cleaner diff

* Actually fix extended markdown tags

* Fully comment out version matchers

* Smaller diff

* Rely only on Liquid internals for conditionals

* Use new operators option in Liquid engine

* Fix link.js

* Don't need options

* Updoot to the right doot

* Fix some bugs

* Fix another bug

* Pass a test

* Fix the translate bits

* Adjust a test

* Fix another invalid Liquid bug

* Two more borked translations

* Found some more

* Don't need this change

* Revert "Don't need this change"

This reverts commit a916d619747f0492865a69c3e237c97c4d4e7fad.

* This should fix the broken links

* Missed one

* Revert "This should fix the broken links"

This reverts commit e6c2cc0d9055d958706260d57edbe293281c150e.

* Revert "Missed one"

This reverts commit bbe1f23baf16e020f6f7931589decb1afc75dfbd.

* Updoot liquidjs
2021-02-08 12:58:51 -05:00
Jason Etcovitch
f2c08b31a8 Static method isn't a thing on this version? (#17580) 2021-01-29 17:38:50 -05:00
Jason Etcovitch
653a57aa00 Don't use slugger singleton (#17579) 2021-01-29 17:15:08 -05:00
Jason Etcovitch
53ad15c959 Use hast-util-to-string to get heading text (#17576) 2021-01-29 21:42:35 +00:00
Jason Etcovitch
bd63f47636 Remove cheerio from Page#render (#17566)
* Write our plugin

* Include it

* Move the RegEx

* Don't rewriteLocalLinks with cheerio anymore

* Process after HTML ast is generated

* Use the same logic as before, just to see if it'll pass

* Don't require languageCode/version

* Only work on local links

* Needs an href

* Only update href if there's a new one to use

* Check for node.properties

* Some links are just mean

* Move use-english-headings to be a plugin

* Bail if no englishHeadings were passed

* Install rehype-wrap

* Wrap ol > li img in div.procedural-image-wrapper

* Test for platform without cheerio

* Use a plugin for rewriteAssetPathsToS3

* Remove cheerio from page.render

* Fix require paths

* SImplify

* Fix some 🐛s

* Use our own rehype-wrap

* Move rewriteAssetPathsToS3 after HTML AST

* Remove some console logs

* Fix check for includesPlatformSpecificContent

* Rename ast => tree
2021-01-29 15:44:50 -05:00
Jason Etcovitch
989006bab5 Move the rewriteLocalLinks behavior to an AST pipeline plugin (#17550)
* Write our plugin

* Include it

* Move the RegEx

* Don't rewriteLocalLinks with cheerio anymore

* Process after HTML ast is generated

* Use the same logic as before, just to see if it'll pass

* Don't require languageCode/version

* Only work on local links

* Needs an href

* Only update href if there's a new one to use

* Check for node.properties

* Some links are just mean
2021-01-29 15:36:17 +00:00
Jason Etcovitch
2572d7bb85 Remove hubdown and use our own markdown pipeline (#17551)
* Uninstall hubdown, install unified deps

* Create create-processor

* Use it

* Update a doc

* Tweak the language

* Use the same versions that hubdown used
2021-01-28 17:06:19 -05:00
Vanessa Yuen
b46da8dfc7 Sublanding page all guides section (#16869)
* get link liquid tag to accept variables as param

* new liquid tag `link_as_article_card`

* refactor link liquid tag slightly so we can control what props get rendered

* generalize filterCodeExample to use in all guides section

* pass in `js-filter-card-max` instead of hardcode max

* tweaks and add `data` to CSP for images

* add liquid tag tests

* add some browser tests for card filters

* we still need to rely on `getPathWithLanguage` for hrefs that already have the language code embedded


Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-18 12:23:23 +00:00
Vanessa Yuen
eaacb54422 small liquid link tag cleanup (#17280)
* remove unnecessary `render` methods
* we don't use `link_with_short_title` anymore
* remove `shortTitle` option
* remove ink_with_short_title tag test
2021-01-15 13:24:39 +00:00
Jason Etcovitch
ca127e987e Change release notes colors (#16923)
* Use pastel colors

* Whit text

* Slugify/anchor section headings

* Use classes instead of style attributes

* Use fancy-pants SCSS

* Simplify a tad

* TIL text-inherit helper

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>

* Remove redundant `style` attr

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
2020-12-14 15:06:03 +00:00
Jason Etcovitch
4484068e01 Move render-content code to this repo (#16544)
* Move render-content files in here

* Replace existing file with nested index.js

* Copy in tests and jest-ify

* Update docs

* Uninstall @github-docs/render-content

* Bring over README

* Add missing dependencies

* Fix require paths
2020-11-25 11:20:23 -05:00