1
0
mirror of synced 2026-01-05 21:04:17 -05:00
Commit Graph

477 Commits

Author SHA1 Message Date
James M. Greene
2dbae93c53 Try to prevent late/duplicate response errors (#20077)
* Ensure all Express 'next' calls include 'return's

* Add headersSent checks during archived versions flow

* Return a 404 earlier if archived resource fetch fails

* Short-circuit responses for archived stuff

* Be more careful about responding to and short-circuiting after search requests

* Fix tests
2021-06-28 19:31:54 +00:00
Mike Surowiec
9471394406 Disable client-side link transitions (#20141)
* add prop to disable client-side transition

* fix: disableClientTransition by default until we can figure out caching issue

* skip the next/link test
2021-06-24 14:35:23 -07:00
Rachael Sewell
6d248082b5 sidebar style updates (#19929) 2021-06-24 11:15:24 -07:00
Rachael Sewell
52cf583bdd add short titles to frontmatter (#20131) 2021-06-24 11:02:53 -07:00
Sarah Schneider
cffafaf748 Merge branch 'main' into revert-20087-revert-20069-fix-homepage-versions-dropdown 2021-06-24 12:40:17 -04:00
Kevin Heis
d3403e8653 Address goofy exports (#20113)
* Address a goofy export

* Fix more exports

* Change two exports
2021-06-24 14:59:06 +00:00
Sarah Schneider
d3b794f5b7 remove out of date test 2021-06-24 10:26:22 -04:00
Sarah Schneider
7de66fe4ef Merge branch 'main' of github.com:github/docs-internal into script-to-use-short-versions 2021-06-24 10:14:50 -04:00
Matt Pollard
46cca06438 Merge branch 'main' into revert-20087-revert-20069-fix-homepage-versions-dropdown 2021-06-24 08:57:17 +02:00
Matt Pollard
4e99bceff3 Change title for admin product from "GitHub Enterprise" back to "Enterprise administrators" (#20089) 2021-06-24 06:15:42 +00:00
Sarah Schneider
3b78be7ff0 Merge branch 'main' into revert-20087-revert-20069-fix-homepage-versions-dropdown 2021-06-23 18:55:17 -04:00
Kevin Heis
a92d820888 Remove remaining JSON requires (#20110)
* Remove remaining JSON requires

* Lint

* Update feature-flags.js
2021-06-23 14:57:50 -07:00
Sarah Schneider
7e3e75616c Merge branch 'main' of github.com:github/docs-internal into feature-versioning 2021-06-23 15:59:37 -04:00
Sarah Schneider
d454e4032e Merge branch 'main' of github.com:github/docs-internal into feature-versioning 2021-06-23 15:16:52 -04:00
Sarah Schneider
a8709c42ee lint 2021-06-23 15:16:16 -04:00
Sarah Schneider
2427f92893 write tests to ensure that ghes versioning in a feature gets combined with ghes versioning frontmatter, and does NOT overwrite it 2021-06-23 15:03:12 -04:00
Sarah Schneider
5e10cea9ac Merge branch 'main' of github.com:github/docs-internal into script-to-use-short-versions 2021-06-23 14:45:10 -04:00
Grace Park
06ebe03c9b one more update on createApp change 2021-06-23 11:25:29 -07:00
Grace Park
bb86a86459 Merge branch 'dynamic-esm' of https://github.com/github/docs-internal into dynamic-esm 2021-06-23 11:21:28 -07:00
Grace Park
fcf1fdd682 adding james feedback to add single app instance 2021-06-23 11:21:20 -07:00
Grace Park
00ed3e945a Update tests/unit/versions.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-06-23 11:20:35 -07:00
Grace Park
cb69acf071 Update tests/unit/products.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-06-23 11:20:26 -07:00
Grace Park
cbed05ad17 usefaketimers on server test 2021-06-23 11:13:06 -07:00
Grace Park
cbdd722cac Merge branch 'main' into dynamic-esm 2021-06-23 10:46:25 -07:00
Grace Park
6c0b43a4bb updating libapp in one script and tests 2021-06-23 10:46:10 -07:00
Grace Park
24bf653228 Update tests/unit/versions.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-06-23 10:21:04 -07:00
Grace Park
dce2a7b629 Update tests/unit/products.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-06-23 10:20:43 -07:00
Sarah Schneider
af018389ce add tests to ensure that the homepages have the expected links 2021-06-23 13:09:04 -04:00
Sarah Schneider
15e33f05e7 Revert "Revert "Fix homepage versions dropdown" (#20087)"
This reverts commit f9f0b2ce86.
2021-06-23 10:12:36 -04:00
Matt Pollard
f9f0b2ce86 Revert "Fix homepage versions dropdown" (#20087) 2021-06-23 09:11:51 +02:00
James M. Greene
7ee7a1aaaa Merge branch 'main' into feature-versioning 2021-06-22 15:28:34 -05:00
Grace Park
bcb11e607e Merge branch 'main' into dynamic-esm 2021-06-22 12:55:26 -07:00
Sarah Schneider
d0f130734e update tests 2021-06-22 15:16:31 -04:00
Grace Park
26f70c5563 updating tests for usefaketimers 2021-06-22 11:53:47 -07:00
Grace Park
23f586bb93 merge and fix conflicts 2021-06-22 11:41:10 -07:00
Grace Park
d3d1902414 Merge pull request #20017 from github/upgrade-esm
Enforce and Move to Top Level require
2021-06-22 11:27:48 -07:00
Sarah Schneider
489031c805 add a note about linting test 2021-06-22 13:44:22 -04:00
Mike Surowiec
a24d01f78a Fix NextJS 500s (#20048)
* feat: allow server to contextualize request when on a /_next/data path

* add client side routing test, run lint

* enable nextjs client side routing
2021-06-22 17:30:40 +00:00
Sarah Schneider
0c35c0233b Merge branch 'main' of github.com:github/docs-internal into script-to-use-short-versions 2021-06-22 12:50:47 -04:00
Sarah Schneider
1188fa557e Merge branch 'main' into feature-versioning 2021-06-22 11:07:27 -04:00
Sarah Schneider
c4d6ae71a0 fix versions schema 2021-06-22 10:40:02 -04:00
Sarah Schneider
04b6c07c8e Merge branch 'main' of github.com:github/docs-internal into feature-versioning 2021-06-22 10:26:02 -04:00
Sarah Schneider
c34e3e06e8 Merge branch 'main' into fix-early-access-tocs 2021-06-22 10:05:52 -04:00
Grace Park
ee58981b6a Merge branch 'main' into dynamic-esm 2021-06-21 13:35:30 -07:00
Grace Park
4850cceca2 Merge branch 'dynamic-esm' of https://github.com/github/docs-internal into dynamic-esm 2021-06-21 13:02:32 -07:00
Grace Park
2385f1407d updating faketimers to be used in tests with setTimeout 2021-06-21 13:02:18 -07:00
Mike Surowiec
b084dbc23d React: Enable all remaining pages (#20012)
* enable all remaining pages

* update tests for survey, filter card dropdowns

* fix search test

* fix: mobile search layout

* update sidebar test

* fix: learning track page is optional

* fix broken links
2021-06-21 19:52:58 +00:00
Grace Park
0beb64935f Merge branch 'main' into dynamic-esm 2021-06-21 12:12:35 -07:00
Grace Park
9a00195746 adding useFakeTimers 2021-06-21 12:11:15 -07:00
hubwriter
287a857511 Update Packages docs for Container registry GA (#19987)
* Update packages landing page

* Docs updates for Container reg GA

* Update billing note

* Delete CR feature preview files

* Fix broken link

* Remove github.ref from workflows

See https://github.com/github/docs-internal/pull/19953

* Put 3rd party action message in a reusable

* Update content/billing/managing-billing-for-github-packages/about-billing-for-github-packages.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/learn-github-packages/deleting-and-restoring-a-package.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/working-with-a-github-packages-registry/migrating-to-the-container-registry-from-the-docker-registry.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/working-with-a-github-packages-registry/migrating-to-the-container-registry-from-the-docker-registry.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/working-with-a-github-packages-registry/working-with-the-container-registry.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* fix bug with wbr breaking a link inside a code tag inside a table

* Make revisions suggested by Nilofer

See https://github.com/github/docs-internal/pull/19987/files#r655014673

* Mention that migration is happening gradually

* Reapply change suggested by Shayne

* Fix punctuation

* Remove bad link

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
2021-06-21 15:10:12 -04:00