Grace Park
576cf5c345
Update spacing for header ( #39059 )
2023-07-14 16:13:58 +00:00
Peter Bengtsson
2ec905fc77
trailingCommas:all on prettier ( #38888 )
2023-07-11 11:44:52 +00:00
Peter Bengtsson
9041a57ae5
Refactor how currentProductTree works ( #37808 )
...
Co-authored-by: Grace Park <gracepark@github.com >
2023-07-10 19:26:10 +00:00
Peter Bengtsson
8216de8f87
Remove banner to say the translations is incomplete ( #38634 )
2023-06-28 11:55:00 +00:00
Kevin Heis
f7fbba9074
Set cookies consistently ( #37819 )
2023-06-14 18:20:59 +00:00
Peter Bengtsson
d92c098daa
Stop using currentProductTree in Header component ( #37737 )
2023-06-12 18:14:26 +00:00
Kevin Heis
ab91bc6b43
Move more REST files into src ( #37026 )
...
Co-authored-by: Rachael Sewell <rachmari@github.com >
2023-05-11 17:17:57 +00:00
Steve Ward
8e1900b3f6
Remove Desktop update banner ( #36945 )
2023-05-09 12:36:22 +00:00
Kevin Heis
022c8b03e6
Add aria-label to external site icons ( #36269 )
2023-04-07 17:12:11 +00:00
Peter Bengtsson
b6b99c8d9a
Remove some unnecessary imports ( #36260 )
2023-04-07 14:30:41 +00:00
Kevin Heis
babb4a11ad
Underline links in deprecation banner ( #36212 )
2023-04-05 21:04:42 +00:00
Kevin Heis
68e29e17f6
Move search files to src ( #35822 )
...
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2023-04-03 17:14:26 +00:00
Peter Bengtsson
9ffd1e365c
Revert "let's not be dangerous 💥 " ( #35659 )
2023-03-17 16:00:21 +00:00
Evan Bonsignori
b3c8147bf6
let's not be dangerous 💥 ( #35635 )
2023-03-16 20:26:18 +00:00
Grace Park
f15aaee17c
Upgrade primer react and primer css to use TreeView ( #35408 )
2023-03-09 22:12:02 +00:00
Evan Bonsignori
3f9651fbdf
react page translation audit fixes ( #35071 )
2023-03-01 07:28:26 +00:00
Robert Sese
e5370a5990
Feature Branch: Global Nav Phase 2 ( #34359 )
...
Co-authored-by: Grace Park <gracepark@github.com >
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com >
2023-02-13 17:37:47 +00:00
Grace Park
302b3a0663
Fixing mobile search header ( #34326 )
2023-02-01 18:21:18 +00:00
Grace Park
6b375939f3
Remove aria-hidden for accessibility ( #34350 )
2023-02-01 18:04:16 +00:00
Grace Park
95c3e494fc
Update margins in header ( #34301 )
2023-01-31 18:25:46 +00:00
Grace Park
ef2efb0636
Feature Branch: Global Nav Phase 1 ( #33465 )
...
Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com >
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com >
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2023-01-31 17:49:50 +00:00
Laura Coursen
2b1689b43e
Add instructions for updating GitHub Desktop to resolve crash at launch ( #34272 )
...
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
2023-01-30 18:06:42 +00:00
Peter Bengtsson
862172e8af
only send the minimal language needed as prop ( #32765 )
...
Co-authored-by: Grace Park <gracepark@github.com >
2023-01-04 19:43:37 +00:00
Grace Park
baa53b778f
Picker refactor ( #33113 )
...
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2022-12-07 23:17:06 +00:00
Kevin Heis
6b1ac124d8
Update "preferredlang" to "user_language" ( #33045 )
2022-11-30 17:51:51 +00:00
Grace Park
e3f8f71c42
Rest api versioning redo ( #33011 )
...
Co-authored-by: Rachael Sewell <rachmari@github.com >
Co-authored-by: Sarah Edwards <skedwards88@github.com >
Co-authored-by: Grace Park <gracepark@Graces-MacBook-Pro-2.local >
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com >
Co-authored-by: Sarah Schneider <sarahs@github.com >
2022-11-28 11:55:02 -08:00
Peter Bengtsson
dd120617ef
no language drop-down on early-access docs ( #32749 )
2022-11-18 16:46:52 +00:00
Grace Park
0ed7777736
Bring back wip temporarily for the dark ship of fr, ru, ko, and de ( #32539 )
2022-11-11 00:25:50 +00:00
Peter Bengtsson
26291a6e52
remove pageVersionTitle from page context data ( #32453 )
2022-11-10 13:38:40 +00:00
Peter Bengtsson
cb97fb4db3
Search result widget expands the whole page down ( #30101 )
2022-08-19 12:24:09 -04:00
Peter Bengtsson
8765c628ff
dedicated search results page (redux) ( #29902 )
...
* dedicated search results page (redux)
* Update SearchResults.tsx
* adding pagination
* fix pagination
* say something on NoQuery
* better Flash
* tidying link
* small fixes for results
* debug info
* l18n the meta info
* inDebugMode
* basic jest rendering of the skeleton page
* basic jest rendering test
* fix content tests
* better document title
* fix tests
* quote query in page title
* use home page sidebar
* something when nothing is found
* parseInt no longer needs the 10
* fix linting tests
* fix test
* prettier
* Update pages/search.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
2022-08-19 13:36:55 +00:00
Kevin Heis
ca61b3465a
Use color_mode for gating "sign up" button ( #29901 )
...
* Use color_mode for gating "sign up" button
* Update useHasAccount.ts
* Update useHasAccount.ts
* Update useHasAccount.ts
2022-08-12 18:18:58 +00:00
Peter Bengtsson
5084160024
correct language link in header notification ( #29799 )
2022-08-10 15:52:24 +00:00
Kevin Heis
101e7155c8
userLanguage in browser instead of XHR ( #29782 )
...
* userLanguage in browser instead of XHR
* refactors on pr 29782 (#29798 )
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2022-08-10 15:28:21 +00:00
Peter Bengtsson
a1e3866fa5
don't get available languages from session ( #29715 )
...
* don't get available languages from session
* update useSession
* one more fix
2022-08-08 11:13:27 -04:00
Kevin Heis
56aa9ea094
Move use session to its own hook file ( #29641 )
...
* Move use session to its own hook file
* Trying useSWR
* Try one hour html cache
* blah blah lint
* Update to include loading state
* Update components/hooks/useSession.ts
Co-authored-by: Peter Bengtsson <peterbe@github.com >
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2022-08-05 14:47:10 +00:00
Evan Bonsignori
ec76c796bb
fix: nav scroll on mobile
2022-07-29 16:06:15 -07:00
Kevin Heis
0886faddac
Move language context to browser/session ( #29433 )
2022-07-28 18:50:46 +00:00
Kevin Heis
13093f421d
Change sign up button to browser-side only ( #29400 )
...
* Change sign up button to browser-side only
* Remove console.log
* Try removing components/context/DotComAuthenticatedContext.tsx, I don't think anything else is using it
* Revert "Try removing components/context/DotComAuthenticatedContext.tsx, I don't think anything else is using it"
This reverts commit 64d72c5dcb2efc67273a84fed371ff2ecc6c6f43.
2022-07-27 13:37:37 -07:00
Peter Bengtsson
b1226676e7
Picker sends just the selected value ( #29191 )
2022-07-19 18:06:55 -04:00
Grace Park
822fe2926b
Megabranch: Upgrade primer/react ( #28458 )
...
* upgrade primer/react
* upgrade
* using deprecated
* remove lib"
* Upgrade primer/react: Upgrade Label (#28502 )
update Label to primer/react 35.2.2
* fix merge conflicts
* primer/react v35: update ActionList (#28467 )
* Update to v35 ActionList for LearningTrack
* Update to v35 ActionList for ArticleList
* Update to v35 ActionList for ProductArticleList
* Update to v35 ActionList for TableOfContents
* Update to v35 ActionList for ProductCollapsibleSection
* Update to v35 ActionList for RestCollapsibleSection
* Update to v35 ActionList for SidebarHomepage
* Update to v35 ActionList for MiniTocs
* Update to v35 ActionList for Search
* Extra div for rendering test
* One less div for rendering test
* All the style updates for v35 ActionList
* Works without setting as an li which is already the default (didn't before for some reason)
* Use deprecated ItemInput for now
* Picker update for primer/react (#28485 )
* update picker
* inline picker for mobile
* set width to auto
* Update components/ui/Picker/Picker.tsx
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
* update
* Update Picker.tsx
* update onselect
* checking language code
* move language cookie setting to language picker
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
* Resolve package merge conflicts
* fresh npm install
* Primer update UnderlineNav (#28582 )
* update underlinenav for primer/react update
* update tests
* update switches test
* update one last label
* update header test"
* remove href in underlinenav
* update rendering tests
* update cursor
* primer/react v35: update DropDownMenu to ActionMenu (#28576 )
* Update to v35 ActionMenu for ArticleCards
* Update to v35 ActionMenu for Search
* Set button to inline-block
* Put the props on the overlay
* Update test for ActionMenu markup
* update package
* update package lock
* primer/react v35: CodeLanguagePicker update from SelectMenu to ActionMenu (#28625 )
* Use octicon for menu down arrow
* Update to v35 ActionMenu for CodeLanguagePicker
* update to SubNav
Co-authored-by: Grace Park <gracepark@github.com >
* update package-lock
Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com >
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
2022-07-11 11:51:18 -07:00
Matt Pollard
ab1f8b0ee2
First responder bug fixes for 2022-05-20 ( #27875 )
2022-05-23 15:41:33 +00:00
Peter Bengtsson
18504871b9
cache full rendering ( #25424 )
...
* cache full rendering
* still not working with gzip
* progress progress progress
* smaller
* hacky progress
* small fixes
* wip
* lock file
* wip
* wip
* package-lock updates
* wip
* search DOM in lowercase
* simplify
* with instrument
* improve test coverage
* mutateCheeriobodyByRequest
* fix
* remove renderContentCacheByContex
* disable render caching in sync-search
* diables things in github/github link checker
* gzip lru
* tidying up
* updated
* correct tests
* fix: move userLanguage to LanguagesContext
* Revert "fix: move userLanguage to LanguagesContext"
This reverts commit d7c05d958c71eaad496eb46764eb845d80b866ca.
* contexts ftw
* fixed rendering tests
* oops for got new file
* nits addressed
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com >
2022-05-23 12:12:09 +00:00
Grace Park
10fea98af5
Search updates larger font ( #27838 )
...
* removing search from home page and adding to header
* remove homepage search
* adding description
* update to f5
* remove homepage search test
* removing homepage search rendering test
* showing preview of larger font
* update wording at breakpoint
* update to short description everywhere
* Update components/homepage/HomePageHero.tsx
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com >
* remove unnecessary stylesheet
* Update data/ui.yml
Co-authored-by: Janice <janiceilene@github.com >
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com >
Co-authored-by: Janice <janiceilene@github.com >
2022-05-20 12:12:36 -07:00
Sarah Schneider
a9d3390c2f
change hiddenNoBanner to noEarlyAccessBanner
2022-05-13 16:35:33 -04:00
Sarah Schneider
2962666b55
update banner component
2022-05-13 12:47:11 -04:00
Robert Sese
3404349081
Fix sticky header issue in Firefox ( #27159 )
...
* Redundant sticky?
* update zindex to bring scroll button up
Co-authored-by: Grace Park <gracepark@github.com >
2022-04-22 21:31:12 +00:00
Grace Park
b98c83e924
REST operations sidebar ( #26225 )
...
* testing out a rest operations sidebar
* cleanup
* renamed 5 files
* renamed 5 files
* set redirect_from on 5 files
* renamed 1 files
* renamed 1 files
* renamed 3 files
* renamed 1 files
* renamed 1 files
* renamed 3 files
* renamed 1 files
* renamed 2 files
* renamed 1 files
* renamed 4 files
* renamed 15 files
* renamed 2 files
* renamed 6 files
* renamed 1 files
* renamed 4 files
* renamed 7 files
* renamed 1 files
* renamed 3 files
* renamed 3 files
* renamed 1 files
* renamed 5 files
* renamed 1 files
* renamed 1 files
* renamed 3 files
* renamed 4 files
* renamed 1 files
* renamed 1 files
* renamed 2 files
* renamed 4 files
* renamed 1 files
* renamed 1 files
* renamed 1 files
* renamed 6 files
* renamed 6 files
* renamed 4 files
* move files
* adding more
* updating to add restcontext and start of removing data/reusables/rest-reference
* removed data/reusables
* add a RestMiniTocItem and updating the filtering to add a subcategory so all manually added H3s are in mini tocs in addition to operations
* remove console log
* [WIP]: REST New Proposal Sidebar (#26471 )
* saving
* update sidebar
* remove console log
* update guides and overview
* import Category for category level rest pages
* update undefined restOperations
* update restOperationData category and subcategory levels"
* minor updates
* update get mini toc items function
* updating REST context for sidebar
* updating rest data
* remove console logs
* WIP: mini-toc-ing the sidebar
Co-authored-by: Robert Sese <rsese@github.com >
* A little cleanup
* Fix first subcategory link and add some comments
* updating anchor links in sidebar
* adding updates
* remove standalone
* update product and maptopic pages using article context
* add conditional link wrapper
* fix sidebar toggle and versions for enterprise admin
* update versions per subcategory
* Highlight sidebar link for current page
* Update miniToc hash links and hash change tracking
* fix unique key in CollapsibleSection
* Fix list markup
* remove title
* update permissions
* Hide minitocs on landing (#26594 )
* hide minitocs on landing page
* simplify page components and remove minitoc from sidebar for guides/overview
* fix carats and category fix
* remove id
Co-authored-by: Grace Park <gracepark@github.com >
* updating content based on versions script check with the OpenAPI
* update script and content files
* update script and content/rest files
* update to add TocLanding
* update script
* update index files
* add codespaces repository-secrets
* remove openapi schema check script
* remove minitocs at the top
* add h2 about the {title} api
* fix tests/unit/openapi-schema.js
* Fix linting tests
* fix search/topics test
* fix tests/unit/pages test
* update rest/reference links in components
* run prettier
* Update components/rest/RestReferencePage.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update components/rest/RestReferencePage.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update tests/unit/openapi-schema.js
Co-authored-by: Rachael Sewell <rachmari@github.com >
* updating comment location
* remove dependabot override
* remove path-utils current product update for rest
* run linter
* remove dependabot.md and remove h2 heading on restreference
* update the correct product to rest for rest pages
* adding comments for updates to path-utils
* remove console log
* REST sidebar: handle legacy v3 redirects (#26686 )
* Add script to handle legacy v3 REST redirects
* Run the script
* Handle a redirect to a redirect
* Update REST test URLs
* 'await' and test runs subcategory of checks
* Update REST URLs for routing/developer-site-redirects tests
* Update developer-redirects fixture with new REST URLs
* Resolve merge conflicts
* Update rest-redirects fixture with new REST URLs
* Fix broken links with REST pages re-org
* redirectTo could be undefined
* Fix script for posterity, can't redirect paths with hashes
* Remove invalid hash redirects
* Typically don't need to save one-off scripts
* Undo redirect changes (not necessary for handling v3 redirects)
* Remove script-added redirects
* Update old v3 redirects with new REST URLs
* No more GHES search indexing page
* 'org' not 'organization'
* Update fixture data for new REST URLs
* revert any content directory changes
Co-authored-by: Grace Park <gracepark@github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Adding test rest (#26750 )
* add test to check openapi schema versions and content rest frontmatter versions
* update lib/redirects
* fix test and add error messages
* adding repository secrets
* adding repository-secrets.md
* Revert "update lib/redirects"
This reverts commit 3aafe28265764d5bc09c0c478c8e0ca099c8fbcf.
* remove lib/redirects changes and console logs
* Update lib/rest/index.js
Co-authored-by: Rachael Sewell <rachmari@github.com >
* update unique key
* Rest client side redirects (#26754 )
* adding tags subcategory for the rest content repos category
* run prettier
* bug fix for anchor scrolls" (#26892 )
* updating width size for rest reference page
* Rest sidebar consolidation (#26862 )
* refactor sidebar
* fix articlecontext provider issue on rest product landing page for all versions
* fix a bug, create new component
* revert change to create new component and fix bug
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Set currentAnchor with a hashchange handler (#26923 )
* Rest sidebar design tweaks (#26807 )
* Rest sidebar design tweaks
* tweak color to subtle
* use muted color and margin for line
* update to design feedback
Co-authored-by: Grace Park <gracepark@github.com >
* Remove cheerio from rest-collapsible (#26948 )
* remove cheerio from rest-collapsible
* update type
* adding endswith instead
* use productId instead
* one off edge case for secret-scanning
* Reorganize subcategory and category, Update pre -> div, Add RestContext (#26950 )
* reorganize subcategory and category
* add RestContext
* update comment
* update for endpoints page
* add comment
* move object to restcontext
* remove effectiveDate in restcontext
* remove width calculation for rest reference page
* fix adding manual writer's minitocs to sidebar
* update with feedback
* update comment
* update isRestReferencePage
* remove page component and fix bug
* adding back rest/index.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* update content/rest"
* add back design tweak
* update to div
* update margins on rest api reference
* remove page component
* adding tests
* separate product from rest sidebar (#27065 )
* separate product from rest sidebar
* Use ProductCollapsibleSections for product pages
* fix tests
Co-authored-by: Robert Sese <rsese@github.com >
Co-authored-by: Grace Park <gracepark@github.com >
* Rest sidebar translations (#27052 )
* update translations
* remove general test
Co-authored-by: Robert Sese <rsese@github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
2022-04-20 10:19:48 -07:00
Peter Bengtsson
43f0e5270c
remove GHEC signup button for dotcom_user cookied users ( #26521 )
2022-03-29 20:21:38 +00:00
Grace Park
2c8713037d
Move deploy keys from deployments to keys in rest pages ( #26166 )
...
* move deploy keys from deployments to keys in rest pages
* move minitocs above intro
* Update content/rest/reference/keys.md
Co-authored-by: Sarah Edwards <skedwards88@github.com >
* add to banner, add redirects from deployments
* remove deploy keys from deployments intro
* update data/reusables name
* update - to _
* update script and add redirects for subcategories turned categories
Co-authored-by: Sarah Edwards <skedwards88@github.com >
2022-03-17 17:25:12 +00:00