Kevin Heis
58ff4b44b9
A11y: remove horizontal scroll ( #39170 )
2023-07-17 18:38:45 +00:00
Kevin Heis
9e599bc8eb
A11y: Update note colors ( #39112 )
2023-07-17 17:31:34 +00:00
Peter Bengtsson
2ec905fc77
trailingCommas:all on prettier ( #38888 )
2023-07-11 11:44:52 +00:00
Kevin Heis
3c99d06192
Min-width all the things ( #37850 )
2023-06-15 15:19:10 +00:00
Kevin Heis
0c34f6d648
Code-headers plugin rewrite ( #37654 )
...
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2023-06-12 15:04:49 +00:00
Robert Sese
9b12559589
more specifically find links in minitoc ( #36840 )
2023-05-04 21:00:39 +00:00
Kevin Heis
d5281724e2
Update permalinks for accessibility ( #36714 )
...
Co-authored-by: Peter Bengtsson <mail@peterbe.com >
2023-05-01 14:03:02 +00:00
Sujal Shah
a5488d2179
style: center ChevronUpIcon vertically ( #24981 )
...
Co-authored-by: Sujal Shah <sujal@zuru.com >
2023-04-12 13:22:18 +00:00
Peter Bengtsson
b6b99c8d9a
Remove some unnecessary imports ( #36260 )
2023-04-07 14:30:41 +00:00
Kevin Heis
babb4a11ad
Underline links in deprecation banner ( #36212 )
2023-04-05 21:04:42 +00:00
Robert Sese
afcdda4489
lower-alpha list style type for nested ordered lists ( #35761 )
2023-04-03 17:27:14 +00:00
Hector Alfaro
4ba4b732e1
Add label for minitoc items ( #36029 )
2023-03-30 16:36:32 +00:00
Grace Park
dd134aac62
Update table for mobile ( #36009 )
2023-03-29 21:54:42 +00:00
Grace Park
80e96bd5fa
Add aria-current to set to current anchor ( #34747 )
2023-02-14 19:11:00 +00:00
Hector Alfaro
8f31b582e8
Add aria-label to Mini TOC for more accessibility ( #34725 )
2023-02-14 15:35:17 +00:00
Peter Bengtsson
bb0bd0c00e
fix hydration warning in version picker ( #34539 )
2023-02-08 12:25:58 +00:00
Grace Park
ef2efb0636
Feature Branch: Global Nav Phase 1 ( #33465 )
...
Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com >
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com >
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2023-01-31 17:49:50 +00:00
Peter Bengtsson
b240055443
Permissions statement rendering on automated pages ( #33718 )
2023-01-03 19:44:44 +00:00
Grace Park
baa53b778f
Picker refactor ( #33113 )
...
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2022-12-07 23:17:06 +00:00
Grace Park
e3f8f71c42
Rest api versioning redo ( #33011 )
...
Co-authored-by: Rachael Sewell <rachmari@github.com >
Co-authored-by: Sarah Edwards <skedwards88@github.com >
Co-authored-by: Grace Park <gracepark@Graces-MacBook-Pro-2.local >
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com >
Co-authored-by: Sarah Schneider <sarahs@github.com >
2022-11-28 11:55:02 -08:00
Grace Park
7190f42fc2
Fix enumerated parameters bg color ( #32454 )
2022-11-10 18:43:51 +00:00
Peter Bengtsson
a9a0b1323b
set nested minitoc padding once ( #32315 )
2022-11-03 17:11:34 +00:00
Grace Park
6c0eb08199
Fix minitoc link issue for translations ( #31061 )
2022-09-22 15:13:50 -07:00
Grace Park
543b3eee9d
Unbreak for code in rest tables and remove unnecessary import ( #30314 )
2022-08-29 17:12:00 +00:00
Grace Park
df6b782b11
Update navlist for MiniTocs ( #30167 )
...
* update navlist
* fix tests
* update to component
* update platform
* update key
* fix platform tool picker issue
* add key
* remove unnecessary key
* fix test
* update styling
* fix indented test
* Update components/ui/MiniTocs/MiniTocs.tsx
Co-authored-by: Peter Bengtsson <peterbe@github.com >
* remove null
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2022-08-25 09:33:08 -07:00
Peter Bengtsson
d38b8351a8
Revert "Update to NavList for minitocs" ( #30051 )
...
Revert "Update to NavList for minitocs (#29885 )"
This reverts commit b5ea7bbcc5 .
2022-08-18 09:44:23 -04:00
Grace Park
b5ea7bbcc5
Update to NavList for minitocs ( #29885 )
...
* update to NavList for minitocs
* fix minitoc tests
2022-08-11 18:40:02 -07:00
Rachael Sewell
467459af7c
Reactify graphql pages ( #28547 )
2022-08-03 10:51:21 -07:00
Evan Bonsignori
febc27cb8f
fix: dark mode miniToc style overrides ( #29364 )
2022-07-27 22:18:39 +00:00
Grace Park
822fe2926b
Megabranch: Upgrade primer/react ( #28458 )
...
* upgrade primer/react
* upgrade
* using deprecated
* remove lib"
* Upgrade primer/react: Upgrade Label (#28502 )
update Label to primer/react 35.2.2
* fix merge conflicts
* primer/react v35: update ActionList (#28467 )
* Update to v35 ActionList for LearningTrack
* Update to v35 ActionList for ArticleList
* Update to v35 ActionList for ProductArticleList
* Update to v35 ActionList for TableOfContents
* Update to v35 ActionList for ProductCollapsibleSection
* Update to v35 ActionList for RestCollapsibleSection
* Update to v35 ActionList for SidebarHomepage
* Update to v35 ActionList for MiniTocs
* Update to v35 ActionList for Search
* Extra div for rendering test
* One less div for rendering test
* All the style updates for v35 ActionList
* Works without setting as an li which is already the default (didn't before for some reason)
* Use deprecated ItemInput for now
* Picker update for primer/react (#28485 )
* update picker
* inline picker for mobile
* set width to auto
* Update components/ui/Picker/Picker.tsx
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
* update
* Update Picker.tsx
* update onselect
* checking language code
* move language cookie setting to language picker
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
* Resolve package merge conflicts
* fresh npm install
* Primer update UnderlineNav (#28582 )
* update underlinenav for primer/react update
* update tests
* update switches test
* update one last label
* update header test"
* remove href in underlinenav
* update rendering tests
* update cursor
* primer/react v35: update DropDownMenu to ActionMenu (#28576 )
* Update to v35 ActionMenu for ArticleCards
* Update to v35 ActionMenu for Search
* Set button to inline-block
* Put the props on the overlay
* Update test for ActionMenu markup
* update package
* update package lock
* primer/react v35: CodeLanguagePicker update from SelectMenu to ActionMenu (#28625 )
* Use octicon for menu down arrow
* Update to v35 ActionMenu for CodeLanguagePicker
* update to SubNav
Co-authored-by: Grace Park <gracepark@github.com >
* update package-lock
Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com >
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
2022-07-11 11:51:18 -07:00
Peter Bengtsson
67dc3ac7cd
remove need for styled-jsx construct ( #28749 )
...
* remove need for styled-jsx construct
* remove line that might not be needed
2022-06-28 11:53:35 +00:00
Peter Bengtsson
071c95a91c
make miniToc pure data and no html strings ( #28517 )
...
* make miniToc pure data and no html strings
* fixups
* some types refactoring
2022-06-15 18:31:36 +00:00
Grace Park
2c56b5fdea
Fix REST small bugs ( #27484 )
...
* fix lucas found bugs
* remove language-
* update getLanguageHighlight
* add back launch.json
* remove line break
2022-05-11 12:57:14 -07:00
Grace Park
b98c83e924
REST operations sidebar ( #26225 )
...
* testing out a rest operations sidebar
* cleanup
* renamed 5 files
* renamed 5 files
* set redirect_from on 5 files
* renamed 1 files
* renamed 1 files
* renamed 3 files
* renamed 1 files
* renamed 1 files
* renamed 3 files
* renamed 1 files
* renamed 2 files
* renamed 1 files
* renamed 4 files
* renamed 15 files
* renamed 2 files
* renamed 6 files
* renamed 1 files
* renamed 4 files
* renamed 7 files
* renamed 1 files
* renamed 3 files
* renamed 3 files
* renamed 1 files
* renamed 5 files
* renamed 1 files
* renamed 1 files
* renamed 3 files
* renamed 4 files
* renamed 1 files
* renamed 1 files
* renamed 2 files
* renamed 4 files
* renamed 1 files
* renamed 1 files
* renamed 1 files
* renamed 6 files
* renamed 6 files
* renamed 4 files
* move files
* adding more
* updating to add restcontext and start of removing data/reusables/rest-reference
* removed data/reusables
* add a RestMiniTocItem and updating the filtering to add a subcategory so all manually added H3s are in mini tocs in addition to operations
* remove console log
* [WIP]: REST New Proposal Sidebar (#26471 )
* saving
* update sidebar
* remove console log
* update guides and overview
* import Category for category level rest pages
* update undefined restOperations
* update restOperationData category and subcategory levels"
* minor updates
* update get mini toc items function
* updating REST context for sidebar
* updating rest data
* remove console logs
* WIP: mini-toc-ing the sidebar
Co-authored-by: Robert Sese <rsese@github.com >
* A little cleanup
* Fix first subcategory link and add some comments
* updating anchor links in sidebar
* adding updates
* remove standalone
* update product and maptopic pages using article context
* add conditional link wrapper
* fix sidebar toggle and versions for enterprise admin
* update versions per subcategory
* Highlight sidebar link for current page
* Update miniToc hash links and hash change tracking
* fix unique key in CollapsibleSection
* Fix list markup
* remove title
* update permissions
* Hide minitocs on landing (#26594 )
* hide minitocs on landing page
* simplify page components and remove minitoc from sidebar for guides/overview
* fix carats and category fix
* remove id
Co-authored-by: Grace Park <gracepark@github.com >
* updating content based on versions script check with the OpenAPI
* update script and content files
* update script and content/rest files
* update to add TocLanding
* update script
* update index files
* add codespaces repository-secrets
* remove openapi schema check script
* remove minitocs at the top
* add h2 about the {title} api
* fix tests/unit/openapi-schema.js
* Fix linting tests
* fix search/topics test
* fix tests/unit/pages test
* update rest/reference links in components
* run prettier
* Update components/rest/RestReferencePage.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update components/rest/RestReferencePage.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update pages/[versionId]/rest/[category]/[subcategory].tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update tests/unit/openapi-schema.js
Co-authored-by: Rachael Sewell <rachmari@github.com >
* updating comment location
* remove dependabot override
* remove path-utils current product update for rest
* run linter
* remove dependabot.md and remove h2 heading on restreference
* update the correct product to rest for rest pages
* adding comments for updates to path-utils
* remove console log
* REST sidebar: handle legacy v3 redirects (#26686 )
* Add script to handle legacy v3 REST redirects
* Run the script
* Handle a redirect to a redirect
* Update REST test URLs
* 'await' and test runs subcategory of checks
* Update REST URLs for routing/developer-site-redirects tests
* Update developer-redirects fixture with new REST URLs
* Resolve merge conflicts
* Update rest-redirects fixture with new REST URLs
* Fix broken links with REST pages re-org
* redirectTo could be undefined
* Fix script for posterity, can't redirect paths with hashes
* Remove invalid hash redirects
* Typically don't need to save one-off scripts
* Undo redirect changes (not necessary for handling v3 redirects)
* Remove script-added redirects
* Update old v3 redirects with new REST URLs
* No more GHES search indexing page
* 'org' not 'organization'
* Update fixture data for new REST URLs
* revert any content directory changes
Co-authored-by: Grace Park <gracepark@github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Adding test rest (#26750 )
* add test to check openapi schema versions and content rest frontmatter versions
* update lib/redirects
* fix test and add error messages
* adding repository secrets
* adding repository-secrets.md
* Revert "update lib/redirects"
This reverts commit 3aafe28265764d5bc09c0c478c8e0ca099c8fbcf.
* remove lib/redirects changes and console logs
* Update lib/rest/index.js
Co-authored-by: Rachael Sewell <rachmari@github.com >
* update unique key
* Rest client side redirects (#26754 )
* adding tags subcategory for the rest content repos category
* run prettier
* bug fix for anchor scrolls" (#26892 )
* updating width size for rest reference page
* Rest sidebar consolidation (#26862 )
* refactor sidebar
* fix articlecontext provider issue on rest product landing page for all versions
* fix a bug, create new component
* revert change to create new component and fix bug
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Set currentAnchor with a hashchange handler (#26923 )
* Rest sidebar design tweaks (#26807 )
* Rest sidebar design tweaks
* tweak color to subtle
* use muted color and margin for line
* update to design feedback
Co-authored-by: Grace Park <gracepark@github.com >
* Remove cheerio from rest-collapsible (#26948 )
* remove cheerio from rest-collapsible
* update type
* adding endswith instead
* use productId instead
* one off edge case for secret-scanning
* Reorganize subcategory and category, Update pre -> div, Add RestContext (#26950 )
* reorganize subcategory and category
* add RestContext
* update comment
* update for endpoints page
* add comment
* move object to restcontext
* remove effectiveDate in restcontext
* remove width calculation for rest reference page
* fix adding manual writer's minitocs to sidebar
* update with feedback
* update comment
* update isRestReferencePage
* remove page component and fix bug
* adding back rest/index.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* update content/rest"
* add back design tweak
* update to div
* update margins on rest api reference
* remove page component
* adding tests
* separate product from rest sidebar (#27065 )
* separate product from rest sidebar
* Use ProductCollapsibleSections for product pages
* fix tests
Co-authored-by: Robert Sese <rsese@github.com >
Co-authored-by: Grace Park <gracepark@github.com >
* Rest sidebar translations (#27052 )
* update translations
* remove general test
Co-authored-by: Robert Sese <rsese@github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
2022-04-20 10:19:48 -07:00
Hector Alfaro
7e09e2ba85
offset underline for md content
2022-04-07 11:26:46 -04:00
Hector Alfaro
ba27b2e62c
use functional variables
2022-04-05 18:43:11 -04:00
Hector Alfaro
3a5f786e62
override minitoc bg for better contrast
2022-04-05 12:29:04 -04:00
Grace Park
e0e2ed3de3
adding observer disconnect ( #26228 )
2022-03-15 16:54:32 -07:00
Grace Park
21b59b5805
Move mini tocs rest + collapsible ( #26069 )
...
* starting minitocs change
* moving rest mini tocs and adding functionality to collapse
* adding some comments
* update margins
* minor updates: fix scroll to top button add padding to resthttpmethod verbs and background color for nested arrows in minitocs
* Update components/rest/RestReferencePage.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* Update components/rest/RestReferencePage.tsx
Co-authored-by: Rachael Sewell <rachmari@github.com >
* fix comment
* fix wording and z index
* bring back articlegridlayout
* updating margins for lg and xl
Co-authored-by: Rachael Sewell <rachmari@github.com >
2022-03-14 10:50:53 -07:00
Grace Park
1a6bee4601
Refactor to add RestReferencePage ( #25781 )
...
* refactor to add RestReferencePage
* remove structured data from article page
* add back clientsidehightlight js and remove structuredcontent
* update endpoint available for github apps page to use RestReferencePage
* check for minitocs
* use children for ArticlePage for overview endpoints page and move category data to RestReferencePage
* create MiniTocs component
* add MiniTocs
* fix unique key issue
* break into out into own div
* remove some unnecessary ts
* refactor looping section
* simplify markdown component usage
* add key prop
* add key prop
* add unique key
Co-authored-by: Rachael Sewell <rachmari@github.com >
2022-03-08 18:00:38 +00:00
Mike Surowiec
f3fc80cf05
Upgrade primer/components -> primer/react ( #25591 )
...
* upgrade primer/components -> primer/react
* fix jest failure
2022-02-24 00:30:14 +00:00
Grace Park
934b255119
add keyboard focus to scroll top and remove wording to keep one button ( #24817 )
2022-01-31 17:45:44 +00:00
Robert Sese
abe3881aa3
a11y: link style updates ( #24680 )
...
* Remove opacity classes on REST pages
* Underline links in article page content
* Typo 🔨
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
2022-01-28 11:11:23 -06:00
Grace Park
eb776f64e4
Small accessibility changes - adding ul to li ( #24449 )
...
* adding ul to li
* move ul for just the mobile picker
2022-01-20 17:54:49 +00:00
Robert Sese
d0db00cd98
a11y: match picker label with current selection ( #24321 )
...
* Match label with selection
* defaultText is a better default
Co-authored-by: Peter Bengtsson <peterbe@github.com >
* No longer used
* Also no longer used
* No longer used in the dropdown pickers
* Add translation strings for pickers
* Use translated strings in picker components
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2022-01-19 18:43:31 +00:00
Grace Park
47de433865
Accessibility Search updates and additional minor changes ( #24136 )
...
* update to use heading markup
* updating to h3 for accessibility
* increase opactiy to meet 5.5:1 color contrast ratio
* update opacity to meet color contrast ratio
* update styling to match original but use heading markup
* remove aria-hidden for accessibility
* add h1 title search results and update scroll tip colors
* add number of matches
* remove no results since we are showing 0 results
* add overflow to fix border bottom on version search
* Update components/Search.tsx
Co-authored-by: Peter Bengtsson <peterbe@github.com >
* Update components/Search.tsx
Co-authored-by: Peter Bengtsson <peterbe@github.com >
* incorporating feedback and update padding
Co-authored-by: Peter Bengtsson <peterbe@github.com >
2022-01-07 21:29:49 +00:00
Grace Park
124f54eb0c
Accessibility changes for Nav Menu ( #24099 )
...
* updating to nav landmark
* support keyboard esc to close mobile menu
* update to ChevronDown to remove nested div
2022-01-06 17:34:19 +00:00
Robert Sese
bcb1b3c8bc
Use lang attribute and translate picker aria-label ( #24096 )
...
* Translate picker aria-label
* Use lang attribute
2022-01-05 23:28:05 +00:00
Grace Park
3ce46b9172
move custom tool tip to remain permanent next to scroll to top button ( #23551 )
2021-12-13 17:40:48 +00:00
Grace Park
078fdc9a71
Remove bumplink symbol ( #23539 )
...
* run prettier
* removing space
* run prettier again
2021-12-09 18:41:35 +00:00