1
0
mirror of synced 2025-12-21 02:46:50 -05:00
Commit Graph

35 Commits

Author SHA1 Message Date
Felicity Chapman
a72d1c4d87 Clarify code scanning permissions (#16386)
* Fix the issues raised in docs-content/3159

* Fix the issues raised in docs#763

* Fix broken anchor and improve heading

* Fix two more examples of the same anchor

* Apply suggestions from code review

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
2020-11-11 11:26:25 +00:00
Larry Claman
660d664ac7 Changed 'people' to 'accounts' (#765)
* Changed 'people' to 'accounts'

Adding some precision:  Changed 'People with write permission to a repository can manage' to 'Accounts with write permission to a repository can manage"

People don't have permission; accounts have permission.

* edits for clarity

* clarity

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/managing-code-scanning-alerts-for-your-repository.md

Co-authored-by: hubwriter <54933897+hubwriter@users.noreply.github.com>

Co-authored-by: hubwriter <54933897+hubwriter@users.noreply.github.com>
2020-10-28 11:36:54 +00:00
hubwriter
03a59f0a9f Update docs to reflect default (#16170) 2020-10-26 15:30:29 +00:00
hubwriter
1652960986 [DSP, already shipped] Use conditioning to revert the dismiss/delete alert changes on GHES (#16211)
* Use conditioning to revert dismiss/delete alert changes on GHES

* Add new dotcom version text that is also good for GHES

* Reinstate original subheading for GHES 2.22
2020-10-26 15:12:12 +00:00
hubwriter
6487712b15 [DSP, already shipped] Code scanning: Small update for change from head to merge commit for attribution (#16169)
* Small update for change from head to merge commit for attribution

* Simplify the sentence about when codescan is run against PRs

Whether it does attribution using a comparison of the HEAD commit
or a merge into a temporary copy of the default branch
is too much information here.
2020-10-26 14:47:27 +00:00
hubwriter
a4bc1a6d7c Revert "[DSP, already shipped] Use conditioning to revert the dismiss/delete alert changes on GHES (#16206)" (#16210)
This reverts commit 270803995e.
2020-10-26 12:08:45 +00:00
hubwriter
270803995e [DSP, already shipped] Use conditioning to revert the dismiss/delete alert changes on GHES (#16206)
* Use conditioning to revert dismiss/delete alert changes on GHES

* Add new dotcom version text that is also good for GHES

* Reinstate original subheading for GHES 2.22
2020-10-26 12:05:41 +00:00
JBryceOrtiz
6932075719 Update managing-code-scanning-alerts-for-your-repository.md (#760)
Edited introductory paragraph and step 4 of the section to state that admin permissions are required to delete alerts. 
Introductory paragraph changed to say, "Alternatively, if you have admin permissions for the repository, you can delete alerts."
and step 4 to "If you have admin permissions for the repository, and you want to delete alerts[...]"

Co-authored-by: hubwriter <54933897+hubwriter@users.noreply.github.com>
2020-10-26 09:30:50 +00:00
mc
6fe121dcf4 add short title to article (#16190) 2020-10-23 14:48:24 +01:00
Laura Coursen
a51872d042 Change != "free-pro-team@latest" to enterpriseServerVersions contains currentVersion, actually (#16114)
* Run script/new-versioning/update-not-fpt-conditionals.js

* Fix a few things

* Remove outdated versioning

* Fix broken link

Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com>
2020-10-21 21:33:43 -07:00
hubwriter
c6490230fa Use capc version of code scanning variable (#16131) 2020-10-20 16:09:16 +01:00
Felicity Chapman
cdd8d33c5f Add HTML comments for known UI links to two code scanning topics (#16091) 2020-10-20 14:36:22 +01:00
hubwriter
913e9b2acb [Already shipped] Add information on how to run analysis in a container (#15886)
* Add new placeholder topic file - WiP

* Add content for new topic + cross-refs to it

* Change topic title just to get through the PR check for matching filename & title

* Rework the workflow example section

* Remove 4 lines from workflow - see:

https://github.com/github/code-scanning/issues/1826
2020-10-19 14:12:29 +01:00
hubwriter
fce5464e31 [Already shipped] Code scanning: Dismiss and delete alerts (#16086)
* Updates for delete and dismiss alerts

* Add back the text for the now-deleted reusable

* Make s/shots relevant to the PR context of the text

* Make review comment changes

* More review comments attended to
2020-10-18 08:27:28 +01:00
James Fletcher
b92cafff5a Update about-integration-with-code-scanning.md (#16085) 2020-10-16 11:01:30 +01:00
mc
fd130da977 Code Scanning python setup (#15972)
* document new behavior for Python analysis

* add versioning

* update the second article

* add link to Cnfiguring article

* add word

* polishing

* Apply suggestions from code review

Co-authored-by: Felicity Chapman <felicitymay@github.com>

* address review comments

* add comments in yaml snippet

* remove contraction

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning.md

Co-authored-by: Felicity Chapman <felicitymay@github.com>

* commit changes

* false, not true

* write comments over 2 lines

* again

* remove white spaces

Co-authored-by: Felicity Chapman <felicitymay@github.com>
2020-10-13 16:02:24 +01:00
hubwriter
48ae6ccba3 [Already shipped] Code scanning: Restructure 'Integrating with code scanning' category (#15971)
* Restructure files and change topic titles and file names

* Update links to files whose names have changed

* Finish restructuring work for runner topics

* Makes changes suggested by James
2020-10-13 10:47:11 +01:00
Tobias
3ab9409bd9 Update GitHub Actions with syntax to map 2020-10-09 15:23:55 +02:00
Felicity Chapman
e588ff3747 Revise Go analysis text and convert to reusable (#15911) 2020-10-09 11:17:21 +01:00
hubwriter
c52a4885c9 Merge branch 'main' into patch-20 2020-10-08 09:27:14 +01:00
Arthur Casals
374352d644 Update running-code-scanning-in-your-ci-system.md
Fixes #167 .
2020-10-08 01:38:06 +02:00
Arthur Casals
e0c2d0457b Update running-code-scanning-in-your-ci-system.md
Fixes #168 with the proposed changes.
2020-10-07 22:17:20 +02:00
hubwriter
bcc045319b Fix missing word in message text (#15852) 2020-10-02 09:08:45 +01:00
Alistair Christie
0c942aa32c [Code scanning dotcom GA] Add more help for users who have just enabled code scanning (#15816)
* Add more information to the codescan enabling topic - WiP

* Add more details and s/shots to the Enabling topic

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Make change suggested by Justin, but in step 5 rather than step 4.

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Not all workflows will have `on:push` and `on:pull_request` so clarify that this refers to the CodeQL workflow.

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Revert changes to this file to the file as it currently is on main

* Attempt to remove package.json

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Chiedo <chiedo@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-10-01 22:08:51 +01:00
Sarah Schneider
f272eec944 Remove deprecated GHES versions from content and data (#15830)
* ran script/remove-unused-assets.js (manually removed unused variables printed by the script)

* package-lock

* turn elsif into two ifs to prepare for running Liquid deprecation script

* ran script/remove-deprecated-enterprise-version-markup.js --release 2.14 (ONLY UPDATES LINE BREAKS ETC.)

* ran script/remove-deprecated-enterprise-version-markup.js --release 2.15

* ran script/remove-deprecated-enterprise-version-markup.js --release 2.17

* ran script/remove-deprecated-enterprise-version-markup.js --release 2.18

* update hardcoded test

* Update content/github/collaborating-with-issues-and-pull-requests/filtering-files-in-a-pull-request.md

Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>

* add currentVersion is NOT free-pro-team to conditional, to make sure the deprecation script does the right thing when it is time to deprecate 2.21

Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
2020-10-01 10:55:34 -04:00
Felicity Chapman
55c2d4b2d2 Code scanning GA on dotcom-specific changes (#15749) 2020-09-30 17:09:07 +01:00
James Fletcher
7e498136e6 Mention webhooks in "About integration with code scanning" (#15791)
Mention webhooks in "About integration with code scanning"
2020-09-30 03:26:15 -07:00
Jason Etcovitch
caaee7a124 Update all files to use {% data %} (#15253)
* Add back changes from prior to purge

* Manually fix some invalid Liquid

* Updoot render-content

* Improve test messages to show correct output

* Run el scripto

* Pass the remaining test
2020-09-29 16:01:04 -04:00
mc
a6f7478f62 update shortTitle in frontmatter (#15792) 2020-09-29 15:55:58 +01:00
Felicity Chapman
a6c582899c Add updated examples from dsp-testing/sarif-demo (#15751) 2020-09-29 11:40:44 +01:00
Felicity Chapman
20790e724c Add topic for developers who need to triage code scanning alerts in PRs (#15740) 2020-09-29 11:18:50 +01:00
mc
461a74f293 2599 - improve refs to language matrix in Troubleshooting article (#15788)
* add requested sentences

* actually replace previous sentence and linkW
2020-09-29 10:22:30 +01:00
Shati Patel
a302fbf36a Code scanning: autobuild update on Windows and macOS (#15078)
[Sept 22 or later] Code scanning: C++ autobuild for Windows and macOS
2020-09-28 11:32:02 -07:00
Shati Patel
ae0d0f530e Code scanning troubleshooting: How to set up environment with CodeQL runner (#15746)
* Code scanning troubleshooting: Set up environment with CodeQL runner

* Change "trace" to "monitor"

* Fix note syntax
2020-09-28 18:42:34 +01:00
Vanessa Yuen
3df90fc9b8 Hello git history spelunker!
Are you looking for something? Here is all of the GitHub Docs history in one single commit. Enjoy! 🎉
2020-09-27 14:10:11 +02:00