* cache asset images more aggressively
* more careful about which gets the manual surrogate key
* fix rendered-content-link-checker script too
* feedbacked
* one fast link checker to rule them all
* -L alias
* refactor
* hacking away
* passing pages
* adding a workflow
* limit level to critical
* ability to pass a specific set of files
* testing specific files
* remove temporary debugging
* reorganize the printing
* formatting of output
* check images too
* prettyFullPath()
* minimal permission on workflow
* update comment
* new permission
* fix actions shas
* Output every file reset
* Add --dry-run and --reason options to reset-translated-file.js
* Output reason when reset-translated-file.js script is called
* Add script to report reset files
* Has the workflow report the reset files
* Fix script name
* Filter report by language
* Update .github/workflows/create-translation-batch-pr.yml
* Use build in array methods
* Fix error
* Attempt to fix that error
* Remove debugging code
* fix: Update path of lint-translation script
* fix: Update conditional guard clause
The conditional compared an array to a string using strict equality, so
it was never going to be true. This change makes sure we return early
when there are no changes.
* fix: Exit early when there are no files to lint
* refactor: Filter files to reset in plain javascript
As opposed to doing it in bash.
* Update tests/linting/lint-files.js
Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
* Update tests/linting/lint-files.js
Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
* Update script/i18n/lint-translation-files.js
Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
* fix: update lint-translation script to point to the correct test
This change reflects its new home in `test/linting/lint-files.js` as committed in f0d17c300d on April 28, 2021.
* test: check release notes can be parsed a single YAML document
* test: check yaml content parsability
* test: check parsability for all YAML content
* refactor: move annotations to lint yaml content suite
* fix: revert file contents
* fix: remove local test script
* refactor: lowercase yaml file type
* fix: remove null assignment to stay consistent with other variables
* refactor: update reference name to caught error
* fix: remove the royal we from annotation
* refactor: update annotation for improved readability
* fix: add missing preposition
* fix: make script for linting translations executable
* fix: execute the command directly
* feat: surface any errors if lint check fails
* fix: do not return early if lint check errors
Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
* feat: stub two reset scripts
* refactor: split lint script into two separate files
* fix: revert back to original lint script
* refactor: use commander interface for linting translation files
* Skip reset attempt when violation list is empty
So that "execSync(`cat ${log}...`)" in line 64 is never executed. When
there are no errors, the log file is not created, and unless it had been
previously created by another process, the script will error out.
Co-authored-by: Marcelo Jacobus <marcelo.jacobus@gmail.com>
* fix: de-duplicate and filter non-existent broken files
* fix: sequentially reset known broken translation files
When a known broken translation is reset, a Git operation performs the
underlying reset. If more than one Git operation is running at a time,
Git will throw an error:
> Another git process seems to be running in this repository [...]
This change ensures that we reset each broken translation file
sequentially to not run into this error.
* Skip reset of a file that does not exist
Co-authored-by: Marcelo Jacobus <marcelo.jacobus@gmail.com>
* updating search icon
* remove no fill
* update fill color
* using ActionList and Overlay
* update to ActionList, Overlay, add Label to Breadcrumbs, and change Mark
* add search-results test data and move header search results to right
* make search results scrollable and fix max-width in header search
* update header search and styling updates
* add highlight
* update styling
* styling and lint errors
* fix lint error and fetch
* Update components/Search.tsx
* update label color
* remove bottom margin
Co-authored-by: Rachael Sewell <rachmari@github.com>
* Create migrate-colors-primer-18.js
* Update colors round 1
* upgrade primer packages
* Update index.scss
* Replace auto colors
* remove btn-primary-matte
* Turns out the class names and variables names DONT LINE UP... ugh....
* Check for allowed var colors
* Do not use `build.status` of 'pending' as a looping condition for Heroku deployment
* Don't wait for `appSetup.status` either
* Fix incorrect Octokit method usage in local deploy script
* Bump the number of allowable errors from 5 to 10
* More logging!
* Add an environment variable for easily increasing the number of allowed Heroku failures per phase of polling
* Move concurrency control to top-level in prod deploy workflow
* Add 503 to the list of temporarily acceptable Heroku failure codes
* Add HEROKU_PRODUCTION_APP_NAME back into the prod deploy workflow
* run prettier
* removing files from test/integration
* update cron job to not start on the hour
* add github/github comment
* update comment
* updating to search by indices in the content rather than by line
* small updates and updating character max
* update name of script run
* updating to use api search code and get contents
* using api search code and get contents
* adding token check and .js
* remove blank line for title
* update issue body content
* update comment
* add support for GitHub.developer_help_url links
* Update the production deployment workflow to target the main Heroku app
Without exposing our internal Heroku app name!
* Refactor the staging deployment script a bit to match more closely
* Use the HEROKU_PRODUCTION_APP_NAME Secret in the workflow
* Add a note about the newly required environment variable for production deployment into the local deploy script
* Add critical errors if the HEROKU_PRODUCTION_APP_NAME is missing
* Extract HEROKU_PRODUCTION_APP_NAME from process.env
* Revert the critical parts of PR #21807 to no longer deploy to prod via Actions
* Don't require HEROKU_PRODUCITON_APP_NAME
