jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-23 03:44:00 -05:00
Code Issues Projects Releases Wiki Activity
19,902 Commits 28 Branches 1 Tag
b45f4c5300633a48e204f356fe72584732dc2c68
Commit Graph

302 Commits

Author SHA1 Message Date
Grace Park
d5097397c8 underline links on toc pages (#24217) 2022-01-11 20:48:35 +00:00
Grace Park
f5c615cbd0 Guides List markup and Link Icon in Permalink Headings (#24211) 
* list markup for article cards and learning paths

* adding link icon to section permalinks
 2022-01-11 11:38:57 -08:00
Grace Park
d2494c3e2d Keyboard focus on Guides Pages (#24209) 
* accessibility: make label autofocus on dropdown when clicked

* update to div element

* fix keyboard focus on X more guides and load more guides

* tabIndex is optional
 2022-01-11 19:26:12 +00:00
Grace Park
69543377cb Accessibility: Guides Pages, types/topics dropdown (#24185) 
* accessibility: make label autofocus on dropdown when clicked

* update to div element
 2022-01-11 17:53:55 +00:00
Peter Bengtsson
4947218cba fix React key uniqueness in Breadcrumbs (#24182) 2022-01-11 01:56:30 +00:00
Rachael Sewell
a340162d84 reorganize repository apis (#23728) 
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
 2022-01-11 11:53:12 +10:00
Robert Sese
d31d6a5b4e a11y: add title text for view all links (#24193) 
* Add optional 'view all' title text in the context

* Use viewAllTitleText in ArticleList

* Set viewAllTitleText for sections with 'view all' links
 2022-01-11 01:30:10 +00:00
Robert Sese
fcc9b904dd Comment on why we do manual email validation (#24192) 
* Comment on why we do manual email validation

* One 'do'
 2022-01-10 22:47:46 +00:00
Grace Park
0b33fbb167 Fix max height for minitocs (#24163) 
* update max-height

* set fixed max height for mini tocs to make scrollable from top
 2022-01-08 01:48:02 +00:00
dependabot[bot]
ce8f21487b Bump @primer/components from 32.1.0 to 33.1.0 (#24023) 2022-01-08 00:25:04 +00:00
Grace Park
e37fc2edd9 Accessibility footer color color contrast ratio (#24158) 
* programmatically group breadcrumbs

* forgot to commit li
'
'

* adding inline-block

* add emphasis color on border to meet accessibility color contrast ratio

* update border for footer buttons to meet accessibility color contrast ratio

* run prettier
 2022-01-07 16:20:54 -08:00
Robert Sese
76b0b5ade1 a11y: survey email validation (#24159) 
* Add email error state checking

* Clear email error on cancel

* Disable submit if email is invalid

* Add Primer-ized error message

* Add aria attributes

* Better function name
 2022-01-08 00:01:42 +00:00
Grace Park
47de433865 Accessibility Search updates and additional minor changes (#24136) 
* update to use heading markup

* updating to h3 for accessibility

* increase opactiy to meet 5.5:1 color contrast ratio

* update opacity to meet color contrast ratio

* update styling to match original but use heading markup

* remove aria-hidden for accessibility

* add h1 title search results and update scroll tip colors

* add number of matches

* remove no results since we are showing 0 results

* add overflow to fix border bottom on version search

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* incorporating feedback and update padding

Co-authored-by: Peter Bengtsson <peterbe@github.com>
 2022-01-07 21:29:49 +00:00
Grace Park
a4c5d58507 Accessibility: Breadcrumbs (#24151) 
* programmatically group breadcrumbs

* forgot to commit li
'
'

* adding inline-block
 2022-01-07 12:01:52 -08:00
Peter Bengtsson
7d75265b01 hydration fails on CollapsibleSection with hash in URL (#24105) 2022-01-07 02:25:16 +00:00
Robert Sese
d2b9b236c4 Add label for search input (#24130) 2022-01-06 22:35:56 +00:00
Peter Bengtsson
5893ae32b3 don't let the href depend on the router hash in client-side rendering (#24106) 2022-01-06 20:59:47 +00:00
Grace Park
124f54eb0c Accessibility changes for Nav Menu (#24099) 
* updating to nav landmark

* support keyboard esc to close mobile menu

* update to ChevronDown to remove nested div
 2022-01-06 17:34:19 +00:00
Robert Sese
bcb1b3c8bc Use lang attribute and translate picker aria-label (#24096) 
* Translate picker aria-label

* Use lang attribute
 2022-01-05 23:28:05 +00:00
Peter Bengtsson
3f9d798037 render same DOM in SSR as client (#24078) 2022-01-05 14:53:43 +00:00
hubwriter
0651660f33 Change "workflow templates" to "starter workflows" (#23823) 
Co-authored-by: skedwards88 <skedwards88@github.com>
 2021-12-21 18:15:54 +00:00
Robert Sese
5d88ffbef7 Use ol for LearningTracks (#23461) 
* Use ol for LearningTracks

* Flip li counter bg/fg colors

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
 2021-12-17 13:52:49 -06:00
Robert Sese
a2bd8ae67f Add support for videos to landing pages (#23801) 
* Add new video properties frontmatter

* Handle video links in the middleware

* Video links don't have intros, authors, or full titles

* Make videos available from context

* Add default video heading

* Add basic tests for videos

* tmp videos test

* Remove stray test debugging

* more tmp videos testing

* Add videos test fixture

* Revert "more tmp videos testing"

This reverts commit 382946a5603ff217014797f77f37216bb8bb6c9c.

* Revert "tmp videos test"

This reverts commit 8767d0eaf08bd4ca04e2dacd12d476a2506c0367.
 2021-12-17 11:09:00 -06:00
Grace Park
65db364ef1 remove avatar for accessibility (#23706) 2021-12-16 17:09:35 +00:00
Peter Bengtsson
53b0484a66 unique keys for RestRepoBanner links (#23764) 2021-12-15 16:08:43 -08:00
Grace Park
9e21836f4d Revert "Accessibility: Nesting headingLevel 3 mini tocs (#23663)" (#23759) 
This reverts commit 41c7f58437.
 2021-12-15 12:34:21 -08:00
Robert Sese
5ff7bf2c65 Capitalize and comma outside link (#23723) 2021-12-14 16:57:24 -06:00
Rachael Sewell
bf7b2085bd fix broken links in banner component (#23719) 2021-12-14 14:00:47 -08:00
Rachael Sewell
daafb8cb9d break up large rest pages (#23652) 2021-12-14 20:39:25 +00:00
Grace Park
11a01104b1 update to list mark up for screen readers (#23712) 2021-12-14 11:58:48 -08:00
Grace Park
a39f8a16bd add permanent search code example label (#23709) 2021-12-14 11:14:18 -08:00
Grace Park
41c7f58437 Accessibility: Nesting headingLevel 3 mini tocs (#23663) 
* nesting headingLevel 3 mini tocs

* fix tests

* Update components/article/ArticlePage.tsx

Co-authored-by: Robert Sese <robert.sese@gmail.com>

* run prettier

Co-authored-by: Robert Sese <robert.sese@gmail.com>
 2021-12-14 04:29:09 +00:00
Kevin Heis
821c1e693b Release note sticky fixes (#23643) 2021-12-13 18:23:30 +00:00
Grace Park
cb4e962ce8 fixing styling of toc pages (#23583) 2021-12-13 18:05:02 +00:00
Grace Park
e0c31e09e7 update padding bottom (#23580) 
Co-authored-by: docubot <67483024+docubot@users.noreply.github.com>
 2021-12-13 09:58:53 -08:00
Grace Park
3ce46b9172 move custom tool tip to remain permanent next to scroll to top button (#23551) 2021-12-13 17:40:48 +00:00
Peter Bengtsson
815f9d40c3 only link all enterprise versions if any is enterprise version (#23640) 2021-12-13 17:19:15 +00:00
Peter Bengtsson
9d59f7dc8b Lack of unique React keys (#23573) 2021-12-11 03:32:45 +00:00
Grace Park
70262789ec make clear list structure in footer for accessibility (#23549) 2021-12-09 20:31:22 +00:00
Robert Sese
4ce6dd2840 More misc a11y bits (#23542) 
* List-ify guide labels

* Use aria-expanded with 🍔 menu
 2021-12-09 19:20:04 +00:00
Grace Park
078fdc9a71 Remove bumplink symbol (#23539) 
* run prettier

* removing space

* run prettier again
 2021-12-09 18:41:35 +00:00
Grace Park
f19223503a Update Search Version Button to Dropdown (#23465) 
* adding to view

* updating the portal location

* add new line

* updating font styling to class

* Update components/Search.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* Update components/Search.module.scss

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* update ItemInput

* using router.replace and import updates

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* run prettier

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
 2021-12-09 17:56:24 +00:00
Kevin Heis
86b5a52b3e Query string abuse causing 5xxs (#23501) 2021-12-08 21:05:32 +00:00
Robert Sese
9dbc44100c Misc accessibility bits (#23495) 
* Fix and make article date format consistent

* Add aria-label to repo icon

* Remove unnecessary title attribute
 2021-12-08 19:01:40 +00:00
Peter Bengtsson
7f6f20a73f run prettier on all code in CI (#23482) 
* run prettier on all code in CI

* rename

* test .tsx too

* ignore more

* prettier the stragglers

* minimal permission
 2021-12-08 16:11:52 +00:00
Matt Pollard
b3e1ff4e89 Update documentation for GitHub AE's December 2021 release (#23405) 2021-12-07 10:36:37 +01:00
Peter Bengtsson
046de169fd fix TypeScript violation with Overlay in @primer/components@32.1.0 (#23358) 
Part of #1311
 2021-12-03 19:43:12 +00:00
Grace Park
8931793024 updating table-of-contents pages with actionlist (#23338) 2021-12-02 12:50:04 -08:00
Robert Sese
9d79148aef ActionList for LearningTracks (#23335) 
* ActionList for LearningTracks

* Try to resolve TS error
 2021-12-02 19:59:01 +00:00
Grace Park
4ff5167e51 Updating name: sublanding to guides and using DropdownMenu for type/topics filter (#23290) 
* updating sublanding to guides page and using DropdownMenu primer component

* fix linting error

* remove unnecessary import

* updating translation files

* move data-testid

* trying to fix test

* fix browser tests

* Update content/README.md

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
 2021-12-02 18:43:33 +00:00