1
0
mirror of synced 2025-12-22 03:16:52 -05:00
Commit Graph

50 Commits

Author SHA1 Message Date
Rachael Sewell
a340162d84 reorganize repository apis (#23728)
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-11 11:53:12 +10:00
Grace Park
0b33fbb167 Fix max height for minitocs (#24163)
* update max-height

* set fixed max height for mini tocs to make scrollable from top
2022-01-08 01:48:02 +00:00
dependabot[bot]
ce8f21487b Bump @primer/components from 32.1.0 to 33.1.0 (#24023) 2022-01-08 00:25:04 +00:00
Grace Park
9e21836f4d Revert "Accessibility: Nesting headingLevel 3 mini tocs (#23663)" (#23759)
This reverts commit 41c7f58437.
2021-12-15 12:34:21 -08:00
Grace Park
41c7f58437 Accessibility: Nesting headingLevel 3 mini tocs (#23663)
* nesting headingLevel 3 mini tocs

* fix tests

* Update components/article/ArticlePage.tsx

Co-authored-by: Robert Sese <robert.sese@gmail.com>

* run prettier

Co-authored-by: Robert Sese <robert.sese@gmail.com>
2021-12-14 04:29:09 +00:00
Robert Sese
37b311dd8f Actionlist-ify ProductArticleList (#23280)
* WIP: ActionList ProductArticleList

* remove mb

* Put article count in link

* Full width links

* remove indent

* fixing link space for mini tocs

Co-authored-by: Grace Park <gracepark@github.com>
2021-12-01 21:49:52 +00:00
Mike Surowiec
39cdb0dce6 fix: tool picker update content on currentTool change (#23216) 2021-11-30 17:07:39 +00:00
Kevin Heis
e3b2e820fd React tool picker (#23004)
* Working on tool picker

* Start on react version of tool picker

* Update ToolPicker.tsx

* Update tool-switcher.html

* Get it working

* Update browser.js

* Update browser.js

* Update ToolPicker.tsx
2021-11-29 23:04:06 +00:00
Amy Burns
c3bc538cd4 Add 2 pane layout to "Setting up Codespaces" docs and update IA (#21700) 2021-11-24 11:41:30 -08:00
Grace Park
33c5ce2d36 Updating images styling and accessibility for minitocitems (#22976)
* updating images styling on design systems feedback

* maintaining ul li structure for accessiblity

Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
2021-11-19 00:56:51 +00:00
Grace Park
75577663e9 bringing back i - thanks rsese (#22969) 2021-11-18 17:41:20 +00:00
Grace Park
5a809be3dc MiniTocItems: rerender tocs and fix bugs (#22948)
* add key to force rerender tocs

* move up platform specific to properly display none and go back to using contents

* remove i
2021-11-17 22:29:07 -08:00
Robert Sese
98d87bb4f2 Make list key unique (#22946) 2021-11-17 23:30:21 -06:00
Grace Park
130016bd0a Fix html in tocs (#22936)
* fix html in tocs

* render html
2021-11-17 17:17:10 -08:00
Grace Park
0afdf66a08 Primer Update: Table of Contents (#22933)
* update to ActionList

* fix nested mini tocs

* adding key

* remove li and fix tests

* update font size to 14px

* remove border radius
2021-11-18 00:27:12 +00:00
Mike Surowiec
d6e0485602 fix: platform content initial render (#22802) 2021-11-12 11:15:08 -06:00
Mike Surowiec
7310fc998a Refactor display-platform-specific-content (#22665)
* refactor display-platform-specific-content

* update PlatformPicker tests and cleanup
2021-11-12 14:40:35 +00:00
Rachael Sewell
0244fda807 search improvements (#22443) 2021-11-10 11:11:28 -08:00
Kevin Heis
6ec20638b5 Version picker combo (#22694)
* Move version picker next to product picker

* Always render in header

* Inline variant

* Remove topper-sidebar

* Handle breadcrumb length

* Have breadcrumbs use Primer breakpoint

* Make a breadcrumbs scss module

* Update Breadcrumbs.tsx

* Update Breadcrumbs.module.scss

* Update Breadcrumbs.module.scss

* Update server.js

* Use responsive classes for hide/show breadcrumb
2021-11-10 16:20:34 +00:00
Grace Park
75d41076a7 Article Layout Improvements (#22424)
* moving breadcrumbs to sticky header

* update scroll

* update color-bg-primary to color-bg-default

* change back to primary since were on primer 17

* add effect dependency

* not changing

* clip left box shadow of header and unmount

* update to default

* update breadcrumbs tests

* sticky editor
2021-10-29 19:57:07 +00:00
Kevin Heis
567652b0e3 Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Mike Surowiec
567879365f fix: grid blowout due to missing min width (#22352) 2021-10-21 20:25:23 +00:00
Grace Park
884556eb02 Adding effectiveDate frontmatter property (#22317)
* adding effectiveDate frontmatter property

* Update components/article/ArticlePage.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* adding validation for correct date

* update to dateTime

* update to year month day

* update error date validation

* moving validation to getArticleContextFromRequest and moving id to div

* remove enteredDate

* Update content/README.md

Co-authored-by: Laura Coursen <lecoursen@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
2021-10-20 19:40:13 +00:00
Steve Guntrip
32f59ee7b0 add ShieldLockIcon octicon to permissions statement (#21829) 2021-10-06 09:07:58 +00:00
Mike Surowiec
85f6a43502 Mini TOC semantic rendering (#21836)
* semantic rendering of miniTocItems

* feat: create nested mini toc structure to simplify semantic rendering

* remove className usage of indentationLevel in miniToc rendering

* manually run script/graphql/update-files.js to update pre-rendered files

* use less brittle regex method to extract number
2021-10-04 10:48:42 -04:00
Robert Sese
000799df17 Handle learning track paths from a different product (#21776)
* Add trackProduct property

* Fall back to learning track product URL param

* Add product URL param to learning track banner

* Add product URL param to featured track links

* Fix typo :(

* Add product URL param to learning track

* Add multi-product learning track tests

* Re-enable tests with a Code Security learning track

* Re-enable more tests with Code Security learning tracks

* Add more multi-product testing

* Update components/sublanding/LearningTrack.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 21:17:02 +00:00
Mike Surowiec
d81f51ebf7 Picker improvements (#21765)
* close Language and ArticleVersion pickers after click

* cleanup ArticleGridLayout due to VersionPicker changes

* fix tsc errors resulting from primer upgrade

* fix / update tests

* cleanup mobile pickers visual consistency

* use btn-sm on VersionPicker

* update translation and close on click for enterprise releases

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 20:22:13 +00:00
Martin Lopes
83dc407ada Restructure Actions guides (#21577)
Co-authored-by: Sarah Edwards <skedwards88@github.com>
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-09-22 16:49:41 +10:00
Kevin Heis
504155926d Create a lead component (#21311)
* Create a lead component

* Update to remove markdown-body from Lead, copy over <code> styles

* ...so I can read the test output

* Update Lead.tsx

* Update Lead.tsx
2021-09-16 19:02:56 +00:00
Kevin Heis
57621df550 Rm print button (#21237)
* Remove print button

* Found another print button
2021-09-01 18:20:42 +00:00
Kevin Heis
9f7c20dae8 Upgrade Primer CSS to version 17, removing marketing styles (#20965)
* Package updates

* Fix up things that look broken

* Add to utils

* Lead now just sets font size, just use f3 where needed

* Update package-lock.json

* Update index.tsx

* Delete bump-link.scss

* Update trigger-error.js

* Update components/GenericError.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update ArticlePage.tsx

* Update ActionBar.tsx

* Changes from meeting

* Found a few more monos

* Fix from a merge conflict

* Missed a few f3s

* Update SubLandingHero.tsx

* Bye gradients

* Match up breadcrumbs

* Update SubLandingHero.tsx

* Update lists.scss

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-08-31 14:49:39 -07:00
Mike Surowiec
d76c16da19 Scope markdown body (#21082)
* update article content to markdown ui component

* decouple lunr indexing from class name

* remove summary outline none rule, apply utility class instead

* improve typing

* scope more styles down to markdown-body/extended-markdown

* move all markdown-body style overrides to MarkdownContent component

* fix class targeting within css module

* clean up MarkdownContent header style

* rename data-lunr to data-search

* fix: inline code color issue

* fix: update article markdown to work with MarkdownContent
2021-08-30 14:24:49 +00:00
Mike Surowiec
06d8f81401 Two-pane Experiment (#21092)
* pull changes from docs-playground

* cleanup, add callout banner

* cleanup linting and test fixes

* add discussion link

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-08-26 14:19:40 -04:00
Robert Sese
f2106f33c3 Apply markdown-body styles to intros (#21046) 2021-08-23 21:28:43 +00:00
Mike Surowiec
4b9a6912b9 Scope sub-landing scss and remove some custom styles (#20893)
* scope sub-landing scss and remove some custom styles
2021-08-16 17:22:21 +00:00
Mike Surowiec
23f4681b42 Scope product-callout and contributor-callout css to component (#20801)
* remove custom css for product-callout and contributor-callout

* create callout component, update existing test

* use Callout in more places
2021-08-11 17:50:20 +00:00
Rachael Sewell
a92853e40d reapply some classes for lunr indexing (#20765) 2021-08-11 15:06:01 +00:00
Mike Surowiec
a511c95c7f SCSS and Component cleanup (pt 1) (#20572)
* turn article.scss into a module + componentized

* Update Survey to use only component styles, add cancel button

* Update GenericError + 404 page to use only standard classes

* update LearningTrack to not use markdown-body

* remove / consolidate stylesheets

* cleanup Graphiql explorer page and scss

* Componentize Breadcrumb styles

* Componentize DeprecationBanner styles

* scope h2 a link style to markdown-body

* cleanup nav, organize page-header and page-footer components

* remove unused scroll-button.scss

* organize LanguagePicker and ProductPicker

* add declarations file

* remove featured-links.scss, update tests

* update list utility and toc test

* fix bad merge resolution

* update breadcrumbs test
2021-07-29 17:27:20 +00:00
Mike Surowiec
9386571aa4 fix: use named export for all-versions (#20478)
* fix: use named export for all-versions

* run prettier
2021-07-22 19:29:00 +00:00
Grace Park
27aa5d92ea Remove FEATURE_NEXTJS Flag Part 1 (#20176)
* cleanup FEATURE_NEXTJS

* fixing some server tests

* updating article a for server tests

* update h2 to h4 map topic tests

* data off on TOCs

* updating dropdown article versions links

* Update so markdown renders in intros

* updating typo and all server tests are now passing

* remove nextjs feature flag

* head.js tests pass

* updating article-version-picker

* remove nextjs feature flag browser test

* update header.js tests

* fix page-titles.js test

* fix deprecated-enterprise versions

* adding early access

* testing

* getting childTocItem

* fixing table of contents to show child toc items

* updated to 2 because the sidebar article also has the same link

* remove comment

* updating pick

* Update TocLandingContext.tsx

* update package.json and change className to h4 for h2

* updating with mikes feedback

* remove a.active test

* React clean up: Delete unnecessary layouts/includes Part 2 (#20143)

* Delete unnecessary layouts

* setting back tests failing :(

* update layouts

* delete unnecessary includes

* remove github-ae-release-notes and updating layouts

* remove a.active test
2021-07-16 14:54:25 -07:00
Sarah Schneider
15e33f05e7 Revert "Revert "Fix homepage versions dropdown" (#20087)"
This reverts commit f9f0b2ce86.
2021-06-23 10:12:36 -04:00
Matt Pollard
f9f0b2ce86 Revert "Fix homepage versions dropdown" (#20087) 2021-06-23 09:11:51 +02:00
Sarah Schneider
43c04966e5 update React components that use the homepage version 2021-06-22 15:16:01 -04:00
Mike Surowiec
e377d74419 React: import necessary javascripts directly (#20001)
* import javascript files directly

* move globally required js to _app

* fix: js initialization

* set next env for tests
2021-06-21 21:55:49 +00:00
Mike Surowiec
732b5fa554 Fix Product sidebar (react) (#19843)
* fix sidebar product rendering logic to match existing sidebar
2021-06-10 19:23:47 +00:00
Kate Higa
982b8bfa53 disable rules until ready to be addressed so we can have it enabled right away 2021-06-09 09:41:15 -07:00
Mike Surowiec
37499b80d2 Reactify article page rendering (#19679)
* feat: reactify article page rendering

* feat: add LearningTrackNav

* fix: use plain text title for article
2021-06-07 22:56:33 +00:00
Mike Surowiec
bc1ee6c60d Custom Link component (#19682)
* use our own Link component instead of next/link directly

* only show link href warnings outside of production environments
2021-06-03 08:21:33 -07:00
Mike Surowiec
e0d9a061a3 React category / sub-landing page (#19635)
Re-work routes to use GlobalPage, implements TocLanding, bundle of minor cleanup / fixes
2021-06-02 16:28:39 +00:00
Mike Surowiec
4661a36d5d feat: add alternate landing page layout (#19571) 2021-05-27 07:21:40 -07:00