1
0
mirror of synced 2026-01-04 09:06:46 -05:00
Commit Graph

555 Commits

Author SHA1 Message Date
Robert Sese
df2e3be178 Small bits of test cleanup 🧹 (#22442)
* Unskip test, ghec graphql version added

* Link to test skip issue

* Stray console.log ✂️
2021-10-27 22:31:41 +00:00
Robert Sese
693e36bfdd Fix breadcrumbs when paths have partial match 🍞 (#22414)
* Add failing breadcrumb test for paths with partial match

* Handle overlapping paths when creating breadcrumbs
2021-10-26 21:24:54 +00:00
Mike Surowiec
e3074d998f fix: detect language error on /_next/data/ input (#22419) 2021-10-26 21:03:47 +00:00
Mike Surowiec
bede852dc4 fix: detect-language correctly handles root path, add unit tests (#22404) 2021-10-26 03:22:25 +00:00
Kevin Heis
3b092b4cb8 Deprecate 2.22 b (#22366)
* Update enterprise-server-releases.js

* Run deprecation script

* Remove finding / managing security vulnerabilities

* remove vuln from translations

* remove more dead pages

* Restore heavily used files

* Remove 2.22 refs in tests

* Update working-with-the-npm-registry.md
2021-10-22 13:23:16 -07:00
Edward Thomson
0fee9aedcd Landing page: groups of features (#22313)
* homepage: reduce padding below search area

Bring as much useful content up "above the fold".

* homepage: add groups for the front page sections

Group the homepage links into sections that map to the GitHub features
page (`/features`) plus two groups that are bespoke to the docs ("Get
started" and "Developers").

* homepage: update group design

Group the feature list area using the design exploration work by
@arisacoba.  Remove the description.

* homepage: remove ungrouped items from main area

Remove ungrouped items (like the external links) from the main feature
area.  Users can still navigate to ungrouped items in the sidebar.

* fix tsc error, use Link component

* homepage: support empty icon in group

Don't assume that we have icons everywhere on the landing page groups.

* homepage: drop octocat/invertocat

Looks weird with the modern icons, looks bad in dark mode.  Drop them
for now.

* homepage: document the childGroups frontmatter property

* homepage: don't test that sidebar == main content

We're reducing the links on the homepage in the main content area, but
the sidebar should be the complete list of products.  Remove the tests
that ensure that the main content area has all the sidebar content.  But
keep the tests that ensure that the sidebar content has all the links in
the main content area.

* homepage: remove "GitHub" doc set

The "GitHub" doc set "will be removed soon as we keep moving more content
out of it, so let's not include it here to keep the page more
evergreen."

* homepage: don't test that `/github` is linked on the main page

We're removing the `/github` doc set, and it's now not in the main page
grouped links.  Remove the test that `/github` exists, now look for
`/get-started`.

* homepage: use octicons instead of images

The images from https://github.com/features will be updated 🔜 - in
the meantime, let's use octicons which are consistent and give visual
interest.

* homepage: use octicons from @primer/octicons-react

Using the react components adds `<svg>` elements instead of `<img>`
elements, which lets the element use the current fill color, supporting
both light and dark themes.

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-10-22 17:58:16 +00:00
Sarah Edwards
ce5ab14f67 Not as big as it looks! Migrate guide.github.com content (#21942) 2021-10-20 14:53:24 +00:00
Peter Bengtsson
4e4ca1d12d gg commit (#22323)
Part of #1061
2021-10-20 09:45:18 -04:00
Rachael Sewell
8ad7c37cee Remove German as supported language (#22311) 2021-10-19 21:36:46 +00:00
Peter Bengtsson
1d72d4c87e use temporary redirect to inject locale prefix (#22239)
* use temporary redirect to inject locale prefix

Fixes #996

* fix routing tests
2021-10-18 20:09:20 +00:00
Peter Bengtsson
c712da8f5d be more conservative with spotting q= in URL (#21945)
* be more conservative with spotting q= in URL

Fixes https://github.com/github/docs-engineering/issues/951

* refactor check

* Update tests/routing/redirects.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-10-18 12:04:45 +00:00
Edward Thomson
dba3b44ea9 frontpage: add npm documentation links (#22173)
Co-authored-by: Laura Coursen <lecoursen@github.com>
2021-10-15 22:16:03 +00:00
Laura Coursen
8f964ea2cb GHEC version (#20947)
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: Steve Guntrip <12534592+stevecat@users.noreply.github.com>
Co-authored-by: Robert Sese <sese@github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-10-15 15:41:33 -05:00
Grace Park
fd3d223bce Adding links to all skipped tests (#22037)
* adding links to all skipped tests

* updating links
2021-10-08 21:53:44 +00:00
Mike Surowiec
b279482cf9 Footer styling (#21877) 2021-10-06 18:09:11 +00:00
Matt Pollard
307e8094ec Backport updated content from GitHub AE M2 megabranch and version for ghae-next (#21525) 2021-10-04 16:11:57 +00:00
Mike Surowiec
85f6a43502 Mini TOC semantic rendering (#21836)
* semantic rendering of miniTocItems

* feat: create nested mini toc structure to simplify semantic rendering

* remove className usage of indentationLevel in miniToc rendering

* manually run script/graphql/update-files.js to update pre-rendered files

* use less brittle regex method to extract number
2021-10-04 10:48:42 -04:00
Kevin Heis
1e2fedd16a Update developer-site-redirects.js (#21848) 2021-10-01 17:11:32 +00:00
Robert Sese
000799df17 Handle learning track paths from a different product (#21776)
* Add trackProduct property

* Fall back to learning track product URL param

* Add product URL param to learning track banner

* Add product URL param to featured track links

* Fix typo :(

* Add product URL param to learning track

* Add multi-product learning track tests

* Re-enable tests with a Code Security learning track

* Re-enable more tests with Code Security learning tracks

* Add more multi-product testing

* Update components/sublanding/LearningTrack.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 21:17:02 +00:00
Mike Surowiec
d81f51ebf7 Picker improvements (#21765)
* close Language and ArticleVersion pickers after click

* cleanup ArticleGridLayout due to VersionPicker changes

* fix tsc errors resulting from primer upgrade

* fix / update tests

* cleanup mobile pickers visual consistency

* use btn-sm on VersionPicker

* update translation and close on click for enterprise releases

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 20:22:13 +00:00
Marcelo Jacobus
aed6c1654f translation batch 1632491035 (#21717) 2021-09-30 11:53:04 +00:00
Melanie Yarbrough
2a10e30adc New workflow to aid internal contributions in PRs (#21612)
Co-authored-by: Sarah Edwards <skedwards88@github.com>
2021-09-29 13:09:26 -04:00
Rachael Sewell
c0a667a8d1 fix a few hardcoded tests temporarily (#21740) 2021-09-27 20:56:42 +00:00
Robert Sese
27eaff7caa Handle learning track URL redirects (#21613)
* Handle redirects for learning tracks

* Test for learning track URL redirects

* Test latest Enterprise version

Co-authored-by: Rachael Sewell <rachmari@github.com>

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-09-22 20:33:56 +00:00
Martin Lopes
83dc407ada Restructure Actions guides (#21577)
Co-authored-by: Sarah Edwards <skedwards88@github.com>
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-09-22 16:49:41 +10:00
Mike Surowiec
d2199e3deb Use Doctocat link header style (#21615)
* update autolinkHeadings to use Doctocat link header style

* fix header link test

* update graphql/rest rendering to use doctocat header link

* fix: miniToc issue with stray anchor

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-09-21 18:14:38 -04:00
Kevin Heis
9ba2e1dd41 Refactor repo ref tests (#21631)
* Refactor repo ref tests

* Update repository-references.js

* Update repository-references.js

* Update repository-references.js

* Update repository-references.js
2021-09-21 21:20:15 +00:00
AlonaHlobina
5f01af06ec Update beta-codeql-runner.md (#21605)
* Update beta-codeql-runner.md

* Rename beta-codeql-runner.md to deprecation-codeql-runner.md

* update reusable name

* Update about-codeql-code-scanning-in-your-ci-system.md

* Update running-codeql-code-scanning-in-a-container.md

* Update uploading-a-sarif-file-to-github.md

* Update sarif-support-for-code-scanning.md

* Update running-codeql-runner-in-your-ci-system.md

* Update configuring-codeql-cli-in-your-ci-system.md

* Update configuring-codeql-runner-in-your-ci-system.md

* Update running-codeql-runner-in-your-ci-system.md

* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/using-codeql-code-scanning-with-your-existing-ci-system/troubleshooting-codeql-code-scanning-in-your-ci-system.md

* Update configuring-codeql-cli-in-your-ci-system.md

* Apply suggestions from code review

Co-authored-by: Steve Guntrip <12534592+stevecat@users.noreply.github.com>

* update codeql runner reusable

* add new article about runner to cli migration

* fix typo in new article title

* Update deprecation-codeql-runner.md

* Update deprecation-codeql-runner.md

* Apply suggestions from code review

* fix failing test

* fix failing test

* Update versioning to fix failing test

* add `codeql-cli-binaries` to allow list

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Steve Guntrip <12534592+stevecat@users.noreply.github.com>
Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com>
2021-09-21 13:12:11 -07:00
Laura Coursen
b8429d8248 "Authentication" top-level doc set (#21531) 2021-09-21 19:27:08 +00:00
Kevin Heis
cdbbc63219 Send new analytics fields for path_language, path_version, path_product, path_article (#21562)
* Send new analytics fields for path_language, path_version, path_product, path_article

* Update DefaultLayout.tsx

* Update events.js
2021-09-17 19:22:54 +00:00
Grace Park
6a490ed8bb Adding next next version support (#21481)
* adding next next version support

* adding check for next next version

* update to use semver
2021-09-15 13:24:33 -07:00
Kevin Heis
43158e8392 Upgrade NPM packages (#21480)
* Upgrade a bunch of packages

* ...and upgrade highlightjs

* ... and ajv-formats (but not ajv)

* Revert graphql changes

* Revert "Revert graphql changes"

This reverts commit a5b8a34d52a48a7c2858415f6b1081c1d4902482.

* Update build-changelog.js

* Upgrade html-entities

* Upgrade commander, following migration guide
2021-09-13 23:31:43 +00:00
Laura Coursen
57740f3424 Add "Repositories" doc set (#21294) 2021-09-10 13:48:54 +00:00
Rachael Sewell
9bf6afd13d Webhooks bugfix (#21374) 2021-09-09 23:25:43 +00:00
Kevin Heis
9f7c20dae8 Upgrade Primer CSS to version 17, removing marketing styles (#20965)
* Package updates

* Fix up things that look broken

* Add to utils

* Lead now just sets font size, just use f3 where needed

* Update package-lock.json

* Update index.tsx

* Delete bump-link.scss

* Update trigger-error.js

* Update components/GenericError.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update ArticlePage.tsx

* Update ActionBar.tsx

* Changes from meeting

* Found a few more monos

* Fix from a merge conflict

* Missed a few f3s

* Update SubLandingHero.tsx

* Bye gradients

* Match up breadcrumbs

* Update SubLandingHero.tsx

* Update lists.scss

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-08-31 14:49:39 -07:00
Mike Surowiec
d76c16da19 Scope markdown body (#21082)
* update article content to markdown ui component

* decouple lunr indexing from class name

* remove summary outline none rule, apply utility class instead

* improve typing

* scope more styles down to markdown-body/extended-markdown

* move all markdown-body style overrides to MarkdownContent component

* fix class targeting within css module

* clean up MarkdownContent header style

* rename data-lunr to data-search

* fix: inline code color issue

* fix: update article markdown to work with MarkdownContent
2021-08-30 14:24:49 +00:00
Mike Surowiec
06d8f81401 Two-pane Experiment (#21092)
* pull changes from docs-playground

* cleanup, add callout banner

* cleanup linting and test fixes

* add discussion link

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-08-26 14:19:40 -04:00
Rachael Sewell
039cb2270b revert a search test change (#21142) 2021-08-25 20:13:18 -07:00
Grace Park
5de3e4250a Update README.md (#21137)
Updating the README.md to reflect the updates on running tests locally: https://docs.google.com/document/d/1qy9aenegmKhQSyc1a0fghnQATMZx2kRO9MSsnVgixFU/edit#
2021-08-25 16:19:50 -07:00
Rachael Sewell
df16267a8f remove cached-index-names file and dry run sync used for Algolia (#21133) 2021-08-25 22:04:26 +00:00
James M. Greene
08db1c970c Refactor Staging deployment workflow to support open source PRs (#20459)
* Add a Staging build workflow

* Remove all commented out code from build workflow

It will be handled in https://github.com/github/docs-engineering/issues/726

* Use pinned version of upload-artifact action

* Tweaks to build

* Minor deployment script refactoring

* Update the Staging deployment workflow

* Missed refactoring tweak

* Add relevant comments

* Update Heroku app naming convention for Actions deploy to include 'gha-' prefix

* Update Heroku app ConfigVars and SourceBlob for optional prebuilt app

* Remove obsolete 'dist/' dir from PR build artifact

See https://github.com/github/docs-internal/pull/20405

* Ensure a new enough version of npm is used

* Switch to creating a tarball for upload

* Remove obsolete 'layouts' dir from file list

* Ditch the verbosity for 'tar'... too many files

* Add tarball support to deploy

* Add esm workaround to deploy script

See https://github.com/actions/github-script/issues/168

* Temporarily ignore staging deploy workflow from workflow linter

* Update deployment to use a Heroku Build Source instead of a GitHub Actions Artifact

* Update undeploy workflow to use ESM workaround

See https://github.com/actions/github-script/issues/168

* Add 'esm' package to optionalDependencies to better support workaround

See https://github.com/actions/github-script/issues/168

* Add Slack notifications for workflow failures

* Wrap AppSetup polling in try-catch

* Improve dyno monitoring

* Rename 'script/deploy' to have a .js extension #esm

* Update script references to include the extension

* Use non-deprecated Sources API for Heroku

* Use normal quotes

* Stub in a step to mark deployment inactive after timing out

* Apply suggestions from code review

Co-authored-by: Rachael Sewell <rachmari@github.com>

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-08-25 20:45:51 +00:00
Laura Coursen
60b0d95f0d Hide the GitHub Insights docs (#20414) 2021-08-25 18:36:35 +00:00
Sarah Edwards
95bd8c84f9 [Aug 24, 2021] Top level CLI docs set (#20628)
Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
2021-08-24 15:44:25 +00:00
Mike Surowiec
5f5aa0b0d1 BumpLink component (#21033)
* create BumpLink component, re-org components/ui
2021-08-24 11:25:38 -04:00
Laura Coursen
0f03dac1ea Create "Account and profile" top-level docset (#20982) 2021-08-24 15:08:25 +00:00
Kevin Heis
86b6b1ad6f Remove storybook (#21037)
* Remove storybook

* Update index.js
2021-08-23 12:07:54 -07:00
Mike Surowiec
2a25efcd8e Scope Search scss (#20964)
* scope Search scss, reduce custom styling

* use translation for loading and no results found

* remove unnescessary test
2021-08-23 09:15:39 -04:00
Grace Park
5bf7cca35d remove liquid tags (#20937) 2021-08-18 15:52:44 +00:00
Rachael Sewell
8e7b1a0370 Remove 2.21 from the supported list of GHES versions (#20935) 2021-08-17 15:43:06 -07:00
Kevin Heis
ae7b652463 Create a storybook with callout component (#20902)
* Create a storybook with callout component

* Add to dist/storybook

* Remove references to dist dir, storybook takes place

* Update Callout.stories.tsx

* Update Dockerfile

* Update Dockerfile
2021-08-17 20:28:59 +00:00