Sarah Schneider
5d03537551
differentiate between TOCs with grandchildren vs. only children
2021-04-20 11:15:03 -04:00
Sarah Schneider
26c351f4ff
Merge branch 'main' of github.com:github/docs-internal into update-new-site-tree-deps
2021-04-15 14:46:27 -04:00
Sarah Schneider
d1524b16a5
add feature flagged middleware
2021-04-15 14:46:16 -04:00
Sarah Schneider
974b3bb148
add new middleware contextualizers that are feature flagged
2021-04-15 14:36:16 -04:00
Sarah Schneider
e6b2aedd66
Merge branch 'main' into move-html-into-include-files
2021-04-15 13:55:08 -04:00
Sarah Schneider
56f1cdd12b
add example variables to context via product ID
2021-04-15 12:31:59 -04:00
Sarah Schneider
18b91cd3b1
Merge branch 'main' into update-categories-json
2021-04-15 10:29:46 -04:00
Mike Surowiec
cf886a385c
fix: enterprise server releases layout and mini toc contents
2021-04-14 12:02:17 -07:00
Mike Surowiec
ac84e362b0
Merge branch 'main' into update-webpack-dep
2021-04-14 10:30:59 -07:00
Sarah Schneider
15ff2e2e98
update categories-for-support-team middleware
2021-04-14 10:34:49 -04:00
Mike Surowiec
4a931237ea
Merge branch 'main' into update-webpack-dep
2021-04-13 16:55:31 -07:00
Sarah Schneider
03ee839af6
Merge branch 'main' into add-layouts-middleware
2021-04-13 16:03:36 -04:00
Mike Surowiec
10b7603af0
Merge branch 'main' into prerender-gql-input-objects
2021-04-13 12:47:41 -07:00
Sarah Schneider
e7ec2809f5
Merge branch 'main' into add-layouts-middleware
2021-04-13 14:40:14 -04:00
Sarah Schneider
1623191243
extract layout handling into separate middleware
2021-04-13 14:24:06 -04:00
Mike Surowiec
89b08ccf26
fix: include builtAssets for error-404 page rendering
2021-04-13 10:48:55 -07:00
Mike Surowiec
4b746d037e
Merge branch 'main' into prerender-gql-input-objects
2021-04-13 08:31:56 -07:00
Mike Surowiec
c4c5c59e70
reduce max request timeout to 10 seconds
2021-04-12 09:25:43 -07:00
Mike Surowiec
02cfde71bf
Merge branch 'main' into prerender-gql-input-objects
2021-04-12 07:21:18 -07:00
Mike Surowiec
2fa97a2287
Merge branch 'main' into update-webpack-dep
2021-04-11 19:46:17 -07:00
Sarah Schneider
8049882d41
Merge branch 'main' into refactor-site-tree
2021-04-09 15:29:03 -04:00
Kevin Heis
f160594a09
Enable set AIRGAP cookie to view Lunr search results ( #18648 )
...
* Enable set `lunr` cookie to view Lunr search results
* Use AIRGAP instead of lunr for cookie name
2021-04-09 17:38:32 +00:00
Sarah Schneider
53b7208fe9
Merge branch 'main' into update-webpack-dep
2021-04-09 12:22:18 -04:00
Mike Surowiec
9185eb3c2a
pre-render graphql input-objects
...
resolves #18269
2021-04-09 08:32:42 -07:00
Sarah Schneider
c02673241d
just return early instead of throwing an error until we rewrite this middleware for the new siteTree structure
2021-04-09 09:36:34 -04:00
Sarah Schneider
307d1deb59
remove commented out code
2021-04-09 09:10:13 -04:00
Sarah Schneider
7c4240bea4
Merge branch 'main' of github.com:github/docs-internal into refactor-site-tree
2021-04-09 09:09:13 -04:00
Vanessa Yuen
bbd9f03f6e
Populate product-landing "What's new" section using GitHub Changelog ( #18328 )
...
Co-authored-by: Jason Etcovitch <jasonetco@github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com >
2021-04-08 20:51:37 +00:00
Mike Surowiec
f79d23ccb9
Merge branch 'main' into webhook-response-no-hydro
2021-04-08 08:41:01 -07:00
Sarah Schneider
520ff1bc5f
Merge branch 'main' of github.com:github/docs-internal into move-product-list-to-frontmatter
2021-04-07 14:33:56 -04:00
Sarah Schneider
f765c21650
updates required for webpack 5
2021-04-07 11:27:00 -04:00
Mike Surowiec
8998e52dc0
move hydro sentry error out of /events, to hydro
2021-04-06 16:28:41 -07:00
Mike Surowiec
008faf57eb
improve sentry reporting, add metrics for hydro
2021-04-06 16:21:40 -07:00
Mike Surowiec
adb81ce5b5
update webhook response to not return fields, return 200
2021-04-06 11:24:21 -07:00
Mike Surowiec
0a8b108b2a
remove semi-colon
2021-04-06 10:53:14 -07:00
Mike Surowiec
bd152312f2
don't await hydro for /events POST response
2021-04-06 07:41:30 -07:00
Mike Surowiec
548a436e57
Merge branch 'main' into fix-sentry-hydro-error
2021-04-05 11:10:38 -07:00
James M. Greene
22e8d75c91
RedisAccessor tolerance for GET failures ( #18586 )
...
* Update RedisAccessor to allow for graceful GET failures, too
* Add unit tests for allowGetFailures behavior
2021-04-05 16:26:46 +00:00
Mike Surowiec
93b78216f8
fix: middleware/events - check res.headerSent before attempting to send response
...
- Closes #18527
2021-04-05 09:23:45 -07:00
Sarah Schneider
c7f647f68a
update references
2021-04-01 15:29:59 -04:00
Sarah Schneider
b86b681620
Merge branch 'main' of github.com:github/docs-internal into refactor-site-tree
2021-03-29 16:46:46 -04:00
Sarah Schneider
50787186a4
hacky way to pull in the new siteTree
2021-03-29 16:46:36 -04:00
James M. Greene
84547e54c7
Use node-redis for page cache ( #18421 )
...
* Use [node-]redis as a direct dependency
* Extract Redis client creation to its own module
* Attach extensive logging in the Redis client creation module
* Allow the rate limiter to pass requests when Redis is disconnected
* Update rate-limit-redis
* Default error input to empty object for formatRedisError method
* Provide a name for the rate limiter's Redis client
* Include redis-mock, exclude ioredis/ioredis-mock
* Remove unused RedisAccessor#exists method
* Switch RedisAccessor to use redis/redis-mock
* Provide a name for logging on the Redis page cache
* Remove extraneous trailing space from Redis logging prefix
Our updated use of console.* will already be adding a space after the prefix
* Replace ioredis-mock with redis-mock in tests
* Revert removal of ioredis dependency
* Bind Redis client to async promisified methods
* Extract former RedisAccessor constructor tests to new create-client tests
* Update RedisAccessor tests to work with the callback-based redis client
* Handle formatting Redis errors (or not) with more resiliency
2021-03-29 17:34:22 +00:00
James M. Greene
23bcc0bb06
Use node-redis for rate limiter ( #18416 )
...
* Use [node-]redis as a direct dependency
* Extract Redis client creation to its own module
* Attach extensive logging in the Redis client creation module
* Allow the rate limiter to pass requests when Redis is disconnected
* Update rate-limit-redis
* Default error input to empty object for formatRedisError method
* Provide a name for the rate limiter's Redis client
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
2021-03-25 23:54:25 +00:00
Rachael Sewell
0df04f99c5
deprecate 2.20 version ( #18354 )
2021-03-23 19:38:04 +00:00
Sarah Schneider
fb0cb29b94
add convenience props to context obj for use in release notes layout
2021-03-19 10:20:14 -04:00
Kevin Heis
2e07070fb9
Add filters params to search endpoint ( #18289 )
...
* Add filters params to search endpoint
* Update search.md
* Update middleware/search.js
Co-authored-by: Rachael Sewell <rachmari@github.com >
Co-authored-by: Rachael Sewell <rachmari@github.com >
2021-03-17 21:02:47 +00:00
James M. Greene
a11d0075ef
Prevent REALLY garbage request URLs ( #18216 )
...
* Block paths that do not normalize well
2021-03-12 02:58:47 +00:00
James M. Greene
c940dcd98b
Middleware overhaul! ( #18218 )
...
* Middleware overhaul!
- Remove unnecessary 'async' keywords from middleware functions
- Ensure all middleware functions we create have names
- Wrap the method contents of all async middleware functions in a try-catch+next(error) pattern
* Use asyncMiddleware wrapper instead of try-catch+next(error) pattern
* Remove unnecessary try-catch+next(error) pattern from context middleware
2021-03-11 01:12:41 +00:00
James M. Greene
9e31597ee4
Use promisified fs.readFile instead of fs.promises.readFile ( #18204 )
...
* Create a readFileAsync wrapper module
* Use the readFileAsync wrapper module instead of fs.promises.readFile
* Fix require path in test
2021-03-10 17:57:10 +00:00
