Lately i'm working on an unofficial Chinese translation of GitHub Pages docs due to the incompletion of the original and currently there is no way to contribute translations to the docs. So, I hope that's ok to you guys.
The thing is, I'm seeing that this document is using both `<user>` and `<username>` as subdomain pronouns among the context. It's not a big problem, but in my opnion, this might cause some unnecessary confusion to some users.
If it was intended to be so, I'd like to know why?
Thank you!
Co-authored-by: hubwriter <hubwriter@github.com>
* use ed25519 keys instead of rsa keys
RSA keys are outdated. Even by using larger 4096 keys maybe it's best to move away from rsa keys altogether.
This PR updates the document to suggest using ed25519 keys which, at this time, defaults to a 16 round key deviation function. It may be useful to suggest more rounds for the KDF but that's for a different PR.
--timball
* Add RSA fallback and change id_rsa to id_ed25519
Co-authored-by: hubwriter <54933897+hubwriter@users.noreply.github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
* Changed 'people' to 'accounts'
Adding some precision: Changed 'People with write permission to a repository can manage' to 'Accounts with write permission to a repository can manage"
People don't have permission; accounts have permission.
* edits for clarity
* clarity
* Update content/github/finding-security-vulnerabilities-and-errors-in-your-code/managing-code-scanning-alerts-for-your-repository.md
Co-authored-by: hubwriter <54933897+hubwriter@users.noreply.github.com>
Co-authored-by: hubwriter <54933897+hubwriter@users.noreply.github.com>
* Use conditioning to revert dismiss/delete alert changes on GHES
* Add new dotcom version text that is also good for GHES
* Reinstate original subheading for GHES 2.22
* Small update for change from head to merge commit for attribution
* Simplify the sentence about when codescan is run against PRs
Whether it does attribution using a comparison of the HEAD commit
or a merge into a temporary copy of the default branch
is too much information here.
* Use conditioning to revert dismiss/delete alert changes on GHES
* Add new dotcom version text that is also good for GHES
* Reinstate original subheading for GHES 2.22
Edited introductory paragraph and step 4 of the section to state that admin permissions are required to delete alerts.
Introductory paragraph changed to say, "Alternatively, if you have admin permissions for the repository, you can delete alerts."
and step 4 to "If you have admin permissions for the repository, and you want to delete alerts[...]"
Co-authored-by: hubwriter <54933897+hubwriter@users.noreply.github.com>
* first stab
* fix issues with liquid tags
* applied a few fixes and improvements
* rewrite options
* rewrite for GHES 2.21
* fix liquid versioning (again)
* I love liquid tags
* swap paragraphs for GHES 2.21
* add link to new article in 2 existing articles
* started major rework to avoid info duplication
* part of the reorg work
* starting the major reorg
* fix syntax
* rework Configuring notifications article
* reorganizing again
* more reorg
* add new reusable
* fix typo
* add correct variable
* link to correct article for GHES < 2.21
* Update content/github/managing-security-vulnerabilities/configuring-notifications-for-vulnerable-dependencies.md
Co-authored-by: Alex Mullans <infin8x@github.com>
* Apply suggestions from code review
Co-authored-by: Felicity Chapman <felicitymay@github.com>
* Update data/reusables/notifications/vulnerable-dependency-notification-options-detailed.md
Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com>
* fix typo reported in #16036
* address comments from code review
* yet another commit
* polishing
* Update content/github/managing-security-vulnerabilities/configuring-notifications-for-vulnerable-dependencies.md
Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com>
* use variables
* address more comments
* add condition to link as linked article is free-pro-team only
* fix condition
* remove reusable that had duplicated content
* remove incorrect info
* fix issue in GHES article
* added shortTitle
* Apply suggestions from code review
Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com>
* reword for clarity
* add more detail
Co-authored-by: Alex Mullans <infin8x@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com>
* Run script/new-versioning/update-not-fpt-conditionals.js
* Fix a few things
* Remove outdated versioning
* Fix broken link
Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com>
