### Why:
A lot of content gets mistranslated, some common patterns are: frontmatter date and enums getting translated, liquid tags get translated or go missing during the translation process. These translation errors are tough to catch, especially when they often come in huge PRs.
### What's being changed:
- Frontmatter is also getting linted against schema as part of `lint-files`
- When an environment variable `TEST_TRANSLATION` is passed,
- `lint-files` will run its tests against all files that have been newly translated (by git-diffing between `translations` branch and `main` branch), and
- results are outputted using a custom jest reporter. The output is formatted in a way that makes it easy to exclude the problematic translated files from being merged, and to share the errors with [localization support](https://github.com/github/localization-support/issues/489).
- Run the implemented translation test as part of the existing `Node.js Tests - Translations` workflow
* Add markdown parsing dependencies
* Use it for the link test
* Use ast tests for hard-coded language
* Dedupe visiting for links
* Add new mdast utils to check-deps exclusions
* Move site search to use an endpoint
* Update browser.js
* Update search.js
* Update lib/search/versions.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
* Fix URLs
Co-authored-by: James M. Greene <JamesMGreene@github.com>
* Update tests to use fs.promises when not top-level
* Move two to asyncFilter
* Update site-data-references.js
* Update site-data-references.js
* Clear out await fs.exists
* Lint
* A few more fixes
* Can't use async when defining tests
* Update README
* [Universe] Dark mode (#16545)
* Dark mode updates (#16696)
* [Universe] Corporate sponsors (#16457)
* Dependency review beta (#16563)
* Add placeholder topic file
* Revert change I didn't make
I'm not sure where this change came from or why it's showing up in my PR here but I didn't make this change and it's not part of Dependency Review so I'm reverting it.
* Un-revert previous change
OK I see what happened there. I was comparing the PR to main rather than the Universe megabranch, hence it showed a change I didn't make.
This commit undoes the change I do not want to revert on the megabranch.
* Update image to add the Checks tab
* Finish updating topic to mention DR
* Fix check errors
* Fix another versioning error
* Add a sentence about supported ecosystems
* Add review changes
* Remove Further reading topics in same category
As suggested by James, I've removed the links to topics that are in the same `/collaborating-with-issues-and-pull-requests/` category as this topic.
* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md
* Updates in the light of Maya's review
* Remove use of "exploit" in description
* Change 'dependency review summary' to 'dependency review'
See PR review comment from Maya.
* Mention that the age of the dependency is given
* Update screenshots to latest GUI
* Add details of dependency ordering within a DR
* Update content/github/collaborating-with-issues-and-pull-requests/reviewing-dependency-changes-in-a-pull-request.md
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
* Update content/github/visualizing-repository-data-with-graphs/about-the-dependency-graph.md
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
* [Universe 2020] New audit log REST API endpoint (#16699)
* Minimal updates for preview
* ✨ API previews ✨
* Update beta note
* ✨ Update API previews ✨
* ✨ Update previews ✨
* Add draft section for git events
* Clean API previews
* More fixes + API previews
* Address review comments + update API previews
* Mention cursor-based pagination
* Update content/rest/overview/resources-in-the-rest-api.md
Co-authored-by: Jeff Saracco <jeffsaracco@github.com>
* Temporarily revert API previews
* Small tweaks from review comments + API previews
* revert json schemas
* Updating OpenAPI descriptions (#16776)
* Updating OpenAPI descriptions
* Add decorated OpenAPI schema files
Co-authored-by: Jeff Saracco <jeffsaracco@github.com>
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com>
* [Universe 2020] GitHub Actions: Workflow visualization (#16629)
* initial empty commit
* replace image used only for dotcom
* add new image and version usage
* add new image and version usage
* add new image and version usage
* add new image and version usage, delete unneeded image
* add new image and version usage, fix incorrect image
* add new image and version usage
* add new image and version usage
* add new image and version usage
* add new image and version usage
* update screenshot update
* add new image and version usage
* add new image and version usage
* update text
* update images and fix list numbering
* add step with graph
* Add missing versioning
* add overview of visualization
* fix title to match filename
* add beta note
* update wording
* Restructuring packages (#16731)
* restructuring packages
* moving more content
* moving more content
* fixing the toc for guides
* removing CR from the landing page
* adjusting qs
* updating npm
* enhancing guides
* Update updating-github-insights.md
* fixing link problems
* fixing link problems
* redirecting the redirects
* another change
* fixing the guides landing page
* add packages quickstart
* moving CR content
* adding some descriptive text
* add packages landing page
* adding guide content back
* update popular articles based on data
* fix caps on product name
* try removing product from front matter
* Update content/packages/quickstart.md
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
* Update content/packages/quickstart.md
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
* add node package instructions to quickstart
* fixing links and adding redirect
* fixing redirects
* renaming to container guides
* renaming to container guides and fixing reusables
* adding context and about section to CR
* removign landign page extra titles and descriptions
* reverting the packages
* updating link
* Apply suggestions from code review
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
* updating
* update test to reflect redesigned product landing page
* Add private vs public clarification
* Fix borked test
* filter out standalone category files from test
Co-authored-by: Cynthia Rich <crichID@github.com>
Co-authored-by: Cynthia Rich <crichID@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
* Add discussions video
See https://github.com/github/docs-internal/pull/16759
* Remove typos
* update article name in test
Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Jeff Saracco <jeffsaracco@github.com>
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com>
Co-authored-by: Meg Bird <megbird@github.com>
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
Co-authored-by: Cynthia Rich <crichID@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
* Update README
* create structure for discussions landing page
* is everything broken
* [Universe] Dark mode (#16545)
* Fix title
* Add Discussions product
* Correct title
* Correct title
* Move quickstart article
* Move quickstart back out into article
* Add and incorporate reusables
* Move information about search
* Draft conceptual information
* Draft best practices
* Draft further reading
* Draft product introduction
* Draft introduction
* Add author metadata
* Pluralize
* Fix typos
* Add introduction
* Bump Octicons
* Add some reusables
* Add images
* Revise article
* Draft article
* Change word
* 🔪 the gerund
* Add reusable
* Revise introduction
* Revise list
* Simplify
* Revise reusable
* Fix reusable; add context
* Rename reusable
* Deduplicate conceptual information
* 🔪 gerund
* Add link to further reading
* Move link and dispose of tip
* Delete space
* Add images
* Add conceptual section
* Add word
* Delete newline
* Revert package.json to state on main
* Tweak images
* Draft article
* Add product name
* Remove beta note
* Use product name for future-proofing
* Begin adding search information
* Fix copypasta
* little edits
* build out a bit more of the guides content
* Don't mention integrations for now
* Escape quote
* Remove authorship information for new defaults
* Finish drafting article
* Replace encoded character to match description
* Revise away inline link
* Accommodate 'for more information' in reusable
* Fix links
* Fix one last bit of copypasta
* Update indices
* Temporarily remove heading
* Update introduction
* Add new article 💀
* Remove commits from universe-2020-megabranch
* Add article 💀
* update with a very rough draft
* Add content about collaboration options to "About repositories"
* Add content about discussions to "About issues"
* Reorder content
* Add is:discussion query
* update with a few mmore fleshed out sections
* update with more structure
* Add reusable
* Add screenshots
* Clear way for actual procedural
* Discussions landing page "Communities" section (#16692)
* Make button Overview-able
* Make card filtering more extensible
* Guard for missing attributes
* Use arbitrary dataset attributes
* Add section with discussions-community-card
* Tweak show more button behavior
* Conditionally show "Show more"
* Add beta_product frontmatter/label
* Remove beta callout note
* Hide changelog with no items
* Finish importing community info
* Fix borked markup
* Omit search abr
* Two columns should actually be two columns
* Use org image, change card layout
* Add two more examples
* Fix title
* Escape quote
* Escape another quote
* Draft article
* Lower case
* Relocate conceptual information
* Update qualifier name
* Draft article
* Add conceptual information and links
* Remove duplicative section
* Fix copypasta
* Revise reusable
* Update link
* Add content on categories
* Lint the discussions YAML file
* Update introduction and permissions
* ⚓
* Reusablize; fix link
* more planning content stuff
* Escape quotes
* Align prerequisites
* Soften
* Clean up prerequisites
* Fix titles; version; add screenshot
* Fix links
* Actually fix links
* Use better variable
* Mention pinning
* Update screenshots
* Add screenshot
* forgot to committ
* update with reusable
* add that screenshot
* beef up landing page a bit
* remove extra space
* messed that up
* fix hardcoded linkks weirdo
* fix tests
* update with permissions content
* update with placeholder
* filter out standalone category files from test
* update
* update @becca's ⚡ feedback
* update with more feedback
* so many updates
* fix links
* fix some more tests
* flesh some more things out
* update with further reading blah blah
* fix some things
* remove the gate-features label for beta ship only
* Add discussions video to product landing page (#16759)
* Add discussions video placeholder
* This might work maybe
* fix tests
* apply all of @becca's and @lecoursen's ⚡ feedback ❤️
* rename to fix test
* Revert "Add discussions video to product landing page (#16759)"
This reverts commit 2247e5d0881ca6b36cee421218e8341a7cc12ac7.
* update with test fix
Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
* Revise the 'pages' module to export two methods: 'loadPages' and 'loadPageMap'
Update all existing references to use 'loadPages' for now
* Remove explicit Promise resolutions on loadPage* methods
* Condense reduction method into its now-singular usage spot
* Opt for for-of instead of forEach
* Make require of pages in warm-server more explicit
* Be more explicit about find-page using a pageMap
* Be more explicit about find-page-in-version using a pageMap
* Be more explicit about site-tree using a pageMap
* Extract the map creation from loadPageMap
* Be more explicit about using a pageMap
* Update redirects precompile to take two arguments: pageList, pageMap
* Rename internal loadPages method to loadPageList
* Clarify pageMap is what is stored in context.pages
* Use loadPageMap in tests and stuff
* Create basic layout
* Create stubbed out release note YAML
* Get a real implementation going
* Simplify using site-data
* Add a real page to send from render-page.js
* Use array of patches
* Render patches
* Add sidebar and breadcrumbs
* Reverse order
* Add date
* Tweak labels
* Redirect to entweb for missing versions
* Render patch.intro
* Move to separate files for patches
* Show support for RC versions
* Improve some comments
* Sticky headers!
* Remove a console log
* Improve example formatting
* Add a link on /admin
* Add a schema and test
* Move to /index.md, add version_num filter
* Improve layout
* Use <details>
* Placeholder more realistic notes
* Don't require links in index pages
* Remove admin/index link for now
* Remove unused frontmatter field
* Add a test for middleware
* Fix remaining YAML file to test CI
* Update 2-rc.yml
* Don't call it RC
* Just push
* Make a main a div
* Fix a borked class
* Lint YAML files
* Improve Download link
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
* Improve check order
* Move to contextualizers
* Use alternative version thing
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
* Move back to `release-notes.md`
* Use version for anchor IDs
* Undo category-pages test change
* Fix borked details layout in Chrome
* Improve mobile setup
* Render markdown in note tags
* Use allVersions[currentVersion] again
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
* Undo change to extended-markdown
* Add whitespace so it renders markdown bits
* Remove 2-22 files
* Add check for any release notes
* Fix the failing tests
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
* Add custom hover shadows
* Support avatars
* Add guide-card include
* Use it in product-landing
* Add gradient styles
* Add guides frontmatter
* Use guideArticles instead of full objects
* Add support for authors
* Add support for category header
* Just pass the whole page
* Use it
* guide.url => guide.href
* Use `*.githubusercontent.com`
* Fix mobile card width
* Remove showDescription check
* Use featureLinks.guideCards
* Forgot an if
* Add contextualizers/actions-code-examples
* Use code-example-card include
* Tweak sizing/shadows
* Add a basic filterer
* Some visual tweaks
* labels => tags
* Cleanup some code
* Improve spacing on mobile
* Add "No results!" blurb
* Fix a boog
* Tweak spacing
* Remove support banner
* Improve "No results" state
* Just use login instead of name/avatarUrl
* Change card spacing
* Use circular avatars
* Add "Show more" button
* Add margin beneath "Guides"
* Use smaller font
* Assume github.com for code examples
* Show two columns at small screen
* Make "Show more" a btn
* Use the "repo" octicon
* Link to contributing guide
* Use a YAML file instead of a middleware
* Link straight to the file
* Fix some wonky markuip
* Fix a broken link
* Fix the borked test
* Allow variables that aren't strings
* Fix remaining tests
* Add featuredLinks to frontmatter
* Parse them in featured-links.js
* Remove old raw setup
* Use them
* Missed a couple
* Update translation files
* Fix frontmatter schema
* Loop over the right object
* Also update translations' usage
* Update docs and tests
* Better README comment
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
* Return next()
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
* update Liquid deprecation fixtures to use new versions
* update module that removes deprecated GHES frontmatter for new versions
* update module that removes deprecated GHES conditionals for new versions
* update script to use new versions and also remove internal-developer checkout option
* update deprecated Liquid tests to use new versions
* remove unnecessary leading slash in getEnterpriseServerNumber pattern
* include a step that runs script/remove-unused-assets.js
* Update script/remove-deprecated-enterprise-version-markup.js
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
* require script instead of execSync
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
* Add back changes from prior to purge
* Manually fix some invalid Liquid
* Updoot render-content
* Improve test messages to show correct output
* Run el scripto
* Pass the remaining test
* remove FEATURE_NEW_VERSIONS from feature-flags.json
* remove process.env.FEATURE_NEW_VERSIONS from include files
* remove process.env.FEATURE_NEW_VERSIONS from lib files
* remove process.env.FEATURE_NEW_VERSIONS from middleware files
* remove process.env.FEATURE_NEW_VERSIONS from script files
* remove process.env.FEATURE_NEW_VERSIONS from test files
* update test fixtures to use new versions as canonical fixtures
